Re: [PATCH v1 4/7] ima: measure and appraise kexec image and initramfs

2015-12-17 Thread Luis R. Rodriguez
On Thu, Dec 17, 2015 at 07:32:10AM -0500, Mimi Zohar wrote: > On Thu, 2015-12-17 at 14:45 +0800, Dave Young wrote: > > On 12/08/15 at 02:15pm, Mimi Zohar wrote: > > > There's a lot of code duplication for reading a file by the kernel (eg. > > > kexec, firmware, kernel modules, ...). Each place

Re: [PATCH v1 4/7] ima: measure and appraise kexec image and initramfs

2015-12-17 Thread Mimi Zohar
On Thu, 2015-12-17 at 14:45 +0800, Dave Young wrote: > On 12/08/15 at 02:15pm, Mimi Zohar wrote: > > On Tue, 2015-12-08 at 13:32 -0500, Vivek Goyal wrote: > > > On Tue, Dec 08, 2015 at 01:01:21PM -0500, Mimi Zohar wrote: > > > > > > [..] > > > > #ifdef CONFIG_IMA_APPRAISE > > > > diff --git

Re: [PATCH v1 4/7] ima: measure and appraise kexec image and initramfs

2015-12-16 Thread Dave Young
On 12/08/15 at 02:15pm, Mimi Zohar wrote: > On Tue, 2015-12-08 at 13:32 -0500, Vivek Goyal wrote: > > On Tue, Dec 08, 2015 at 01:01:21PM -0500, Mimi Zohar wrote: > > > > [..] > > > #ifdef CONFIG_IMA_APPRAISE > > > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > > > index

Re: [PATCH v1 4/7] ima: measure and appraise kexec image and initramfs

2015-12-08 Thread Vivek Goyal
On Tue, Dec 08, 2015 at 01:01:21PM -0500, Mimi Zohar wrote: [..] > #ifdef CONFIG_IMA_APPRAISE > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > index b70ada0..18c4a84 100644 > --- a/kernel/kexec_file.c > +++ b/kernel/kexec_file.c > @@ -18,6 +18,7 @@ > #include > #include > #include

Re: [PATCH v1 4/7] ima: measure and appraise kexec image and initramfs

2015-12-08 Thread Mimi Zohar
On Tue, 2015-12-08 at 13:32 -0500, Vivek Goyal wrote: > On Tue, Dec 08, 2015 at 01:01:21PM -0500, Mimi Zohar wrote: > > [..] > > #ifdef CONFIG_IMA_APPRAISE > > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > > index b70ada0..18c4a84 100644 > > --- a/kernel/kexec_file.c > > +++