Am 03.05.24 um 17:29 schrieb Arnd Bergmann:
On Fri, Apr 5, 2024, at 11:04, Thomas Zimmermann wrote:
Hi,
if there are no further comments, can this series be merged through
asm-generic?
Sorry for the delay, I've merged these for asm-generic now.
Thank you so much!
Arnd
Hi,
if there are no further comments, can this series be merged through
asm-generic?
Best regards
Thomas
Am 29.03.24 um 21:32 schrieb Thomas Zimmermann:
Make architecture helpers for display functionality depend on general
video functionality instead of fbdev. This avoids the dependency
, and Makefiles.
Also update a few strings and comments to refer to video instead of
fbdev.
v3:
- arc, arm, arm64, sh: generate asm header via build system (Sam,
Helge, Arnd)
- um: rename fb.h to video.h
- fix typo in commit message (Sam)
Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
The per-architecture video helpers do not depend on struct fb_info
or anything else from fbdev. Remove it from the interface and replace
fb_is_primary_device() with video_is_primary_device(). The new helper
is similar in functionality, but can operate on non-fbdev devices.
Signed-off-by: Thomas
for the use of more fine-grained control for each directory's
files, such as the use of CONFIG_STI_CORE on parisc.
v2:
- sparc: rebased onto Makefile changes
Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
Cc: "James E.J. Bottomley"
Cc: Helge Deller
Cc: "David S. Mille
minor change in fbcon, which is
the only caller of fb_is_primary_device().
Patch 3 renames the source and header files from fbdev to video.
v3:
- arc, arm, arm64, sh, um: generate asm/video.h (Sam, Helge, Arnd)
- fix typos (Sam)
v2:
- improve cover letter
- rebase onto v6.9-rc1
Thomas Zimmermann (3
Hi
Am 28.03.24 um 13:39 schrieb Helge Deller:
On 3/27/24 21:41, Thomas Zimmermann wrote:
Various Kconfig options selected the per-architecture helpers for
fbdev. But none of the contained code depends on fbdev. Standardize
on CONFIG_VIDEO, which will allow to add more general helpers for
video
Hi
Am 28.03.24 um 12:04 schrieb Helge Deller:
On 3/27/24 21:41, Thomas Zimmermann wrote:
The per-architecture video helpers do not depend on struct fb_info
or anything else from fbdev. Remove it from the interface and replace
fb_is_primary_device() with video_is_primary_device(). The new
Hi
Am 28.03.24 um 13:51 schrieb Arnd Bergmann:
On Thu, Mar 28, 2024, at 13:46, Helge Deller wrote:
On 3/27/24 21:41, Thomas Zimmermann wrote:
+++ b/arch/arc/include/asm/video.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef _ASM_VIDEO_H_
+#define _ASM_VIDEO_H_
+
+#include
minor change in fbcon, which is
the only caller of fb_is_primary_device().
Patch 3 renames the source and files from fbdev to video.
v2:
- improve cover letter
- rebase onto v6.9-rc1
Thomas Zimmermann (3):
arch: Select fbdev helpers with CONFIG_VIDEO
arch: Remove struct fb_info from video
a few strings and comments to refer to video instead of
fbdev.
Signed-off-by: Thomas Zimmermann
Cc: Vineet Gupta
Cc: Catalin Marinas
Cc: Will Deacon
Cc: Huacai Chen
Cc: WANG Xuerui
Cc: Geert Uytterhoeven
Cc: Thomas Bogendoerfer
Cc: "James E.J. Bottomley"
Cc: Helge Deller
Cc: Michae
for the use of more fine-grained control for each directory's
files, such as the use of CONFIG_STI_CORE on parisc.
v2:
- sparc: rebased onto Makefile changes
Signed-off-by: Thomas Zimmermann
Cc: "James E.J. Bottomley"
Cc: Helge Deller
Cc: "David S. Miller"
Cc: Andreas Larsson
The per-architecture video helpers do not depend on struct fb_info
or anything else from fbdev. Remove it from the interface and replace
fb_is_primary_device() with video_is_primary_device(). The new helper
is similar in functionality, but can operate on non-fbdev devices.
Signed-off-by: Thomas
change in fbcon, which is
the only caller of fb_is_primary_device().
Patch 3 renames the source and files from fbdev to video.
Thomas Zimmermann (3):
arch: Select fbdev helpers with CONFIG_VIDEO
arch: Remove struct fb_info from video helpers
arch: Rename fbdev header and source files
arch
a few strings and comments to refer to video instead of
fbdev.
Signed-off-by: Thomas Zimmermann
Cc: Vineet Gupta
Cc: Catalin Marinas
Cc: Will Deacon
Cc: Huacai Chen
Cc: WANG Xuerui
Cc: Geert Uytterhoeven
Cc: Thomas Bogendoerfer
Cc: "James E.J. Bottomley"
Cc: Helge Deller
Cc: Michae
for the use of more fine-grained control for each directory's
files, such as the use of CONFIG_STI_CORE on parisc.
Signed-off-by: Thomas Zimmermann
Cc: "James E.J. Bottomley"
Cc: Helge Deller
Cc: "David S. Miller"
Cc: Andreas Larsson
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc:
The per-architecture video helpers do not depend on struct fb_info
or anything else from fbdev. Remove it from the interface and replace
fb_is_primary_device() with video_is_primary_device(). The new helper
is similar in functionality, but can operate on non-fbdev devices.
Signed-off-by: Thomas
Hi
Am 12.05.23 um 13:16 schrieb David Laight:
From: Thomas Zimmermann
Sent: 12 May 2023 11:25
Cast I/O offsets to pointers to use them with I/O functions. The I/O
functions expect pointers of type 'volatile void __iomem *', but the
offsets are plain integers. Build warnings are
../drivers
Replace include statements for with . Fixes
the coding style: if a header is available in asm/ and linux/, it
is preferable to include the header from linux/. This only affects
a few source files, most of which already include .
Suggested-by: Sam Ravnborg
Signed-off-by: Thomas Zimmermann
-by: Thomas Zimmermann
Tested-by: Sui Jingfeng
Reviewed-by: Arnd Bergmann
add mips fb_q()
---
arch/ia64/include/asm/fb.h | 20 +++
arch/loongarch/include/asm/fb.h | 21 +++
arch/mips/include/asm/fb.h | 22 +++
arch/sparc/include/asm/fb.h | 20 +++
include/asm-generic
fb_io_fops.c
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Sam Ravnborg
Reviewed-by: Sui Jingfeng
---
arch/ia64/include/asm/fb.h | 12 ++--
arch/loongarch/include/asm/fb.h | 12 ++--
arch/sparc/include/asm/fb.h | 12
)
* don't include (Sam)
v3:
* add the new helpers in
* support reordering and native byte order (Geert, Arnd)
v2:
* use Linux I/O helpers (Sam, Arnd)
Thomas Zimmermann (7):
fbdev/hitfb: Cast I/O offset to address
fbdev/matrox: Remove trailing whitespaces
ipu-v3: Include
The code uses writel() and similar I/O-memory helpers. Include
the header file to get the declarations.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Sam Ravnborg
Reviewed-by: Sui Jingfeng
---
drivers/video/fbdev/arcfb.c | 1 +
drivers/video/fbdev/aty/atyfb.h
The code uses readl() and writel(). Include the header file to
get the declarations.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Sam Ravnborg
Reviewed-by: Sui Jingfeng
---
drivers/gpu/ipu-v3/ipu-prv.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Sam Ravnborg
Reviewed-by: Sui Jingfeng
Tested-by: Sui Jingfeng
---
drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++---
drivers/video/fbdev/matrox/matroxfb_base.h | 4
g the I/O base address.
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202305102136.emjtspwh-...@intel.com/
Signed-off-by: Thomas Zimmermann
Cc: Artur Rojek
---
drivers/video/fbdev/hitfb.c | 122
1 file changed, 69 insertions(+)
Hi
Am 11.05.23 um 15:05 schrieb Helge Deller:
On 5/11/23 09:55, Thomas Zimmermann wrote:
Hi
Am 10.05.23 um 20:20 schrieb Sui Jingfeng:
Hi, Thomas
I love your patch, yet something to improve:
On 2023/5/10 19:05, Thomas Zimmermann wrote:
Fix coding style. No functional changes.
Signed
Hi
Am 10.05.23 um 17:54 schrieb Arnd Bergmann:
On Wed, May 10, 2023, at 16:27, Thomas Zimmermann wrote:
Am 10.05.23 um 16:15 schrieb Arnd Bergmann:
On Wed, May 10, 2023, at 16:03, kernel test robot wrote:
I think that's a preexisting bug and I have no idea what the
correct solution
Hi
Am 10.05.23 um 17:54 schrieb Arnd Bergmann:
On Wed, May 10, 2023, at 16:27, Thomas Zimmermann wrote:
Am 10.05.23 um 16:15 schrieb Arnd Bergmann:
On Wed, May 10, 2023, at 16:03, kernel test robot wrote:
I think that's a preexisting bug and I have no idea what the
correct solution
Hi
Am 10.05.23 um 20:20 schrieb Sui Jingfeng:
Hi, Thomas
I love your patch, yet something to improve:
On 2023/5/10 19:05, Thomas Zimmermann wrote:
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Sam Ravnborg
Reviewed
Hi Geert
Am 10.05.23 um 16:34 schrieb Geert Uytterhoeven:
Hi Thomas,
On Wed, May 10, 2023 at 4:20 PM Thomas Zimmermann wrote:
Am 10.05.23 um 14:34 schrieb Geert Uytterhoeven:
On Wed, May 10, 2023 at 1:06 PM Thomas Zimmermann wrote:
Implement framebuffer I/O helpers, such as fb_read
here to silence the problem. In the current upstream code,
that appears to be done by sh's __raw_readw() internally:
https://elixir.bootlin.com/linux/latest/source/arch/sh/include/asm/io.h#L35
Best regards
Thomas
Arnd
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solut
Hi Geert
Am 10.05.23 um 14:34 schrieb Geert Uytterhoeven:
Hi Thomas,
On Wed, May 10, 2023 at 1:06 PM Thomas Zimmermann wrote:
Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(),
in the architecture's header file or the generic one.
The common case has been the use
-by: Thomas Zimmermann
Tested-by: Sui Jingfeng
Reviewed-by: Arnd Bergmann
add mips fb_q()
---
arch/ia64/include/asm/fb.h | 20 +++
arch/loongarch/include/asm/fb.h | 21 +++
arch/mips/include/asm/fb.h | 22 +++
arch/sparc/include/asm/fb.h | 20 +++
include/asm-generic
fb_io_fops.c
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Sam Ravnborg
Reviewed-by: Sui Jingfeng
---
arch/ia64/include/asm/fb.h | 12 ++--
arch/loongarch/include/asm/fb.h | 12 ++--
arch/sparc/include/asm/fb.h | 12
Replace include statements for with . Fixes
the coding style: if a header is available in asm/ and linux/, it
is preferable to include the header from linux/. This only affects
a few source files, most of which already include .
Suggested-by: Sam Ravnborg
Signed-off-by: Thomas Zimmermann
The code uses writel() and similar I/O-memory helpers. Include
the header file to get the declarations.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Sam Ravnborg
Reviewed-by: Sui Jingfeng
---
drivers/video/fbdev/arcfb.c | 1 +
drivers/video/fbdev/aty/atyfb.h
in
* support reordering and native byte order (Geert, Arnd)
v2:
* use Linux I/O helpers (Sam, Arnd)
Thomas Zimmermann (6):
fbdev/matrox: Remove trailing whitespaces
ipu-v3: Include
fbdev: Include in various drivers
fbdev: Include instead of
fbdev: Move framebuffer I/O
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Sam Ravnborg
Reviewed-by: Sui Jingfeng
Tested-by: Sui Jingfeng
---
drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++---
drivers/video/fbdev/matrox/matroxfb_base.h | 4
The code uses readl() and writel(). Include the header file to
get the declarations.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Sam Ravnborg
Reviewed-by: Sui Jingfeng
---
drivers/gpu/ipu-v3/ipu-prv.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers
The code uses writel() and similar I/O-memory helpers. Include
the header file to get the declarations.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Sam Ravnborg
Reviewed-by: Sui Jingfeng
---
drivers/video/fbdev/arcfb.c | 1 +
drivers/video/fbdev/aty/atyfb.h
The code uses readl() and writel(). Include the header file to
get the declarations.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Sam Ravnborg
Reviewed-by: Sui Jingfeng
---
drivers/gpu/ipu-v3/ipu-prv.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers
Replace include statements for with . Fixes
the coding style: if a header is available in asm/ and linux/, it
is preferable to include the header from linux/. This only affects
a few source files, most of which already include .
Suggested-by: Sam Ravnborg
Signed-off-by: Thomas Zimmermann
, sparc64: add fb_mem*() to arch headers
to keep current semantics (Arnd)
v3:
* implement all architectures with generic helpers
* support reordering and native byte order (Geert, Arnd)
Signed-off-by: Thomas Zimmermann
Tested-by: Sui Jingfeng
Reviewed-by: Arnd Bergmann
Update the names of the fb_mem*() helpers to be consistent with their
regular counterparts. Hence, fb_memset() now becomes fb_memset_io(),
fb_memcpy_fromfb() now becomes fb_memcpy_fromio() and fb_memcpy_tofb()
becomes fb_memcpy_toio(). No functional changes.
Signed-off-by: Thomas Zimmermann
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Arnd Bergmann
Reviewed-by: Sam Ravnborg
Reviewed-by: Sui Jingfeng
Tested-by: Sui Jingfeng
---
drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++---
drivers/video/fbdev/matrox/matroxfb_base.h | 4
I/O helpers (Sam, Arnd)
Thomas Zimmermann (6):
fbdev/matrox: Remove trailing whitespaces
ipu-v3: Include
fbdev: Include in various drivers
fbdev: Include instead of
fbdev: Move framebuffer I/O helpers into
fbdev: Rename fb_mem*() helpers
arch/ia64/include/asm/fb.h
Hi
Am 04.05.23 um 17:37 schrieb Sam Ravnborg:
Hi Thomas,
On Thu, May 04, 2023 at 09:45:37AM +0200, Thomas Zimmermann wrote:
Replace include statements for with . Fixes
the coding style: if a header is available in asm/ and linux/, it
is preferable to include the header from linux/. This only
Hi
Am 04.05.23 um 10:08 schrieb Arnd Bergmann:
On Thu, May 4, 2023, at 09:45, Thomas Zimmermann wrote:
Fbdev provides helpers for framebuffer I/O, such as fb_readl(),
fb_writel() or fb_memcpy_to_fb(). The implementation of each helper
depends on the architecture, but they are all equivalent
.
On 2023/5/4 15:45, Thomas Zimmermann wrote:
Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(),
in the architecture's header file or the generic one.
The common case has been the use of regular I/O functions, such as
__raw_readb() or memset_io(). A few architectures used plain
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
---
drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++---
drivers/video/fbdev/matrox/matroxfb_base.h | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video
to keep current semantics (Arnd)
v3:
* implement all architectures with generic helpers
* support reordering and native byte order (Geert, Arnd)
Signed-off-by: Thomas Zimmermann
---
arch/ia64/include/asm/fb.h | 20 +++
arch/loongarch/include/asm/fb.h | 21
Replace include statements for with . Fixes
the coding style: if a header is available in asm/ and linux/, it
is preferable to include the header from linux/. This only affects
a few source files, most of which already include .
Suggested-by: Sam Ravnborg
Signed-off-by: Thomas Zimmermann
The code uses readl() and writel(). Include the header file to
get the declarations.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
---
drivers/gpu/ipu-v3/ipu-prv.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/ipu-v3/ipu-prv.h b/drivers/gpu/ipu-v3/ipu-prv.h
index
The code uses writel() and similar I/O-memory helpers. Include
the header file to get the declarations.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
---
drivers/video/fbdev/arcfb.c | 1 +
drivers/video/fbdev/aty/atyfb.h | 2 ++
drivers/video/fbdev/wmt_ge_rops.c | 2 ++
3
Update the names of the fb_mem*() helpers to be consistent with their
regular counterparts. Hence, fb_memset() now becomes fb_memset_io(),
fb_memcpy_fromfb() now becomes fb_memcpy_fromio() and fb_memcpy_tofb()
becomes fb_memcpy_toio(). No functional changes.
Signed-off-by: Thomas Zimmermann
, aarch64, ppc64, parisc, m64k, mips and sparc.
v4:
* keep fb_mem*() as-is on ia64, loongarch, sparc64 (Arnd)
* don't include (Sam)
v3:
* add the new helpers in
* support reordering and native byte order (Geert, Arnd)
v2:
* use Linux I/O helpers (Sam, Arnd)
Thomas
Hi
Am 02.05.23 um 22:06 schrieb Arnd Bergmann:
On Tue, May 2, 2023, at 15:02, Thomas Zimmermann wrote:
Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(),
in the architecture's header file or the generic one.
The common case has been the use of regular I/O functions
Hi
Am 02.05.23 um 22:08 schrieb Sam Ravnborg:
Hi Thomas.
On Tue, May 02, 2023 at 03:02:23PM +0200, Thomas Zimmermann wrote:
Update the names of the fb_mem*() helpers to be consistent with their
regular counterparts. Hence, fb_memset() now becomes fb_memset_io(),
fb_memcpy_fromfb() now becomes
Hi
Am 03.05.23 um 09:19 schrieb Javier Martinez Canillas:
Thomas Zimmermann writes:
Hello Thomas,
Am 02.05.23 um 21:54 schrieb Sam Ravnborg:
On Tue, May 02, 2023 at 03:02:21PM +0200, Thomas Zimmermann wrote:
[...]
#include /* Why should fb driver call console functions?
because
Hi
Am 02.05.23 um 21:54 schrieb Sam Ravnborg:
Hi Thomas,
On Tue, May 02, 2023 at 03:02:21PM +0200, Thomas Zimmermann wrote:
Fbdev's main header file, , includes to get
declarations for I/O helper functions. From these declarations, it
later defines framebuffer I/O helpers, such as fb_{read
Hi Sam
Am 02.05.23 um 22:03 schrieb Sam Ravnborg:
Hi Thomas,
On Tue, May 02, 2023 at 03:02:22PM +0200, Thomas Zimmermann wrote:
Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(),
in the architecture's header file or the generic one.
In reality they are now all
Update the names of the fb_mem*() helpers to be consistent with their
regular counterparts. Hence, fb_memset() now becomes fb_memset_io(),
fb_memcpy_fromfb() now becomes fb_memcpy_fromio() and fb_memcpy_tofb()
becomes fb_memcpy_toio(). No functional changes.
Signed-off-by: Thomas Zimmermann
into . Prepare this change by first
adding an include statement for to .
Include in all source files that use the framebuffer I/O
helpers, so that they still get the necessary I/O functions.
v3:
* fix grammar in commit message
Signed-off-by: Thomas Zimmermann
---
drivers/video/fbdev/arkfb.c
The code uses writel() and similar I/O-memory helpers. Include
the header file to get the declarations.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
---
drivers/video/fbdev/arcfb.c | 1 +
drivers/video/fbdev/aty/atyfb.h | 2 ++
drivers/video/fbdev/wmt_ge_rops.c | 2 ++
3
The code uses readl() and writel(). Include the header file to
get the declarations.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
---
drivers/gpu/ipu-v3/ipu-prv.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/ipu-v3/ipu-prv.h b/drivers/gpu/ipu-v3/ipu-prv.h
index
* support reordering and native byte order (Geert, Arnd)
Signed-off-by: Thomas Zimmermann
---
include/asm-generic/fb.h | 101 +++
include/linux/fb.h | 53
2 files changed, 101 insertions(+), 53 deletions(-)
diff --git a/include/asm-generic
built for a variety of platforms, such as x86-64,
arm, aarch64, ppc64, parisc, m64k, mips and sparc.
v3:
* add the new helpers in
* support reordering and native byte order (Geert, Arnd)
v2:
* use Linux I/O helpers (Sam, Arnd)
Thomas Zimmermann (6):
fbdev/matrox: Remove
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
---
drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++---
drivers/video/fbdev/matrox/matroxfb_base.h | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video
Hi Sam
Am 28.04.23 um 18:54 schrieb Sam Ravnborg:
Hi Thomas,
On Fri, Apr 28, 2023 at 04:18:38PM +0200, Thomas Zimmermann wrote:
I'd be happy to have fb_() wrappers that are I/O helpers without
ordering guarantees. I'd just wouldn't want them in
How about throwing them into a new drm_fb.h
Hi
Am 28.04.23 um 15:17 schrieb Arnd Bergmann:
On Fri, Apr 28, 2023, at 13:27, Geert Uytterhoeven wrote:
On Fri, Apr 28, 2023 at 2:18 PM Robin Murphy wrote:
On 2023-04-28 10:27, Thomas Zimmermann wrote:
-
-#elif defined(__i386__) || defined(__alpha__) || defined(__x86_64__
Hi
Am 28.04.23 um 15:12 schrieb Sam Ravnborg:
Hi Thomas,
On Fri, Apr 28, 2023 at 11:27:11AM +0200, Thomas Zimmermann wrote:
Implement framebuffer I/O helpers, such as fb_read*() and fb_write*()
with Linux' regular I/O functions. Remove all ifdef cases for the
various architectures.
Most
Hi Sam
Am 28.04.23 um 15:07 schrieb Sam Ravnborg:
On Fri, Apr 28, 2023 at 11:27:10AM +0200, Thomas Zimmermann wrote:
Fbdev's main header file, , includes to get
declarations of I/O helper functions. From these declaratons, it later
defines framebuffer I/O helpers, such as fb_{read,write}[bwlq
,
Geert
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
OpenPGP_signature
Description: OpenPGP digital signature
Hi Robin, Geert
Am 28.04.23 um 14:27 schrieb Geert Uytterhoeven:
On Fri, Apr 28, 2023 at 2:18 PM Robin Murphy wrote:
On 2023-04-28 10:27, Thomas Zimmermann wrote:
Implement framebuffer I/O helpers, such as fb_read*() and fb_write*()
with Linux' regular I/O functions. Remove all ifdef cases
helpers. Prepare this change by adding an
include statement for to all source files that use the
framebuffer I/O helpers. They will still get declarations of the I/O
functions even after has been cleaned up. Driver source
files that already include convert to .
Signed-off-by: Thomas Zimmermann
, we can use those instead.
We leave a TODO item to replace all fb_() functions with their regular
I/O counterparts throughout the fbdev drivers.
Signed-off-by: Thomas Zimmermann
---
include/linux/fb.h | 63 +++---
1 file changed, 15 insertions(+), 48
The code uses writel() and similar I/O-memory helpers. Include
the header file to get the declarations.
Signed-off-by: Thomas Zimmermann
---
drivers/video/fbdev/arcfb.c | 1 +
drivers/video/fbdev/aty/atyfb.h | 2 ++
drivers/video/fbdev/wmt_ge_rops.c | 2 ++
3 files changed, 5 insertions
The code uses readl() and writel(). Include the header file to
get the declarations.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/ipu-v3/ipu-prv.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/ipu-v3/ipu-prv.h b/drivers/gpu/ipu-v3/ipu-prv.h
index 291ac1bab66d..d4621b1ea7f1
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++---
drivers/video/fbdev/matrox/matroxfb_base.h | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video/fbdev/matrox/matroxfb_accel.c
and remove the fbdev-specific defines.
The patchset has been built for a variety of platforms, such as x86-64,
arm, aarch64, ppc64, parisc, m64k, mips and sparc.
v2:
* use Linux I/O helpers (Sam, Arnd)
Thomas Zimmermann (5):
fbdev/matrox: Remove trailing whitespaces
ipu-v3: Include
Hi Sam
Am 26.04.23 um 21:21 schrieb Sam Ravnborg:
Hi Thomas.
On Wed, Apr 26, 2023 at 03:04:15PM +0200, Thomas Zimmermann wrote:
Fbdev provides helpers for framebuffer I/O, such as fb_readl(),
fb_writel() or fb_memcpy_to_fb(). The implementation of each helper
depends on the architecture. It's
into . Prepare this change by first
adding an include statement for to .
Include in all source files that use the framebuffer I/O
helpers, so that they still get the necessary I/O functions.
Signed-off-by: Thomas Zimmermann
---
drivers/video/fbdev/arkfb.c | 2 ++
drivers/video/fbdev/aty
, loongarch and m68k operate on system
memory. As framebuffer memory is declared with volatile __iomem, the
helpers add a __force cast to avoid warnings.
Sparc uses SBus to connect framebuffer devices. It provides respective
implementations of the framebuffer I/O helpers.
Signed-off-by: Thomas
The code uses writel() and similar I/O-memory helpers. Include
the header file to get the declarations.
Signed-off-by: Thomas Zimmermann
---
drivers/video/fbdev/arcfb.c | 1 +
drivers/video/fbdev/aty/atyfb.h | 2 ++
drivers/video/fbdev/wmt_ge_rops.c | 2 ++
3 files changed, 5 insertions
, such as x86-64,
arm, aarch64, ppc64, parisc, m64k, mips and sparc.
Thomas Zimmermann (5):
fbdev/matrox: Remove trailing whitespaces
ipu-v3: Include
fbdev: Include in various drivers
fbdev: Include via
fbdev: Move framebuffer I/O helpers into
arch/arc/include/asm/fb.h | 29
The code uses readl() and writel(). Include the header file to
get the declarations.
Signed-off-by: Thomas Zimmermann
---
drivers/gpu/ipu-v3/ipu-prv.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/ipu-v3/ipu-prv.h b/drivers/gpu/ipu-v3/ipu-prv.h
index 291ac1bab66d..d4621b1ea7f1
Fix coding style. No functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++---
drivers/video/fbdev/matrox/matroxfb_base.h | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video/fbdev/matrox/matroxfb_accel.c
Hi
Am 17.04.23 um 16:12 schrieb Arnd Bergmann:
On Mon, Apr 17, 2023, at 14:56, Thomas Zimmermann wrote:
Various architectures provide with helpers for fbdev
framebuffer devices. Share the contained code where possible. There
is already , which implements generic (as in
'empty') functions
Hi
Am 17.04.23 um 16:13 schrieb John Paul Adrian Glaubitz:
Hi Thomas!
On Mon, 2023-04-17 at 16:06 +0200, Thomas Zimmermann wrote:
Hi
Am 17.04.23 um 15:02 schrieb John Paul Adrian Glaubitz:
Hi Thomas!
On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote:
Replace the architecture's
Am 17.04.23 um 16:06 schrieb Thomas Zimmermann:
Hi
Am 17.04.23 um 15:02 schrieb John Paul Adrian Glaubitz:
Hi Thomas!
On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote:
Replace the architecture's fbdev helpers with the generic
ones from . No functional changes.
v2:
* use
Hi
Am 17.04.23 um 15:02 schrieb John Paul Adrian Glaubitz:
Hi Thomas!
On Mon, 2023-04-17 at 14:56 +0200, Thomas Zimmermann wrote:
Replace the architecture's fbdev helpers with the generic
ones from . No functional changes.
v2:
* use default implementation for fb_pgprotect() (Arnd
Replace the architecture's fb_is_primary_device() with the generic
one from . No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Thomas Bogendoerfer
---
arch/mips/include/asm/fb.h | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/mips/include/asm/fb.h
Replace the architecture's fb_is_primary_device() with the generic
one from . No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: Michael Ellerman
Cc: Nicholas Piggin
Cc: Christophe Leroy
Acked-by: Michael Ellerman
---
arch/powerpc/include/asm/fb.h | 8 +++-
1 file changed, 3
Fix trailing whitespaces. No functional changes.
Signed-off-by: Thomas Zimmermann
---
drivers/video/console/sticon.c | 4 +-
drivers/video/console/sticore.c | 102 ++---
drivers/video/fbdev/sticore.h | 14 +--
drivers/video/fbdev/stifb.c | 156
()
Signed-off-by: Thomas Zimmermann
Cc: "David S. Miller"
---
arch/sparc/include/asm/fb.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/sparc/include/asm/fb.h b/arch/sparc/include/asm/fb.h
index 28609f7a965c..689ee5c60054 100644
--- a/arch/spa
.
Cleans up the console makefile and prepares PARISC to implement
fb_is_primary_device() within the arch/ directory. No functional
changes.
Signed-off-by: Thomas Zimmermann
---
drivers/video/Kconfig| 7 +++
drivers/video/Makefile | 1 +
drivers
Move PARISC's implementation of fb_is_primary_device() into the
architecture directory. This the place of the declaration and
where other architectures implement this function. No functional
changes.
Signed-off-by: Thomas Zimmermann
Cc: "James E.J. Bottomley"
Cc: Helge Deller
---
a
Include and set the required preprocessor tokens
correctly. x86 now implements its own set of fb helpers, but still
follows the overall pattern of the other files.
v3:
* clarified commit message
Signed-off-by: Thomas Zimmermann
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: Borislav Petkov
Fix trailing whitespaces. No functional changes.
Signed-off-by: Thomas Zimmermann
Cc: "James E.J. Bottomley"
Cc: Helge Deller
---
arch/parisc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index a2
1 - 100 of 156 matches
Mail list logo
