Re: [PATCH v3 4/4] hwmon: (lm90) use enums for the indexes of temp8 and temp11

2013-07-29 Thread Wei Ni
On 07/27/2013 11:38 PM, Jean Delvare wrote: Hi Wei, On Fri, 12 Jul 2013 15:48:07 +0800, Wei Ni wrote: Using enums for the indexes and nrs of temp8 and temp11. This make the code much more readable. I can't say I'm thrilled by this patch. The improved readability is questionable. In the

Re: [PATCH v3 4/4] hwmon: (lm90) use enums for the indexes of temp8 and temp11

2013-07-27 Thread Jean Delvare
Hi Wei, On Fri, 12 Jul 2013 15:48:07 +0800, Wei Ni wrote: Using enums for the indexes and nrs of temp8 and temp11. This make the code much more readable. I can't say I'm thrilled by this patch. The improved readability is questionable. In the original code, each line already had one constant

[PATCH v3 4/4] hwmon: (lm90) use enums for the indexes of temp8 and temp11

2013-07-12 Thread Wei Ni
Using enums for the indexes and nrs of temp8 and temp11. This make the code much more readable. Signed-off-by: Wei Ni w...@nvidia.com --- drivers/hwmon/lm90.c | 179 -- 1 file changed, 114 insertions(+), 65 deletions(-) diff --git