Re: [PATCH] usbnet: fix race condition caused spinlock bad magic issue

2013-11-11 Thread Ingo Molnar
* wangbiao biao.w...@intel.com wrote: @@ -1448,8 +1448,10 @@ static void usbnet_bh (unsigned long param) // waiting for all pending urbs to complete? if (dev-wait) { + wait_queue_head_t *wait_d = dev-wait; if ((dev-txq.qlen + dev-rxq.qlen +

Re: [PATCH] usb: phy: remove dead code

2013-11-11 Thread Sebastian Andrzej Siewior
On 11/10/2013 07:37 PM, Michal Nazarewicz wrote: From: Michal Nazarewicz min...@mina86.com Thanks. This is the result of a merge. Felipe noticed this a few days back and wanted to take care of this, not sure what the exact status is. Sebastian -- To unsubscribe from this list: send the line

Re: [PATCH] usbnet: fix race condition caused spinlock bad magic issue

2013-11-11 Thread Oliver Neukum
On Mon, 2013-11-11 at 11:08 +0800, wangbiao wrote: From: wang, biao biao.w...@intel.com Date: Mon, 11 Nov 2013 10:23:40 +0800 Subject: [PATCH] usbnet: fix race condition caused spinlock bad magic issue there is race between usbnet_terminate_urbs and usbnet_bh, when unlink_wakeup used in

Re: [RFCv2 1/4] usb: gadget: epautoconf: switch over to usb_endpoint_type()

2013-11-11 Thread Sebastian Andrzej Siewior
On 11/08/2013 07:39 PM, Felipe Balbi wrote: diff --git a/drivers/usb/gadget/epautoconf.c b/drivers/usb/gadget/epautoconf.c index a777f7b..feaaa7b 100644 --- a/drivers/usb/gadget/epautoconf.c +++ b/drivers/usb/gadget/epautoconf.c @@ -58,7 +58,7 @@ ep_matches ( return 0;

Re: [RFCv2 2/4] usb: gadget: ep: add feature flags

2013-11-11 Thread Sebastian Andrzej Siewior
On 11/08/2013 07:39 PM, Felipe Balbi wrote: diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h index 942ef5e..cf1d027 100644 --- a/include/linux/usb/gadget.h +++ b/include/linux/usb/gadget.h @@ -177,6 +183,13 @@ struct usb_ep { u8 address;

[pandaboard] OTG port not working

2013-11-11 Thread Tobias Jakobi
Since suggested by gregkh, here a CC. Greets, Tobias EDIT: Oops, I totally missed the most important bit: https://bugzilla.kernel.org/show_bug.cgi?id=64771 -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo

Re: huawei_cdc_ncm driver

2013-11-11 Thread Bjørn Mork
Thomas Schäfer tschae...@t-online.de writes: The second device with problems is Huawei E3276 (Speedstick LTE III, Telekom, no Hilink, but ipv6-cabable version) This device worked before with SLAAC, now with -next-20131107 it doesn't. Ouch. I noticed after submitting this driver that it

Re: [Pull Request] xhci: Bug fixes, now with more tags!

2013-11-11 Thread Vincent Thiele
This Bug is still not completely solved (Ubuntu 13.10 newest kernel 3.11) Syslog: Nov 2 18:44:29 Arbeits-PC whoopsie[961]: online Nov 2 18:45:41 whoopsie[961]: last message repeated 2 times Nov 2 18:56:27 Arbeits-PC kernel: [ 8411.030685] usb 3-2: USB disconnect, device number 21 Nov 2 18:56:27

Re: [PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-11 Thread Govindarajulu Varadarajan
On Mon, 4 Nov 2013, David Miller wrote: From: Govindarajulu Varadarajan govindarajul...@gmail.com Date: Sat, 2 Nov 2013 19:17:43 +0530 @@ -1030,10 +1030,8 @@ static void ni65_xmit_intr(struct net_device *dev,int csr0) } #ifdef XMT_VIA_SKB -

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-11 Thread Kishon Vijay Abraham I
Hi, On Wednesday 06 November 2013 05:37 AM, Jingoo Han wrote: On Wednesday, November 06, 2013 2:58 AM, Vivek Gautam wrote: On Tue, Nov 5, 2013 at 5:33 PM, Jingoo Han jg1@samsung.com wrote: [.] USB3.0 PHY consists of two blocks such as 3.0 block and 2.0 block. This USB3.0 PHY can

[PATCHv2 2/2] check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-11 Thread Michal Nazarewicz
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs to pad epout buffer to match above condition if quirk is found. Signed-off-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_fs.c | 23

musb: babble interrupt

2013-11-11 Thread Yingchun Li
Hi, On my board, my musb works as host. my kernel version is 3.4.0. The host cannot enumerate some low speed mouse normally,but if I add an extersion cord (abour 1.5m) between the host and device, the mouse can work normally. If the enumeration fails, there is always a babble interrupt happen just

[PATCH] usb: chipidea: udc: first start device on pullup

2013-11-11 Thread Michael Grzeschik
Don't pullup the resistors on hw_device_state. The gadget framework has the prepared callback for this. This is necessary if we use gadgets which need to be enabled after an userspace application got prepared, or other delayed conditiions have passed. Signed-off-by: Michael Grzeschik

[PATCH] usb: gadget: move gadget start to bind of each driver

2013-11-11 Thread Michael Grzeschik
We currently enable the udc on bind_to_driver. This breaks the de/activate mechanism for drivers that depent on userspace components. This patch fixes this by moving the pullup call to each bind. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/usb/gadget/f_acm.c

[PATCH v2] usb: xhci: Link TRB must not occur within a USB payload burst

2013-11-11 Thread David Laight
Section 4.11.7.1 of rev 1.0 of the xhci specification states that a link TRB can only occur at a boundary between underlying USB frames (512 bytes for 480M). If this isn't done the USB frames aren't formatted correctly and, for example, the USB3 ethernet ax88179_178a card will stop sending

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Gustavo Zacarias
On 11/08/2013 04:44 AM, Bjørn Mork wrote: I believe it's nice to document the layout of complex composite devices if known, but if not then I don't see any need to delay a patch like this. From looking at the .inf files from the windows drivers i can't get much info other than:

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Gustavo Zacarias
On 11/09/2013 10:47 AM, Johan Hovold wrote: Ok. Thanks. Gustavo, could you fix up the commit message (the subject line) and resend so we can apply this? Sure, but it was already handled by { USB_VENDOR_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0xff, 0xff, 0xff) } which caused issues without the

[PATCH] usb: xhci: Improve tracing of error events

2013-11-11 Thread David Laight
Even when compiled with USB_DEBUG the diagnostic traces don't contain any values that help diagnose any errors. Trace all the fields from error events. Include the unknown address when the DMA pointer from an event isn't part of the current TD. This will happen if the error code is TRB error.

[PATCHv3] USB: serial: option: add support for Huawei E173s-6

2013-11-11 Thread Gustavo Zacarias
Interface 1 on this device isn't for option to bind to otherwise an oops on usb_wwan with log flooding will happen when accessing the port: tty_release: ttyUSB1: read/write wait queue active! It doesn't seem to respond to QMI if it's added to qmi_wwan so don't add it there - it's likely used by

Re: [pandaboard] OTG port not working

2013-11-11 Thread Kishon Vijay Abraham I
Hi, On Monday 11 November 2013 03:04 PM, Tobias Jakobi wrote: Since suggested by gregkh, here a CC. CONFIG_OMAP_OCP2SCP should also be enabled. Thanks Kishon Greets, Tobias EDIT: Oops, I totally missed the most important bit: https://bugzilla.kernel.org/show_bug.cgi?id=64771 --

[PATCHv4] USB: serial: option: add support for Huawei E173s-6

2013-11-11 Thread Gustavo Zacarias
Interface 1 on this device isn't for option to bind to otherwise an oops on usb_wwan with log flooding will happen when accessing the port: tty_release: ttyUSB1: read/write wait queue active! It doesn't seem to respond to QMI if it's added to qmi_wwan so don't add it there - it's likely used by

[PATCH] usb: xhci: Add support for URB_ZERO_PACKET

2013-11-11 Thread David Laight
If URB_ZERO_PACKET is set on a transfer that is an integral number of maximum length packets (1k for USB3 bulk) then an additional zero length fragment must be sent. Merge together the functions that setup single buffer and scatter-gather transfers (they aren't that different) simplifying the

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Bjørn Mork
Gustavo Zacarias gust...@zacarias.com.ar writes: On 11/08/2013 04:44 AM, Bjørn Mork wrote: I believe it's nice to document the layout of complex composite devices if known, but if not then I don't see any need to delay a patch like this. From looking at the .inf files from the windows

[PATCH 1/4] usb: chipidea: msm: Add device tree binding information

2013-11-11 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/usb/msm-hsusb.txt | 16 1 file changed, 16 insertions(+) diff --git

[PATCH 0/4] usb: chipidea: msm: Clean and fix glue layer driver

2013-11-11 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com Hi, This series intend to fixup driver, which was broken for a while. It is used to create peripheral role device, which in coordination with phy-usb-msm driver (still some cleanups pending) will provide again USB2.0 gadget support for MSM targets.

[PATCH 3/4] usb: chipidea: msm: Initialize offset of the capability registers

2013-11-11 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- drivers/usb/chipidea/ci_hdrc_msm.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c index 747d6c1..e9624f3 100644 ---

[PATCH 2/4] usb: chipidea: msm: Add device tree support

2013-11-11 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com Allows controller to be specified via device tree. Pass PHY phandle specified in DT to core driver. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com Cc: devicet...@vger.kernel.org --- drivers/usb/chipidea/ci_hdrc_msm.c | 23 ++- 1

[PATCH 4/4] usb: chipidea: msm: Use USB PHY API to control PHY state

2013-11-11 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com PHY drivers keep track of the current state of the hardware, so don't change PHY settings under it. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- drivers/usb/chipidea/ci_hdrc_msm.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-)

USB-3.0 suspend/resume issues

2013-11-11 Thread Hans de Goede
Hi All, While reviewing and testing patches for my latest uas patch series, I realized that uas did not have suspend / resume support. Which is not good for a storage driver, since that means a disconnect and reconnect will happen over suspend resume, causing any mounted filesystems on the disk

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Johan Hovold
On Mon, Nov 11, 2013 at 06:47:52AM -0300, Gustavo Zacarias wrote: On 11/09/2013 10:47 AM, Johan Hovold wrote: Ok. Thanks. Gustavo, could you fix up the commit message (the subject line) and resend so we can apply this? Sure, but it was already handled by {

Re: [PATCH] usb: chipidea: udc: first start device on pullup

2013-11-11 Thread Peter Chen
On Mon, Nov 11, 2013 at 12:39:30PM +0100, Michael Grzeschik wrote: Don't pullup the resistors on hw_device_state. The gadget framework has the prepared callback for this. This is necessary if we use gadgets which need to be enabled after an userspace application got prepared, or other delayed

Re: [PATCH 4/4] usb: chipidea: msm: Use USB PHY API to control PHY state

2013-11-11 Thread Peter Chen
On Mon, Nov 11, 2013 at 03:35:37PM +0200, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com PHY drivers keep track of the current state of the hardware, so don't change PHY settings under it. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com ---

Re: [PATCH 0/4] usb: chipidea: msm: Clean and fix glue layer driver

2013-11-11 Thread Peter Chen
On Mon, Nov 11, 2013 at 03:35:33PM +0200, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Hi, This series intend to fixup driver, which was broken for a while. It is used to create peripheral role device, which in coordination with phy-usb-msm driver (still some cleanups

RE: [PATCH] USBNET: fix handling padding packet

2013-11-11 Thread David Laight
As my below test on ax99179_178a, I believe the patch should fix padding for dma sg, but need a little update, and I will send out v1 later: $ping -s 974 another_machine #from host with ax99179_178a attached If FLAG_SEND_ZLP is set for ax99179_178a, the above ping won't work

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Gustavo Zacarias
On 11/11/2013 10:41 AM, Bjørn Mork wrote: One way, if you have access to a Windows system, is observing what happens there. You can look up vid/pid/intfnumber in the Windows device manager. From windows i've got: 3G Modem - usbcdcacm\VID_12D1PID_1C07MI_00 HUAWEI Mobile Connect Network

Re: [PATCH 4/4] usb: chipidea: msm: Use USB PHY API to control PHY state

2013-11-11 Thread Ivan T. Ivanov
Hi Peter, On Mon, 2013-11-11 at 21:59 +0800, Peter Chen wrote: On Mon, Nov 11, 2013 at 03:35:37PM +0200, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com PHY drivers keep track of the current state of the hardware, so don't change PHY settings under it.

Re: [PATCH v2 1/7] usb: dwc3: get usb_phy only if the platform indicates the presence of PHY's

2013-11-11 Thread Kishon Vijay Abraham I
Hi Felipe, On Thursday 17 October 2013 10:08 PM, Felipe Balbi wrote: Hi, On Wed, Oct 16, 2013 at 01:24:11AM +0530, Kishon Vijay Abraham I wrote: There can be systems which does not have a external usb_phy, so get usb_phy only if dt data indicates the presence of PHY in the case of dt boot

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Bjørn Mork
Gustavo Zacarias gust...@zacarias.com.ar writes: With minicom on /dev/cdc-wdm0 after patching qmi_wwan it seems to be responsive to AT commands so yes it seems we are dealing with ECM here. I'll send a followup patch to include qmi_wwan. Maybe run a small discussion on the ModemManager list

Re: [PATCH 0/4] usb: chipidea: msm: Clean and fix glue layer driver

2013-11-11 Thread Ivan T. Ivanov
Hi Peter, On Mon, 2013-11-11 at 22:02 +0800, Peter Chen wrote: On Mon, Nov 11, 2013 at 03:35:33PM +0200, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Hi, This series intend to fixup driver, which was broken for a while. It is used to create peripheral role

Re: [PATCH] usb: chipidea: udc: first start device on pullup

2013-11-11 Thread Michael Grzeschik
On Mon, Nov 11, 2013 at 09:42:35PM +0800, Peter Chen wrote: On Mon, Nov 11, 2013 at 12:39:30PM +0100, Michael Grzeschik wrote: Don't pullup the resistors on hw_device_state. The gadget framework has the prepared callback for this. This is necessary if we use gadgets which need to be enabled

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Dan Williams
On Mon, 2013-11-11 at 15:43 +0100, Bjørn Mork wrote: Gustavo Zacarias gust...@zacarias.com.ar writes: With minicom on /dev/cdc-wdm0 after patching qmi_wwan it seems to be responsive to AT commands so yes it seems we are dealing with ECM here. I'll send a followup patch to include

[PATCH v2] usb: xhci: Use TRB_CYCLE instead of the constant 0x1

2013-11-11 Thread David Laight
This makes it clear that the ring-cycle_state value is used when writing to the actual ring itself. Always use ^= TRB_CYCLE to invert the bit. Signed-off-by: David Laight david.lai...@aculab.com --- Changes for v2: 1 Adjusted so that it should apply to HEAD. (One of the ?: had been changed

Re: [PATCH] usb: musb: gadget: stall when SETUP packet size is invalid

2013-11-11 Thread Bin Liu
While working on v2 - already figured out MUSB_CSR0_P_DATAEND bit also needs to be set - I found a weird thing. For debug purpose, I changed Line 803 in musb_gadget_ep0.c as following to stall all SETUP packets. -if (len != 8) { +if (len == 8) { Then the protocol analyzer shows total 16

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Bjørn Mork
Dan Williams d...@redhat.com writes: On Mon, 2013-11-11 at 15:43 +0100, Bjørn Mork wrote: Maybe run a small discussion on the ModemManager list first? This would be the first non-QMI device there, and I don't think userspace is prepared for that We've got a bug open for this in

RE: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-11 Thread David Laight
From: Alan Stern [mailto:st...@rowland.harvard.edu] On Fri, 8 Nov 2013, David Laight wrote: ... GET_MAX_PACKET always returns MaxPacketSize, and for USB-3 bulk endpoints, MaxPacketSize is always 1024. MaxBurstSize can be anything from 1 to 16. I've just read something that explained about

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Gustavo Zacarias
On 11/11/2013 01:10 PM, Dan Williams wrote: This is a bit confusing... so you added the device to qmi_wwan, and now one of the AT ports works (cdc-wdm0) and the net port also works, as exposed by qmi_wwan? What's the full lsusb -v for this device after it's modeswitched? I looked through

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Bjørn Mork
Gustavo Zacarias gust...@zacarias.com.ar writes: On 11/11/2013 01:10 PM, Dan Williams wrote: This is a bit confusing... so you added the device to qmi_wwan, and now one of the AT ports works (cdc-wdm0) and the net port also works, as exposed by qmi_wwan? What's the full lsusb -v for this

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Dan Williams
On Mon, 2013-11-11 at 18:03 +0100, Bjørn Mork wrote: Dan Williams d...@redhat.com writes: On Mon, 2013-11-11 at 15:43 +0100, Bjørn Mork wrote: Maybe run a small discussion on the ModemManager list first? This would be the first non-QMI device there, and I don't think userspace is

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Dan Williams
On Mon, 2013-11-11 at 18:27 +0100, Bjørn Mork wrote: Gustavo Zacarias gust...@zacarias.com.ar writes: On 11/11/2013 01:10 PM, Dan Williams wrote: This is a bit confusing... so you added the device to qmi_wwan, and now one of the AT ports works (cdc-wdm0) and the net port also works, as

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Bjørn Mork
Dan Williams d...@redhat.com writes: On Mon, 2013-11-11 at 18:03 +0100, Bjørn Mork wrote: Dan Williams d...@redhat.com writes: On Mon, 2013-11-11 at 15:43 +0100, Bjørn Mork wrote: Maybe run a small discussion on the ModemManager list first? This would be the first non-QMI device there,

[PATCH v6 2/2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-11-11 Thread Andrew Lunn
Add a driver which supports the following Moxa USB to serial converters: * 2 ports : UPort 1250, UPort 1250I * 4 ports : UPort 1410, UPort 1450, UPort 1450I * 8 ports : UPort 1610-8, UPort 1650-8 * 16 ports : UPort 1610-16, UPort 1650-16 The UPORT devices don't directy fit

[PATCH v6 1/2] tty: Add C_CMSPAR(tty)

2013-11-11 Thread Andrew Lunn
Add the missing C_CMSPAR(tty) macro. Signed-off-by: Andrew Lunn and...@lunn.ch --- include/linux/tty.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/tty.h b/include/linux/tty.h index 64f864651d86..8d1ba896070a 100644 --- a/include/linux/tty.h +++ b/include/linux/tty.h @@

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Gustavo Zacarias
On 11/11/2013 02:27 PM, Bjørn Mork wrote: If dhcp doesn't work after a successful AT^NDISDUP connection, then there is still a chance that this actuall is a NCM device. That would make things easier in many ways :-) Please try the huawei_cdc_ncm driver, although I am not completely sure

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Dan Williams
On Mon, 2013-11-11 at 18:41 +0100, Bjørn Mork wrote: Dan Williams d...@redhat.com writes: On Mon, 2013-11-11 at 18:03 +0100, Bjørn Mork wrote: Dan Williams d...@redhat.com writes: On Mon, 2013-11-11 at 15:43 +0100, Bjørn Mork wrote: Maybe run a small discussion on the ModemManager

Re: [PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-11 Thread Bjørn Mork
Dan Williams d...@redhat.com writes: So the net-port parts of qmi_wwan just do standard ECM then? Yes. Only the descriptors are weird. The rest is standard ECM. Well, including all the IPv4/IPv6 quirks? No, all the firmware bugs are very implementation specific :-) I don't know if the

Re: [PATCHv2 2/2] check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-11 Thread David Cohen
On 11/11/2013 03:21 AM, Michal Nazarewicz wrote: Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs to pad epout buffer to match above condition if quirk is found. Signed-off-by: Michal Nazarewicz

[PATCH v2] usb: musb: gadget: stall when SETUP packet size is invalid

2013-11-11 Thread Bin Liu
This is required by the USB Specs. Also dump the fifo for debug purpose. Signed-off-by: Bin Liu b-...@ti.com --- v2: - Modification based on Felipe's comments * Added commit log; * Wrapped dump fifo function with #ifdef DEBUG; * Used static buffer for dump; * Changed dump level to

Re: [PATCH 09/12] usb: gadget: r8a66597-udc: Convert to clk_prepare/unprepare

2013-11-11 Thread Felipe Balbi
On Sat, Nov 09, 2013 at 03:09:33PM +0100, Laurent Pinchart wrote: Hi Felipe, On Tuesday 29 October 2013 18:47:19 Shimoda, Yoshihiro wrote: Hi Laurent-san, (2013/10/29 7:49), Laurent Pinchart wrote: Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and

Re: [pandaboard] OTG port not working

2013-11-11 Thread Felipe Balbi
Hi, On Sun, Nov 10, 2013 at 07:58:50PM -0500, Alan Ott wrote: On 11/10/2013 06:14 PM, Tobias Jakobi wrote: Since suggested by gregkh, here a CC. Typically you're going to get a better response on mailing lists if you give a little more information. Start with the following: 1. What

Re: musb: babble interrupt

2013-11-11 Thread Felipe Balbi
Hi, On Mon, Nov 11, 2013 at 07:38:14PM +0800, Yingchun Li wrote: Hi, On my board, my musb works as host. my kernel version is 3.4.0. The host cannot enumerate some low speed mouse normally,but if I add an extersion cord (abour 1.5m) between the host and device, the mouse can work normally.

Re: [PATCH] usb: chipidea: udc: first start device on pullup

2013-11-11 Thread Felipe Balbi
On Mon, Nov 11, 2013 at 12:39:30PM +0100, Michael Grzeschik wrote: Don't pullup the resistors on hw_device_state. The gadget framework has the prepared callback for this. This is necessary if we use gadgets which need to be enabled after an userspace application got prepared, or other delayed

Re: [PATCH 1/2] usb: gadget: f_fs: remove loop from I/O function

2013-11-11 Thread David Cohen
Hi Michal, On 11/10/2013 08:50 AM, Michal Nazarewicz wrote: From: Michal Nazarewicz min...@mina86.com When endpoint changes (due to it being disabled or alt setting changed), mimic the action as if the change happened after the request has been queued, instead of retrying with the new

[PATCH v5 1/5] usb: gadget: move bitflags to the end of usb_gadget struct

2013-11-11 Thread David Cohen
This patch moves all bitflags to the end of usb_gadget struct in order to improve readability. Signed-off-by: David Cohen david.a.co...@linux.intel.com --- include/linux/usb/gadget.h | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git

[PATCH v5 5/5] usb: dwc3: set gadget's quirk ep_out_align_size

2013-11-11 Thread David Cohen
DWC3 requires epout to have buffer size aligned to MaxPacketSize value. This patch sets necessary quirk for it. Signed-off-by: David Cohen david.a.co...@linux.intel.com --- drivers/usb/dwc3/gadget.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c

[PATCH v5 4/5] usb: f_fs: check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-11 Thread David Cohen
From: Michal Nazarewicz min...@mina86.com Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs to pad epout buffer to match above condition if quirk is found. Signed-off-by: Michal Nazarewicz

[PATCH v5 0/5] add gadget quirk to adapt f_fs for DWC3

2013-11-11 Thread David Cohen
Hi, These patches are a proposal to add gadget quirks in an immediate objective to adapt f_fs when using DWC3 controller. But the quirk solution is generic and can be used by other controllers to adapt gadget functions to their non-standard restrictions. This change is necessary to make

[PATCH v5 2/5] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget

2013-11-11 Thread David Cohen
Due to USB controllers may have different restrictions, usb gadget layer needs to provide a generic way to inform gadget functions to complain with non-standard requirements. This patch adds 'quirk_ep_out_aligned_size' field to struct usb_gadget to inform when controller's epout requires buffer

[PATCH v5 3/5] usb: gadget: f_fs: remove loop from I/O function

2013-11-11 Thread David Cohen
From: Michal Nazarewicz min...@mina86.com When endpoint changes (due to it being disabled or alt setting changed), mimic the action as if the change happened after the request has been queued, instead of retrying with the new endpoint. Signed-off-by: Michal Nazarewicz min...@mina86.com Cc: David

Re: [PATCHv2 2/2] check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-11 Thread Alan Stern
On Mon, 11 Nov 2013, Michal Nazarewicz wrote: Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs to pad epout buffer to match above condition if quirk is found. Signed-off-by: Michal Nazarewicz

RE: [PATCH] usb: xhci: Link TRB must not occur with a USB payload burst.

2013-11-11 Thread Alan Stern
On Mon, 11 Nov 2013, David Laight wrote: Suppose, for example, the MBP is 1024. If you have a TD with length 1500, and if it had only one fragment, the last (and only) fragment's length would not less than the MBP and it would not be an exact multiple of the MBP. That doesn't matter -

Re: [PATCHv2 2/2] check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-11 Thread Michal Nazarewicz
On Mon, Nov 11 2013, Alan Stern wrote: On Mon, 11 Nov 2013, Michal Nazarewicz wrote: Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs to pad epout buffer to match above condition if quirk is

Re: [PATCHv2 2/2] check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-11 Thread Michal Nazarewicz
On Mon, Nov 11 2013, David Cohen wrote: But the whole series became messy with too many amends. If you don't mind, I'll send a v5 of my patch set including my v4.1 patches + your 2 ones following the correct sequence. Please do, but as Alan pointed out my second patch needs some fixes, namely

Re: [PATCH 1/2] usb: gadget: f_fs: remove loop from I/O function

2013-11-11 Thread Michal Nazarewicz
On 11/10/2013 08:50 AM, Michal Nazarewicz wrote: +if (wait_event_interruptible(epfile-wait, (ep = epfile-ep))) { On Mon, Nov 11 2013, David Cohen wrote: FYI this line fails checkpatch: ERROR: do not use assignment in if condition #70: FILE: drivers/usb/gadget/f_fs.c:777: +

Re: [PATCH v4 1/3] usb: ehci: add freescale imx28 special write register method

2013-11-11 Thread Marc Kleine-Budde
On 10/30/2013 04:06 AM, Peter Chen wrote: According to Freescale imx28 Errata, ENGR119653 USB: ARM to USB register error issue, All USB register write operations must use the ARM SWP instruction. So, we implement a special ehci_write for imx28. Discussion for it at below:

Re: [PATCH v4 2/3] usb: chipidea: add freescale imx28 special write register method

2013-11-11 Thread Marc Kleine-Budde
On 10/30/2013 04:06 AM, Peter Chen wrote: According to Freescale imx28 Errata, ENGR119653 USB: ARM to USB register error issue, All USB register write operations must use the ARM SWP instruction. So, we implement special hw_write and hw_test_and_clear for imx28. Discussion for it at below:

Re: [pandaboard] OTG port not working

2013-11-11 Thread Tobias Jakobi
Kishon Vijay Abraham I wrote: CONFIG_OMAP_OCP2SCP should also be enabled. Suggestion tried and getting new (interesting) messages from the kernel. Updated the bug: https://bugzilla.kernel.org/show_bug.cgi?id=64771 - Tobias -- To unsubscribe from this list: send the line unsubscribe linux-usb

Re: [PATCH v4 3/3] usb: chipidea: imx: set CI_HDRC_IMX28_WRITE_FIX for imx28

2013-11-11 Thread Marc Kleine-Budde
On 10/30/2013 04:06 AM, Peter Chen wrote: Due to imx28 needs ARM swp instruction for writing, we set CI_HDRC_IMX28_WRITE_FIX for imx28. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci_hdrc_imx.c | 32 ++-- 1 files changed, 26

Re: gadget: should usb_ep_enable() clear EP STALL?

2013-11-11 Thread Felipe Balbi
Hi, On Fri, Nov 01, 2013 at 09:26:41AM +0100, Johannes Stezenbach wrote: Hi, On Thu, Oct 31, 2013 at 10:21:28AM -0500, Felipe Balbi wrote: On Thu, Oct 31, 2013 at 04:02:20PM +0100, Johannes Stezenbach wrote: On Wed, Oct 30, 2013 at 10:44:30PM +0100, Johannes Stezenbach wrote: On Wed,

Re: [PATCHv2 2/2] check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-11 Thread David Cohen
Hi Alan, Michal, On 11/11/2013 01:09 PM, Michal Nazarewicz wrote: On Mon, Nov 11 2013, Alan Stern wrote: On Mon, 11 Nov 2013, Michal Nazarewicz wrote: Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io()

[PATCH] usb: gadget: composite: reset delayed_status on reset_config

2013-11-11 Thread Michael Grzeschik
The delayed_status value is used to keep track of status response packets on ep0. It needs to be reset or the set_config function would still delay the answer, if the usb device got unplugged while waiting for setup_continue to be called. Cc: sta...@vger.kernel.org Signed-off-by: Michael

Re: [PATCH 1/2] usb: gadget: f_fs: remove loop from I/O function

2013-11-11 Thread David Cohen
Hi Michal, On 11/10/2013 08:50 AM, Michal Nazarewicz wrote: From: Michal Nazarewicz min...@mina86.com When endpoint changes (due to it being disabled or alt setting changed), mimic the action as if the change happened after the request has been queued, instead of retrying with the new

Re: [PATCHv2 2/2] check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-11 Thread David Cohen
On 11/11/2013 03:21 AM, Michal Nazarewicz wrote: Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs to pad epout buffer to match above condition if quirk is found. Signed-off-by: Michal Nazarewicz

Re: [PATCH v5 3/5] usb: gadget: f_fs: remove loop from I/O function

2013-11-11 Thread David Cohen
On 11/11/2013 12:16 PM, David Cohen wrote: From: Michal Nazarewicz min...@mina86.com When endpoint changes (due to it being disabled or alt setting changed), mimic the action as if the change happened after the request has been queued, instead of retrying with the new endpoint. Signed-off-by:

Re: [PATCH v5 2/5] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget

2013-11-11 Thread Michal Nazarewicz
On Mon, Nov 11 2013, David Cohen wrote: Due to USB controllers may have different restrictions, usb gadget layer needs to provide a generic way to inform gadget functions to complain with non-standard requirements. This patch adds 'quirk_ep_out_aligned_size' field to struct usb_gadget to

[PATCHv5.1 3/5] usb: gadget: f_fs: remove loop from I/O function

2013-11-11 Thread Michal Nazarewicz
When endpoint changes (due to it being disabled or alt setting changed), mimic the action as if the change happened after the request has been queued, instead of retrying with the new endpoint. Signed-off-by: Michal Nazarewicz min...@mina86.com Cc: David Cohen david.a.co...@linux.intel.com ---

[PATCHv5.1 4/5] check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-11 Thread Michal Nazarewicz
Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs to pad epout buffer to match above condition if quirk is found. Signed-off-by: Michal Nazarewicz min...@mina86.com --- drivers/usb/gadget/f_fs.c | 10

Re: [PATCH v5 2/5] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget

2013-11-11 Thread David Cohen
On 11/11/2013 03:55 PM, Michal Nazarewicz wrote: On Mon, Nov 11 2013, David Cohen wrote: Due to USB controllers may have different restrictions, usb gadget layer needs to provide a generic way to inform gadget functions to complain with non-standard requirements. This patch adds

Re: [PATCHv5.1 4/5] check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-11 Thread David Cohen
Hi Michal, On 11/11/2013 03:58 PM, Michal Nazarewicz wrote: Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs to pad epout buffer to match above condition if quirk is found. Signed-off-by: Michal

Re: [PATCH v4 1/3] usb: ehci: add freescale imx28 special write register method

2013-11-11 Thread Peter Chen
On Mon, Nov 11, 2013 at 10:32:51PM +0100, Marc Kleine-Budde wrote: On 10/30/2013 04:06 AM, Peter Chen wrote: According to Freescale imx28 Errata, ENGR119653 USB: ARM to USB register error issue, All USB register write operations must use the ARM SWP instruction. So, we implement a special

Re: [PATCH v4 3/3] usb: chipidea: imx: set CI_HDRC_IMX28_WRITE_FIX for imx28

2013-11-11 Thread Peter Chen
On Mon, Nov 11, 2013 at 10:37:07PM +0100, Marc Kleine-Budde wrote: On 10/30/2013 04:06 AM, Peter Chen wrote: Due to imx28 needs ARM swp instruction for writing, we set CI_HDRC_IMX28_WRITE_FIX for imx28. Signed-off-by: Peter Chen peter.c...@freescale.com ---

Re: [PATCH] usb: chipidea: udc: first start device on pullup

2013-11-11 Thread Peter Chen
On Mon, Nov 11, 2013 at 04:37:26PM +0100, Michael Grzeschik wrote: On Mon, Nov 11, 2013 at 09:42:35PM +0800, Peter Chen wrote: On Mon, Nov 11, 2013 at 12:39:30PM +0100, Michael Grzeschik wrote: Don't pullup the resistors on hw_device_state. The gadget framework has the prepared callback

Re: [PATCH 10/16] usb/gadget: FunctionFS: Remove VLAIS usage from gadget code

2013-11-11 Thread Andrzej Pietrasiewicz
W dniu 08.11.2013 16:38, Sebastian Andrzej Siewior pisze: On 11/08/2013 04:01 PM, Andrzej Pietrasiewicz wrote: Hello Sebastian, Hallo Andrzej, Please correct me if I'm wrong but I think it is not possible to use usb_gstrings_attach(). Basically, usb_gstrings_attach() requires struct

Re: [PATCH] usb: chipidea: udc: first start device on pullup

2013-11-11 Thread Michael Grzeschik
On Mon, Nov 11, 2013 at 02:00:36PM -0600, Felipe Balbi wrote: On Mon, Nov 11, 2013 at 12:39:30PM +0100, Michael Grzeschik wrote: Don't pullup the resistors on hw_device_state. The gadget framework has the prepared callback for this. This is necessary if we use gadgets which need to be