...@wwwdotorg.org]
Sent: Wednesday, December 04, 2013 9:29 AM
To: Chris Ruehl; ba...@ti.com
Cc: gre...@linuxfoundation.org; thierry.red...@gmail.com; linux-
u...@vger.kernel.org; linux-te...@vger.kernel.org; linux-
ker...@vger.kernel.org; Venu Byravarasu
Subject: Re: [PATCH] usb: phy-tegra-usb.c
-Original Message-
From: Chris Ruehl [mailto:chris.ru...@gtsys.com.hk]
Sent: Monday, November 18, 2013 11:56 AM
To: linux-usb@vger.kernel.org; Venu Byravarasu; Greg Kroah-Hartman
Subject: phy-tegra-usb.c: wrong pointer check for remap UTMI
While I hunt an other problem with my
GPIO
6) Added nvidia,is-wired property to indicate whether the device is
hard wired on the board, or pluggable.
This patch fixes the binding definition to resolve these issues.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v3:
Added a blank line at EOF of nvidia,tegra20
the driver has been updated to assume the new bindings.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v3:
Added status field to USB PHY DT nodes.
delta from v2:
1. Removed dr_mode setting to otg, due to lack of knowledge of all Vbus
supplies,
on all target platforms.
2. All
Added a new PHY mode to support OTG.
Obtained Tegra USB PHY mode using DT property.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v3 v2:
No change
delta from v1:
replaced gadget with peripheral.
drivers/usb/host/ehci-tegra.c |1 -
drivers/usb/phy/phy-tegra
based handling in host driver.
Made use of DT params to get the PHY Pad registers.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v3:
Removed functions pointers to access PORTSC registers from PHY accessing
them from PHY using exported functions.
delta from v2:
Rebased to TOT
As GPIO information is avail through DT, used it to get Tegra ULPI
reset GPIO number. Added a new member to tegra_usb_phy structure to
store this number.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1, v2 v3: no change.
drivers/usb/phy/phy-tegra-usb.c | 25
In case if clk_get_sys fails, return correct error value provided by
the API.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1, v2 v3: no change.
drivers/usb/phy/phy-tegra-usb.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy
1. All Tegra20 ULPI reset GPIO DT properties are modified to indicate active
low nature of the GPIO.
2. Placed USB PHY DT node immediately below the EHCI controller DT nodes
and corrected reg value in the name of USB PHY DT node.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta
delta from v3:
This patch series is prepared as follow up of TEGRA USB PHY driver patch series
discussed at: https://lkml.org/lkml/2013/5/10/241
Venu Byravarasu (8):
ARM: tegra: finalize USB EHCI and PHY bindings
arm: dt: Tegra20: Modify ULPI reset GPIO properties
ARM: tegra: update device
delta from v2:
This patch is prepared as follow up patch of TEGRA USB PHY driver
patch series discussed at:
http://marc.info/?l=linux-tegram=136497946026787w=2
Venu Byravarasu (10):
ARM: tegra: finalize USB EHCI and PHY bindings
arm: dt: Tegra20: Modify ULPI reset GPIO properties
ARM: tegra
GPIO
6) Added nvidia,is-wired property to indicate whether the device is
hard wired on the board, or pluggable.
This patch fixes the binding definition to resolve these issues.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1:
1. added UTMI PHY timing params.
2. replaced
based handling in host driver.
Made use of DT params to get the PHY Pad registers.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1:
1. Removed extra memory allocation for u_phy-otg
2. Moved ulpi_init code into separate function.
3. Initializing all clk and GPIOs in probe.
4
Changes with this patch:
1. As PHY is being registered as separate platform driver EHCI Tegra
is no more calling PHY open, moved tegra_ehci_set_pts tegra_ehci_set_phcd
functions to PHY driver,
2. Removed unused defines for multiple USB port base addresses
Signed-off-by: Venu Byravarasu
Added a new PHY mode to support OTG.
Obtained Tegra USB PHY mode using DT property.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1:
replaced gadget with peripheral.
delta from v2:
No change
drivers/usb/host/ehci-tegra.c |3 +--
drivers/usb/phy/phy-tegra-usb.c
In case if clk_get_sys fails, return correct error value provided by
the API.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1 v2: no change.
drivers/usb/phy/phy-tegra-usb.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy
Check return values from all GPIO APIs and handle errors accordingly.
Remove the call to clk_disable_unprepare(); this function does not
prepare or enable the clock, so the error path should not disable or
unprepare it.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1
As GPIO information is avail through DT, used it to get Tegra ULPI
reset GPIO number. Added a new member to tegra_usb_phy structure to
store this number.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1 v2: no change.
drivers/usb/phy/phy-tegra-usb.c | 25
This reverts commit ee5d5499edb94cd03738a52a7e234b139da8fd72.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
As PHY is being registered as separate driver, solution proposed with
this patch cannot work anymore.
Hence pushed patch 10 of this series to address the issue.
drivers/usb
changes with this patch:
1. All Tegra20 ULPI reset GPIO DT properties are modified to indicate active
low nature of the GPIO.
2. Placed USB PHY DT node immediately below the EHCI controller DT nodes
and corrected reg value in the name of USB PHY DT node.
Signed-off-by: Venu Byravarasu vbyravar
.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1:
1. Fixed voltage regulators were used for vbus-supply
2. Added UTMI PHY timing Parameters to DT.
delta from v2:
1. Removed dr_mode setting to otg, due to:
a. Any ways existing Tegra USB driver does not support OTG.
b. lack
-Original Message-
From: linux-tegra-ow...@vger.kernel.org [mailto:linux-tegra-
ow...@vger.kernel.org] On Behalf Of Stephen Warren
Sent: Thursday, April 04, 2013 12:38 AM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; ba...@ti.com;
st...@rowland.harvard.edu; linux-te
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Thursday, April 04, 2013 1:06 AM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; ba...@ti.com;
st...@rowland.harvard.edu; linux-te...@vger.kernel.org; linux-
u...@vger.kernel.org; linux-ker
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Thursday, April 04, 2013 12:47 AM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; ba...@ti.com;
st...@rowland.harvard.edu; linux-te...@vger.kernel.org; linux-
u...@vger.kernel.org; linux-ker
As GPIO information is avail through DT, used it to get Tegra ULPI
reset GPIO number. Added a new member to tegra_usb_phy structure to
store this number.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v2: no change.
drivers/usb/phy/phy-tegra-usb.c | 25
Check return values from all GPIO APIs and handle errors accordingly.
Remove clk_disable_unprepare which is no more needed.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v2: no change.
drivers/usb/phy/phy-tegra-usb.c | 50 ++
1 files
based handling in host driver.
Made use of DT params to get the PHY Pad registers.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1:
1. Removed extra memory allocation for u_phy-otg
2. Moved ulpi_init code into separate function.
3. Initializing all clk and GPIOs in probe.
4
In case if clk_get_sys fails, return correct error value provided by
the API.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1: no change.
drivers/usb/phy/phy-tegra-usb.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-tegra
the driver has been updated to assume the new bindings.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1:
1. Fixed voltage regulators were used for vbus-supply
2. Added UTMI PHY timing Parameters to DT.
arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 ++
arch/arm/boot/dts
delta from v1:
This patch is prepared as follow up patch of TEGRA USB PHY driver
patch series being discussed at:
http://marc.info/?l=linux-tegram=136361016003625w=2
Venu Byravarasu (7):
ARM: tegra: finalize USB EHCI and PHY bindings
ARM: tegra: update device trees for USB binding rework
Added a new PHY mode to support OTG.
Obtained Tegra USB PHY mode using DT property.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1:
replaced gadget with peripheral.
drivers/usb/host/ehci-tegra.c |3 +--
drivers/usb/phy/phy-tegra-usb.c | 13
To clear any configurations made by U-Boot on Tegra USB controller,
reset it before init in probe.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
Acked-by: Alan Stern st...@rowland.harvard.edu
Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org
reviewed-by: Stephen Warren swar
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Tuesday, April 02, 2013 9:02 PM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu; linux-
u...@vger.kernel.org; linux-ker...@vger.kernel.org
Subject: Re: [PATCH] usb: host: tegra
) and is therefore NULL. Add a separate label for error
unwinding and initialize the transceiver field to ERR_PTR(-ENODEV) when
the operating mode isn't TEGRA_USB_OTG to allow for consistent checking.
This change looks good to me.
Acked-by: Venu Byravarasu vbyravar...@nvidia.com
Signed-off
-Original Message-
From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org]
Sent: Tuesday, March 05, 2013 6:04 AM
To: Stephen Warren
Cc: Venu Byravarasu; st...@rowland.harvard.edu; linux-
u...@vger.kernel.org; linux-ker...@vger.kernel.org
Subject: Re: [PATCH] usb: host
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Wednesday, March 20, 2013 1:22 AM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-te
-Original Message-
From: Venu Byravarasu
Sent: Wednesday, March 20, 2013 11:30 AM
To: 'Stephen Warren'
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-te...@vger.kernel.org; devicetree-disc
-Original Message-
From: kishon [mailto:kis...@ti.com]
Sent: Wednesday, March 20, 2013 4:49 PM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;
swar...@wwwdotorg.org; linux-te
-Original Message-
From: kishon [mailto:kis...@ti.com]
Sent: Wednesday, March 20, 2013 4:53 PM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;
swar...@wwwdotorg.org; linux-te
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Wednesday, March 20, 2013 1:24 AM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-te
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Wednesday, March 20, 2013 1:29 AM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-te
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Wednesday, March 20, 2013 5:55 PM
To: Venu Byravarasu
Cc: kishon; gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;
swar...@wwwdotorg.org
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Wednesday, March 20, 2013 1:51 AM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-te
register space. We can't assume the PHY1
driver is present, so the PHY3 driver will directly access those
registers.
3) The list of clocks required by the PHY was missing some required
entries.
This patch fixes the binding definition to resolve these issues.
Signed-off-by: Venu Byravarasu vbyravar
As GPIO information is avail through DT, used it to get Tegra ULPI
reset GPIO number. Added a new member to tegra_usb_phy structure to
store this number.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
drivers/usb/phy/tegra_usb_phy.c | 25 +++--
include/linux
based handling in host driver.
Made use of DT params to get the PHY Pad registers.
Merged tegra_phy_init into tegra_usb_phy_init.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
drivers/usb/host/ehci-tegra.c | 99 ++--
drivers/usb/phy/tegra_usb_phy.c | 308
the driver has been updated to assume the new bindings.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++
arch/arm/boot/dts/tegra20-harmony.dts |8 +++---
arch/arm/boot/dts/tegra20-iris-512.dts |4 +++
arch/arm/boot/dts
Added a new PHY mode to support OTG.
Obtained Tegra USB PHY mode using DT property.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
drivers/usb/host/ehci-tegra.c |3 +--
drivers/usb/phy/tegra_usb_phy.c | 13 +++--
include/linux/usb/tegra_usb_phy.h |3 ++-
3
In case if clk_get_sys fails, return correct error value provided by
the API.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
drivers/usb/phy/tegra_usb_phy.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy
As part of this series, apart from patch containing changes to register TEGRA
USB PHY driver as platform driver, prepared below patches:
1. Re-arranging adding new DT properties.
2. Getting various params from DT properties added.
3. code clean up.
Venu Byravarasu (7):
ARM: tegra: finalize USB
-Original Message-
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
ow...@vger.kernel.org] On Behalf Of Sergei Shtylyov
Sent: Monday, March 18, 2013 6:32 PM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-usb@vger.kernel.org
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Friday, March 08, 2013 1:08 PM
To: Venu Byravarasu
Cc: Stephen Warren; Felipe Balbi; Linux USB Mailing List; Greg KH; linux-
te...@vger.kernel.org; s.ha...@pengutronix.de; sachin.ka...@linaro.org;
aletes@gmail.com
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Thursday, February 28, 2013 11:47 PM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu; linux-
u...@vger.kernel.org; linux-ker...@vger.kernel.org
Subject: Re: [PATCH] usb: host
To clear any configurations made by U-Boot on Tegra USB controller,
reset it before init in probe.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
When U-Boot configures a Tegra USB controller in device mode and if the EHCI
driver of kernel tries to set it to HOST mode, message irq 52
As drivers/usb/otg/otg.c contains most of the PHY related APIs which
are not OTG specific, moving them to more logical place under
drivers/usb/phy.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v2:
renamed usb_phy.c to phy.c.
delta from v1:
Missed adding newly created file
-Original Message-
From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-
ow...@vger.kernel.org] On Behalf Of Stephen Warren
Sent: Thursday, February 07, 2013 10:26 PM
To: kishon
Cc: Venu Byravarasu; ba...@ti.com; gre...@linuxfoundation.org; linux-
ker...@vger.kernel.org
As pointer to PHY structure can be stored in struct usb_hcd
making use of it, to call Tegra PHY APIs.
Call to usb_phy_shutdown() is moved up in tegra_ehci_remove(),
so that to avoid dereferencing of hcd after its freed up.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
First version
As drivers/usb/otg/otg.c contains most of the PHY related APIs
which are not OTG specific, moving them to more logical place
under driver/usb/phy.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
drivers/usb/otg/otg.c| 184 --
drivers/usb
As drivers/usb/otg/otg.c contains most of the PHY related APIs
which are not OTG specific, moving them to more logical place
under driver/usb/phy.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1:
Missed adding newly created file usb_phy.c with previous patch.
hence sending
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Tuesday, January 22, 2013 4:31 PM
To: Venu Byravarasu
Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org;
linux-ker...@vger.kernel.org
Subject: Re: [PATCH] usb: phy: moving all PHY API definitions
-Original Message-
From: Roger Quadros [mailto:rog...@ti.com]
Sent: Tuesday, January 22, 2013 7:51 PM
To: Venu Byravarasu
Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org;
linux-ker...@vger.kernel.org
Subject: Re: [PATCH v2] usb: phy: moving all PHY API
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Wednesday, January 23, 2013 6:03 AM
To: Venu Byravarasu
Cc: Alan Stern; Greg Kroah-Hartman; linux-te...@vger.kernel.org; linux-arm-
ker...@lists.infradead.org; linux-usb@vger.kernel.org; Stephen Warren
-Original Message-
From: linux-tegra-ow...@vger.kernel.org [mailto:linux-tegra-
ow...@vger.kernel.org] On Behalf Of Stephen Warren
Sent: Wednesday, January 23, 2013 5:58 AM
To: Alan Stern; Greg Kroah-Hartman; Stephen Warren
Cc: Venu Byravarasu; linux-te...@vger.kernel.org; linux-arm
As Tegra PHY driver need to access one of the Host registers,
added few APIs to ehci tegra driver.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1:
Taken care of RWC bits, while accessing PORTSC register.
drivers/usb/host/ehci-tegra.c | 70
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Thursday, January 17, 2013 2:33 PM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;
swar...@wwwdotorg.org; linux-te
-Original Message-
From: Alan Stern [mailto:st...@rowland.harvard.edu]
Sent: Thursday, January 17, 2013 8:45 PM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; ba...@ti.com; linux-usb@vger.kernel.org;
linux-ker...@vger.kernel.org; swar...@wwwdotorg.org; linux-
te
-Original Message-
From: Venu Byravarasu
Sent: Friday, January 18, 2013 10:26 AM
To: 'Alan Stern'
Cc: gre...@linuxfoundation.org; ba...@ti.com; linux-usb@vger.kernel.org;
linux-ker...@vger.kernel.org; swar...@wwwdotorg.org; linux-
te...@vger.kernel.org
Subject: RE: [PATCH v2 4/4
As Tegra PHY driver needs to access one of the Host registers,
added few APIs.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v2:
Renamed USB_PORTSC1 to TEGRA_USB_PORTSC1.
Removed tegra_ehci_set_wakeon_events() and its references.
Used standard defines for accessing PORTSC
PHY driver and added APIs to ehci driver for
this purpose.
Venu Byravarasu (4):
arm: tegra: Add DT nodes for Tegra USB PHY
USB: PHY: Get rid of instance number to differentiate legacy
controller
USB: PHY: Tegra: Get rid of instance number to differentiate PHY type
usb: Add APIs
As Tegra PHY driver needs to access one of the Host registers,
added few APIs.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
drivers/usb/host/ehci-tegra.c | 71 -
drivers/usb/phy/tegra_usb_phy.c | 51 +++
include
Add DT nodes for Tegra USB PHY along with related documentation.
Also added a phandle property to controller DT node, for referring
to connected PHY instance.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
.../bindings/usb/nvidia,tegra20-ehci.txt |1 +
.../bindings/usb
Tegra20 USB has 3 PHY instances. Instance 0 is based on
legacy PHY interface and other two are standard interfaces.
As instance number was used to differentiate legacy from
standard interfaces, used DT param to get this info and
processed accordingly.
Signed-off-by: Venu Byravarasu vbyravar
Tegra20 USB has 3 PHY instances:
Instance 1 and 3 are UTMI. Instance 2 is ULPI.
As instance number was used to differentiate ULPI from UTMI,
used DT param to get this info and processed accordingly.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
drivers/usb/phy/tegra_usb_phy.c
As tegra_usb_phy_clk_disable/enable() are not being
used, removing them.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
drivers/usb/phy/tegra_usb_phy.c | 13 -
include/linux/usb/tegra_usb_phy.h |4
2 files changed, 0 insertions(+), 17 deletions(-)
diff --git
Thanks Stephen.
Venu
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Saturday, December 22, 2012 2:25 AM
To: Venu Byravarasu
Cc: ba...@ti.com; gre...@linuxfoundation.org; sshtyl...@mvista.com;
linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Wednesday, December 19, 2012 11:08 PM
To: Venu Byravarasu
Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-
ker...@vger.kernel.org; linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: phy: tegra: Using
Use kzalloc instead of kmalloc to allocate struct tegra_usb_phy.
This ensures that all function pointers in member u_phy are
initialized to NULL.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
This patch is v3 patch for the patch discussed at
http://marc.info/?l=linux-kernelm
on USB PHY instance 1 UTMI is
used on other two instances. Hence modified PHY type
detection also from instance number to the parameter
passed from host driver.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
As PHY instance 2 is of UTMI type with non legacy interface,
replaced phy
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Tuesday, December 18, 2012 10:03 PM
To: Venu Byravarasu
Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-
ker...@vger.kernel.org; linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: phy: tegra: Using
Using devm_kzalloc for allocating memory needed for PHY
pointer and hence removing kfree calls to PHY pointer.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
drivers/usb/phy/tegra_usb_phy.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/phy
As pointer to PHY structure can be stored in struct usb_hcd
making use of it, to call PHY APIs.
Call to usb_phy_shutdown() is moved up in tegra_ehci_remove(),
so that to avoid dereferencing of hcd after its freed up.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
This patch depends
to reset the port second time.
Venu Byravarasu (2):
arm: tegra: Add new DT property to USB node.
usb: host: tegra: Resetting PORT0 based on information received via
DT.
.../bindings/usb/nvidia,tegra20-ehci.txt |2 ++
arch/arm/boot/dts/tegra20.dtsi |1
As Tegra USB host driver is using instance number for resetting
PORT0 twice, adding a new DT property for handling this.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
.../bindings/usb/nvidia,tegra20-ehci.txt |2 ++
arch/arm/boot/dts/tegra20.dtsi
Tegra USB host driver is using port instance number,
to handle some of the hardware issues on SOC e.g. reset PORT0
twice etc. As instance number based handling looks ugly,
making use of information passed through DT for achieving this.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
-Original Message-
From: Venu Byravarasu
Sent: Monday, October 22, 2012 4:04 PM
To: 'ba...@ti.com'
Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-
u...@vger.kernel.org; linux-ker...@vger.kernel.org
Subject: RE: [PATCH v3 resend] USB: PHY: Re-organize Tegra USB PHY
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Friday, October 19, 2012 9:06 PM
To: Venu Byravarasu
Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org;
ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org
Subject: Re: [PATCH v3 resend] USB
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Monday, October 22, 2012 3:33 PM
To: Venu Byravarasu
Cc: ba...@ti.com; st...@rowland.harvard.edu;
gre...@linuxfoundation.org; linux-usb@vger.kernel.org; linux-
ker...@vger.kernel.org
Subject: Re: [PATCH v3 resend
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Monday, October 22, 2012 3:46 PM
To: Venu Byravarasu
Cc: ba...@ti.com; st...@rowland.harvard.edu;
gre...@linuxfoundation.org; linux-usb@vger.kernel.org; linux-
ker...@vger.kernel.org
Subject: Re: [PATCH v3 resend
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Wednesday, October 03, 2012 4:19 AM
To: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org; linux-te...@vger.kernel.org; Stephen
Warren; Venu Byravarasu
Subject: [PATCH] usb: host: tegra remove include
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Wednesday, October 03, 2012 4:20 AM
To: Felipe Balbi
Cc: Greg Kroah-Hartman; linux-usb@vger.kernel.org; linux-
te...@vger.kernel.org; Stephen Warren; Venu Byravarasu
Subject: [PATCH] usb: phy: tegra remove
-Original Message-
From: ABRAHAM, KISHON VIJAY [mailto:kis...@ti.com]
Sent: Monday, September 24, 2012 11:48 AM
To: Venu Byravarasu
Cc: Stephen Warren; ba...@ti.com; gre...@linuxfoundation.org; linux-
ker...@vger.kernel.org; linux-usb@vger.kernel.org
Subject: Re: [PATCH v3] USB: PHY
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Friday, September 21, 2012 3:07 PM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; ba...@ti.com; Stephen Warren; linux-
ker...@vger.kernel.org; linux-usb@vger.kernel.org; linux-
te...@vger.kernel.org; Stephen
.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v2:
Added an if condition to check for device_node to be not NULL,
before dereferencing it.
drivers/usb/host/ehci-tegra.c | 26 +-
drivers/usb/phy/Makefile |1 +
.../usb/phy
Thanks Greg, for quick response.
Venu
-Original Message-
From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org]
Sent: Thursday, September 20, 2012 5:30 PM
To: Venu Byravarasu
Cc: ba...@ti.com; Stephen Warren; linux-ker...@vger.kernel.org; linux-
u...@vger.kernel.org
Hi Greg Felipe,
Can any of you please review and merge this change?
Thanks,
Venu
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Thursday, September 13, 2012 10:49 PM
To: Venu Byravarasu
Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org;
ba
.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
delta from v1:
1. Added two new phy_open functions, which will be called based
on the phy type being used.
2. Moved function pointer initialization to these two functions.
3. Renamed usb_phy_ops to tegra_usb_phy_ops.
4. Moved
Thanks Kishon, for your comments.
Plz see my answers inline.
-Original Message-
From: ABRAHAM, KISHON VIJAY [mailto:kis...@ti.com]
Sent: Thursday, September 13, 2012 3:25 PM
To: Venu Byravarasu
Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org;
ba...@ti.com; Stephen Warren
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Wednesday, September 12, 2012 11:41 PM
To: Venu Byravarasu
Cc: ba...@ti.com; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: host: tegra: code clean up
On 09/12/2012 01
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Thursday, September 13, 2012 12:06 AM
To: Venu Byravarasu
Cc: ba...@ti.com; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org;
linux-te...@vger.kernel.org
Subject: Re: [PATCH] USB: phy: re-organize
Forgot to address some of the comments made by stephen, in my previous update.
Hence addressing them now.
Thanks a lot Stephen, for detailed review.
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Thursday, September 13, 2012 12:06 AM
To: Venu Byravarasu
1 - 100 of 117 matches
Mail list logo
