Dan == Dan Carpenter dan.carpen...@oracle.com writes:
Dan The callers expect this function to return zero on success or -EIO if it
Dan times out. The type should be int instead of unsigned short.
Dan Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Acked-by: Peter Korsgaard jac
sensible. The fixes are independent of eachother, so they should be
submitted as 3 seperate patches.
Could you resend as 3 seperate git formatted patches please?
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
Dave == Dave Tubbs dave.tu...@portalislc.com writes:
Dave From: Dave Tubbs dave.tu...@portalislc.com
Dave TD data length is 10 bits, correct TD_PORTLENMASK_DL. Reference
Dave Cypress Semiconductor BIOS User's Manual 1.2, page 3-10
Thanks, content looks good.
Acked-by: Peter Korsgaard jac
Acked-by: Peter Korsgaard jac...@sunsite.dk
Dave ---
Dave drivers/usb/c67x00/c67x00-sched.c |2 +-
Dave 1 files changed, 1 insertions(+), 1 deletions(-)
Dave diff --git a/drivers/usb/c67x00/c67x00-sched.c
b/drivers/usb/c67x00/c67x00-sched.c
Dave index a03fbc1..aa2262f 100644
Dave
Dave == Dave Tubbs dave.tu...@portalislc.com writes:
Dave From: Dave Tubbs dave.tu...@portalislc.com
Dave RetryCnt value in c67x00 TD should be 3 (both bits set to 1). Reference
Dave Cypress Semiconductor BIOS User's Manual 1.2, page 3-14
Acked-by: Peter Korsgaard jac...@sunsite.dk
Dave
trailing spaces on the last line.
Dave /* Sequence ok and acked, don't need to fix toggle */
Dave ack_ok = 1;
Dave --
Dave 1.7.1
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
-by: Dave Tubbs dave.tu...@portalislc.com
Acked-by: Peter Korsgaard jac...@sunsite.dk
Dave ---
Dave drivers/usb/c67x00/c67x00-sched.c |6 ++
Dave 1 files changed, 6 insertions(+), 0 deletions(-)
Dave diff --git a/drivers/usb/c67x00/c67x00-sched.c
b/drivers/usb/c67x00/c67x00-sched.c
Dave
mode as well, but am currently stuck working
on non-am335x stuff - So I'm definately interested in getting it to
work, but don't have free cycles to look into it right now.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message
tristate Renesas M66592 USB Peripheral Controller
Danielhelp
Daniel --
Daniel 1.8.1.4
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
Daniel == Daniel Mack zon...@gmail.com writes:
Daniel Let the function declarations live in the header files they belong to,
Daniel which makes it easier to stub them out later.
Daniel Signed-off-by: Daniel Mack zon...@gmail.com
Acked-by: Peter Korsgaard jac...@sunsite.dk
Daniel
Daniel == Daniel Mack zon...@gmail.com writes:
Daniel In particular, this introduces musb_host_resume_root_hub()and
Daniel musb_host_poke_root_hub() which will be stubbed out later.
Daniel Signed-off-by: Daniel Mack zon...@gmail.com
Acked-by: Peter Korsgaard jac...@sunsite.dk
--
Bye
Daniel == Daniel Mack zon...@gmail.com writes:
Daniel This will be done from a more appropriate location and as it doesn't
Daniel work anyway, it can safely be removed before the other changes.
Daniel Signed-off-by: Daniel Mack zon...@gmail.com
Acked-by: Peter Korsgaard jac...@sunsite.dk
musb_to_hcd(MUSB) ((MUSB)-hcd)
I dislike the capitals, but as it's going away later:
Acked-by: Peter Korsgaard jac...@sunsite.dk
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info
musb_hdrc-$(CONFIG_USB_MUSB_GADGET)$(CONFIG_USB_MUSB_DUAL_ROLE) +=
musb_gadget_ep0.o musb_gadget.o
Other than that, it looks good:
Acked-by: Peter Korsgaard jac...@sunsite.dk
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message
Daniel == Daniel Mack zon...@gmail.com writes:
Daniel This patch re-introduces the bits that are necessary to use the musb
Daniel controller in host mode.
Acked-by: Peter Korsgaard jac...@sunsite.dk
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux
Daniel documented but in fact unusued.
Daniel Signed-off-by: Daniel Mack zon...@gmail.com
It would have been nice to add an explicit reference to am33xx-usb.txt /
omap-usb.txt for the bindings, but that's minor (should those files be
combined?)
Acked-by: Peter Korsgaard jac...@sunsite.dk
-by: Peter Korsgaard jac...@sunsite.dk
Daniel ---
Daniel drivers/usb/musb/musb_core.c| 22 +-
Daniel drivers/usb/musb/musb_virthub.c | 3 ++-
Daniel 2 files changed, 19 insertions(+), 6 deletions(-)
Daniel diff --git a/drivers/usb/musb/musb_core.c
b/drivers/usb
musb_host.c
Daniel Signed-off-by: Daniel Mack zon...@gmail.com
You seem to have forgotten to remove the musb_to_hcd() implementation.
With that fixed:
Acked-by: Peter Korsgaard jac...@sunsite.dk
Daniel ---
Daniel drivers/usb/musb/musb_core.c| 4 ++--
Daniel drivers/usb/musb/musb_host.c| 8
Daniel == Daniel Mack zon...@gmail.com writes:
Daniel This function has its only user in musb_virthub.c, so let's move it
Daniel there and make it static.
Daniel Signed-off-by: Daniel Mack zon...@gmail.com
Acked-by: Peter Korsgaard jac...@sunsite.dk
Daniel ---
Daniel drivers/usb/musb
.
Daniel Signed-off-by: Daniel Mack zon...@gmail.com
Daniel Acked-by: Peter Korsgaard jac...@sunsite.dk
Daniel ---
Daniel drivers/usb/musb/musb_core.c| 22 +-
Daniel drivers/usb/musb/musb_virthub.c | 3 ++-
Daniel 2 files changed, 19 insertions(+), 6 deletions
in the musb struct.
Daniel struct hc_driver musb_hc_driver can now also be static to musb_host.c,
Daniel and the macro musb_to_hcd() is just a pointer dereferencer for now, and
Daniel will be eliminated later.
Daniel Signed-off-by: Daniel Mack zon...@gmail.com
Daniel Acked-by: Peter Korsgaard jac
that it's an unneeded extra level of indirection.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
this work!
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Ming == Ming Lei ming@canonical.com writes:
Ming Use usbnet_link_change to handle link change centrally.
Acked-by: Peter Korsgaard jac...@sunsite.dk
Ming Cc: Peter Korsgaard jac...@sunsite.dk
Ming Signed-off-by: Ming Lei ming@canonical.com
Ming ---
Ming drivers/net/usb/dm9601.c
David == David Brownell [EMAIL PROTECTED] writes:
Hi,
David On Tuesday 06 November 2007, Peter Korsgaard wrote:
Commit a4e3ef5... (USB: gadget: gadget_is_{dualspeed,otg} predicates and
cleanup) broke fsl_usb2_udc. udc-gadget is a struct usb_gadget, not a
pointer to one.
Signed-off
interface (16bit SRAM-like parallel bus).
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
---
drivers/usb/c67x00/c67x00-ll-hpi.c | 426 +
drivers/usb/c67x00/c67x00.h| 289 +
2 files changed, 715 insertions(+)
Index: linux
behaviours; it
just controls access to the chip.
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
---
MAINTAINERS |6 +
drivers/usb/c67x00/c67x00-drv.c | 236
include/linux/usb/c67x00.h | 48
3 files changed, 290
and this series?
Sure, http://peter.korsgaard.com/c67x00-v3-v4.patch (not posting as
it's more than 100k)
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
of a reason to demand multiple upstream links, though
David sharing them between root hubs like that isn't a common structure.
David - Dave
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo
:
- Addressed Grant's comments (c67x00_dev-c67x00_hcd_dev, label indent)
- Moved c67x00_ll_set_ep_{ctrl,packet_size}_reg() to patch 4 as they are
only needed for gadget support.
- Added c67x00_ prefix to struct lcp_int_data
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line
USB_C67X00_HCD
+ bool Cypress C67X00 HCD support
+ depends on USB USB_C67X00_DRV
+ default y
+ help
+ Enable this option to support the Cypress C67x00 in host
+ controller mode.
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe
This patch adds HCD support for the Cypress c67x00 family of devices.
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
---
drivers/usb/Makefile |2
drivers/usb/c67x00/Makefile| 11
drivers/usb/c67x00/c67x00-drv.c| 13
drivers/usb/c67x00/c67x00-hcd.c| 410
USB_C67X00_HCD
+ bool Cypress C67X00 HCD support
+ depends on USB USB_C67X00_DRV
+ default y
+ help
+ Enable this option to support the Cypress C67x00 in host
+ controller mode.
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe
interface (16bit SRAM-like parallel bus).
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
---
drivers/usb/c67x00/c67x00-ll-hpi.c | 410 +
drivers/usb/c67x00/c67x00.h| 285 +
2 files changed, 695 insertions(+)
Index: linux
as they are
only needed for gadget support.
- Added c67x00_ prefix to struct lcp_int_data
Changes since v3:
- Lots of cleanups: checkpatch, interrupt handling, c67x00_ prefixes, ..
- The dummy platform_device's created per serial engine are gone.
- Gadget driver (WIP)
--
Bye, Peter Korsgaard
Alan == Alan Stern [EMAIL PROTECTED] writes:
Alan On Tue, 29 Jan 2008, Peter Korsgaard wrote:
This patch adds HCD support for the Cypress c67x00 family of devices.
--- /dev/null
+++ linux-2.6/drivers/usb/c67x00/c67x00-hcd.c
+int c67x00_urb_dequeue(struct usb_hcd *hcd, struct urb *urb
, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
The config symbol for mpc834x processors is CONFIG_PPC_MPC834x,
not CONFIG_MPC834x.
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index d97b16b..2dd0544 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
USB_C67X00_HCD
+ bool Cypress C67X00 HCD support
+ depends on USB USB_C67X00_DRV
+ default y
+ help
+ Enable this option to support the Cypress C67x00 in host
+ controller mode.
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe
created per serial engine are gone.
- Gadget driver (WIP)
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
{ctrl,packet_size}_reg() to patch 4 as they are
only needed for gadget support.
Changes since v3:
- Lots of cleanups: checkpatch, interrupt handling, c67x00_ prefixes, ..
- The dummy platform_device's created per serial engine are gone.
- Gadget driver (WIP)
--
Bye, Peter Korsgaard
)
+{
+}
+#endif /* CONFIG_USB_C67X00_HCD */
/* -
* Transfer Descriptor scheduling functions
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
interface (16bit SRAM-like parallel bus).
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
Acked-by: David Brownell [EMAIL PROTECTED]
---
drivers/usb/c67x00/c67x00-ll-hpi.c | 405 +
drivers/usb/c67x00/c67x00.h| 285 ++
2 files
This patch adds HCD support for the Cypress c67x00 family of devices.
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
---
drivers/usb/Makefile |2
drivers/usb/c67x00/Makefile| 11
drivers/usb/c67x00/c67x00-drv.c| 13
drivers/usb/c67x00/c67x00-hcd.c| 412
and then move it once the gadget
driver gets finished/merged, but that seems silly to me..
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Greg == Greg KH [EMAIL PROTECTED] writes:
Greg On Wed, Feb 20, 2008 at 10:07:27AM +0100, Peter Korsgaard wrote:
The Cypress c67x00 (EZ-Host/EZ-OTG) controllers are multi-role low/fullspeed
USB controllers. This patch series implements a HCD driver and shows the
work-in-progress status
haven't seen it before. The other things it complains about seems to
be rubbish though (except for the single indented label).
I'll send a v9 series shortly.
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED
warning with the advent of 2.6.25-rc1, but
Greg that's no reason to ignore it :)
Sure. it's fixed in the v9 series.
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
engine are gone.
- Gadget driver (WIP)
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
behaviours; it
just controls access to the chip.
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
Acked-by: David Brownell [EMAIL PROTECTED]
---
MAINTAINERS |6 +
drivers/usb/c67x00/c67x00-drv.c | 229
include/linux/usb/c67x00.h
)
+{
+}
+#endif /* CONFIG_USB_C67X00_HCD */
/* -
* Transfer Descriptor scheduling functions
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
the
David normal alphabetical order convention, so maybe one big
David cleanup patch would be in order ... but still, I'd rather see
David such new options added in the right place, rather than need
David to see them fixed up later.
And this as well.
--
Bye, Peter Korsgaard
-
To unsubscribe from
This patch adds HCD support for the Cypress c67x00 family of devices.
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
---
drivers/usb/Makefile |2
drivers/usb/c67x00/Makefile|9
drivers/usb/c67x00/c67x00-drv.c| 13
drivers/usb/c67x00/c67x00-hcd.c| 412
interface (16bit SRAM-like parallel bus).
Signed-off-by: Peter Korsgaard [EMAIL PROTECTED]
Acked-by: David Brownell [EMAIL PROTECTED]
---
drivers/usb/c67x00/c67x00-ll-hpi.c | 405 +
drivers/usb/c67x00/c67x00.h| 285 ++
2 files
USB_EHCI_ROOT_HUB_TT
Anton - default y if MPC834x || PPC_MPC831x
Notice that I have a patch in the USB queue which fixes up the MPC834x
symbol (PPC_MPC834x instead of MPC834x) so this patch won't apply.
--
Bye, Peter Korsgaard
-
To unsubscribe from this list: send the line unsubscribe linux-usb
On Fri, Feb 22, 2008 at 2:36 AM, Peter Korsgaard [EMAIL PROTECTED] wrote:
Notice that I have a patch in the USB queue which fixes up the MPC834x
symbol (PPC_MPC834x instead of MPC834x) so this patch won't apply.
Never mind, Greg fixed it.
--
Bye, Peter Korsgaard
-
To unsubscribe from
+};
Joseph +
Joseph +module_usb_driver(dm9620_driver);
Joseph +
Joseph +MODULE_AUTHOR(Peter Korsgaard jac...@sunsite.dk);
I'm not the author of this file.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
into writing a driver for it / extending dm9601.c. Please
contact me off list for that.
Thanks!
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
infrastructure already, with the exception
of the call to print_hex_dump(). So move everything to the dynamic
debug infrastructure, including one odd printk(KERN_DEBUG...) line that
looks like it was forgotten about a long time ago.
Cc: Peter Korsgaard jac...@sunsite.dk
Signed-off-by: Greg
kthread+0x72/0x78
ret_from_kernel_thread+0x8/0xc
Signed-off-by: Max Filippov jcmvb...@gmail.com
Acked-by: Peter Korsgaard pe...@korsgaard.com
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More
,write}_reg.
It would be good to add a sensible named define (with the above
description) as a comment and use that instead of the magic 125 constant
in the code.
With that fixed:
Acked-by: Peter Korsgaard pe...@korsgaard.com
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line
Nicolas == Nicolas Ferre nicolas.fe...@atmel.com writes:
Nicolas On 11/19/2012 07:21 PM, Bill Pemberton :
CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.
Signed-off-by: Bill Pemberton wf...@virginia.edu
Cc: Peter Korsgaard jac...@sunsite.dk
Cc
-by: Peter Korsgaard jac...@sunsite.dk
---
drivers/usb/serial/ftdi_sio.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 8c3379b..e1203bd 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial
since 2009 or so.
It could very well be that the numbers are wrong.
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
do this automatically without an explicit action from the user.
How common are these adapters without valid eeprom? What happens if the
eeprom content isn't fixed?
Do we need to reset the device once the eeprom is updated?
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "
8-bytes data to host per interrupt-interval */
> +dm_write_reg(dev, DM_USB_CTRL, USB_CTRL_EP3ACK);
Why would we want to do that instead of the current setup that afaik
only returns data when the link status changes?
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubs
d function dm9601_set_eeprom which tested good with ethtool
> utility.
Thanks for the patch. This sounds like 3 seperate changes, could you
please restructure it as 3 patches each doing one of the changes?
--
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "uns
67 matches
Mail list logo
