On Mon, 12 Aug 2013 gre...@linuxfoundation.org wrote:

> This is a note to let you know that I've just added the patch titled
> 
>     usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET
> 
> to my usb git tree which can be found at
>     git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
> in the usb-next branch.
> 
> The patch will show up in the next release of the linux-next tree
> (usually sometime within the next 24 hours during the week.)
> 
> The patch will also be merged in the next major kernel release
> during the merge window.
> 
> If you have any questions about this process, please let me know.
> 
> 
> From 9841f37a1cca5357c1fd198b1068c12955aa632f Mon Sep 17 00:00:00 2001
> From: Manu Gautam <mgau...@codeaurora.org>
> Date: Thu, 8 Aug 2013 16:49:24 -0700
> Subject: usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET
> 
> The USB Embedded High-speed Host Electrical Test (EHSET) defines the
> SINGLE_STEP_SET_FEATURE test as follows:
> 
> 1) The host enumerates the test device with VID:0x1A0A, PID:0x0108
> 2) The host sends the SETUP stage of a GetDescriptor(Device)
> 3) The device ACKs the request
> 4) The host issues SOFs for 15 seconds allowing the test operator to
>    raise the scope trigger just above the SOF voltage level
> 5) The host sends the IN packet
> 6) The device sends data in response, triggering the scope
> 7) The host sends an ACK in response to the data
> 
> This patch adds additional handling to the EHCI hub driver and allows
> the EHSET driver to initiate this test mode by issuing a a SetFeature
> request to the root hub with a Test Selector value of 0x06. From there
> it mimics ehci_urb_enqueue() but separately submits QTDs for the
> SETUP and DATA/STATUS stages in order to insert a delay in between.
> 
> Signed-off-by: Manu Gautam <mgau...@codeaurora.org>
> Acked-by: Alan Stern <st...@rowland.harvard.edu>
> [ja...@codeaurora.org: imported from commit c2084930 on codeaurora.org;
>  minor cleanup and updated author email]
> Signed-off-by: Jack Pham <ja...@codeaurora.org>
> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

Okay, I was a little too late and Greg has merged the patch.

Jack or Manu, can you write a follow-on patch that adds a Kconfig 
option to enable test modes in the HCDs, and then avoids compiling the 
new code added to ehci-hcd if the config option is disabled?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to