Re: [linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-30 Thread Al Borchers
Jaako -- Jaakko Niemi wrote: Next, does anyone have ideas why an Edgeport/4 using the io_ti driver does not work with 2.4.26 untill I unplug the box and plug it in again? Same ohci hardware. I saw a similar problem on the Edgeport 421--don't know if that is related to the problem you are seeing

Re: [linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-30 Thread Al Borchers
Jaakko -- Jaakko Niemi wrote: Next, does anyone have ideas why an Edgeport/4 using the io_ti driver does not work with 2.4.26 untill I unplug the box and plug it in again? Same ohci hardware. One other thing to check--the Edgeport 4 is actually 2 2 port devices behind an embedded hub.

Re: [linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-28 Thread Jaakko Niemi
On Thu, 24 Jun 2004, Jaakko Niemi wrote: On Mon, 21 Jun 2004, Al Borchers wrote: Jaakko -- Here is a patch against 2.4.26 for io_edgeport.c that I am testing. The driver still has problems, but you can try this out if you want. Thanks for the patch. It's been in use few days with

Re: [linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-24 Thread Jaakko Niemi
On Mon, 21 Jun 2004, Al Borchers wrote: Jaakko -- Here is a patch against 2.4.26 for io_edgeport.c that I am testing. The driver still has problems, but you can try this out if you want. Thanks for the patch. It's been in use few days with ciscos attached to the Edgeport, and no problems

Re: [linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-21 Thread Al Borchers
(Jaako pointed out that the patch had extra spaces added--sorry. Here it is again without the spaces.) Jaakko -- Here is a patch against 2.4.26 for io_edgeport.c that I am testing. The driver still has problems, but you can try this out if you want. This includes the changes needed to fix the

Re: [linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-20 Thread Al Borchers
Jaakko -- Here is a patch against 2.4.26 for io_edgeport.c that I am testing. The driver still has problems, but you can try this out if you want. This includes the changes needed to fix the 2.4.26 OHCI problem you found, along with some other changes: fix for oops on disconnect, and spin locks to

Re: [linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-17 Thread Al Borchers
On Tue, 15 Jun 2004, Al Borchers wrote: I will make this change and try to test it out on OHCI. I have made the change to defer the submit_urb in the interrupt callback and tested on OHCI. The driver no longer locks when opening a port, and I can send some data in both directions. However,

[linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-15 Thread Jaakko Niemi
Hello, Can anyone give pointers where to start looking for more information about the problem below? My little experience so far is with nic drivers and I don't have time to start reading on usb guts, unfortunately. - Forwarded message from Jaakko Niemi [EMAIL PROTECTED] - From:

Re: [linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-15 Thread Al Borchers
Jaakko Niemi wrote: I have couple different problems with two different Edgeport boxes, which are hooked into a Dell PowerEdge 1750 with ServerWorks OSB4/CSB5 ohci usb controller, running 2.4.26 without any patches. First, with older Edgeport/8, if I try to access any of /dev/ttyUSBx devices,

Re: [linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-15 Thread Johannes Erdfelt
On Tue, Jun 15, 2004, Al Borchers [EMAIL PROTECTED] wrote: Skimming through the usb-ohci.c code quickly, it seems that OHCI calls the interrupt urb completion handlers for periodic interrupt urbs with its ohci_t ohci_lock spin lock held. (See hc_interrupt, dl_done_list, and sohci_return_urb.)

Re: [linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-15 Thread Jaakko Niemi
On Tue, 15 Jun 2004, Al Borchers wrote: I will make this change and try to test it out on OHCI. Ok, if you have a patch, I can test it. Sorry, that I cannot do anything more atm. --j --- This SF.Net email is sponsored by

Re: [linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-15 Thread Al Borchers
Johannes Erdfelt wrote: UHCI had a similar problem. We just created a list of completions and added the URB to that list and then called the completions later in the interrupt with no locks held. And it looks like OHCI does something similar for bulk, control, and one-shot interrupt urbs. But

Re: [linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-15 Thread David Brownell
Al Borchers wrote: Johannes Erdfelt wrote: UHCI had a similar problem. We just created a list of completions and added the URB to that list and then called the completions later in the interrupt with no locks held. And it looks like OHCI does something similar for bulk, control, and one-shot

Re: [linux-usb-devel] [liiwi@lonesom.pp.fi: Re: [Linux-usb-users] Edgeport problems]

2004-06-15 Thread Al Borchers
David Brownell wrote: And 2.6 cleans up that locking wierdness, as well as others. Though to be honest, I don't remember this as a 2.4 issue; is that from those recent OHCI changes? I don't know the history, but these changes (the ohci_lock spin lock and postponing the callback or not until after