[linux-usb-devel] Re: [PATCH] queue usb hotplug events

2003-06-09 Thread Olaf Hering
On Sun, Jun 08, Olaf Hering wrote: touch ${REMOVER}.queue.$$ It should be ' ${REMOVER}.queue.$$' to avoid yet another process. Gruss Olaf -- USB is for mice, FireWire is for men! --- This SF.net email is sponsored by: Etnus,

[linux-usb-devel] Re: [PATCH] queue usb hotplug events

2003-06-09 Thread David Brownell
Olaf Hering wrote: there is a hardcoded sleep 3 in the usb.agent. But this is wrong, because the kernel runs all hotplug events at once for a new hub. The result is that every event still runs in parallel, just 3 seconds later. That sleep is a workaround for uhci and usb-uhci bugs: you can

[linux-usb-devel] Re: [PATCH] queue usb hotplug events

2003-06-09 Thread Olaf Hering
On Sun, Jun 08, David Brownell wrote: Olaf Hering wrote: there is a hardcoded sleep 3 in the usb.agent. But this is wrong, because the kernel runs all hotplug events at once for a new hub. The result is that every event still runs in parallel, just 3 seconds later. That sleep is a

Re: [linux-usb-devel] Re: [PATCH] queue usb hotplug events

2003-06-09 Thread David Brownell
Olaf Hering wrote: Running parallel isn't a bug, doesn't need to be changed. Typically the agents just finish faster that way. You could drop the sleep 3 at all if you argue that way. No, that works around (partially) that bug in the 2.4 (and older) UHCI drivers. It's often seen with usbfs, but

[linux-usb-devel] Re: [PATCH] queue usb hotplug events

2003-06-08 Thread Olaf Hering
On Sat, Jun 07, David Brownell wrote: Olaf Hering wrote: Hi, there is a hardcoded sleep 3 in the usb.agent. But this is wrong, because the kernel runs all hotplug events at once for a new hub. The result is that every event still runs in parallel, just 3 seconds later. That sleep is a

[linux-usb-devel] Re: [PATCH] queue usb hotplug events

2003-06-07 Thread David Brownell
Olaf Hering wrote: Hi, there is a hardcoded sleep 3 in the usb.agent. But this is wrong, because the kernel runs all hotplug events at once for a new hub. The result is that every event still runs in parallel, just 3 seconds later. That sleep is a workaround for uhci and usb-uhci bugs: they don't

[linux-usb-devel] Re: [PATCH] queue usb hotplug events

2003-06-07 Thread Olaf Hering
On Sat, Jun 07, David Brownell wrote: Olaf Hering wrote: Hi, there is a hardcoded sleep 3 in the usb.agent. But this is wrong, because the kernel runs all hotplug events at once for a new hub. The result is that every event still runs in parallel, just 3 seconds later. That sleep is a

[linux-usb-devel] Re: [PATCH] queue usb hotplug events

2003-06-07 Thread David Brownell
Olaf Hering wrote: That sleep is a workaround for uhci and usb-uhci bugs: they don't queue control transfers. No complete user mode workaround is possible; it doesn't affect just hotplug, or even just usbfs-based applications. my patch fixes the timeouts. Have you even tried it? Actually it's

[linux-usb-devel] Re: [PATCH] queue usb hotplug events

2003-06-07 Thread Olaf Hering
On Sat, Jun 07, David Brownell wrote: Olaf Hering wrote: That sleep is a workaround for uhci and usb-uhci bugs: they don't queue control transfers. No complete user mode workaround is possible; it doesn't affect just hotplug, or even just usbfs-based applications. my patch fixes the