Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-13 Thread Robert Marquardt
Alan Stern schrieb: However I did make up a list of source files which seem to use UTF-8 in a nontrivial or interesting way: ./drivers/s390/char/keyboard.c ./drivers/firmware/efivars.c ./drivers/char/n_tty.c ./drivers/char/vt.c ./drivers/char/keyboard.c ./fs/nls/nls_base.c

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-12 Thread Robert Marquardt
Alan Stern schrieb: Well, I don't know whether case conversion of Unicode or UTF-8 strings is needed anywhere in the kernel. I don't propose to add routines to handle it in the upcoming library. If you want to add them, you are welcome to do so -- assuming you can avoid provoking loud

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-12 Thread Robert Marquardt
Alan Stern schrieb: I have already done the review; how else could I have justified the comments above? Where can i read it? - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-12 Thread Alan Stern
On Tue, 12 Jun 2007, Robert Marquardt wrote: Alan Stern schrieb: I have already done the review; how else could I have justified the comments above? Where can i read it? You can't, because it isn't written down -- it exists mostly in my head. However I did make up a list of source

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-08 Thread Robert Marquardt
Alan Stern schrieb: The current Unicode usage in the kernel is not nearly as simple as you seem to think. It includes lots of local assumptions, features that aren't documented or commented, special-purpose inline code, and so on. Converting it all to use a single centralized library

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-08 Thread Alan Stern
On Fri, 8 Jun 2007, Nicolas Mailhot wrote: Le mardi 05 juin 2007 à 17:00 -0400, Alan Stern a écrit : Here's a patch. Anybody see anything wrong with it? I don't have any devices with non-ASCII characters in the default language descriptors for testing. It would be nice if there

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-08 Thread Alan Stern
On Fri, 8 Jun 2007, Robert Marquardt wrote: Alan Stern schrieb: The current Unicode usage in the kernel is not nearly as simple as you seem to think. It includes lots of local assumptions, features that aren't documented or commented, special-purpose inline code, and so on.

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-08 Thread Ken Moffat
On Fri, Jun 08, 2007 at 08:15:44AM +0200, Robert Marquardt wrote: Alan Stern schrieb: full handling of Unicode? You must be kidding. Do you have any idea how difficult it is to do something as simple as converting between lower- and uppercase? If it is required somewhere in the

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-07 Thread Robert Marquardt
Alan Stern schrieb: Any suggestions for the best way to organize all this? First a list of all files handling Unicode and a list of all files in need of handling Unicode is needed (for all Linux). A first step would be to centralize the various implementations. Then unification into a single

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-07 Thread Alan Stern
On Thu, 7 Jun 2007, Robert Marquardt wrote: Alan Stern schrieb: Any suggestions for the best way to organize all this? First a list of all files handling Unicode and a list of all files in need of handling Unicode is needed (for all Linux). A first step would be to centralize the

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-07 Thread David Brownell
On Thursday 07 June 2007, Alan Stern wrote: full handling of Unicode? You must be kidding. Do you have any idea how difficult it is to do something as simple as converting between lower- and uppercase? Case conversion is another one of those conceptual bugs. It's not even a meaningful

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-07 Thread Alan Stern
On Thu, 7 Jun 2007, David Brownell wrote: On Thursday 07 June 2007, Alan Stern wrote: full handling of Unicode? You must be kidding. Do you have any idea how difficult it is to do something as simple as converting between lower- and uppercase? Case conversion is another one of

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-06 Thread Alan Stern
On Tue, 5 Jun 2007, David Brownell wrote: Date: Tue, 5 Jun 2007 17:00:56 -0400 (EDT) From: Alan Stern [EMAIL PROTECTED] Does anybody think it would be worthwhile to convert string descriptors from UCS-16 to UTF-8 (instead of Latin1) when we read them in? Or even

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-06 Thread Nicolas Mailhot
So, should I test the original patch or wait while you tweak it? Regards, -- Nicolas Mailhot - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-06 Thread Alan Stern
On Wed, 6 Jun 2007, Nicolas Mailhot wrote: So, should I test the original patch or wait while you tweak it? Go ahead and test it as is. It ought to work well enough, and if there's something terribly wrong I'd like to know sooner rather than later. Alan Stern

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-06 Thread Alan Stern
It turns out that fs/nls/nls_base.c already includes conversion routines such as utf8_wcstombs(). Unforunately they are not an ideal match to what we want for several reasons: They work with wchar_t, typedef'd as __u16 in include/linux/nls.h. Hence they expect to see

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-06 Thread David Brownell
On Wednesday 06 June 2007, Alan Stern wrote: It turns out that fs/nls/nls_base.c already includes conversion routines such as utf8_wcstombs(). Unforunately they are not an ideal match to what we want for several reasons: ... One of the ongoing headaches of I18N work is backwards compat

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-06 Thread David Brownell
On Wednesday 06 June 2007, Alan Stern wrote: On Tue, 5 Jun 2007, David Brownell wrote: Date: Tue, 5 Jun 2007 17:00:56 -0400 (EDT) From: Alan Stern [EMAIL PROTECTED] Does anybody think it would be worthwhile to convert string descriptors from UCS-16 to UTF-8 (instead

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-05 Thread Oliver Neukum
Am Montag, 4. Juni 2007 22:52 schrieb Alan Stern: Regarding: http://bugzilla.kernel.org/show_bug.cgi?id=8310 Does anybody think it would be worthwhile to convert string descriptors from UCS-16 to UTF-8 (instead of Latin1) when we read them in? Yes, I do. We should either pass them

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-05 Thread Alan Stern
On Mon, 4 Jun 2007, David Brownell wrote: On Monday 04 June 2007, Pete Zaitcev wrote: On Mon, 4 Jun 2007 16:52:01 -0400 (EDT), Alan Stern [EMAIL PROTECTED] wrote: Does anybody think it would be worthwhile to convert string descriptors from UCS-16 to UTF-8 (instead of Latin1) when

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-05 Thread David Brownell
Date: Tue, 5 Jun 2007 17:00:56 -0400 (EDT) From: Alan Stern [EMAIL PROTECTED] Does anybody think it would be worthwhile to convert string descriptors from UCS-16 to UTF-8 (instead of Latin1) when we read them in? Or even UTF-7 ... ? FWIW the input isn't UCS-16; it's UTF16-LE.

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-04 Thread Alan Stern
Regarding: http://bugzilla.kernel.org/show_bug.cgi?id=8310 Does anybody think it would be worthwhile to convert string descriptors from UCS-16 to UTF-8 (instead of Latin1) when we read them in? Alan Stern - This

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-04 Thread Pete Zaitcev
On Mon, 4 Jun 2007 16:52:01 -0400 (EDT), Alan Stern [EMAIL PROTECTED] wrote: Regarding: http://bugzilla.kernel.org/show_bug.cgi?id=8310 Does anybody think it would be worthwhile to convert string descriptors from UCS-16 to UTF-8 (instead of Latin1) when we read them in? I remember

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-06-04 Thread David Brownell
On Monday 04 June 2007, Pete Zaitcev wrote: On Mon, 4 Jun 2007 16:52:01 -0400 (EDT), Alan Stern [EMAIL PROTECTED] wrote: Does anybody think it would be worthwhile to convert string descriptors from UCS-16 to UTF-8 (instead of Latin1) when we read them in? Or even UTF-7 ... ? FWIW the

Re: [linux-usb-devel] [Bugme-new] [Bug 8310] New: USB device names are not sanitized for UTF-8

2007-04-07 Thread Andrew Morton
On Sat, 7 Apr 2007 03:12:49 -0700 [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8310 Summary: USB device names are not sanitized for UTF-8 Kernel Version: 2.6.21-rc5 Status: NEW Severity: normal Owner: [EMAIL