Re: [linux-usb-devel] [PATCH] iuu_phoenix - new release v0.4 - call for review/comments

2007-08-13 Thread Oliver Neukum
Am Sonntag 12 August 2007 schrieb [EMAIL PROTECTED]: In this release, the driver use the interrupt context. So no more latency problem. I still kfree the buffers provided by the usb-serial framework. All comments/remarks are welcome This driver seems very stable ( tested with 5 readers at

Re: [linux-usb-devel] [PATCH] iuu_phoenix - new release v0.4 - call for review/comments

2007-08-13 Thread Alan Cox
+static int iuu_alloc_buf(struct iuu_private *priv) +{ + priv-buf = kzalloc(256, GFP_KERNEL); + priv-dbgbuf = kzalloc(256, GFP_KERNEL); + priv-writebuf = kzalloc(256, GFP_KERNEL); + if (!priv-buf || !priv-dbgbuf || !priv-writebuf) { + dbg(%s problem allocation

Re: [linux-usb-devel] [PATCH] iuu_phoenix - new release v0.4 - call for review/comments

2007-08-13 Thread Oliver Neukum
Am Montag 13 August 2007 schrieb Alan Cox: +static int iuu_alloc_buf(struct iuu_private *priv) +{ + priv-buf = kzalloc(256, GFP_KERNEL); + priv-dbgbuf = kzalloc(256, GFP_KERNEL); + priv-writebuf = kzalloc(256, GFP_KERNEL); + if (!priv-buf || !priv-dbgbuf || !priv-writebuf) {

Re: [linux-usb-devel] [PATCH] iuu_phoenix - new release v0.4 - call for review/comments

2007-08-13 Thread Alan Cox
+static int +iuu_ioctl(struct usb_serial_port *port, struct file *file, unsigned int cmd, + unsigned long arg) +{ + This is very wrong. Your driver may not intercept TCGETS and similar ioctls. In fact you don't seem to need any of it. Terminal changes are handled by the set_termios

Re: [linux-usb-devel] [PATCH] iuu_phoenix - new release v0.4 - call for review/comments

2007-08-13 Thread Alan Cox
On Mon, 13 Aug 2007 15:48:40 +0200 Oliver Neukum [EMAIL PROTECTED] wrote: Am Montag 13 August 2007 schrieb Alan Cox: +static int iuu_alloc_buf(struct iuu_private *priv) +{ + priv-buf = kzalloc(256, GFP_KERNEL); + priv-dbgbuf = kzalloc(256, GFP_KERNEL); + priv-writebuf =

Re: [linux-usb-devel] [PATCH] iuu_phoenix - new release v0.4 - call for review/comments

2007-08-13 Thread Oliver Neukum
Am Montag 13 August 2007 schrieb Alan Cox: On Mon, 13 Aug 2007 15:48:40 +0200 Oliver Neukum [EMAIL PROTECTED] wrote: Am Montag 13 August 2007 schrieb Alan Cox: +static int iuu_alloc_buf(struct iuu_private *priv) +{ + priv-buf = kzalloc(256, GFP_KERNEL); +

Re: [linux-usb-devel] [PATCH] iuu_phoenix - new release v0.4 - call for review/comments

2007-08-12 Thread Alain Degreffe
By the way, What are the condition to see this driver in the main kernel tree ? Alain -Message d'origine- De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] De la part de [EMAIL PROTECTED] Envoyé : dimanche 12 août 2007 11:02 À : linux-usb-devel@lists.sourceforge.net Objet :