Re: current version of http://www.linux-usb.org/usbtest/ testusb.c

2013-09-09 Thread Pratyush Anand
On Mon, Sep 09, 2013 at 02:08:02AM +0800, joe M wrote: Hello, Just wanted to check if there is a version of http://www.linux-usb.org/usbtest/ testusb.c or test.sh scrpts that work with the current kernel. The files seem to be using usbfs, which is deprecated. ./testusb -a usbfs files

[PATCH 3/5] usb: chipidea: imx: Add usb_phy_shutdown at probe's error path

2013-09-09 Thread Peter Chen
If not, the PHY will be active even the controller is not in use. We find this issue due to the PHY's clock refcount is not correct due to -EPROBE_DEFER return after phy's init. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci_hdrc_imx.c |7 +-- 1 files

[PATCH 2/2] usb: phy-mxs: Add auto clock and power setting

2013-09-09 Thread Peter Chen
With the auto setting, the PHY's clock and power can be recovered correctly from low power mode, it is ganranteed by IC logic. Besides, we enable the IC fixes for this PHY at mx6 platform. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 30

[PATCH 1/2] usb: mxs-phy: Add platform judgement code

2013-09-09 Thread Peter Chen
The mxs-phy has three versions, each version has some differences among PHY operation. the 1st version is for mx23/mx28 SoC, The 2nd version is for mx6q and mx6dl, the 3rd version is for mx6sl and later mx6 platform. Signed-off-by: Peter Chen peter.c...@freescale.com ---

[RESEND PATCH v2 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-09-09 Thread Peter Chen
In order to increase test coverage, we can change the interval between two remote wakeups every time, and the interval can be any user defined value. This change will no affect current behavior if the user does not use two introduced module paramters. Signed-off-by: Peter Chen

Re: [RFC v4 06/19] xhci: use completion event's slot id rather than dig it out of command

2013-09-09 Thread Xenia Ragiadakou
On 09/04/2013 08:39 AM, Xenia Ragiadakou wrote: Since the slot id retrieved from the command TRB matches the one in Slot ID field of the command completion event, which is available, there is no need to determine it again. This patch removes the uneccessary reassignment to slot id and adds a

[PATCH] hid-elo: some systems cannot stomach work around

2013-09-09 Thread oliver
From: Oliver Neukum oneu...@suse.de Some systems although they have firmware class 'M', which usually needs a work around to not crash, must not be subjected to the work around because the work around crashes them. They cannot be told apart by their own device descriptor, but as they are part of

[RFC v5 02/19] xhci: rename existing Command Completion Event handlers

2013-09-09 Thread Xenia Ragiadakou
This patch renames the function handlers of a triggered Command Completion Event that correspond to each command type into 'xhci_handle_cmd_type'. That is done to give a consistent naming space to all the functions that handle Command Completion Events and that will permit the code reader to

[RFC v5 13/19] xhci: add variable 'cmd_trb' in handle_cmd_completion()

2013-09-09 Thread Xenia Ragiadakou
This patch adds a new variable 'cmd_trb' to hold the address of the command TRB, that is associated with the command completion event, and to replace repetitions of xhci-cmd_ring-dequeue into the code. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Acked-by: Sarah Sharp

[RFC v5 10/19] xhci: remove unused 'ep_ring' variable in handle_cmd_completion()

2013-09-09 Thread Xenia Ragiadakou
This patch removes the variable 'ep_ring' that is assigned in TRB_CONFIG_EP switch case but never used. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com --- drivers/usb/host/xhci-ring.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c

[RFC v5 07/19] xhci: refactor TRB_RESET_DEV case into function

2013-09-09 Thread Xenia Ragiadakou
The function that handles xHCI command completion is much too long and there is need to be broken up into individual functions for each command completion to improve code readablity. This patch refactors the code in TRB_RESET_DEV switch case in handle_cmd_completion() into a fuction named

[RFC v5 19/19] xhci: add trace for missed periodic transfers

2013-09-09 Thread Xenia Ragiadakou
There are situations under which xHC is unable to service an isochronous endpoint within its service interval. For an IN isoc endpoint, this is the case when its ring is full, while for an OUT isoc endpoint when its ring is empty. This patch adds a trace event to the class 'xhci_log_msg', called

[RFC v5 12/19] xhci: add variable 'cmd_comp_code' in handle_cmd_completion()

2013-09-09 Thread Xenia Ragiadakou
This patch adds a new variable 'cmd_comp_code' to hold the command completion status code aiming to reduce code duplication and to improve code readability. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-ring.c

[RFC v5 04/19] xhci: refactor TRB_DISABLE_SLOT case into function

2013-09-09 Thread Xenia Ragiadakou
The function that handles xHCI command completion is much too long and there is need to be broken up into individual functions for each command completion to improve code readablity. This patch refactors the code in TRB_DISABLE_SLOT switch case in handle_cmd_completion() into a fuction named

[RFC v5 16/19] xhci: add argument 'slot_id' in stop_ep, set_deq and reset_ep cmd handlers

2013-09-09 Thread Xenia Ragiadakou
Since the Slot ID field in the command completion event matches the Slot ID field in the associated command TRB for the Stop Endpoint, Set Dequeue Pointer and Reset Endpoint commands, this patch adds in the handlers of their completion events a 'slot_id' argument and removes the slot id

[RFC v5 06/19] xhci: use completion event's slot id rather than dig it out of command

2013-09-09 Thread Xenia Ragiadakou
Since the slot id retrieved from the Reset Device TRB matches the slot id in the command completion event, which is available, there is no need to determine it again. This patch removes the uneccessary reassignment to slot id and adds a WARN_ON in case the two Slot ID fields differ (although

[RFC v5 05/19] xhci: refactor TRB_ADDR_DEV case into function

2013-09-09 Thread Xenia Ragiadakou
The function that handles xHCI command completion is much too long and there is need to be broken up into individual functions for each command completion to improve code readablity. This patch refactors the code in TRB_ADDR_DEV switch case in handle_cmd_completion() into a fuction named

[RFC v5 14/19] xhci: add variable 'cmd_type' in handle_cmd_completion()

2013-09-09 Thread Xenia Ragiadakou
This patch adds a new variable 'cmd_type' to hold the command type so that switch cases can be simplified by removing TRB_TYPE() macro improving code readability. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com --- Differences from v3: update changelog to report the reason for such change

[RFC v5 09/19] xhci: refactor TRB_EVAL_CONTEXT case into function

2013-09-09 Thread Xenia Ragiadakou
The function that handles xHCI command completion is much too long and there is need to be broken up into individual functions for each command completion to improve code readablity. This patch refactors the code in TRB_EVAL_CONTEXT switch case in handle_cmd_completion() into a fuction named

[RFC v5 15/19] xhci: replace 'xhci-cmd_ring-dequeue' with 'trb' in stop_ep cmd handler

2013-09-09 Thread Xenia Ragiadakou
This patch replaces 'xhci-cmd_ring-dequeue' with 'trb', the address of the command TRB, since it is available to reduce line length. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com --- drivers/usb/host/xhci-ring.c | 6 ++ 1 file

[RFC v5 11/19] xhci: refactor TRB_CONFIG_EP case into function

2013-09-09 Thread Xenia Ragiadakou
The function that handles xHCI command completion is much too long and there is need to be broken up into individual functions for each command completion to improve code readablity. This patch refactors the code in TRB_CONFIG_EP switch case, in handle_cmd_completion(), into a fuction named

[RFC v5 03/19] xhci: refactor TRB_ENABLE_SLOT case into function

2013-09-09 Thread Xenia Ragiadakou
The function that handles xHCI command completion is much too long and there is need to be broken up into individual functions for each command completion to improve code readablity. This patch refactors the code in TRB_ENABLE_SLOT switch case in handle_cmd_completion() into a fuction named

[RFC v5 18/19] xhci: add label 'update_ring' in handle_cmd_completion()

2013-09-09 Thread Xenia Ragiadakou
This patch adds the label 'update_ring' for the common code path: inc_deq(xhci, xhci-cmd_ring); return; Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com --- Differences from v3: -remove return statement drivers/usb/host/xhci-ring.c | 7 +++ 1 file changed, 3 insertions(+), 4

[RFC v5 17/19] xhci: replace 'event' with 'cmd_comp_code' in set_deq and reset_ep handlers

2013-09-09 Thread Xenia Ragiadakou
This patch replaces the 'event' argument of xhci_handle_cmd_set_deq() and xhci_handle_cmd_reset_ep(), which is used to retrieve the command completion status code, with the cmd_comp_code directly, since it is available. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com Acked-by: Sarah Sharp

Re: Virtual Interrupts -- Need help please

2013-09-09 Thread Mark Brown
On Sun, Sep 08, 2013 at 05:35:56PM -0700, Guenter Roeck wrote: Please fix your mailer to word wrap within paragraphs, not doing this makes your mail very hard to read. It looks like your mailer has also reflowed Daniel's mail. On 09/08/2013 04:50 PM, Daniel Santos wrote: Even better, thank

Re: Virtual Interrupts -- Need help please

2013-09-09 Thread Mark Brown
On Sat, Sep 07, 2013 at 07:19:06PM -0500, Daniel Santos wrote: So do i create an IRQ domain and then call generic_handle_irq() from my URB complete() function? If so, which type of IRQ Domain is appropriate for this? Unlike typical platform devices, these are dynamically added and removed

Re: Virtual Interrupts -- Need help please

2013-09-09 Thread Alexander Holler
Am 09.09.2013 13:02, schrieb Mark Brown: On Sun, Sep 08, 2013 at 05:35:56PM -0700, Guenter Roeck wrote: Please fix your mailer to word wrap within paragraphs, not doing this makes your mail very hard to read. It looks like your mailer has also reflowed Daniel's mail. That's just wrong. Mail

Re: Virtual Interrupts -- Need help please

2013-09-09 Thread Guenter Roeck
On 09/09/2013 04:18 AM, Alexander Holler wrote: Am 09.09.2013 13:02, schrieb Mark Brown: On Sun, Sep 08, 2013 at 05:35:56PM -0700, Guenter Roeck wrote: Please fix your mailer to word wrap within paragraphs, not doing this makes your mail very hard to read. It looks like your mailer has also

Re: Virtual Interrupts -- Need help please

2013-09-09 Thread Alexander Holler
Am 09.09.2013 13:45, schrieb Guenter Roeck: On 09/09/2013 04:18 AM, Alexander Holler wrote: Am 09.09.2013 13:02, schrieb Mark Brown: On Sun, Sep 08, 2013 at 05:35:56PM -0700, Guenter Roeck wrote: Please fix your mailer to word wrap within paragraphs, not doing this makes your mail very hard

Re: [Bug] 0ac8:0321 Vimicro generic vc0321 Camera is not working and causes crashes since 3.2

2013-09-09 Thread Hans de Goede
Hi, On 09/08/2013 01:37 PM, Frank Dierich wrote: Hi, I have an ASUS A8JP Notebook with Ubuntu 12.04 with the following build in webcam Bus 001 Device 004: ID 0ac8:0321 Z-Star Microelectronics Corp. Vimicro generic vc0321 Camera The camera is working nice with Cheese and kernels before

[PATCH] Fix IPv6 support in usbipd

2013-09-09 Thread Dominik Paulus
getaddrinfo() leaves the order of the returned addrinfo structs unspecified. On systems with bindv6only disabled (this is the default), PF_INET6 sockets bind to IPv4, too. Thus, IPv6 support in usbipd was broken when getaddrinfo returned first IPv4 and then IPv6 addrinfos, as the IPv6 bind failed

Re: [alsa-devel] question about webcam audio capture

2013-09-09 Thread Clemens Ladisch
vichy wrote: I try to do webcam audio capture on my arm platform. when I execute audio capture I got below message retire_capture_urb: 108 callbacks suppressed This means that the retire_capture_urb() function printed lots of messages, and that 108 of them were thrown away because they were

Re: Virtual Interrupts -- Need help please

2013-09-09 Thread Mark Brown
On Mon, Sep 09, 2013 at 01:18:01PM +0200, Alexander Holler wrote: Am 09.09.2013 13:02, schrieb Mark Brown: makes your mail very hard to read. It looks like your mailer has also reflowed Daniel's mail. That's just wrong. Mail readers should wrap lines, not senders. And readers can do this

Re: [PATCH 4/4] RX-51: Add platform function and data for bq24150a charger

2013-09-09 Thread Sebastian Reichel
Hi Pali, On Sun, Sep 08, 2013 at 10:50:39AM +0200, Pali Rohár wrote: This patch will register bq24150a charger in RX-51 board data. Patch also adding platform function between isp1704 and bq2415x drivers for detecting charger type. So finally charging battery on Nokia N900 (RX-51) working

Re: current version of http://www.linux-usb.org/usbtest/ testusb.c

2013-09-09 Thread Greg KH
On Mon, Sep 09, 2013 at 11:33:01AM +0530, Pratyush Anand wrote: On Mon, Sep 09, 2013 at 02:08:02AM +0800, joe M wrote: Hello, Just wanted to check if there is a version of http://www.linux-usb.org/usbtest/ testusb.c or test.sh scrpts that work with the current kernel. The files

[PATCH] Fix man-pages for usbip userspace utilities

2013-09-09 Thread Tobias Polzer
The usbip userspace utilities contained some half-documented (only in --help, not in man) options. They were added to the man-pages of usbip and usbipd. Also a typo in the usbip headline was fixed. Signed-off-by: Tobias Polzer tobias.pol...@fau.de Signed-off-by: Dominik Paulus

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-09-09 Thread Daniel Mack
On 28.08.2013 20:46, Alan Stern wrote: On Wed, 28 Aug 2013, Clemens Ladisch wrote: Sorry, what I said applies more to explicit sync endpoints. When using implicit sync, a playback URB is submitted for each completed capture URB, with the number of samples per packet identical to the

Re: Virtual Interrupts -- Need help please

2013-09-09 Thread Alexander Holler
Am 09.09.2013 15:45, schrieb Mark Brown: On Mon, Sep 09, 2013 at 01:18:01PM +0200, Alexander Holler wrote: Am 09.09.2013 13:02, schrieb Mark Brown: makes your mail very hard to read. It looks like your mailer has also reflowed Daniel's mail. That's just wrong. Mail readers should wrap

Re: current version of http://www.linux-usb.org/usbtest/ testusb.c

2013-09-09 Thread joe M
Hello Pratyush, If I remember well it was working till 3.5 only Does it not work for USB Ch.9 tests? I am trying to test the control transactions of a HID device with testusb and I get the Inappropriate ioctl for device. I am not sure if it is something wrong with my environment/setup or

Re: [PATCH 2/2] usb: phy-mxs: Add auto clock and power setting

2013-09-09 Thread Marek Vasut
Dear Peter Chen, With the auto setting, the PHY's clock and power can be recovered correctly from low power mode, it is ganranteed by IC logic. Besides, we enable the IC fixes for this PHY at mx6 platform. Signed-off-by: Peter Chen peter.c...@freescale.com ---

Re: [alsa-devel] question about webcam audio capture

2013-09-09 Thread vichy
hi Clemens: 2013/9/9 Clemens Ladisch clem...@ladisch.de: vichy wrote: I try to do webcam audio capture on my arm platform. when I execute audio capture I got below message retire_capture_urb: 108 callbacks suppressed This means that the retire_capture_urb() function printed lots of

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-09-09 Thread Greg Kroah-Hartman
On Mon, Sep 09, 2013 at 07:33:31AM +0200, Andreas Larsson wrote: On 2013-08-28 11:02, Andreas Larsson wrote: On 2013-08-12 16:05, Andreas Larsson wrote: This adds an UDC driver for GRUSBDC USB Device Controller cores available in the GRLIB VHDL IP core library. The driver only supports

Re: testusb on a HID device

2013-09-09 Thread Alan Stern
On Sun, 8 Sep 2013, joe M wrote: Hello, I do not want to rmmod the hid module as I think it will affect my being-used usb keyboard and mouse too. I just want to rmmod the hid module for the device being tested. I got this

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-09-09 Thread Alan Stern
On Mon, 9 Sep 2013, Daniel Mack wrote: I gave this patch a try and I can confirm that it results in a sigificant improvement for small sample buffers. So feel free to add my Tested-by: Daniel Mack zon...@gmail.com Thanks; I'll include this when the patch is submitted. Alan Stern --

Re: testusb on a HID device

2013-09-09 Thread joe M
Hello, This is the wrong driver. You need to unbind usbhid, not hid-generic. Like at the files under /sys/bus/usb/drivers/usbhid/. That worked like a charm. Thanks a lot. Joe -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: current version of http://www.linux-usb.org/usbtest/ testusb.c

2013-09-09 Thread joe M
Hello Pratyush, Does it not work for USB Ch.9 tests? I am trying to test the control transactions of a HID device with testusb and I get the Inappropriate ioctl for device. I am not sure if it is something wrong with my environment/setup or if testusb does not work anymore. my uname -a is:

Re: [alsa-devel] question about webcam audio capture

2013-09-09 Thread vichy
hi Clemens: 2013/9/9 vichy vichy@gmail.com: hi Clemens: 2013/9/9 Clemens Ladisch clem...@ladisch.de: vichy wrote: I try to do webcam audio capture on my arm platform. when I execute audio capture I got below message retire_capture_urb: 108 callbacks suppressed This means that the

Re:Very Urgent!!!

2013-09-09 Thread Doris Omar
Greetings from BURKINA FASO: Let me start by introduce myself,I am Mrs Doris Omar, BILL AND EXCHANGE MANAGER (Bank of Africa) Ouagadougou, Burkina Faso.I am writting you this letter based on the latest development at our bank which I will like to bring to your personal edification.

FROM Mr USMAN ABU

2013-09-09 Thread Mr usman abu
FROM Mr USMAN ABU BILLS AND EXCHANGE MANAGER, BANK OF AFRICA (B.O.A) OUAGADOUGOU BURKINA FASO. IN WEST AFRICA For your kind attention, i will be very glad if you do assist me to relocate a sum of (US18.5 Million) to your personal bank account for the benefit of both of us. This is a genuine

[PATCH 4/5] USB : serial : invoke dcd_change ldisc's handler.

2013-09-09 Thread Paul Chavent
In order to have the PPS line discipline to work with usb devices. Signed-off-by: Paul Chavent paul.chav...@onera.fr --- drivers/usb/serial/generic.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c index 91f0592..a18a086

[PATCH 2/5] USB : serial : get protected tty in handle_dcd_change.

2013-09-09 Thread Paul Chavent
This patch depends on 72df17e... (PATCH 1). It restores the retreiving of a protected instance of tty. As opposed to the serialcore.c dcd_change implementation, the callers of dcd_change used to get protected tty instance. Signed-off-by: Paul Chavent paul.chav...@onera.fr ---

[PATCH 3/5] USB : serial : call handle_dcd_change in ftdi driver.

2013-09-09 Thread Paul Chavent
Signed-off-by: Paul Chavent paul.chav...@onera.fr --- drivers/usb/serial/ftdi_sio.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index c45f9c0..2d3d3a0 100644 --- a/drivers/usb/serial/ftdi_sio.c +++

[PATCH 1/5] USB : serial : remove tty arg of handle_dcd_change.

2013-09-09 Thread Paul Chavent
Do the same way as in serialcore.c for uart_handle_dcd_change. It removes duplicated code around the usb_serial_handle_dcd_change calls. Signed-off-by: Paul Chavent paul.chav...@onera.fr --- drivers/usb/serial/ch341.c | 7 ++- drivers/usb/serial/generic.c | 4 ++--

[PATCH 5/5] USB : serial : pl2303 wake up after dcd status check.

2013-09-09 Thread Paul Chavent
Seems to be done this way in other drivers (ch341, 8250, ...). Signed-off-by: Paul Chavent paul.chav...@onera.fr --- drivers/usb/serial/pl2303.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index

[PATCH 0/5] Enable PPS reporting for USB serial devices

2013-09-09 Thread Paul Chavent
Hi. This series enable the PPS reporting for USB serial devices. Patch 01 : change the interface of handle_dcd_change for usb serial in order to avoid duplicating code when calling this function and to be closer of the uart handle_dcd_change interface. Patch 02 : this patch depends on the

Re: [PATCH 4/5] USB : serial : invoke dcd_change ldisc's handler.

2013-09-09 Thread Greg KH
On Mon, Sep 09, 2013 at 06:01:19PM +0200, Paul Chavent wrote: In order to have the PPS line discipline to work with usb devices. Signed-off-by: Paul Chavent paul.chav...@onera.fr --- drivers/usb/serial/generic.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[RFC 07/21] xhci: fix sparse warning in xhci-trace.h

2013-09-09 Thread Xenia Ragiadakou
This patch fixes the following sparse warnings: drivers/usb/host/./xhci-trace.h:116:1: warning: cast to restricted __le32 drivers/usb/host/./xhci-trace.h:116:1: warning: cast to restricted __le32 drivers/usb/host/./xhci-trace.h:116:1: warning: restricted __le32 degrades to integer

[RFC 03/21] xhci: fix incorrect type in assignment in xhci_address_device()

2013-09-09 Thread Xenia Ragiadakou
The field 'dev_info' in struct xhci_slot_ctx has type __le32 and it needs to be converted to CPU byteorder for the correct retrieval of its subfield 'Context Entries'. This field is used by the trace event 'xhci_address_ctx' to trace only the contexts of valid endpoints. This bug was found using

[RFC 15/21] xhci: replace xhci_writel() with writel() in xhci.c

2013-09-09 Thread Xenia Ragiadakou
Function xhci_writel() is used to write a 32bit value in xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it because internally it simply calls writel(). This creates an illusion that xhci_writel() is an xhci specific

[RFC 06/21] xhci: fix derivation of TRB's DMA address in xhci_log_event Trace Event Class

2013-09-09 Thread Xenia Ragiadakou
This patch fixes the retrieval of the DMA address of the TRB that generated the event by converting the field[0] (low address bits) and field[1] (high address bits) to CPU byteorder and then typecasting field[1] to u64 so that the bitshift will not lead to overflow. In the original code, the

[RFC 18/21] xhci: replace xhci_writel() with writel() in xhci-ring.c

2013-09-09 Thread Xenia Ragiadakou
Function xhci_writel() is used to write a 32bit value in xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it because internally it simply calls writel(). This creates an illusion that xhci_writel() is an xhci specific

[RFC 14/21] xhci: remove xhci_readl()

2013-09-09 Thread Xenia Ragiadakou
This patch removes xhci_readl() because it has been replaced with readl() and it is not used anymore. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com --- drivers/usb/host/xhci.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h index

[RFC 04/21] xhci: convert TRB_CYCLE to le32 before using it to set Link TRB's cycle bit

2013-09-09 Thread Xenia Ragiadakou
This patch converts TRB_CYCLE to le32 to update correctly the Cycle Bit in 'control' field of the link TRB. This bug was found using sparse. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com --- drivers/usb/host/xhci-mem.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[RFC 16/21] xhci: replace xhci_writel() with writel() in xhci-hub.c

2013-09-09 Thread Xenia Ragiadakou
Function xhci_writel() is used to write a 32bit value in xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it because internally it simply calls writel(). This creates an illusion that xhci_writel() is an xhci specific

[RFC 11/21] xhci: replace xhci_readl() with readl() in xhci-hub.c

2013-09-09 Thread Xenia Ragiadakou
Function xhci_readl() is used to read 32bit xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it because internally it simply calls readl. This creates an illusion that xhci_readl() is an xhci specific function that has to

[RFC 12/21] xhci: replace xhci_readl() with readl() in xhci-mem.c

2013-09-09 Thread Xenia Ragiadakou
Function xhci_readl() is used to read 32bit xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it because internally it simply calls readl. This creates an illusion that xhci_readl() is an xhci specific function that has to

Re: [PATCH 1/5] USB : serial : remove tty arg of handle_dcd_change.

2013-09-09 Thread Johan Hovold
On Mon, Sep 09, 2013 at 06:01:16PM +0200, Paul Chavent wrote: Do the same way as in serialcore.c for uart_handle_dcd_change. It removes duplicated code around the usb_serial_handle_dcd_change calls. Signed-off-by: Paul Chavent paul.chav...@onera.fr --- drivers/usb/serial/ch341.c | 7

[RFC 01/21] xhci: fix incorrect type in assignment in xhci_count_num_new_endpoints()

2013-09-09 Thread Xenia Ragiadakou
The fields 'add_flags' and 'drop_flags' in struct xhci_input_control_ctx have type __le32 and need to be converted to CPU byteorder before being used to derive the number of added endpoints. This bug was found using sparse. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com ---

[RFC 08/21] xhci: use ffs() for page size's calculation in xhci_mem_init()

2013-09-09 Thread Xenia Ragiadakou
The first 16 bits of Page Size Register report the page size supported by xHC. If bit i is set, then xHC supports a page size of 2^(i+12). This patch replaces the code that does the lookup for the first set bit with a call to ffs() because using ffs() the code can benefit from architecture

Re: [PATCH 1/5] USB : serial : remove tty arg of handle_dcd_change.

2013-09-09 Thread Johan Hovold
On Mon, Sep 09, 2013 at 07:45:23PM +0200, Johan Hovold wrote: On Mon, Sep 09, 2013 at 06:01:16PM +0200, Paul Chavent wrote: Do the same way as in serialcore.c for uart_handle_dcd_change. It removes duplicated code around the usb_serial_handle_dcd_change calls. Signed-off-by: Paul

[RFC 10/21] xhci: replace xhci_readl() with readl() in xhci-dbg.c

2013-09-09 Thread Xenia Ragiadakou
Function xhci_readl() is used to read 32bit xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it because internally it simply calls readl. This creates an illusion that xhci_readl() is an xhci specific function that has to

[RFC 09/21] xhci: replace xhci_readl() with readl() in xhci.c

2013-09-09 Thread Xenia Ragiadakou
Function xhci_readl() is used to read 32bit xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it because internally it simply calls readl. This creates an illusion that xhci_readl() is an xhci specific function that has to

[RFC 17/21] xhci: replace xhci_writel() with writel() in xhci-mem.c

2013-09-09 Thread Xenia Ragiadakou
Function xhci_writel() is used to write a 32bit value in xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it because internally it simply calls writel(). This creates an illusion that xhci_writel() is an xhci specific

[RFC 13/21] xhci: replace xhci_readl() with readl() in xhci-ring.c

2013-09-09 Thread Xenia Ragiadakou
Function xhci_readl() is used to read 32bit xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it because internally it simply calls readl. This creates an illusion that xhci_readl() is an xhci specific function that has to

[RFC 05/21] xhci: fix incorrect type in assignment in handle_device_notification()

2013-09-09 Thread Xenia Ragiadakou
This patch converts Event TRB's 3rd field, which has type le32, to CPU byteorder before using it to retrieve the Slot ID with TRB_TO_SLOT_ID macro. This bug was found using sparse. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com --- drivers/usb/host/xhci-ring.c | 2 +- 1 file changed, 1

[RFC 02/21] xhci: fix incorrect type in assignment in xhci_count_num_dropped_endpoints()

2013-09-09 Thread Xenia Ragiadakou
The fields 'add_flags' and 'drop_flags' in struct xhci_input_control_ctx have type __le32 and need to be converted to CPU byteorder before being used to derive the number of dropped endpoints. This bug was found using sparse. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com ---

Re: [PATCH 2/5] USB : serial : get protected tty in handle_dcd_change.

2013-09-09 Thread Sergei Shtylyov
Hello. On 09/09/2013 08:01 PM, Paul Chavent wrote: This patch depends on 72df17e... (PATCH 1). You don't need to say that when you publish the patches as a series. It's assumed. It restores the retreiving of a protected instance of tty. As opposed to the serialcore.c dcd_change

[RFC 19/21] xhci: remove xhci_writel()

2013-09-09 Thread Xenia Ragiadakou
This patch removes xhci_writel() since its calls has been replaced with writel() and it is not used anymore. Signed-off-by: Xenia Ragiadakou burzalod...@gmail.com --- drivers/usb/host/xhci.h | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/host/xhci.h

[RFC 21/21] xhci: replace xhci_write_64() with writeq() and remove xhci_write_64()

2013-09-09 Thread Xenia Ragiadakou
Function xhci_write_64() is used to write an 64bit value in xHC registers, residing in MMIO. On 32bit systems, xHC registers should be read/written with 32bit accesses by reading/writing the low 32bits first and then the high 32bits second. Since asm-generic/io-64-nonatomic-lo-hi.h header file was

[RFC 20/21] xhci: replace xhci_read_64() with readq() and remove xhci_read_64()

2013-09-09 Thread Xenia Ragiadakou
Function xhci_read_64() is used to read 64bit xHC registers residing in MMIO. On 32bit systems, registers should be read/written with 32bit accesses by reading/writing the low 32bits first and then the high 32bits second. This patch adds asm-generic/io-64-nonatomic-lo-hi.h header file in xhci.h so

Re: setup msi-x vectors in xhci-hcd

2013-09-09 Thread Sarah Sharp
On Mon, Sep 02, 2013 at 04:43:01PM +0300, Xenia Ragiadakou wrote: Hi Sarah and Alan, I am writing a patch for allocating as many msi-x vectors as the number of event rings because now the msi-x vectors allocated are more than are actually used, since currently xhci-hcd implements only one

Re: [alsa-devel] question about webcam audio capture

2013-09-09 Thread Clemens Ladisch
vichy wrote: 2013/9/9 Clemens Ladisch clem...@ladisch.de: vichy wrote: I try to do webcam audio capture on my arm platform. when I execute audio capture I got below message retire_capture_urb: 108 callbacks suppressed This means that the retire_capture_urb() function printed lots of

Re: Virtual Interrupts -- Need help please

2013-09-09 Thread Daniel Santos
On 09/09/2013 06:06 AM, Mark Brown wrote: On Sat, Sep 07, 2013 at 07:19:06PM -0500, Daniel Santos wrote: So do i create an IRQ domain and then call generic_handle_irq() from my URB complete() function? If so, which type of IRQ Domain is appropriate for this? Unlike typical platform devices,

Re: [PATCH 2/2] usb: phy-mxs: Add auto clock and power setting

2013-09-09 Thread Peter Chen
On Mon, Sep 09, 2013 at 04:41:15PM +0200, Marek Vasut wrote: Dear Peter Chen, With the auto setting, the PHY's clock and power can be recovered correctly from low power mode, it is ganranteed by IC logic. Besides, we enable the IC fixes for this PHY at mx6 platform. Signed-off-by:

[PATCH 3/3] staging: usbip: vhci_hcd: remove check for dma

2013-09-09 Thread navin patidar
vhci_hcd is a virtual usb host controller, so no need to check for dma. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/vhci_hcd.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index

[PATCH 2/3] staging: usbip: vhci_hcd: correctly handle return value

2013-09-09 Thread navin patidar
ret == 0 means success, anything else is failure. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/vhci_hcd.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index d7974cb..b3c9217

[PATCH 1/3] staging: usbip: stub_main: correctly handle return value

2013-09-09 Thread navin patidar
ret == 0 means success, anything else is failure. Signed-off-by: navin patidar nav...@cdac.in --- drivers/staging/usbip/stub_main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/stub_main.c b/drivers/staging/usbip/stub_main.c index