Re: use of aliases in device trees

2007-11-04 Thread Segher Boessenkool
In some discussion on the u-boot dev list it became clear that having aliases in the device tree might be useful as a common way to deal with finding specific nodes that need fixing up by the firmware. One common solution would be having a top level aliases like the pmac tree's have:

Re: [PATCH v2] Restore deterministic CPU accounting on powerpc

2007-11-04 Thread Ingo Molnar
* Paul Mackerras [EMAIL PROTECTED] wrote: Signed-off-by: Paul Mackerras [EMAIL PROTECTED] --- account_process_tick now takes the task_struct * as an argument. Tested both with and without CONFIG_VIRT_CPU_ACCOUNTING. thanks, applied. Ingo

Re: 2.6.24-rc1 freezes on powerbook at first boot stage

2007-11-04 Thread Elimar Riesebieter
On Sat, 03 Nov 2007 the mental interface of Nathan Lynch told: (cc'ing linuxppc-dev, see http://www.mail-archive.com/[EMAIL PROTECTED]/msg221770.html for original post and .config) [...] console handover: boot [udbg0] - real [tty0] Does 2.6.23 (or any earlier kernel) work? The powerbook

Re: [PATCH] Restore deterministic CPU accounting on powerpc

2007-11-04 Thread Michael Neuling
+#ifndef CONFIG_VIRT_CPU_ACCOUNTING +void account_process_tick(int user_tick) +{ + if (user_tick) { + account_user_time(p, jiffies_to_cputime(1)); + account_user_time_scaled(p, jiffies_to_cputime(1)); + } else { +

mpc852t boot question!

2007-11-04 Thread Kugel
I made a MPC852T board. I set the HW config word to 0x0460(D5,D9,D10 pulled up).So the [ISB]=00, and the IMMR = 0x. When the CPU is power up, can it boot from external boot flash(39vf040)? Or just run from internal memory space(because the IMMR=0x0)?

[PATCH] Balance alloc/free and ioremap/iounmap in gpio_mdio_probe (powerpc/platforms/pasemi/gpio_mdio.c)

2007-11-04 Thread Roel Kluin
I think this is how it should be done, but please review: it was not tested. -- Balance alloc/free and ioremap/iounmap Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/arch/powerpc/platforms/pasemi/gpio_mdio.c b/arch/powerpc/platforms/pasemi/gpio_mdio.c index dae9f65..f250ba4 100644

Re: [PATCH] Balance alloc/free and ioremap/iounmap in gpio_mdio_probe (powerpc/platforms/pasemi/gpio_mdio.c)

2007-11-04 Thread Nathan Lynch
Hi, Roel Kluin wrote: I think this is how it should be done, but please review: it was not tested. -- Balance alloc/free and ioremap/iounmap It would be more helpful if your changelog identified the objects which could be leaked. More comments below. -static int __devinit

Re: [PATCH] Balance alloc/free and ioremap/iounmap in gpio_mdio_probe (powerpc/platforms/pasemi/gpio_mdio.c)

2007-11-04 Thread Olof Johansson
On Sun, Nov 04, 2007 at 05:53:40PM +0100, Roel Kluin wrote: I think this is how it should be done, but please review: it was not tested. Hi, Thanks for the bug report. The mdio driver needs a set of other cleanups as well. I have a more comprehensive patch that I'll post tomorrow after I have

Re: [PATCH] Balance alloc/free and ioremap/iounmap in gpio_mdio_probe (powerpc/platforms/pasemi/gpio_mdio.c)

2007-11-04 Thread Roel Kluin
Nathan Lynch wrote: Hi, I moved res to the wrong function, that's fixed as well as the unlikely's and the extra new lines. Thanks for your quick response. Here is an updated version: -- Upon errors gpio_regs was not iounmapped, and later priv nor new_bus-irq was freed. Testing succes of the

Re: [PATCH] Balance alloc/free and ioremap/iounmap in gpio_mdio_probe (powerpc/platforms/pasemi/gpio_mdio.c)

2007-11-04 Thread Roel Kluin
Olof Johansson wrote: On Sun, Nov 04, 2007 at 05:53:40PM +0100, Roel Kluin wrote: I think this is how it should be done, but please review: it was not tested. Hi, Thanks for the bug report. The mdio driver needs a set of other cleanups as well. I have a more comprehensive patch that I'll

Re: [PATCH 0/3] Add device-tree aware NDFC driver

2007-11-04 Thread Thomas Gleixner
Valentine, On Tue, 30 Oct 2007, Valentine Barshak wrote: Thomas Gleixner wrote: On Mon, 29 Oct 2007, Valentine Barshak wrote: This adds a device-tree aware PowerPC 44x NanD Flash Controller driver The code is based on the original NDFC driver by Thomas Gleixner, but since it's been

[PATCH] pasemi: clean up gpio_mdio init

2007-11-04 Thread Olof Johansson
pasemi: clean up mdio_gpio driver init Misc cleanups of mdio_gpio: * Better error handling/unrolling in case of init/alloc failures * Go through child nodes and get their interrupts instead of using hardcoded values * Remap the GPIO registers at module load/driver init instead of during probe *

Re: [PATCH v2 02/12] [POWERPC] Add 'fsl, lpb' bus type for MPC5200 LocalPlus Bus

2007-11-04 Thread David Gibson
On Sun, Nov 04, 2007 at 12:52:22AM +0100, Marian Balakowicz wrote: Define MPC52xx specific device id list, add new 'fsl,lpb' compatible id for LocalPlus Bus. Signed-off-by: Marian Balakowicz [EMAIL PROTECTED] Acked-by: David Gibson [EMAIL PROTECTED] -- David Gibson|

Re: [PATCH v2 01/12] [POWERPC] Add 'model: ...' line to common show_cpuinfo()

2007-11-04 Thread David Gibson
On Sun, Nov 04, 2007 at 12:52:16AM +0100, Marian Balakowicz wrote: Print out 'model' property of '/' node as a machine name in generic show_cpuinfo() routine. Signed-off-by: Marian Balakowicz [EMAIL PROTECTED] Acked-by: David Gibson [EMAIL PROTECTED] -- David Gibson|

Re: [U-Boot-Users] use of aliases in device trees

2007-11-04 Thread David Gibson
On Sat, Nov 03, 2007 at 09:29:48PM -0600, Grant Likely wrote: On 11/3/07, Kumar Gala [EMAIL PROTECTED] wrote: In some discussion on the u-boot dev list it became clear that having aliases in the device tree might be useful as a common way to deal with finding specific nodes that need fixing

Re: [U-Boot-Users] use of aliases in device trees

2007-11-04 Thread Grant Likely
On 11/4/07, David Gibson [EMAIL PROTECTED] wrote: On Sat, Nov 03, 2007 at 09:29:48PM -0600, Grant Likely wrote: Maybe something like: aliases { enet0,phandle = enet0; enet1,phandle = enet1; ... }; The fairly small advantages of using phandles here are not worth the

Re: [PATCH v2 06/12] [POWERPC] TQM5200 DTS

2007-11-04 Thread David Gibson
On Sun, Nov 04, 2007 at 12:52:47AM +0100, Marian Balakowicz wrote: Add device tree source file for TQM5200 board. Signed-off-by: Marian Balakowicz [EMAIL PROTECTED] [snip] + [EMAIL PROTECTED] { [EMAIL PROTECTED] is the new convention, I believe, but I guess you need compatibility with

Re: [PATCH v2 08/12] [POWERPC] CM5200 DTS

2007-11-04 Thread David Gibson
On Sun, Nov 04, 2007 at 12:52:59AM +0100, Marian Balakowicz wrote: Add device tree source file for CM5200 board. Signed-off-by: Marian Balakowicz [EMAIL PROTECTED] Same comments as the TQM device tree, plus those below. [snip] + [EMAIL PROTECTED] { // Real time clock +

Re: [PATCH v2 11/12] [POWERPC] Promess Motion-PRO DTS

2007-11-04 Thread David Gibson
On Sun, Nov 04, 2007 at 12:53:17AM +0100, Marian Balakowicz wrote: Add device tree source file for Motion-PRO board. Signed-off-by: Marian Balakowicz [EMAIL PROTECTED] Same comments as for the other two device trees, plus those below: [snip] + [EMAIL PROTECTED] { //

Re: [PATCH] pasemi: clean up gpio_mdio init

2007-11-04 Thread Olof Johansson
Hi, On Mon, Nov 05, 2007 at 11:23:07AM +1100, Stephen Rothwell wrote: Just a couple of small things ... Thanks! Unless someone finds something bigger, I'll update this before I push it out through git, but I won't repost. On Sun, 4 Nov 2007 15:37:09 -0600 Olof Johansson [EMAIL PROTECTED]

Re: [PATCH v2 01/12] [POWERPC] Add 'model: ...' line to common show_cpuinfo()

2007-11-04 Thread Olof Johansson
On Sun, Nov 04, 2007 at 12:52:16AM +0100, Marian Balakowicz wrote: Print out 'model' property of '/' node as a machine name in generic show_cpuinfo() routine. Signed-off-by: Marian Balakowicz [EMAIL PROTECTED] Acked-by: Olof Johansson [EMAIL PROTECTED] (just as the previous posting of it)

[PATCH] [POWERPC] pasemi: Broaden specific references to 1682M

2007-11-04 Thread Olof Johansson
[POWERPC] pasemi: Broaden specific references to 1682M There will be more product numbers in the future than just PA6T-1682M, but they will share much of the features. Remove some of the explicit references and compatibility checks with 1682M, and replace most of them with the more generic

Re: libfdt: Add more documentation (patch the third)

2007-11-04 Thread David Gibson
libfdt: Add more documentation (patch the third) This patch adds documentation in libfdt.h for a few more libfdt functions. It also makes a slight update to the documentation of fdt_get_name(). Signed-off-by: David Gibson [EMAIL PROTECTED] --- Just the same as before, but now with S-o-b line.

libfdt: Add more documentation (patch the fourth)

2007-11-04 Thread David Gibson
This patch documents a few more functions in libfdt.h. It also makes a slight update to the description of the FDT_ERR_INTERNAL error code. Signed-off-by: David Gibson [EMAIL PROTECTED] Index: dtc/libfdt/libfdt.h === ---

Re: [PATCH 3/6]] POWERPC: fix memset size error

2007-11-04 Thread Benjamin Herrenschmidt
On Mon, 2007-11-05 at 10:21 +0800, Li Zefan wrote: The size passing to memset is wrong. Signed-off-by Li Zefan [EMAIL PROTECTED] Good catch, looks like a remain of when path was an array on the stack. Thanks ! Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] ---