Re: [PATCH] powerpc/lpar - defer prefered console setup

2008-07-30 Thread Bastian Blank
On Wed, Jul 30, 2008 at 12:34:51PM +1000, Michael Ellerman wrote: On Mon, 2008-07-28 at 20:56 +0200, Bastian Blank wrote: * add_preferred_console - add a device to the list of preferred consoles. ... * The last preferred console added will be used for kernel messages * and stdin/out/err

[git pull] Please pull powerpc.git merge branch

2008-07-30 Thread Benjamin Herrenschmidt
Hi Linus ! Hopefully this one won't be busted... I'll hand back the hat to paulus for the rest of 2.6.27, but before that, here's a last pull request. It brings the powerpc variant of the lockless get_user_pages_fast() which took some time because I took it out of -mm and had to adjust a few

Re: ide pmac breakage

2008-07-30 Thread Benjamin Herrenschmidt
On Tue, 2008-07-29 at 21:26 +0200, Bartlomiej Zolnierkiewicz wrote: I WON!!! Only half... It goes further and then blows up again. First problem is, this unregister interface doesn't quite convey the fact that the HW is gone and the IDE code seems to take it's sweet time figuring it out after

Re: [PATCH] powerpc/mm: Lockless get_user_pages_fast()

2008-07-30 Thread Nick Piggin
On Wed, Jul 30, 2008 at 03:08:40PM +1000, Benjamin Herrenschmidt wrote: On Wed, 2008-07-30 at 15:06 +1000, Michael Ellerman wrote: + +/* + * The performance critical leaf functions are made noinline otherwise gcc + * inlines everything into a single function which results in too

[PATCH] hvc - register all available consoles (was: Re: [PATCH] powerpc/lpar - defer prefered console setup)

2008-07-30 Thread Bastian Blank
On Wed, Jul 30, 2008 at 08:29:19AM +0200, Bastian Blank wrote: Okay, so hvc_console is the culprit. It don't register a preferred console if it knows it is not the first in the list. The patch registers all available hvc consoles. It adds one struct console for all possible hvc consoles.

Re: [RFC] [PATCH 0/5 V2] Huge page backed user-space stacks

2008-07-30 Thread Andrew Morton
On Mon, 28 Jul 2008 12:17:10 -0700 Eric Munson [EMAIL PROTECTED] wrote: Certain workloads benefit if their data or text segments are backed by huge pages. The stack is no exception to this rule but there is no mechanism currently that allows the backing of a stack reliably with huge pages.

Re: [RFC] [PATCH 0/5 V2] Huge page backed user-space stacks

2008-07-30 Thread Andrew Morton
On Mon, 28 Jul 2008 12:17:10 -0700 Eric Munson [EMAIL PROTECTED] wrote: Certain workloads benefit if their data or text segments are backed by huge pages. oh. As this is a performance patch, it would be much better if its description contained some performance measurement results! Please.

Warning: Uable to open an inital console

2008-07-30 Thread Vijay Nikam
Hello all, I have mpc8313erdb board and trying boot the kernel from NAND flash ... The kernel is booting fine but it hangs at the following message; Warning: unable to open an initial console. Kernel panic - not syncing: No init found. Try passing init= option to kernel. Following is the log

Re: [PATCH] hvc - register all available consoles (was: Re: [PATCH] powerpc/lpar - defer prefered console setup)

2008-07-30 Thread Milton Miller
On Wed Jul 30 at 17:34:38 EST in 2008, Bastian Blank wrote: On Wed, Jul 30, 2008 at 08:29:19AM +0200, Bastian Blank wrote: Okay, so hvc_console is the culprit. It don't register a preferred console if it knows it is not the first in the list. The patch registers all available hvc consoles. It

Re: [PATCH] hvc - register all available consoles (was: Re: [PATCH] powerpc/lpar - defer prefered console setup)

2008-07-30 Thread Bastian Blank
On Wed, Jul 30, 2008 at 04:13:47AM -0500, Milton Miller wrote: On Wed Jul 30 at 17:34:38 EST in 2008, Bastian Blank wrote: On Wed, Jul 30, 2008 at 08:29:19AM +0200, Bastian Blank wrote: Okay, so hvc_console is the culprit. It don't register a preferred console if it knows it is not the

Re: I2C node in device tree breaks old-style drivers

2008-07-30 Thread Jochen Friedrich
Hi Timur, So my conclusion is that specifying an I2C node in the device tree *requires* that the driver be new-style. Is there any way we can fix this? I'm not going to have time to update the CS4270 driver to a new-style interface before the 2.6.27 window closes. This conclusion is

Re: Warning: Uable to open an inital console

2008-07-30 Thread Geert Uytterhoeven
On Wed, 30 Jul 2008, Vijay Nikam wrote: I have mpc8313erdb board and trying boot the kernel from NAND flash ... The kernel is booting fine but it hangs at the following message; Warning: unable to open an initial console. Your root file system doesn't have /dev/console, which should look

Re: [PATCH] powerpc/mm: Lockless get_user_pages_fast()

2008-07-30 Thread Kumar Gala
On Jul 29, 2008, at 10:37 PM, Benjamin Herrenschmidt wrote: From: Nick Piggin [EMAIL PROTECTED] Implement lockless get_user_pages_fast for powerpc. Page table existence is guaranteed with RCU, and speculative page references are used to take a reference to the pages without having a

Re: I2C node in device tree breaks old-style drivers

2008-07-30 Thread Timur Tabi
On Wed, Jul 30, 2008 at 5:54 AM, Jochen Friedrich [EMAIL PROTECTED] wrote: Hi Timur, So my conclusion is that specifying an I2C node in the device tree *requires* that the driver be new-style. Is there any way we can fix this? I'm not going to have time to update the CS4270 driver to a

Re: [PATCH] powerpc/mm: Lockless get_user_pages_fast()

2008-07-30 Thread Nick Piggin
On Wed, Jul 30, 2008 at 07:33:26AM -0500, Kumar Gala wrote: On Jul 29, 2008, at 10:37 PM, Benjamin Herrenschmidt wrote: From: Nick Piggin [EMAIL PROTECTED] Implement lockless get_user_pages_fast for powerpc. Page table existence is guaranteed with RCU, and speculative page references

Re: [PATCH] powerpc/mm: Lockless get_user_pages_fast()

2008-07-30 Thread Kumar Gala
On Jul 30, 2008, at 8:17 AM, Nick Piggin wrote: On Wed, Jul 30, 2008 at 07:33:26AM -0500, Kumar Gala wrote: On Jul 29, 2008, at 10:37 PM, Benjamin Herrenschmidt wrote: From: Nick Piggin [EMAIL PROTECTED] Implement lockless get_user_pages_fast for powerpc. Page table existence is

Re: [PATCH 2/6] kvmppc: add hypercall infrastructure - host part

2008-07-30 Thread Geert Uytterhoeven
On Thu, 24 Jul 2008, Tony Breeds wrote: On Wed, Jul 23, 2008 at 10:36:43AM +0200, [EMAIL PROTECTED] wrote: From: Christian Ehrhardt [EMAIL PROTECTED] diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c --- a/arch/powerpc/kvm/emulate.c +++ b/arch/powerpc/kvm/emulate.c @@

[PATCH] dtc: give advance warning that -S is going away.

2008-07-30 Thread Paul Gortmaker
The -S option allowed the specification of a minimum size for the blob, however the main reason for caring about the size is so there is enough padding to add a chosen node by u-boot or whoever. In which case, folks don't really care about the absolute size, but rather the size of the padding

Re: [PATCH] dtc: give advance warning that -S is going away.

2008-07-30 Thread Jon Loeliger
The -S option allowed the specification of a minimum size for the blob, however the main reason for caring about the size is so there is enough padding to add a chosen node by u-boot or whoever. In which case, folks don't really care about the absolute size, but rather the size of the

Re: [PATCH] of: i2c: improve last resort compatible entry selection

2008-07-30 Thread Grant Likely
On Mon, Jul 28, 2008 at 09:47:21AM +0200, Segher Boessenkool wrote: A reasonable compatible value would be something like serial-eeprom-24c32. You can go a little bit more generic than that, if you write up in your binding how the driver should figure out the device size and the protocol

Re: [RFC] [PATCH 0/5 V2] Huge page backed user-space stacks

2008-07-30 Thread Eric B Munson
On Wed, 30 Jul 2008, Andrew Morton wrote: On Mon, 28 Jul 2008 12:17:10 -0700 Eric Munson [EMAIL PROTECTED] wrote: Certain workloads benefit if their data or text segments are backed by huge pages. The stack is no exception to this rule but there is no mechanism currently that allows the

Re: [RFC] [PATCH 0/5 V2] Huge page backed user-space stacks

2008-07-30 Thread Eric B Munson
/*** * User front end for using huge pages Copyright (C) 2008, IBM * * * * This program is free software; you can redistribute it and/or

[PATCH] Zero fill the return values of rtas arg buffer

2008-07-30 Thread Nathan Fontenot
The kernel copy of the rtas args struct contains the return value(s) for the specified rtas call. These are copied back to user space with the assumption that every value is properly updated prior. This patch zero's out the return value fields of the rtas args struct before processing the rtas

Re: [RFC] [PATCH 0/5 V2] Huge page backed user-space stacks

2008-07-30 Thread Andrew Morton
/postings/stack-backing-20080730/x86-stream-stack.ps x86_64: http://www.csn.ul.ie/~mel/postings/stack-backing-20080730/x86_64-stream-stack.ps ppc64-small: http://www.csn.ul.ie/~mel/postings/stack-backing-20080730/ppc64-small-stream-stack.ps ppc64-large: http://www.csn.ul.ie/~mel/postings/stack

Re: [RFC] [PATCH 0/5 V2] Huge page backed user-space stacks

2008-07-30 Thread Mel Gorman
showed a performance gain from using hugepages. I can post the raw figures but they are not currently in an eye-friendly format. Here are some plots of the data though; x86: http://www.csn.ul.ie/~mel/postings/stack-backing-20080730/x86-stream-stack.ps x86_64: http://www.csn.ul.ie/~mel/postings

Re: [PATCH] hvc - register all available consoles (was: Re: [PATCH] powerpc/lpar - defer prefered console setup)

2008-07-30 Thread Milton Miller
Please CC me, I'm not subscribed to the list. On Wed Jul 30 at 20:07:01 EST in 2008, Bastian Blank wrote: On Wed, Jul 30, 2008 at 04:13:47AM -0500, Milton Miller wrote: On Wed Jul 30 at 17:34:38 EST in 2008, Bastian Blank wrote: On Wed, Jul 30, 2008 at 08:29:19AM +0200, Bastian Blank wrote:

[patch 2/2] powerpc: replace __FUNCTION__ with __func__

2008-07-30 Thread akpm
From: Harvey Harrison [EMAIL PROTECTED] __FUNCTION__ is gcc-specific, use __func__ [EMAIL PROTECTED]: coding-style fixes] Signed-off-by: Harvey Harrison [EMAIL PROTECTED] Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---

[patch 1/2] ppc: use the common ascii hex helpers

2008-07-30 Thread akpm
From: Harvey Harrison [EMAIL PROTECTED] [EMAIL PROTECTED]: exclude prom_init.c] Signed-off-by: Harvey Harrison [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- arch/powerpc/kernel/btext.c | 34 -- powerpc/kernel/prom_init.c |0 2 files

Re: [RFC] [PATCH 0/5 V2] Huge page backed user-space stacks

2008-07-30 Thread Mel Gorman
are some plots of the data though; x86: http://www.csn.ul.ie/~mel/postings/stack-backing-20080730/x86-stream-stack.ps x86_64: http://www.csn.ul.ie/~mel/postings/stack-backing-20080730/x86_64-stream-stack.ps ppc64-small: http://www.csn.ul.ie/~mel/postings/stack-backing-20080730/ppc64

Re: ide pmac breakage

2008-07-30 Thread Bartlomiej Zolnierkiewicz
On Wednesday 30 July 2008, Benjamin Herrenschmidt wrote: On Tue, 2008-07-29 at 21:26 +0200, Bartlomiej Zolnierkiewicz wrote: I WON!!! Only half... Heh, I wasn't talking about fixing the issue... (hint: look up the author of the bad commit). It goes further and then blows up again. First

Re: [RFC] [PATCH 0/5 V2] Huge page backed user-space stacks

2008-07-30 Thread Andrew Morton
On Wed, 30 Jul 2008 20:30:10 +0100 Mel Gorman [EMAIL PROTECTED] wrote: With Erics patch and libhugetlbfs, we can automatically back text/data[1], malloc[2] and stacks without source modification. Fairly soon, libhugetlbfs will also be able to override shmget() to add SHM_HUGETLB. That should

Re: [PATCH] of: i2c: improve last resort compatible entry selection

2008-07-30 Thread Jon Smirl
On 7/30/08, Grant Likely [EMAIL PROTECTED] wrote: On Mon, Jul 28, 2008 at 09:47:21AM +0200, Segher Boessenkool wrote: A reasonable compatible value would be something like serial-eeprom-24c32. You can go a little bit more generic than that, if you write up in your binding how the

Re: [PATCH] powerpc/ibmveth: fix multiple errors with dma_mapping_error conversion

2008-07-30 Thread Jeff Garzik
Stephen Rothwell wrote: The addition of an argument to dma_mapping_error() in commit 8d8bb39b9eba32dd70e87fd5ad5c5dd4ba118e06 dma-mapping: add the device argument to dma_mapping_error() left a bit of fallout: drivers/net/ibmveth.c:263: error: too few arguments to function 'dma_mapping_error'

Re: [PATCH] powerpc/mm: Lockless get_user_pages_fast()

2008-07-30 Thread Benjamin Herrenschmidt
Index: linux-work/arch/powerpc/Kconfig === --- linux-work.orig/arch/powerpc/Kconfig2008-07-30 13:17:06.0 +1000 +++ linux-work/arch/powerpc/Kconfig 2008-07-30 13:27:40.0 +1000 @@ -42,6 +42,9 @@

Re: ide pmac breakage

2008-07-30 Thread Benjamin Herrenschmidt
On Wed, 2008-07-30 at 21:11 +0200, Bartlomiej Zolnierkiewicz wrote: Note that there shouldn't be anything fundamentally different from ide-pmac here vs. something like pcmcia IDE cards... do you have one of these to test with ? Nope and I really don't intend to have one. I count on

Re: [PATCH] powerpc/ibmveth: fix multiple errors with dma_mapping_error conversion

2008-07-30 Thread Benjamin Herrenschmidt
On Wed, 2008-07-30 at 17:18 -0400, Jeff Garzik wrote: Stephen Rothwell wrote: The addition of an argument to dma_mapping_error() in commit 8d8bb39b9eba32dd70e87fd5ad5c5dd4ba118e06 dma-mapping: add the device argument to dma_mapping_error() left a bit of fallout:

Re: [PATCH] powerpc/mm: Lockless get_user_pages_fast()

2008-07-30 Thread Kumar Gala
Here's the code.. I haven't looked at this in any detail and I didn't write it. - k diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c index c758407..c502909 100644 --- a/arch/powerpc/mm/pgtable_32.c +++ b/arch/powerpc/mm/pgtable_32.c @@ -26,7 +26,13 @@ #include

Re: [RFC] [PATCH 0/5 V2] Huge page backed user-space stacks

2008-07-30 Thread Christoph Lameter
Mel Gorman wrote: With Erics patch and libhugetlbfs, we can automatically back text/data[1], malloc[2] and stacks without source modification. Fairly soon, libhugetlbfs will also be able to override shmget() to add SHM_HUGETLB. That should cover a lot of the memory-intensive apps without

Re: ide pmac breakage

2008-07-30 Thread Bartlomiej Zolnierkiewicz
On Thursday 31 July 2008, Benjamin Herrenschmidt wrote: On Wed, 2008-07-30 at 21:11 +0200, Bartlomiej Zolnierkiewicz wrote: Note that there shouldn't be anything fundamentally different from ide-pmac here vs. something like pcmcia IDE cards... do you have one of these to test with ?

Re: ide pmac breakage

2008-07-30 Thread Benjamin Herrenschmidt
On Thu, 2008-07-31 at 02:48 +0200, Bartlomiej Zolnierkiewicz wrote: There seems to be some confusion between warm-plugging of IDE devices and hot-plugging of IDE devices. not a single piece of HW to exercise those code path ? I don't ask you to get a powermac with a media-bay, but ide_cs

[patch 1/6] kdump: Make elfcorehdr_addr independent of CONFIG_PROC_VMCORE

2008-07-30 Thread Simon Horman
From: Vivek Goyal [EMAIL PROTECTED] o elfcorehdr_addr is used by not only the code under CONFIG_PROC_VMCORE but also by the code which is not inside CONFIG_PROC_VMCORE. For example, is_kdump_kernel() is used by powerpc code to determine if kernel is booting after a panic then use previous

Re: ide pmac breakage

2008-07-30 Thread Bartlomiej Zolnierkiewicz
On Thursday 31 July 2008, Benjamin Herrenschmidt wrote: On Thu, 2008-07-31 at 02:48 +0200, Bartlomiej Zolnierkiewicz wrote: There seems to be some confusion between warm-plugging of IDE devices and hot-plugging of IDE devices. not a single piece of HW to exercise those code path ? I

[PATCH 5/8] Silence warning in arch/powerpc/mm/ppc_mmu_32.c

2008-07-30 Thread Tony Breeds
total_memory is a 'phys_addr_t', cast to unsigned long to silence warning. Signed-off-by: Tony Breeds [EMAIL PROTECTED] --- arch/powerpc/mm/ppc_mmu_32.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/mm/ppc_mmu_32.c b/arch/powerpc/mm/ppc_mmu_32.c index

[PATCH 3/8] Silennce warning in arch/powerpc/mm/mem.c

2008-07-30 Thread Tony Breeds
Explicitly cast to unsigned long long, rather than u64. Signed-off-by: Tony Breeds [EMAIL PROTECTED] --- arch/powerpc/mm/mem.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c index 702691c..1c93c25 100644 ---

[PATCH 1/8] Guard linkstation_physmap_partitions.

2008-07-30 Thread Tony Breeds
linkstation_physmap_partitions is only used when CONFIG_MTD_PHYSMAP is defined, so likewise guard the declaration. Signed-off-by: Tony Breeds [EMAIL PROTECTED] --- arch/powerpc/platforms/embedded6xx/linkstation.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[PATCH 4/8] Silence warnings in arch/powerpc/platforms/52xx/mpc52xx_pci.c

2008-07-30 Thread Tony Breeds
Explicitly cast resource fields to unsigned long long, and match format specifier. Signed-off-by: Tony Breeds [EMAIL PROTECTED] --- arch/powerpc/platforms/52xx/mpc52xx_pci.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git

[PATCH 2/8] Guard htab_dt_scan_hugepage_blocks appropriately

2008-07-30 Thread Tony Breeds
htab_dt_scan_hugepage_blocks is only used when CONFIG_HUGETLB_PAGE is defined, likewise guard the declaration. Signed-off-by: Tony Breeds [EMAIL PROTECTED] --- arch/powerpc/mm/hash_utils_64.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[PATCH 7/8] Guard from_rtc_time() in arch/powerpc/platforms/powermac/time.c

2008-07-30 Thread Tony Breeds
from_rtc_time() is only called when one of 3 CONFIG options are defined. Guard the declaration appropriately. Signed-off-by: Tony Breeds [EMAIL PROTECTED] --- arch/powerpc/platforms/powermac/time.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PATCH 8/8] Enable -Werror in arch/powerpc/{kernel,lib,mm,platforms}

2008-07-30 Thread Tony Breeds
Signed-off-by: Tony Breeds [EMAIL PROTECTED] --- arch/powerpc/kernel/Makefile|1 + arch/powerpc/lib/Makefile |1 + arch/powerpc/mm/Makefile|1 + arch/powerpc/platforms/40x/Makefile |2 ++

[PATCH 6/8] Explictly undefine DEBUG in arch/powerpc/platforms/pseries/eeh_driver.c

2008-07-30 Thread Tony Breeds
print_device_node_tree() is guarded by DEBUG but even when declared, it isn't called. Explicitly undefine DEBUG as you'll need to modify this file anyway to use print_device_node_tree(). Signed-off-by: Tony Breeds [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/eeh_driver.c |3 +++ 1

Re: [PATCH 4/8] Silence warnings in arch/powerpc/platforms/52xx/mpc52xx_pci.c

2008-07-30 Thread Jon Smirl
There are some warnings in mpc5200 spi that I haven't looked at drivers/spi/mpc52xx_psc_spi.c: In function 'mpc52xx_psc_spi_activate_cs': drivers/spi/mpc52xx_psc_spi.c:111: warning: passing argument 1 of 'in_be16' from incompatible pointer type drivers/spi/mpc52xx_psc_spi.c:117: warning:

Re: [PATCH 4/8] Silence warnings in arch/powerpc/platforms/52xx/mpc52xx_pci.c

2008-07-30 Thread Tony Breeds
On Thu, Jul 31, 2008 at 12:08:04AM -0400, Jon Smirl wrote: There are some warnings in mpc5200 spi that I haven't looked at drivers/spi/mpc52xx_psc_spi.c: In function 'mpc52xx_psc_spi_activate_cs': drivers/spi/mpc52xx_psc_spi.c:111: warning: passing argument 1 of 'in_be16' from

Re: ide pmac breakage

2008-07-30 Thread Benjamin Herrenschmidt
Is it actually caused by additional reference counting on drive-gendev? IOW if you reverse the patch below instead of applying the previous fix do things work OK again? Note that there shouldn't be anything fundamentally different from ide-pmac here vs. something like pcmcia IDE cards...

Re: [PATCH 6/8] Explictly undefine DEBUG in arch/powerpc/platforms/pseries/eeh_driver.c

2008-07-30 Thread Michael Ellerman
On Thu, 2008-07-31 at 13:51 +1000, Tony Breeds wrote: print_device_node_tree() is guarded by DEBUG but even when declared, it isn't called. Explicitly undefine DEBUG as you'll need to modify this file anyway to use print_device_node_tree(). Please don't, it breaks CONFIG_PPC_PSERIES_DEBUG.

Re: [PATCH 5/8] Silence warning in arch/powerpc/mm/ppc_mmu_32.c

2008-07-30 Thread Stephen Rothwell
Hi Tony, On Thu, 31 Jul 2008 13:51:43 +1000 (EST) Tony Breeds [EMAIL PROTECTED] wrote: total_memory is a 'phys_addr_t', cast to unsigned long to silence warning. Signed-off-by: Tony Breeds [EMAIL PROTECTED] --- arch/powerpc/mm/ppc_mmu_32.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH] powerpc/pci: Don't keep ISA memory hole resources in the tree

2008-07-30 Thread Benjamin Herrenschmidt
When we have an ISA memory hole (ie, a PCI window that allows to generate PCI memory cycles at low PCI address) mixes with other resources using a different CPU = PCI mapping, we must not keep the ISA hole in the bridge resource list. If we do, things might start trying to allocate device

Re: [PATCH 4/8] Silence warnings in arch/powerpc/platforms/52xx/mpc52xx_pci.c

2008-07-30 Thread Grant Likely
On Wed, Jul 30, 2008 at 10:08 PM, Jon Smirl [EMAIL PROTECTED] wrote: There are some warnings in mpc5200 spi that I haven't looked at drivers/spi/mpc52xx_psc_spi.c: In function 'mpc52xx_psc_spi_activate_cs': drivers/spi/mpc52xx_psc_spi.c:111: warning: passing argument 1 of 'in_be16' from