Re: [PATCH v2 04/10] DMA, CMA: support alignment constraint on cma region

2014-06-12 Thread Joonsoo Kim
On Thu, Jun 12, 2014 at 02:52:20PM +0900, Minchan Kim wrote: On Thu, Jun 12, 2014 at 12:21:41PM +0900, Joonsoo Kim wrote: ppc kvm's cma area management needs alignment constraint on cma region. So support it to prepare generalization of cma area management functionality. Additionally,

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

2014-06-12 Thread Minchan Kim
On Thu, Jun 12, 2014 at 12:21:42PM +0900, Joonsoo Kim wrote: ppc kvm's cma region management requires arbitrary bitmap granularity, since they want to reserve very large memory and manage this region with bitmap that one bit for several pages to reduce management overheads. So support

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

2014-06-12 Thread Joonsoo Kim
On Thu, Jun 12, 2014 at 03:06:10PM +0900, Minchan Kim wrote: On Thu, Jun 12, 2014 at 12:21:42PM +0900, Joonsoo Kim wrote: ppc kvm's cma region management requires arbitrary bitmap granularity, since they want to reserve very large memory and manage this region with bitmap that one bit for

Re: [PATCH] powerpc, kexec: Fix Processor X is stuck issue during kexec from ST mode

2014-06-12 Thread Joel Stanley
Hi Srivatsa, On Sat, Jun 7, 2014 at 7:16 AM, Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com wrote: And with the following hunk added (which I had forgotten earlier), it worked just fine on powernv :-) How are the patches coming along? I just hung a machine here while attempting to kexec.

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

2014-06-12 Thread Minchan Kim
On Thu, Jun 12, 2014 at 03:43:55PM +0900, Joonsoo Kim wrote: On Thu, Jun 12, 2014 at 03:06:10PM +0900, Minchan Kim wrote: On Thu, Jun 12, 2014 at 12:21:42PM +0900, Joonsoo Kim wrote: ppc kvm's cma region management requires arbitrary bitmap granularity, since they want to reserve very

[PATCH] powerpc: Reduce scariness of interrupt frames in stack traces

2014-06-12 Thread Paul Mackerras
Some people see things like Exception: 501 in stack traces in dmesg and assume that means that something has gone badly wrong, when in fact Exception: 501 just means a device interrupt was taken. This changes Exception to interrupt to make it clearer that we are just recording the fact of a change

[PATCH v1] fs2dt: Refine kdump device_tree sort

2014-06-12 Thread Wei.Yang
From: Yang Wei wei.y...@windriver.com The commit b02d735bf was to rearrange the device-tree entries, and assumed that these entries are sorted in the ascending order. but acctually when I was validating kexec and kdump, the order of serial node still is changed. We should not only compare the

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

2014-06-12 Thread Minchan Kim
On Thu, Jun 12, 2014 at 12:21:42PM +0900, Joonsoo Kim wrote: ppc kvm's cma region management requires arbitrary bitmap granularity, since they want to reserve very large memory and manage this region with bitmap that one bit for several pages to reduce management overheads. So support

Re: [PATCH v2 06/10] CMA: generalize CMA reserved area management functionality

2014-06-12 Thread Minchan Kim
On Thu, Jun 12, 2014 at 12:21:43PM +0900, Joonsoo Kim wrote: Currently, there are two users on CMA functionality, one is the DMA subsystem and the other is the kvm on powerpc. They have their own code to manage CMA reserved area even if they looks really similar. From my guess, it is caused by

Re: [PATCH v2 08/10] mm, cma: clean-up cma allocation error path

2014-06-12 Thread Minchan Kim
On Thu, Jun 12, 2014 at 12:21:45PM +0900, Joonsoo Kim wrote: We can remove one call sites for clear_cma_bitmap() if we first call it before checking error number. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acked-by: Minchan Kim minc...@kernel.org -- Kind regards, Minchan Kim

Re: [PATCH v2 09/10] mm, cma: move output param to the end of param list

2014-06-12 Thread Minchan Kim
On Thu, Jun 12, 2014 at 12:21:46PM +0900, Joonsoo Kim wrote: Conventionally, we put output param to the end of param list. cma_declare_contiguous() doesn't look like that, so change it. If you says Conventionally, I'd like to suggest one more thing. Conventionally, we put 'base' ahead 'size'

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

2014-06-12 Thread Zhang Yanfei
On 06/12/2014 03:08 PM, Minchan Kim wrote: On Thu, Jun 12, 2014 at 12:21:42PM +0900, Joonsoo Kim wrote: ppc kvm's cma region management requires arbitrary bitmap granularity, since they want to reserve very large memory and manage this region with bitmap that one bit for several pages to

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

2014-06-12 Thread Joonsoo Kim
On Thu, Jun 12, 2014 at 04:08:11PM +0900, Minchan Kim wrote: On Thu, Jun 12, 2014 at 12:21:42PM +0900, Joonsoo Kim wrote: ppc kvm's cma region management requires arbitrary bitmap granularity, since they want to reserve very large memory and manage this region with bitmap that one bit for

Re: [PATCH v2 06/10] CMA: generalize CMA reserved area management functionality

2014-06-12 Thread Joonsoo Kim
On Thu, Jun 12, 2014 at 04:13:11PM +0900, Minchan Kim wrote: On Thu, Jun 12, 2014 at 12:21:43PM +0900, Joonsoo Kim wrote: Currently, there are two users on CMA functionality, one is the DMA subsystem and the other is the kvm on powerpc. They have their own code to manage CMA reserved area

Re: [PATCH v2 09/10] mm, cma: move output param to the end of param list

2014-06-12 Thread Joonsoo Kim
On Thu, Jun 12, 2014 at 04:19:31PM +0900, Minchan Kim wrote: On Thu, Jun 12, 2014 at 12:21:46PM +0900, Joonsoo Kim wrote: Conventionally, we put output param to the end of param list. cma_declare_contiguous() doesn't look like that, so change it. If you says Conventionally, I'd like to

Re: [PATCH v2 10/10] mm, cma: use spinlock instead of mutex

2014-06-12 Thread Minchan Kim
On Thu, Jun 12, 2014 at 12:21:47PM +0900, Joonsoo Kim wrote: Currently, we should take the mutex for manipulating bitmap. This job may be really simple and short so we don't need to sleep if contended. So I change it to spinlock. I'm not sure it would be good always. Maybe you remember we

Re: [PATCH v2 10/10] mm, cma: use spinlock instead of mutex

2014-06-12 Thread Joonsoo Kim
On Thu, Jun 12, 2014 at 04:40:29PM +0900, Minchan Kim wrote: On Thu, Jun 12, 2014 at 12:21:47PM +0900, Joonsoo Kim wrote: Currently, we should take the mutex for manipulating bitmap. This job may be really simple and short so we don't need to sleep if contended. So I change it to spinlock.

Re: [PATCH v2] powerpc: Avoid circular dependency with zImage.%

2014-06-12 Thread Michal Marek
Dne 12.6.2014 04:07, Mike Qiu napsal(a): This v2 patch is good, Tested-by: Mike Qiu qiud...@linux.vnet.ibm.com Thanks. In kbuild.git it goes. Michal ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

[PATCH 1/4] KVM: PPC: Book3S PR: Fix ABIv2 issues

2014-06-12 Thread Anton Blanchard
binutils knows that a branch to a function descriptor is actually a branch to the function text. By removing the explicit branch to dot symbols, we maintain both ABIv1 and ABIv2 compatibility. Signed-off-by: Anton Blanchard an...@samba.org --- Index: b/arch/powerpc/kvm/book3s_interrupts.S

Re: [PATCH v2 01/10] DMA, CMA: clean-up log message

2014-06-12 Thread Zhang Yanfei
On 06/12/2014 11:21 AM, Joonsoo Kim wrote: We don't need explicit 'CMA:' prefix, since we already define prefix 'cma:' in pr_fmt. So remove it. And, some logs print function name and others doesn't. This looks bad to me, so I unify log format to print function name consistently. Lastly, I

[PATCH 2/4] KVM: PPC: Book3S HV: Fix ABIv2 issues

2014-06-12 Thread Anton Blanchard
binutils knows that a branch to a function descriptor is actually a branch to the function text. By removing the explicit branch to dot symbols, we maintain both ABIv1 and ABIv2 compatibility. Signed-off-by: Anton Blanchard an...@samba.org --- Index: b/arch/powerpc/kvm/book3s_hv_rmhandlers.S

[PATCH 3/4] KVM: PPC: Book3S HV: Fix ABIv2 indirect branch issue

2014-06-12 Thread Anton Blanchard
To establish addressability quickly, ABIv2 requires the target address of the function being called to be in r12. Signed-off-by: Anton Blanchard an...@samba.org --- Index: b/arch/powerpc/kvm/book3s_hv_rmhandlers.S === ---

[PATCH 4/4] KVM: PPC: Assembly functions exported to modules need _GLOBAL_TOC()

2014-06-12 Thread Anton Blanchard
Both kvmppc_hv_entry_trampoline and kvmppc_entry_trampoline are assembly functions that are exported to modules and also require a valid r2. As such we need to use _GLOBAL_TOC so we provide a global entry point that establishes the TOC (r2). Signed-off-by: Anton Blanchard an...@samba.org ---

Re: [PATCH] powerpc, kexec: Fix Processor X is stuck issue during kexec from ST mode

2014-06-12 Thread Srivatsa S. Bhat
Hi Joel, On 06/12/2014 12:09 PM, Joel Stanley wrote: Hi Srivatsa, On Sat, Jun 7, 2014 at 7:16 AM, Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com wrote: And with the following hunk added (which I had forgotten earlier), it worked just fine on powernv :-) How are the patches coming

Re: [PATCH v2 02/10] DMA, CMA: fix possible memory leak

2014-06-12 Thread Zhang Yanfei
On 06/12/2014 02:02 PM, Joonsoo Kim wrote: On Thu, Jun 12, 2014 at 02:25:43PM +0900, Minchan Kim wrote: On Thu, Jun 12, 2014 at 12:21:39PM +0900, Joonsoo Kim wrote: We should free memory for bitmap when we find zone mis-match, otherwise this memory will leak. Then, -stable stuff? I don't

Re: [PATCH] powerpc, xmon: Enable hardware instruction breakpoint support on POWER8

2014-06-12 Thread Anshuman Khandual
On 06/04/2014 02:18 PM, Anshuman Khandual wrote: On 06/03/2014 11:33 AM, Anshuman Khandual wrote: On 05/30/2014 07:12 PM, Aneesh Kumar K.V wrote: Anshuman Khandual khand...@linux.vnet.ibm.com writes: This patch enables support for hardware instruction breakpoints on POWER8 with the help of

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

2014-06-12 Thread Zhang Yanfei
On 06/12/2014 11:21 AM, Joonsoo Kim wrote: ppc kvm's cma region management requires arbitrary bitmap granularity, since they want to reserve very large memory and manage this region with bitmap that one bit for several pages to reduce management overheads. So support arbitrary bitmap

Re: [PATCH v2 06/10] CMA: generalize CMA reserved area management functionality

2014-06-12 Thread Zhang Yanfei
On 06/12/2014 11:21 AM, Joonsoo Kim wrote: Currently, there are two users on CMA functionality, one is the DMA subsystem and the other is the kvm on powerpc. They have their own code to manage CMA reserved area even if they looks really similar. From my guess, it is caused by some needs on

Re: [PATCH v2 08/10] mm, cma: clean-up cma allocation error path

2014-06-12 Thread Zhang Yanfei
On 06/12/2014 11:21 AM, Joonsoo Kim wrote: We can remove one call sites for clear_cma_bitmap() if we first call it before checking error number. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Reviewed-by: Zhang Yanfei zhangyan...@cn.fujitsu.com diff --git a/mm/cma.c b/mm/cma.c index

Re: [PATCH v2 01/10] DMA, CMA: clean-up log message

2014-06-12 Thread Michal Nazarewicz
Joonsoo Kim iamjoonsoo@lge.com writes: We don't need explicit 'CMA:' prefix, since we already define prefix 'cma:' in pr_fmt. So remove it. And, some logs print function name and others doesn't. This looks bad to me, so I unify log format to print function name consistently.

Re: [PATCH v2 01/10] DMA, CMA: clean-up log message

2014-06-12 Thread Michal Nazarewicz
On Thu, Jun 12 2014, Joonsoo Kim iamjoonsoo@lge.com wrote: We don't need explicit 'CMA:' prefix, since we already define prefix 'cma:' in pr_fmt. So remove it. And, some logs print function name and others doesn't. This looks bad to me, so I unify log format to print function name

Re: [PATCH V3 0/3] Add new PowerPC specific ELF core notes

2014-06-12 Thread Anshuman Khandual
On 05/23/2014 08:45 PM, Anshuman Khandual wrote: This patch series adds five new ELF core note sections which can be used with existing ptrace request PTRACE_GETREGSET/SETREGSET for accessing various transactional memory and miscellaneous register sets on PowerPC platform. Please find a

Re: [PATCH v2 02/10] DMA, CMA: fix possible memory leak

2014-06-12 Thread Michal Nazarewicz
On Thu, Jun 12 2014, Joonsoo Kim iamjoonsoo@lge.com wrote: We should free memory for bitmap when we find zone mis-match, otherwise this memory will leak. Additionally, I copy code comment from ppc kvm's cma code to notify why we need to check zone mis-match. Signed-off-by: Joonsoo Kim

Re: [PATCH v2 01/10] DMA, CMA: clean-up log message

2014-06-12 Thread Michal Nazarewicz
On Thu, Jun 12 2014, Michal Nazarewicz min...@mina86.com wrote: I used “function(arg1, arg2, …)” at the *beginning* of functions when the arguments passed to the function were included in the message. In all other cases I left it at just “function:” (or just no additional prefix). IMO that's

Re: [PATCH v2 03/10] DMA, CMA: separate core cma management codes from DMA APIs

2014-06-12 Thread Michal Nazarewicz
On Thu, Jun 12 2014, Joonsoo Kim iamjoonsoo@lge.com wrote: To prepare future generalization work on cma area management code, we need to separate core cma management codes from DMA APIs. We will extend these core functions to cover requirements of ppc kvm's cma area management

Re: [PATCH v2 04/10] DMA, CMA: support alignment constraint on cma region

2014-06-12 Thread Michal Nazarewicz
On Thu, Jun 12 2014, Joonsoo Kim iamjoonsoo@lge.com wrote: ppc kvm's cma area management needs alignment constraint on I've noticed it earlier and cannot seem to get to terms with this. It should IMO be PPC, KVM and CMA since those are acronyms. But if you have strong feelings, it's not a

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

2014-06-12 Thread Michal Nazarewicz
On Thu, Jun 12 2014, Joonsoo Kim iamjoonsoo@lge.com wrote: ppc kvm's cma region management requires arbitrary bitmap granularity, since they want to reserve very large memory and manage this region with bitmap that one bit for several pages to reduce management overheads. So support

Re: [PATCH v2 08/10] mm, cma: clean-up cma allocation error path

2014-06-12 Thread Michal Nazarewicz
On Thu, Jun 12 2014, Joonsoo Kim iamjoonsoo@lge.com wrote: We can remove one call sites for clear_cma_bitmap() if we first call it before checking error number. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Reviewed-by: Michal Nazarewicz min...@mina86.com diff --git a/mm/cma.c

Re: [PATCH v2 09/10] mm, cma: move output param to the end of param list

2014-06-12 Thread Michal Nazarewicz
On Thu, Jun 12 2014, Joonsoo Kim iamjoonsoo@lge.com wrote: Conventionally, we put output param to the end of param list. cma_declare_contiguous() doesn't look like that, so change it. Perhaps the function should be changed to return an error-pointer? Additionally, move down cma_areas

Re: Kernel build issues after yesterdays merge by Linus

2014-06-12 Thread Anton Blanchard
Hi Christoph, This is under Ubuntu Utopic Unicorn on a Power 8 system while simply trying to build with the Ubuntu standard kernel config. It could be that these issues come about because we do not have an rc1 yet but I wanted to give some early notice. Also this is a new arch to me so I may

Re: powerpc/ppc64: Allow allmodconfig to build (finally !)

2014-06-12 Thread Guenter Roeck
On Mon, May 12, 2014 at 03:57:34PM +1000, Benjamin Herrenschmidt wrote: This shuffles code around in exceptions-64s.S in order to allow an allmodconfig build to succeed. The main problems were: - We have a fixed hole from 0x7000 to 0x8000 for use by FW, under some circumstances the code

Re: power and percpu: Could we move the paca into the percpu area?

2014-06-12 Thread Segher Boessenkool
Actually, from gcc/config/rs6000.h: /* 1 for registers that have pervasive standard uses and are not available for the register allocator. [snip] So cr5, which is number 73, is never used by gcc. Not available for RA is not the same thing at all as not used by GCC. For example, GPR1

RE: Kernel build issues after yesterdays merge by Linus

2014-06-12 Thread David Laight
From: Anton Blanchard ... diff --git a/arch/powerpc/boot/install.sh b/arch/powerpc/boot/install.sh index b6a256b..e096e5a 100644 --- a/arch/powerpc/boot/install.sh +++ b/arch/powerpc/boot/install.sh @@ -23,8 +23,8 @@ set -e # User may have a custom install script -if [ -x

[PATCH] KVM: PPC: e500mc: Relax tlb invalidation condition on vcpu schedule

2014-06-12 Thread Mihai Caraman
On vcpu schedule, the condition checked for tlb pollution is too tight. The tlb entries of one vcpu are polluted when a different vcpu from the same partition runs in-between. Relax the current tlb invalidation condition taking into account the lpid. Signed-off-by: Mihai Caraman mihai.caraman at

Re: [PATCH 3/4 v3] KVM: PPC: Alow kvmppc_get_last_inst() to fail

2014-06-12 Thread Alexander Graf
On 06/02/2014 05:50 PM, Mihai Caraman wrote: On book3e, guest last instruction is read on the exit path using load external pid (lwepx) dedicated instruction. This load operation may fail due to TLB eviction and execute-but-not-read entries. This patch lay down the path for an alternative

Re: [PATCH 4/4 v3] KVM: PPC: Bookehv: Get vcpu's last instruction for emulation

2014-06-12 Thread Alexander Graf
On 06/02/2014 05:50 PM, Mihai Caraman wrote: On book3e, KVM uses load external pid (lwepx) dedicated instruction to read guest last instruction on the exit path. lwepx exceptions (DTLB_MISS, DSI and LRAT), generated by loading a guest address, needs to be handled by KVM. These exceptions are

Re: [PATCH] KVM: PPC: e500mc: Relax tlb invalidation condition on vcpu schedule

2014-06-12 Thread Alexander Graf
On 06/12/2014 04:00 PM, Mihai Caraman wrote: On vcpu schedule, the condition checked for tlb pollution is too tight. The tlb entries of one vcpu are polluted when a different vcpu from the same partition runs in-between. Relax the current tlb invalidation condition taking into account the lpid.

Re: [PATCH] powerpc: Add AT_HWCAP2 to indicate V.CRYPTO category support

2014-06-12 Thread Steve Munroe
The precedent we have used is that features that refer to ISA Categories include _HAS_ following the PPC_FEATURE[2]. So GLIBC specifies in hwcap.h: /* Feature definitions in AT_HWCAP2. */ #define PPC_FEATURE2_ARCH_2_07 0x8000 /* ISA 2.07 */ #define PPC_FEATURE2_HAS_HTM 0x4000

Device Tree Binding for DSA on P1023RDB

2014-06-12 Thread Pannirselvam Kanagaratnam
The QORIQ P1023RDB has an option to populate the Marvell 88E6165 Ethernet switch. We populated this device and was able to initialize it as a basic switch in U-Boot. However, the switch driver was not loaded upon kernel bootup. DSA kernel config was enabled for the

Re: Device Tree Binding for DSA on P1023RDB

2014-06-12 Thread Scott Wood
On Thu, 2014-06-12 at 23:36 +0800, Pannirselvam Kanagaratnam wrote: The QORIQ P1023RDB has an option to populate the Marvell 88E6165 Ethernet switch. We populated this device and was able to initialize it as a basic switch in U-Boot. However, the switch driver was not loaded upon kernel

Re: power and percpu: Could we move the paca into the percpu area?

2014-06-12 Thread Benjamin Herrenschmidt
On Thu, 2014-06-12 at 07:26 -0500, Segher Boessenkool wrote: But, indeed, it does look like GCC doesn't use it. It seems to me that some ABI forbade userland (or non-libraries or whatever) from using it. I'll see what I can find out. I can still use -ffixed-cr5 for safety no ? Cheers, Ben.

Re: powerpc/ppc64: Allow allmodconfig to build (finally !)

2014-06-12 Thread Benjamin Herrenschmidt
On Thu, 2014-06-12 at 05:26 -0700, Guenter Roeck wrote: what happened with this patch ? Well it breaks with that binutils version of yours ... I'm trying to fix it in a better way but it's a mess... still working on it. Cheers, Ben. ___ Linuxppc-dev

Re: [PATCH] powerpc: Add AT_HWCAP2 to indicate V.CRYPTO category support

2014-06-12 Thread Benjamin Herrenschmidt
On Thu, 2014-06-12 at 10:13 -0500, Steve Munroe wrote: The precedent we have used is that features that refer to ISA Categories include _HAS_ following the PPC_FEATURE[2]. So GLIBC specifies in hwcap.h: /* Feature definitions in AT_HWCAP2. */ #define PPC_FEATURE2_ARCH_2_07 0x8000

Re: power and percpu: Could we move the paca into the percpu area?

2014-06-12 Thread Segher Boessenkool
On Fri, Jun 13, 2014 at 07:57:08AM +1000, Benjamin Herrenschmidt wrote: On Thu, 2014-06-12 at 07:26 -0500, Segher Boessenkool wrote: But, indeed, it does look like GCC doesn't use it. It seems to me that some ABI forbade userland (or non-libraries or whatever) from using it. I'll see

Re: powerpc/ppc64: Allow allmodconfig to build (finally !)

2014-06-12 Thread Guenter Roeck
On 06/12/2014 02:57 PM, Benjamin Herrenschmidt wrote: On Thu, 2014-06-12 at 05:26 -0700, Guenter Roeck wrote: what happened with this patch ? Well it breaks with that binutils version of yours ... I'm trying to fix it in a better way but it's a mess... still working on it. I updated my

[git pull] Please pull powerpc.git next branch

2014-06-12 Thread Benjamin Herrenschmidt
Hi Linus ! Here are the remaining bits I was mentioning earlier. Mostly bug fixes and new selftests from Michael (yay !). He also removed the WSP platform and A2 core support which were dead before release, so less clutter. One little feature I snuck in is the doorbell IPI support for

Re: [git pull] Please pull powerpc.git next branch

2014-06-12 Thread Benjamin Herrenschmidt
On Fri, 2014-06-13 at 10:55 +1000, Benjamin Herrenschmidt wrote: Hi Linus ! Sending a copy via IBM just in case gmail has an issue with pull requests :-) If it goes through fine I'll stop doing it. Cheers, Ben. Here are the remaining bits I was mentioning earlier. Mostly bug fixes and new

RE: Kernel build issues after yesterdays merge by Linus

2014-06-12 Thread Christoph Lameter
Goobledieguy due to missing Mime header. On Thu, 12 Jun 2014, David Laight wrote: RnJvbTogQW50b24gQmxhbmNoYXJkDQouLi4NCj4gZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9i b290L2luc3RhbGwuc2ggYi9hcmNoL3Bvd2VycGMvYm9vdC9pbnN0YWxsLnNoDQo+IGluZGV4IGI2

Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-12 Thread Timur Tabi
On Thu, Dec 12, 2013 at 4:44 AM, Nicolin Chen guangyu.c...@freescale.com wrote: +static int fsl_ssi_set_dai_sysclk(struct snd_soc_dai *cpu_dai, + int clk_id, unsigned int freq, int dir) +{ + struct fsl_ssi_private *ssi_private =

Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-12 Thread Nicolin Chen
Sir, On Thu, Jun 12, 2014 at 10:24:55PM -0500, Timur Tabi wrote: On Thu, Dec 12, 2013 at 4:44 AM, Nicolin Chen guangyu.c...@freescale.com wrote: +static int fsl_ssi_set_dai_sysclk(struct snd_soc_dai *cpu_dai, + int clk_id, unsigned int freq, int dir) +{

Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-12 Thread Timur Tabi
On Thu, Jun 12, 2014 at 10:21 PM, Nicolin Chen guangyu.c...@freescale.com wrote: It compiles well with my ARM cross compiler. I guess it might be related to the compiler's version? But we should fix it anyway. Would you mind if I submit a patch? Or you do it directly? I just submitted a

Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-12 Thread Nicolin Chen
On Thu, Jun 12, 2014 at 10:44:48PM -0500, Timur Tabi wrote: On Thu, Jun 12, 2014 at 10:21 PM, Nicolin Chen guangyu.c...@freescale.com wrote: It compiles well with my ARM cross compiler. I guess it might be related to the compiler's version? But we should fix it anyway. Would you mind if

Re: Kernel build issues after yesterdays merge by Linus

2014-06-12 Thread Tony Breeds
On Thu, Jun 12, 2014 at 10:09:12PM +1000, Anton Blanchard wrote: The TOC symbol export is special and I think we might need to get our script to ignore it. Try this (untested) patch. If it's good I'll send it to Ben. diff --git a/arch/powerpc/relocs_check.pl b/arch/powerpc/relocs_check.pl