Re: [Bug 206203] kmemleak reports various leaks in drivers/of/unittest.c

2020-04-07 Thread Michael Ellerman
bugzilla-dae...@bugzilla.kernel.org writes: > https://bugzilla.kernel.org/show_bug.cgi?id=206203 > > Erhard F. (erhar...@mailbox.org) changed: > >What|Removed |Added > > Attachment

Re: [PATCH v1 2/2] mm/memory_hotplug: remove is_mem_section_removable()

2020-04-07 Thread Baoquan He
On 04/07/20 at 03:54pm, David Hildenbrand wrote: > Fortunately, all users of is_mem_section_removable() are gone. Get rid of > it, including some now unnecessary functions. > > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Michal Hocko > Cc: Andrew Morton > Cc: Oscar Salvador > Cc:

Re: [PATCH v1 1/2] powerpc/pseries/hotplug-memory: stop checking is_mem_section_removable()

2020-04-07 Thread Baoquan He
Add Pingfan to CC since he usually handles ppc related bugs for RHEL. On 04/07/20 at 03:54pm, David Hildenbrand wrote: > In commit 53cdc1cb29e8 ("drivers/base/memory.c: indicate all memory > blocks as removable"), the user space interface to compute whether a memory > block can be offlined

Re: [PATCH v3 1/1] ppc/crash: Reset spinlocks during crash

2020-04-07 Thread Leonardo Bras
Hello Nick, Michael, On Fri, 2020-04-03 at 16:41 +1000, Nicholas Piggin wrote: [...] > > > PAPR says we are not allowed to have multiple CPUs calling RTAS at once, > > > except for a very small list of RTAS calls. So if we bust the RTAS lock > > > there's a risk we violate that part of PAPR and

Re: [RFC/PATCH 2/3] pseries/kvm: Clear PSSCR[ESL|EC] bits before guest entry

2020-04-07 Thread David Gibson
On Tue, Apr 07, 2020 at 06:55:26PM +0530, Gautham R Shenoy wrote: > Hello David, > > On Mon, Apr 06, 2020 at 07:58:19PM +1000, David Gibson wrote: > > On Fri, Apr 03, 2020 at 03:01:03PM +0530, Gautham R Shenoy wrote: > > > On Fri, Apr 03, 2020 at 12:20:26PM +1000, Nicholas Piggin wrote: > > > >

Re: [PATCH v5 13/21] powerpc/xmon: Use a function for reading instructions

2020-04-07 Thread Jordan Niethe
On Tue, Apr 7, 2020 at 9:31 PM Balamuruhan S wrote: > > On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > > Currently in xmon, mread() is used for reading instructions. In > > preparation for prefixed instructions, create and use a new function, > > mread_instr(), especially for reading

Re: [PATCH v5 12/21] powerpc: Introduce a function for reporting instruction length

2020-04-07 Thread Jordan Niethe
On Tue, Apr 7, 2020 at 9:15 PM Balamuruhan S wrote: > > On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > > Currently all instructions have the same length, but in preparation for > > prefixed instructions introduce a function for returning instruction > > length. > > > > Signed-off-by:

Re: [PATCH v5 11/21] powerpc: Define and use __get_user_instr{, inatomic}()

2020-04-07 Thread Jordan Niethe
On Tue, Apr 7, 2020 at 8:48 PM Balamuruhan S wrote: > > On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > > Define specific __get_user_instr() and __get_user_instr_inatomic() > > macros for reading instructions from user space. > > > > Signed-off-by: Jordan Niethe > > --- > >

Re: [PATCH] cxl: Rework error message for incompatible slots

2020-04-07 Thread Andrew Donnellan
On 7/4/20 9:56 pm, Frederic Barrat wrote: Improve the error message shown if a capi adapter is plugged on a capi-incompatible slot directly under the PHB (no intermediate switch). Fixes: 5632874311db ("cxl: Add support for POWER9 DD2") Cc: sta...@vger.kernel.org # 4.14+ Signed-off-by: Frederic

Re: [PATCH v5 09/21] powerpc: Use a datatype for instructions

2020-04-07 Thread Jordan Niethe
On Tue, Apr 7, 2020 at 8:30 PM Balamuruhan S wrote: > > On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > > Currently unsigned ints are used to represent instructions on powerpc. > > This has worked well as instructions have always been 4 byte words. > > However, a future ISA version will

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-07 Thread Benjamin Herrenschmidt
On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: > Benjamin Herrenschmidt writes: > > On Tue, 2020-03-31 at 16:30 +1100, Michael Ellerman wrote: > > > I have no attachment to 40x, and I'd certainly be happy to have > > > less > > > code in the tree, we struggle to keep even the modern

Re: [PATCH v1 2/2] mm/memory_hotplug: remove is_mem_section_removable()

2020-04-07 Thread Wei Yang
On Tue, Apr 07, 2020 at 03:54:16PM +0200, David Hildenbrand wrote: >Fortunately, all users of is_mem_section_removable() are gone. Get rid of >it, including some now unnecessary functions. > >Cc: Michael Ellerman >Cc: Benjamin Herrenschmidt >Cc: Michal Hocko >Cc: Andrew Morton >Cc: Oscar

Re: [PATCH v3 1/1] powerpc/kernel: Enables memory hot-remove after reboot on pseries guests

2020-04-07 Thread Leonardo Bras
Hello Michael, Would it be ok to add this patch for 5.7 ? Or too late? Regards, On Tue, 2020-04-07 at 09:30 +0530, Bharata B Rao wrote: > On Mon, Apr 06, 2020 at 12:41:01PM -0300, Leonardo Bras wrote: > > Hello Bharata, > > > > On Fri, 2020-04-03 at 20:08 +0530, Bharata B Rao wrote: > > > The

Re: [PATCH vdsotest] Use vdso wrapper for gettimeofday()

2020-04-07 Thread Christophe Leroy
Hi Nathan, Le 16/01/2020 à 17:56, Nathan Lynch a écrit : Hi Christophe, Christophe Leroy writes: To properly handle errors returned by gettimeofday(), the DO_VDSO_CALL() macro has to be used, otherwise vdsotest misinterpret VDSO function return on error. This has gone unnoticed until now

Re: [PATCH V2 0/3] mm/debug: Add more arch page table helper tests

2020-04-07 Thread Gerald Schaefer
On Sun, 5 Apr 2020 17:58:14 +0530 Anshuman Khandual wrote: [...] > > > > Could be fixed like this (the first de-reference is a bit special, > > because at that point *ptep does not really point to a large (pmd) entry > > yet, it is initially an invalid pte entry, which breaks our

Re: [PATCH v6 4/4] powerpc/vdso: Switch VDSO to generic C implementation.

2020-04-07 Thread Naveen N. Rao
Christophe Leroy wrote: powerpc is a bit special for VDSO as well as system calls in the way that it requires setting CR SO bit which cannot be done in C. Therefore, entry/exit needs to be performed in ASM. Implementing __arch_get_vdso_data() would clobbers the link register, requiring the

Re: [PATCH v1 2/2] mm/memory_hotplug: remove is_mem_section_removable()

2020-04-07 Thread Michal Hocko
On Tue 07-04-20 15:54:16, David Hildenbrand wrote: > Fortunately, all users of is_mem_section_removable() are gone. Get rid of > it, including some now unnecessary functions. > > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Michal Hocko > Cc: Andrew Morton > Cc: Oscar Salvador >

Re: [PATCH v1 1/2] powerpc/pseries/hotplug-memory: stop checking is_mem_section_removable()

2020-04-07 Thread Michal Hocko
On Tue 07-04-20 15:54:15, David Hildenbrand wrote: > In commit 53cdc1cb29e8 ("drivers/base/memory.c: indicate all memory > blocks as removable"), the user space interface to compute whether a memory > block can be offlined (exposed via > /sys/devices/system/memory/memoryX/removable) has

[PATCH v1 2/2] mm/memory_hotplug: remove is_mem_section_removable()

2020-04-07 Thread David Hildenbrand
Fortunately, all users of is_mem_section_removable() are gone. Get rid of it, including some now unnecessary functions. Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Michal Hocko Cc: Andrew Morton Cc: Oscar Salvador Cc: Baoquan He Cc: Wei Yang Signed-off-by: David Hildenbrand ---

[PATCH v1 1/2] powerpc/pseries/hotplug-memory: stop checking is_mem_section_removable()

2020-04-07 Thread David Hildenbrand
In commit 53cdc1cb29e8 ("drivers/base/memory.c: indicate all memory blocks as removable"), the user space interface to compute whether a memory block can be offlined (exposed via /sys/devices/system/memory/memoryX/removable) has effectively been deprecated. We want to remove the leftovers of the

[PATCH v1 0/2] mm/memory_hotplug: remove is_mem_section_removable()

2020-04-07 Thread David Hildenbrand
This is the follow-up of "[PATCH v1] drivers/base/memory.c: indicate all memory blocks as removable" [1], which gets rid of is_mem_section_removable(). More details can be found in [1] and [2] [1] https://lkml.kernel.org/r/20200128093542.6908-1-da...@redhat.com [2]

Re: Linux-next POWER9 NULL pointer NIP since 1st Apr.

2020-04-07 Thread Steven Rostedt
On Tue, 7 Apr 2020 09:01:10 -0400 Qian Cai wrote: > + Steven > > > On Apr 7, 2020, at 8:42 AM, Michael Ellerman wrote: > > > > Qian Cai writes: > >> Ever since 1st Apr, linux-next starts to trigger a NULL pointer NIP on > >> POWER9 below using > >> this config, > >> > >>

Re: [RFC/PATCH 2/3] pseries/kvm: Clear PSSCR[ESL|EC] bits before guest entry

2020-04-07 Thread Gautham R Shenoy
Hello David, On Mon, Apr 06, 2020 at 07:58:19PM +1000, David Gibson wrote: > On Fri, Apr 03, 2020 at 03:01:03PM +0530, Gautham R Shenoy wrote: > > On Fri, Apr 03, 2020 at 12:20:26PM +1000, Nicholas Piggin wrote: > > > Gautham R. Shenoy's on March 31, 2020 10:10 pm: > > > > From: "Gautham R.

[PATCH v6 4/4] powerpc/vdso: Switch VDSO to generic C implementation.

2020-04-07 Thread Christophe Leroy
powerpc is a bit special for VDSO as well as system calls in the way that it requires setting CR SO bit which cannot be done in C. Therefore, entry/exit needs to be performed in ASM. Implementing __arch_get_vdso_data() would clobbers the link register, requiring the caller to save it. As the ASM

[PATCH v6 3/4] powerpc/processor: Move cpu_relax() into asm/vdso/processor.h

2020-04-07 Thread Christophe Leroy
cpu_relax() need to be in asm/vdso/processor.h to be used by the C VDSO generic library. Move it there. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/processor.h | 10 ++ arch/powerpc/include/asm/vdso/processor.h | 23 +++ 2 files changed, 25

[PATCH v6 1/4] powerpc/vdso64: Switch from __get_datapage() to get_datapage inline macro

2020-04-07 Thread Christophe Leroy
On the same way as already done on PPC32, drop __get_datapage() function and use get_datapage inline macro instead. See commit ec0895f08f99 ("powerpc/vdso32: inline __get_datapage()") Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/vdso64/cacheflush.S | 9

[PATCH v6 0/4] powerpc: switch VDSO to C implementation

2020-04-07 Thread Christophe Leroy
This is a sixth version of a series to switch powerpc VDSO to generic C implementation. There is no major change since v5, mainly rebasing. Generic changes are all in linus/master now, so the series only includes powerpc parts now. Patch 3 is new, required following rework of header files for

[PATCH v6 2/4] powerpc/vdso: Remove __kernel_datapage_offset and simplify __get_datapage()

2020-04-07 Thread Christophe Leroy
The VDSO datapage and the text pages are always located immediately next to each other, so it can be hardcoded without an indirection through __kernel_datapage_offset In order to ease things, move the data page in front like other arches, that way there is no need to know the size of the library

Re: Linux-next POWER9 NULL pointer NIP since 1st Apr.

2020-04-07 Thread Qian Cai
+ Steven > On Apr 7, 2020, at 8:42 AM, Michael Ellerman wrote: > > Qian Cai writes: >> Ever since 1st Apr, linux-next starts to trigger a NULL pointer NIP on >> POWER9 below using >> this config, >> >> https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config >> >> It takes a

Re: Linux-next POWER9 NULL pointer NIP since 1st Apr.

2020-04-07 Thread Michael Ellerman
Qian Cai writes: > Ever since 1st Apr, linux-next starts to trigger a NULL pointer NIP on POWER9 > below using > this config, > > https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config > > It takes a while to reproduce, so before I bury myself into bisecting and > just send a

Re: [RFC/PATCH 2/3] pseries/kvm: Clear PSSCR[ESL|EC] bits before guest entry

2020-04-07 Thread Gautham R Shenoy
Hello Nicholas, On Fri, Apr 03, 2020 at 03:01:03PM +0530, Gautham R Shenoy wrote: > On Fri, Apr 03, 2020 at 12:20:26PM +1000, Nicholas Piggin wrote: [..snip..] > > > > > > Signed-off-by: Gautham R. Shenoy > > > --- > > > arch/powerpc/kvm/book3s_hv.c| 2 +- > > >

[PATCH] cxl: Rework error message for incompatible slots

2020-04-07 Thread Frederic Barrat
Improve the error message shown if a capi adapter is plugged on a capi-incompatible slot directly under the PHB (no intermediate switch). Fixes: 5632874311db ("cxl: Add support for POWER9 DD2") Cc: sta...@vger.kernel.org # 4.14+ Signed-off-by: Frederic Barrat --- drivers/misc/cxl/pci.c | 4 ++--

Re: [PATCH v5 13/21] powerpc/xmon: Use a function for reading instructions

2020-04-07 Thread Balamuruhan S
On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > Currently in xmon, mread() is used for reading instructions. In > preparation for prefixed instructions, create and use a new function, > mread_instr(), especially for reading instructions. > > Signed-off-by: Jordan Niethe > --- > v5: New

Re: [PATCH v5 0/5] Track and expose idle PURR and SPURR ticks

2020-04-07 Thread Kamalesh Babulal
On 4/7/20 2:17 PM, Gautham R. Shenoy wrote: > From: "Gautham R. Shenoy" > > Hi, > > This is the fifth version of the patches to track and expose idle PURR > and SPURR ticks. These patches are required by tools such as lparstat > to compute system utilization for capacity planning purposes. > >

Re: [PATCH v5 12/21] powerpc: Introduce a function for reporting instruction length

2020-04-07 Thread Balamuruhan S
On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > Currently all instructions have the same length, but in preparation for > prefixed instructions introduce a function for returning instruction > length. > > Signed-off-by: Jordan Niethe > --- > arch/powerpc/include/asm/inst.h | 5 + >

Re: [PATCH v5 11/21] powerpc: Define and use __get_user_instr{, inatomic}()

2020-04-07 Thread Balamuruhan S
On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > Define specific __get_user_instr() and __get_user_instr_inatomic() > macros for reading instructions from user space. > > Signed-off-by: Jordan Niethe > --- > arch/powerpc/include/asm/uaccess.h | 5 + > arch/powerpc/kernel/align.c

Re: [PATCH v5 10/21] powerpc: Use a function for reading instructions

2020-04-07 Thread Balamuruhan S
On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > Prefixed instructions will mean there are instructions of different > length. As a result dereferencing a pointer to an instruction will not > necessarily give the desired result. Introduce a function for reading > instructions from memory

Re: [PATCH v5 09/21] powerpc: Use a datatype for instructions

2020-04-07 Thread Balamuruhan S
On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > Currently unsigned ints are used to represent instructions on powerpc. > This has worked well as instructions have always been 4 byte words. > However, a future ISA version will introduce some changes to > instructions that mean this scheme

Re: [PATCH 1/2] dma-mapping: add a dma_ops_bypass flag to struct device

2020-04-07 Thread Alexey Kardashevskiy
On 07/04/2020 03:17, Christoph Hellwig wrote: > On Mon, Apr 06, 2020 at 11:25:09PM +1000, Alexey Kardashevskiy wrote: Do you see any serious problem with this approach? Thanks! >>> >>> Do you have a link to the whole branch? The github UI is unfortunately >>> unusable for that (or I'm

Re: [PATCH v12 5/8] powerpc/64: make buildable without CONFIG_COMPAT

2020-04-07 Thread Michal Suchánek
On Tue, Apr 07, 2020 at 07:50:30AM +0200, Christophe Leroy wrote: > > > Le 20/03/2020 à 11:20, Michal Suchanek a écrit : > > There are numerous references to 32bit functions in generic and 64bit > > code so ifdef them out. > > > > Signed-off-by: Michal Suchanek > > --- > > v2: > > - fix 32bit

Re: [PATCH v2 1/4] powerpc/64s: implement probe_kernel_read/write without touching AMR

2020-04-07 Thread Daniel Borkmann
Hey Nicholas, On 4/7/20 6:01 AM, Nicholas Piggin wrote: Nicholas Piggin's on April 3, 2020 9:05 pm: Christophe Leroy's on April 3, 2020 8:31 pm: Le 03/04/2020 à 11:35, Nicholas Piggin a écrit : There is no need to allow user accesses when probing kernel addresses. I just discovered the

Re: [PATCH v5 0/5] Track and expose idle PURR and SPURR ticks

2020-04-07 Thread Naveen N. Rao
Gautham R. Shenoy wrote: From: "Gautham R. Shenoy" Hi, This is the fifth version of the patches to track and expose idle PURR and SPURR ticks. These patches are required by tools such as lparstat to compute system utilization for capacity planning purposes. The previous versions can be found

[PATCH v5 5/5] Documentation: Document sysfs interfaces purr, spurr, idle_purr, idle_spurr

2020-04-07 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" Add documentation for the following sysfs interfaces: /sys/devices/system/cpu/cpuX/purr /sys/devices/system/cpu/cpuX/spurr /sys/devices/system/cpu/cpuX/idle_purr /sys/devices/system/cpu/cpuX/idle_spurr Signed-off-by: Gautham R. Shenoy ---

[PATCH v5 4/5] powerpc/sysfs: Show idle_purr and idle_spurr for every CPU

2020-04-07 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" On Pseries LPARs, to calculate utilization, we need to know the [S]PURR ticks when the CPUs were busy or idle. The total PURR and SPURR ticks are already exposed via the per-cpu sysfs files "purr" and "spurr". This patch adds support for exposing the idle PURR and

[PATCH v5 2/5] powerpc/idle: Store PURR snapshot in a per-cpu global variable

2020-04-07 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" Currently when CPU goes idle, we take a snapshot of PURR via pseries_idle_prolog() which is used at the CPU idle exit to compute the idle PURR cycles via the function pseries_idle_epilog(). Thus, the value of idle PURR cycle thus read before pseries_idle_prolog() and

[PATCH v5 3/5] powerpc/pseries: Account for SPURR ticks on idle CPUs

2020-04-07 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" On Pseries LPARs, to calculate utilization, we need to know the [S]PURR ticks when the CPUs were busy or idle. Via pseries_idle_prolog(), pseries_idle_epilog(), we track the idle PURR ticks in the VPA variable "wait_state_cycles". This patch extends the support to

[PATCH v5 1/5] powerpc: Move idle_loop_prolog()/epilog() functions to header file

2020-04-07 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" Currently prior to entering an idle state on a Linux Guest, the pseries cpuidle driver implement an idle_loop_prolog() and idle_loop_epilog() functions which ensure that idle_purr is correctly computed, and the hypervisor is informed that the CPU cycles have been

[PATCH v5 0/5] Track and expose idle PURR and SPURR ticks

2020-04-07 Thread Gautham R. Shenoy
From: "Gautham R. Shenoy" Hi, This is the fifth version of the patches to track and expose idle PURR and SPURR ticks. These patches are required by tools such as lparstat to compute system utilization for capacity planning purposes. The previous versions can be found here: v4:

Re: [PATCH v5 05/21] powerpc: Use a function for getting the instruction op code

2020-04-07 Thread Jordan Niethe
On Tue, Apr 7, 2020 at 5:05 PM Balamuruhan S wrote: > > On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > > In preparation for using a data type for instructions that can not be > > directly used with the '>>' operator use a function for getting the op > > code of an instruction. > >

Re: [PATCH v5 04/21] powerpc: Use a macro for creating instructions from u32s

2020-04-07 Thread Jordan Niethe
On Tue, Apr 7, 2020 at 4:40 PM Balamuruhan S wrote: > > On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > > In preparation for instructions having a more complex data type start > > using a macro, ppc_inst(), for making an instruction out of a u32. A > > macro is used so that

Re: [PATCH v5 07/21] powerpc: Use a function for byte swapping instructions

2020-04-07 Thread Balamuruhan S
On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > Use a function for byte swapping instructions in preparation of a more > complicated instruction type. Reviewed-by: Balamuruhan S > > Signed-off-by: Jordan Niethe > --- > arch/powerpc/include/asm/inst.h | 5 + >

Re: [PATCH v5 08/21] powerpc: Introduce functions for instruction equality

2020-04-07 Thread Balamuruhan S
On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > In preparation for an instruction data type that can not be directly > used with the '==' operator use functions for checking equality. LGTM except one comment below, otherwise Reviewed-by: Balamuruhan S > > Signed-off-by: Jordan

Re: [PATCH v8 1/7] perf expr: Add expr_ prefix for parse_ctx and parse_id

2020-04-07 Thread kajoljain
On 4/6/20 7:43 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Apr 02, 2020 at 02:03:34AM +0530, Kajol Jain escreveu: >> From: Jiri Olsa >> >> Adding expr_ prefix for parse_ctx and parse_id, >> to straighten out the expr* namespace. >> >> There's no functional change. > > Next time please add

Re: [PATCH v5 05/21] powerpc: Use a function for getting the instruction op code

2020-04-07 Thread Balamuruhan S
On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > In preparation for using a data type for instructions that can not be > directly used with the '>>' operator use a function for getting the op > code of an instruction. vecemu.c and sstep.c will need ppc_inst_opcode(). -- Bala > >

Re: [PATCH v5 03/21] powerpc: Change calling convention for create_branch() et. al.

2020-04-07 Thread Balamuruhan S
On Tue, 2020-04-07 at 16:35 +1000, Jordan Niethe wrote: > On Tue, Apr 7, 2020 at 4:10 PM Balamuruhan S wrote: > > On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > > > create_branch(), create_cond_branch() and translate_branch() return the > > > instruction that they create, or return 0

Re: [PATCH v5 02/21] powerpc/xmon: Move out-of-line instructions to text section

2020-04-07 Thread Balamuruhan S
On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > To execute an instruction out of line after a breakpoint, the NIP is set > to the address of struct bpt::instr. Here a copy of the instruction that > was replaced with a breakpoint is kept, along with a trap so normal flow > can be resumed

Re: [PATCH v5 04/21] powerpc: Use a macro for creating instructions from u32s

2020-04-07 Thread Balamuruhan S
On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > In preparation for instructions having a more complex data type start > using a macro, ppc_inst(), for making an instruction out of a u32. A > macro is used so that instructions can be used as initializer elements. > Currently this does

Re: [PATCH v5 03/21] powerpc: Change calling convention for create_branch() et. al.

2020-04-07 Thread Jordan Niethe
On Tue, Apr 7, 2020 at 4:10 PM Balamuruhan S wrote: > > On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > > create_branch(), create_cond_branch() and translate_branch() return the > > instruction that they create, or return 0 to signal an error. Seperate > > s/seperate/separate thanks. >

Re: [PATCH v5 03/21] powerpc: Change calling convention for create_branch() et. al.

2020-04-07 Thread Balamuruhan S
On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > create_branch(), create_cond_branch() and translate_branch() return the > instruction that they create, or return 0 to signal an error. Seperate s/seperate/separate > these concerns in preparation for an instruction type that is not just

Re: [PATCH v12 5/8] powerpc/64: make buildable without CONFIG_COMPAT

2020-04-07 Thread Christophe Leroy
Le 20/03/2020 à 11:20, Michal Suchanek a écrit : There are numerous references to 32bit functions in generic and 64bit code so ifdef them out. Signed-off-by: Michal Suchanek --- v2: - fix 32bit ifdef condition in signal.c - simplify the compat ifdef condition in vdso.c - 64bit is redundant

Re: [PATCH v3 15/15] powerpc: make unrecoverable NMIs die instead of panic

2020-04-07 Thread Christophe Leroy
Le 07/04/2020 à 07:16, Nicholas Piggin a écrit : System Reset and Machine Check interrupts that are not recoverable due to being nested or interrupting when RI=0 currently panic. This is not necessary, and can often just kill the current context and recover. Signed-off-by: Nicholas Piggin

Re: [PATCH v3 14/15] powerpc/64s: system reset do not trace

2020-04-07 Thread Christophe Leroy
Le 07/04/2020 à 07:16, Nicholas Piggin a écrit : Similarly to the previous patch, do not trace system reset. This code is used when there is a crash or hang, and tracing disturbs the system more and has been known to crash in the crash handling path. Acked-by: Naveen N. Rao Signed-off-by:

Re: [PATCH v3 13/15] powerpc/64s: machine check do not trace real-mode handler

2020-04-07 Thread Christophe Leroy
Le 07/04/2020 à 07:16, Nicholas Piggin a écrit : Rather than notrace annotations throughout a significant part of the machine check code across kernel/ pseries/ and powernv/ which can easily be broken and is infrequently tested, use paca->ftrace_enabled to blanket-disable tracing of the