Re: [PATCH] perf vendor events power10: Add metric events json file for power10 platform

2021-10-07 Thread Michael Ellerman
Segher Boessenkool writes: > On Thu, Oct 07, 2021 at 08:47:50AM -0500, Paul A. Clarke wrote: >> On Wed, Oct 06, 2021 at 12:32:48PM -0500, Paul A. Clarke wrote: >> > > +{ >> > > +"BriefDescription": "Average cycles per instruction when the >> > > instruction finishes at dispatch", >>

Re: [PATCH v2] KVM: PPC: Defer vtime accounting 'til after IRQ handling

2021-10-07 Thread Greg Kurz
On Thu, 7 Oct 2021 16:28:56 +0200 Laurent Vivier wrote: > Commit 112665286d08 moved guest_exit() in the interrupt protected > area to avoid wrong context warning (or worse), but the tick counter > cannot be updated and the guest time is accounted to the system time. > > To fix the problem port

linux-next: build warnings in Linus' tree

2021-10-07 Thread Stephen Rothwell
Hi all, After merging the origin tree, today's linux-next build (powerpc allyesconfig) produced these warnings (along with many others): arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge): /pci@fd00: missing ranges for PCI bridge (or not a bridge)

Re: [PATCH] powerpc/eeh:Fix docstrings in eeh

2021-10-07 Thread Daniel Axtens
Hi Kai, Thank you for your patch! I have 3 very minor tweaks and I am otherwise very happy with it. Firstly, in your commit name, there should be a space between "powerpc/eeh:" and "Fix docstrings". You might also want to say "in eeh.c" rather than "in eeh" because there is eeh code in a number

[powerpc:next-test] BUILD SUCCESS 880c5cbb35b2c6e7d9627a53d26799f7affb6472

2021-10-07 Thread kernel test robot
-a002-20211004 i386 randconfig-a004-20211004 i386 randconfig-a006-20211004 hexagon randconfig-r045-20211007 hexagon randconfig-r041-20211007 s390 randconfig-r044-20211007 riscvrandconfig-r042-20211007 --- 0-DAY CI

[powerpc:fixes-test] BUILD SUCCESS eb8257a12192f43ffd41bd90932c39dade958042

2021-10-07 Thread kernel test robot
-a005-20211004 i386 randconfig-a002-20211004 i386 randconfig-a004-20211004 i386 randconfig-a006-20211004 hexagon randconfig-r045-20211007 hexagon randconfig-r041-20211007 s390 randconfig-r044-20211007 riscv

Re: [PATCH] perf vendor events power10: Add metric events json file for power10 platform

2021-10-07 Thread Segher Boessenkool
On Thu, Oct 07, 2021 at 08:47:50AM -0500, Paul A. Clarke wrote: > On Wed, Oct 06, 2021 at 12:32:48PM -0500, Paul A. Clarke wrote: > > > +{ > > > +"BriefDescription": "Average cycles per instruction when the > > > instruction finishes at dispatch", > > > > I'm not sure what that

[PATCH v2] KVM: PPC: Defer vtime accounting 'til after IRQ handling

2021-10-07 Thread Laurent Vivier
Commit 112665286d08 moved guest_exit() in the interrupt protected area to avoid wrong context warning (or worse), but the tick counter cannot be updated and the guest time is accounted to the system time. To fix the problem port to POWER the x86 fix 160457140187 ("Defer vtime accounting 'til

Re: [PATCH] perf vendor events power10: Add metric events json file for power10 platform

2021-10-07 Thread Paul A. Clarke
On Wed, Oct 06, 2021 at 12:32:48PM -0500, Paul A. Clarke wrote: > > +{ > > +"BriefDescription": "Average cycles per instruction when the > > instruction finishes at dispatch", > > I'm not sure what that means. After doing a bit of research, I think it might be a bit more clear as:

Re: [PATCH] KVM: PPC: Defer vtime accounting 'til after IRQ handling

2021-10-07 Thread Laurent Vivier
On 06/10/2021 12:42, Greg Kurz wrote: On Wed, 6 Oct 2021 09:37:45 +0200 Laurent Vivier wrote: Commit 61bd0f66ff92 has moved guest_enter() out of the interrupt protected area to be able to have updated tick counters, but commit 112665286d08 moved back to this area to avoid wrong context

Re: [PATCH] powerpc/eeh:Fix some mistakes in comments

2021-10-07 Thread Michael Ellerman
Daniel Axtens writes: > Hi Kai, > > Thank you for your contribution to the powerpc kernel! > >> Get rid of warning: >> arch/powerpc/kernel/eeh.c:774: warning: expecting prototype for >> eeh_set_pe_freset(). Prototype was for eeh_set_dev_freset() instead > > You haven't said where this warning is

Re: [PATCH] powerpc/mce: check if event info is valid

2021-10-07 Thread Michael Ellerman
Ganesh writes: > On 8/6/21 6:53 PM, Ganesh Goudar wrote: > >> Check if the event info is valid before printing the >> event information. When a fwnmi enabled nested kvm guest >> hits a machine check exception L0 and L2 would generate >> machine check event info, But L1 would not generate any >>

Re: [PATCH] video: fbdev: use memset_io() instead of memset()

2021-10-07 Thread Michael Ellerman
Christophe Leroy writes: > While investigating a lockup at startup on Powerbook 3400C, it was > identified that the fbdev driver generates alignment exception at > startup: ... > > Use fb_memset() instead of memset(). fb_memset() is defined as > memset_io() for powerpc. > > Fixes: 8c8709334cec

Re: [PATCH v1 6/6] x86: remove memory hotplug support on X86_32

2021-10-07 Thread David Hildenbrand
On 07.10.21 11:15, Oscar Salvador wrote: On Wed, Sep 29, 2021 at 04:36:00PM +0200, David Hildenbrand wrote: CONFIG_MEMORY_HOTPLUG was marked BROKEN over one year and we just restricted it to 64 bit. Let's remove the unused x86 32bit implementation and simplify the Kconfig. Signed-off-by: David

Re: [PATCH v1 6/6] x86: remove memory hotplug support on X86_32

2021-10-07 Thread Oscar Salvador
On Wed, Sep 29, 2021 at 04:36:00PM +0200, David Hildenbrand wrote: > CONFIG_MEMORY_HOTPLUG was marked BROKEN over one year and we just > restricted it to 64 bit. Let's remove the unused x86 32bit implementation > and simplify the Kconfig. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar

Re: [PATCH v1 5/6] mm/memory_hotplug: remove stale function declarations

2021-10-07 Thread Oscar Salvador
On Wed, Sep 29, 2021 at 04:35:59PM +0200, David Hildenbrand wrote: > These functions no longer exist. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador > --- > include/linux/memory_hotplug.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git

Re: [PATCH v1 4/6] mm/memory_hotplug: remove HIGHMEM leftovers

2021-10-07 Thread Oscar Salvador
On Wed, Sep 29, 2021 at 04:35:58PM +0200, David Hildenbrand wrote: > We don't support CONFIG_MEMORY_HOTPLUG on 32 bit and consequently not > HIGHMEM. Let's remove any leftover code -- including the unused > "status_change_nid_high" field part of the memory notifier. > > Signed-off-by: David

Re: [PATCH v1 3/6] mm/memory_hotplug: restrict CONFIG_MEMORY_HOTPLUG to 64 bit

2021-10-07 Thread Oscar Salvador
On Wed, Sep 29, 2021 at 04:35:57PM +0200, David Hildenbrand wrote: > 32 bit support is broken in various ways: for example, we can online > memory that should actually go to ZONE_HIGHMEM to ZONE_MOVABLE or in > some cases even to one of the other kernel zones. > > We marked it BROKEN in commit

Re: [PATCH v2 04/10] powerpc/bpf: Fix BPF_SUB when imm == 0x80000000

2021-10-07 Thread Naveen N. Rao
Christophe Leroy wrote: Le 05/10/2021 à 22:25, Naveen N. Rao a écrit : We aren't handling subtraction involving an immediate value of 0x8000 properly. Fix the same. Fixes: 156d0e290e969c ("powerpc/ebpf/jit: Implement JIT compiler for extended BPF") Signed-off-by: Naveen N. Rao ---

Re: [PATCH v1 2/6] mm/memory_hotplug: remove CONFIG_MEMORY_HOTPLUG_SPARSE

2021-10-07 Thread Oscar Salvador
On Wed, Sep 29, 2021 at 04:35:56PM +0200, David Hildenbrand wrote: > CONFIG_MEMORY_HOTPLUG depends on CONFIG_SPARSEMEM, so there is no need for > CONFIG_MEMORY_HOTPLUG_SPARSE anymore; adjust all instances to use > CONFIG_MEMORY_HOTPLUG and remove CONFIG_MEMORY_HOTPLUG_SPARSE. > > Signed-off-by:

Re: [PATCH v1 1/6] mm/memory_hotplug: remove CONFIG_X86_64_ACPI_NUMA dependency from CONFIG_MEMORY_HOTPLUG

2021-10-07 Thread Oscar Salvador
On Wed, Sep 29, 2021 at 04:35:55PM +0200, David Hildenbrand wrote: > SPARSEMEM is the only possible memory model for x86-64, FLATMEM is not > possible: > config ARCH_FLATMEM_ENABLE > def_bool y > depends on X86_32 && !NUMA > > And X86_64_ACPI_NUMA (obviously)

Re: [PATCH 04/12] arm64: Use of_get_cpu_hwid()

2021-10-07 Thread Will Deacon
On Wed, Oct 06, 2021 at 11:43:24AM -0500, Rob Herring wrote: > Replace the open coded parsing of CPU nodes' 'reg' property with > of_get_cpu_hwid(). > > This change drops an error message for missing 'reg' property, but that > should not be necessary as the DT tools will ensure 'reg' is present.

RE: [PATCH 06/12] openrisc: Use of_get_cpu_hwid()

2021-10-07 Thread David Laight
From: Segher Boessenkool > Sent: 06 October 2021 22:27 > > On Thu, Oct 07, 2021 at 05:44:00AM +0900, Stafford Horne wrote: > > You have defined of_get_cpu_hwid to return u64, will this create compiler > > warnings when since we are storing a u64 into a u32? > > > > It seems only if we make with

[V2] powerpc/perf: Fix cycles/instructions as PM_CYC/PM_INST_CMPL in power10

2021-10-07 Thread Athira Rajeev
From: Athira Rajeev In power9 and before platforms, the default event used for cyles and instructions is PM_CYC (0x0001e) and PM_INST_CMPL (0x2) respectively. These events uses two programmable PMCs and by default will count irrespective of the run latch state. But since it is using

[V3 4/4] tools/perf: Add perf tools support to expose instruction and data address registers as part of extended regs

2021-10-07 Thread Athira Rajeev
Patch enables presenting of Sampled Instruction Address Register (SIAR) and Sampled Data Address Register (SDAR) SPRs as part of extended regsiters for perf tool. Add these SPR's to sample_reg_mask in the tool side (to use with -I? option). Signed-off-by: Athira Rajeev ---

[V3 3/4] powerpc/perf: Expose instruction and data address registers as part of extended regs

2021-10-07 Thread Athira Rajeev
Patch adds support to include Sampled Instruction Address Register (SIAR) and Sampled Data Address Register (SDAR) SPRs as part of extended registers. Update the definition of PERF_REG_PMU_MASK_300/31 and PERF_REG_EXTENDED_MAX to include these SPR's. Signed-off-by: Athira Rajeev Reviewed-by:

[V3 2/4] tools/perf: Refactor the code definition of perf reg extended mask in tools side header file

2021-10-07 Thread Athira Rajeev
PERF_REG_PMU_MASK_300 and PERF_REG_PMU_MASK_31 defines the mask value for extended registers. Current definition of these mask values uses hex constant and does not use registers by name, making it less readable. Patch refactor the macro values in perf tools side header file by or'ing together the

[V3 1/4] powerpc/perf: Refactor the code definition of perf reg extended mask

2021-10-07 Thread Athira Rajeev
PERF_REG_PMU_MASK_300 and PERF_REG_PMU_MASK_31 defines the mask value for extended registers. Current definition of these mask values uses hex constant and does not use registers by name, making it less readable. Patch refactor the macro values by or'ing together the actual register value

[V3 0/4] powerpc/perf: Add instruction and data address registers to extended regs

2021-10-07 Thread Athira Rajeev
Patch set adds PMU registers namely Sampled Instruction Address Register (SIAR) and Sampled Data Address Register (SDAR) as part of extended regs in PowerPC. These registers provides the instruction/data address and adding these to extended regs helps in debug purposes. Patch 1/4 and 2/4

Re: [PATCH v3 0/4] Add mem_hops field in perf_mem_data_src structure

2021-10-07 Thread Peter Zijlstra
On Wed, Oct 06, 2021 at 07:36:50PM +0530, Kajol Jain wrote: > Kajol Jain (4): > perf: Add comment about current state of PERF_MEM_LVL_* namespace and > remove an extra line > perf: Add mem_hops field in perf_mem_data_src structure > tools/perf: Add mem_hops field in perf_mem_data_src