Re: [PATCH v5 3/6] mm: make alloc_contig_range work at pageblock granularity

2022-02-13 Thread Christoph Hellwig
> +int > +isolate_single_pageblock(unsigned long boundary_pfn, gfp_t gfp_flags, int > isolate_before_boundary); Please avoid the completely unreadably long line. i.e. int isolate_single_pageblock(unsigned long boundary_pfn, gfp_t gfp_flags, int isolate_before_boundary); Same in

[PATCH] powerpc/boot: Add `otheros-too-big.bld` to .gitignore

2022-02-13 Thread Paul Menzel
Currently, `git status` lists the file as untracked by git, so tell git to ignore it. Fixes: aa3bc365ee73 ("powerpc/ps3: Add check for otheros image size") Signed-off-by: Paul Menzel --- arch/powerpc/boot/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git

No Linux logs when doing `ppc64_cpu --smt=off/8`

2022-02-13 Thread Paul Menzel
Dear PPC folks, On the POWER8 server IBM S822LC running `ppc64_cpu --smt=off` or `ppc64_cpu --smt=8`, Linux 5.17-rc4 does not log anything. I would have expected a message about the change in number of processing units. Kind regards, Paul

Re: [PATCH v3 09/10] powerpc/pseries/vas: sysfs interface to export capabilities

2022-02-13 Thread Nicholas Piggin
Excerpts from Haren Myneni's message of January 22, 2022 6:00 am: > > The hypervisor provides the available VAS GZIP capabilities such > as default or QoS window type and the target available credits in > each type. This patch creates sysfs entries and exports the target, > used and the available

Re: [PATCH v3 08/10] powerpc/vas: Return paste instruction failure if no active window

2022-02-13 Thread Nicholas Piggin
Excerpts from Haren Myneni's message of January 22, 2022 5:59 am: > > The VAS window may not be active if the system looses credits and > the NX generates page fault when it receives request on unmap > paste address. > > The kernel handles the fault by remap new paste address if the > window is

Re: [PATCH v3 07/10] powerpc/vas: Add paste address mmap fault handler

2022-02-13 Thread Nicholas Piggin
Excerpts from Haren Myneni's message of January 22, 2022 5:59 am: > > The user space opens VAS windows and issues NX requests by pasting > CRB on the corresponding paste address mmap. When the system looses s/loose/lose/g throughout the series. > credits due to core removal, the kernel has to

Re: [PATCH v3 06/10] powerpc/vas: Map paste address only if window is active

2022-02-13 Thread Nicholas Piggin
Excerpts from Haren Myneni's message of January 22, 2022 5:58 am: > > The paste address mapping is done with mmap() after the window is > opened with ioctl. But the window can be closed due to lost credit > due to core removal before mmap(). So if the window is not active, > return mmap() failure

Re: [PATCH v3 05/10] powerpc/pseries/vas: Close windows with DLPAR core removal

2022-02-13 Thread Nicholas Piggin
Excerpts from Haren Myneni's message of January 22, 2022 5:57 am: > > The hypervisor reduces the available credits if the core is removed > from the LPAR. So there is possibility of using excessive credits > (windows) in the LPAR and the hypervisor expects the system to close > the excessive

Re: [PATCH v3 04/10] powerpc/pseries/vas: Reopen windows with DLPAR core add

2022-02-13 Thread Nicholas Piggin
Excerpts from Haren Myneni's message of January 22, 2022 5:56 am: > > VAS windows can be closed in the hypervisor due to lost credits > when the core is removed. If these credits are available later > for core add, reopen these windows and set them active. When the > kernel sees page fault on the

Re: [PATCH v5 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

2022-02-13 Thread Mimi Zohar
Hi Michal, On Tue, 2022-01-11 at 12:37 +0100, Michal Suchanek wrote: > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index dea74d7717c0..1cde9b6c5987 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -560,6 +560,22 @@ config KEXEC_FILE > config

Re: [PATCH v3 03/10] powerpc/pseries/vas: Save LPID in pseries_vas_window struct

2022-02-13 Thread Nicholas Piggin
Excerpts from Haren Myneni's message of January 22, 2022 5:55 am: > > The kernel sets the VAS window with partition PID when is opened in > the hypervisor. During DLPAR operation, windows can be closed and > reopened in the hypervisor when the credit is available. So saves > this PID in

[PATCH 04/30] powerpc/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT

2022-02-13 Thread Anshuman Khandual
This defines and exports a platform specific custom vm_get_page_prot() via subscribing ARCH_HAS_VM_GET_PAGE_PROT. Subsequently all __SXXX and __PXXX macros can be dropped which are no longer needed. While here, this also localizes arch_vm_get_page_prot() as powerpc_vm_get_page_prot() and moves it

Re: [PATCH v3 02/10] powerpc/pseries/vas: Add notifier for DLPAR core removal/add

2022-02-13 Thread Nicholas Piggin
Excerpts from Haren Myneni's message of January 22, 2022 5:54 am: > > The hypervisor assigns credits for each LPAR based on number of > cores configured in that system. So expects to release credits > (means windows) when the core is removed. This patch adds notifier > for core removal/add so

Re: [PATCH v3 01/10] powerpc/pseries/vas: Use common names in VAS capability structure

2022-02-13 Thread Nicholas Piggin
Excerpts from Haren Myneni's message of January 22, 2022 5:54 am: > > target/used/avail_creds provides credits usage to user space via > sysfs and the same interface can be used on PowerNV in future. > Remove "lpar" from these names so that applicable on both PowerVM > and PowerNV. But not in

[PATCH] macintosh: Fix warning comparing pointer to 0

2022-02-13 Thread Yang Li
Fix the following coccicheck warnings: ./drivers/macintosh/via-cuda.c:240:16-17: WARNING comparing pointer to 0 ./drivers/macintosh/via-cuda.c:243:16-17: WARNING comparing pointer to 0, suggest !E ./drivers/macintosh/via-cuda.c:521:23-24: WARNING comparing pointer to 0 Reported-by: Abaci Robot

Re: [RFC] Upstreaming Linux for Nintendo Wii U

2022-02-13 Thread Ash Logan
Hi Christophe, On 12/2/22 00:11, Christophe Leroy wrote: Hi Ash, Le 11/02/2022 à 12:29, Michael Ellerman a écrit : Ash Logan writes: - Like the Wii before it, the Wii U has a small amount of RAM at address zero, a gap, then a large amount of RAM at a higher address. Instead of the "map

Re: [RFC] Upstreaming Linux for Nintendo Wii U

2022-02-13 Thread Ash Logan
Thanks for your response! On 11/2/22 22:29, Michael Ellerman wrote: Ash Logan writes: Hello, Hi Ash, I can't really answer all your questions, but I can chime in on one or two things ... - Right now I've made a new platform (like ps3) rather than joining the GameCube and Wii in

[powerpc:next] BUILD SUCCESS 5a72345e6a78120368fcc841b570331b6c5a50da

2022-02-13 Thread kernel test robot
kexec x86_64 allyesconfig clang tested configs: riscvrandconfig-c006-20220213 x86_64randconfig-c007 powerpc randconfig-c003-20220213 arm randconfig-c002-20220213 i386

Re: [PATCH v5 0/6] KEXEC_SIG with appended signature

2022-02-13 Thread Mimi Zohar
[Cc'ing Nageswara R Sastry] Hi Michal, On Tue, 2022-01-11 at 12:37 +0100, Michal Suchanek wrote: > Hello, > > This is a refresh of the KEXEC_SIG series. > > This adds KEXEC_SIG support on powerpc and deduplicates the code dealing > with appended signatures in the kernel.

Re: [PATCH v5 0/6] KEXEC_SIG with appended signature

2022-02-13 Thread Mimi Zohar
Hi Michal, On Tue, 2022-01-11 at 12:37 +0100, Michal Suchanek wrote: > Hello, > > This is a refresh of the KEXEC_SIG series. > This adds KEXEC_SIG support on powerpc and deduplicates the code dealing > with appended signatures in the kernel. > > powerpc supports IMA_KEXEC but that's an

Re: [PATCH v5 2/6] powerpc/kexec_file: Add KEXEC_SIG support.

2022-02-13 Thread Mimi Zohar
Hi Michal, On Wed, 2022-02-09 at 13:01 +0100, Michal Suchánek wrote: > > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > > > index dea74d7717c0..1cde9b6c5987 100644 > > > --- a/arch/powerpc/Kconfig > > > +++ b/arch/powerpc/Kconfig > > > @@ -560,6 +560,22 @@ config KEXEC_FILE > > >

RE: [PATCH] net: Remove branch in csum_shift()

2022-02-13 Thread David Laight
From: Segher Boessenkool > Sent: 13 February 2022 09:16 > > > What happens on x86-64? > > > > Trying to do the same in the x86 ipcsum code tended to make the code worse. > > (Although that test is for an odd length fragment and can just be removed.) > > In an ideal world the compiler could

Re: BUG: sleeping function called from invalid context at include/linux/sched/mm.h:256

2022-02-13 Thread Paul Menzel
Dear Paul, Am 13.02.22 um 15:45 schrieb Paul E. McKenney: On Sun, Feb 13, 2022 at 08:39:13AM +0100, Paul Menzel wrote: Am 13.02.22 um 00:48 schrieb Paul E. McKenney: On Sun, Feb 13, 2022 at 12:05:50AM +0100, Paul Menzel wrote: […] Running rcutorture on the POWER8 system IBM S822LC with

Re: [BUG] mtd: cfi_cmdset_0002: write regression since v4.17-rc1

2022-02-13 Thread Tokunori Ikegami
Hi Ahmad-san, Thanks for your confirmations. Sorry for late to reply. Could you please try the patch attached to disable the chip_good() change as before? I think this should work for S29GL964N since the chip_ready() is used and works as mentioned. On 2022/02/07 23:28, Ahmad Fatoum wrote:

Re: [PATCH] net: Remove branch in csum_shift()

2022-02-13 Thread Segher Boessenkool
On Sun, Feb 13, 2022 at 02:39:06AM +, David Laight wrote: > From: Christophe Leroy > > Sent: 11 February 2022 08:48 > > > > Today's implementation of csum_shift() leads to branching based on > > parity of 'offset' > > > > 02f8 : > > 2f8: 70 a5 00 01 andi. r5,r5,1

[PATCH] powerpc: Don't allow the use of EMIT_BUG_ENTRY with BUGFLAG_WARNING

2022-02-13 Thread Christophe Leroy
Warnings in assembly must use EMIT_WARN_ENTRY in order to generate the necessary entry in exception table. Check in EMIT_BUG_ENTRY that flags don't include BUGFLAG_WARNING. This change avoids problems like the one fixed by commit fd1ea686 ("powerpc/64s: Use EMIT_WARN_ENTRY for SRR debug