Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Xiaomeng Tong
On Thu, 3 Mar 2022 12:18:24 +, Daniel Thompson wrote: > On Thu, Mar 03, 2022 at 03:26:57PM +0800, Xiaomeng Tong wrote: > > On Thu, 3 Mar 2022 04:58:23 +, David Laight wrote: > > > on 3 Mar 2022 10:27:29 +0800, Xiaomeng Tong wrote: > > > > The problem is the mis-use of iterator outside the

[PATCH] powerpc/64e: Tie PPC_BOOK3E_64 to PPC_FSL_BOOK3E

2022-03-03 Thread Michael Ellerman
Since the IBM A2 CPU support was removed, see commit fb5a515704d7 ("powerpc: Remove platforms/wsp and associated pieces"), the only 64-bit Book3E CPUs we support are Freescale (NXP) ones. However our Kconfig still allows configurating a kernel that has 64-bit Book3E support, but no Freescale CPU

[PATCH] powerpc/sysdev: Use of_device_get_match_data()

2022-03-03 Thread cgel . zte
From: Minghao Chi (CGEL ZTE) Use of_device_get_match_data() to simplify the code. Reported-by: Zeal Robot Signed-off-by: Minghao Chi (CGEL ZTE) --- arch/powerpc/sysdev/fsl_msi.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_msi.c

[PATCH v2] powerpc: declare unmodified attribute_group usages const

2022-03-03 Thread Rohan McLure
Inspired by (bd75b4ef4977: Constify static attribute_group structs), accepted by linux-next, reported: https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220210202805.7750-4-rikard.falkeb...@gmail.com/ Nearly all singletons of type struct attribute_group are never modified, and so are

Re: [PATCH 11/12] swiotlb: merge swiotlb-xen initialization into swiotlb

2022-03-03 Thread Stefano Stabellini
On Thu, 3 Mar 2022, Christoph Hellwig wrote: > On Wed, Mar 02, 2022 at 05:25:10PM -0800, Stefano Stabellini wrote: > > Thinking more about it we actually need to drop the xen_initial_domain() > > check otherwise some cases won't be functional (Dom0 not 1:1 mapped, or > > DomU 1:1 mapped). > >

[PATCH] arch:powerpc:kvm: remove unnecessary type castings

2022-03-03 Thread Nour-eddine Taleb
remove unnecessary castings, from "void *" to "struct kvmppc_xics *" Signed-off-by: Nour-eddine Taleb --- arch/powerpc/kvm/book3s_xics.c| 2 +- arch/powerpc/kvm/book3s_xive.c| 2 +- arch/powerpc/kvm/book3s_xive_native.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH 11/12] swiotlb: merge swiotlb-xen initialization into swiotlb

2022-03-03 Thread Boris Ostrovsky
On 3/3/22 5:57 AM, Christoph Hellwig wrote: On Wed, Mar 02, 2022 at 08:15:03AM -0500, Boris Ostrovsky wrote: Not for me, I fail to boot with [ 52.202000] bnxt_en :31:00.0: swiotlb buffer is full (sz: 256 bytes), total 0 (slots), used 0 (slots) (this is iscsi root so I need the NIC).

[Bug 215652] kernel 5.17-rc fail to load radeon DRM "modprobe: ERROR: could not insert 'radeon': Unknown symbol in module, or unknown parameter (see dmesg)"

2022-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215652 --- Comment #7 from Erhard F. (erhar...@mailbox.org) --- (In reply to Alex Deucher from comment #6) > You need to make sure the firmware is in your initrd. When the kernel > loads, it loads from the initrd. There is no filesystem mounted yet

[Bug 215652] kernel 5.17-rc fail to load radeon DRM "modprobe: ERROR: could not insert 'radeon': Unknown symbol in module, or unknown parameter (see dmesg)"

2022-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215652 --- Comment #6 from Alex Deucher (alexdeuc...@gmail.com) --- (In reply to Erhard F. from comment #5) > > With CONFIG_DRM_RADEON=m radeon does not load and I still get "modprobe: > ERROR: could not insert 'radeon': Unknown symbol in module, or

Re: [PATCH v1 2/4] powerpc/ftrace: Refactor ftrace_{regs_}caller

2022-03-03 Thread Christophe Leroy
Le 03/03/2022 à 17:59, Naveen N. Rao a écrit : > Christophe Leroy wrote: >> ftrace_caller() and frace_regs_caller() have now a lot in common. >> >> Refactor them using GAS macros. > > Thanks for doing this - this looks much better. > >> >> Signed-off-by: Christophe Leroy >> --- >>  

Re: [PATCH v1 2/4] powerpc/ftrace: Refactor ftrace_{regs_}caller

2022-03-03 Thread Naveen N. Rao
Christophe Leroy wrote: ftrace_caller() and frace_regs_caller() have now a lot in common. Refactor them using GAS macros. Thanks for doing this - this looks much better. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/trace/ftrace_mprofile.S | 147 ++-- 1 file

Re: [PATCH 06/12] MIPS/octeon: use swiotlb_init instead of open coding it

2022-03-03 Thread Thomas Bogendoerfer
On Tue, Mar 01, 2022 at 12:53:05PM +0200, Christoph Hellwig wrote: > Use the generic swiotlb initialization helper instead of open coding it. > > Signed-off-by: Christoph Hellwig > --- > arch/mips/cavium-octeon/dma-octeon.c | 15 ++- > arch/mips/pci/pci-octeon.c | 2 +- >

[Bug 215652] kernel 5.17-rc fail to load radeon DRM "modprobe: ERROR: could not insert 'radeon': Unknown symbol in module, or unknown parameter (see dmesg)"

2022-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215652 --- Comment #5 from Erhard F. (erhar...@mailbox.org) --- Ok, changed my config to include the firmware via CONFIG_EXTRA_FIRMWARE="radeon/R520_cp.bin" CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware" With CONFIG_DRM_RADEON=y the machine boots now as

[PATCH] RFC: powerpc: wii.dts: Fix up GPIO I2C bus

2022-03-03 Thread Linus Walleij
This portion of the device tree just looks weird to me. We have a standard way of doing I2C-over-GPIO and it is a separate device tree node outside of the SoC node, not inside the GPIO node. Cc: Emmanuel Gil Peyrot Cc: Jonathan Neuschäfer Cc: Albert Herranz Cc: Michael Ellerman Cc: Alexandre

Re: [PATCH V3 05/30] arm64/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT

2022-03-03 Thread Catalin Marinas
Hi Anshuman, On Mon, Feb 28, 2022 at 04:17:28PM +0530, Anshuman Khandual wrote: > +static inline pgprot_t __vm_get_page_prot(unsigned long vm_flags) > +{ > + switch (vm_flags & (VM_READ | VM_WRITE | VM_EXEC | VM_SHARED)) { > + case VM_NONE: > + return PAGE_NONE; > + case

Re: [PATCH] powerpc/security: Provide stubs for when PPC_BARRIER_NOSPEC isn't enabled

2022-03-03 Thread Michael Ellerman
Christophe Leroy writes: > Le 10/01/2022 à 11:07, Naveen N. Rao a écrit : >> kernel test robot reported the below build error with a randconfig: >>powerpc64-linux-ld: arch/powerpc/net/bpf_jit_comp64.o:(.toc+0x0): >>undefined reference to `powerpc_security_features' >> >> This can happen

RE: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Xiaomeng Tong
> From: Xiaomeng Tong > > Sent: 03 March 2022 07:27 > > > > On Thu, 3 Mar 2022 04:58:23 +, David Laight wrote: > > > on 3 Mar 2022 10:27:29 +0800, Xiaomeng Tong wrote: > > > > The problem is the mis-use of iterator outside the loop on exit, and > > > > the iterator will be the HEAD's

Re: [Kgdb-bugreport] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Daniel Thompson
On Thu, Mar 03, 2022 at 03:26:57PM +0800, Xiaomeng Tong wrote: > On Thu, 3 Mar 2022 04:58:23 +, David Laight wrote: > > on 3 Mar 2022 10:27:29 +0800, Xiaomeng Tong wrote: > > > The problem is the mis-use of iterator outside the loop on exit, and > > > the iterator will be the HEAD's

Re: [next-20220225] powerpc boot broken with maple tree code ?

2022-03-03 Thread Abdul Haleem
On 3/2/22 8:22 PM, Liam Howlett wrote: * Abdul Haleem [220302 01:22]: Greeting's linux-next kernel 5.17.0-rc5-next-20220225 boot is broken on powerpc Is this due to Introduction of maple patch series ? It could be - those are certainly maple tree functions. I do have a ppc64le VM booting

Re: [PATCH 11/12] swiotlb: merge swiotlb-xen initialization into swiotlb

2022-03-03 Thread Christoph Hellwig
On Wed, Mar 02, 2022 at 05:25:10PM -0800, Stefano Stabellini wrote: > Thinking more about it we actually need to drop the xen_initial_domain() > check otherwise some cases won't be functional (Dom0 not 1:1 mapped, or > DomU 1:1 mapped). Hmm, but that would be the case even before this series,

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Dan Carpenter
On Wed, Mar 02, 2022 at 10:29:31AM +0100, Rasmus Villemoes wrote: > This won't help the current issue (because it doesn't exist and might > never), but just in case some compiler people are listening, I'd like to > have some sort of way to tell the compiler "treat this variable as > uninitialized

Re: [PATCH 11/12] swiotlb: merge swiotlb-xen initialization into swiotlb

2022-03-03 Thread Christoph Hellwig
On Wed, Mar 02, 2022 at 08:15:03AM -0500, Boris Ostrovsky wrote: > Not for me, I fail to boot with > > [ 52.202000] bnxt_en :31:00.0: swiotlb buffer is full (sz: 256 bytes), > total 0 (slots), used 0 (slots) > > (this is iscsi root so I need the NIC). > > > I bisected it to "x86: remove the

[Bug 215652] kernel 5.17-rc fail to load radeon DRM "modprobe: ERROR: could not insert 'radeon': Unknown symbol in module, or unknown parameter (see dmesg)"

2022-03-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215652 --- Comment #4 from Erhard F. (erhar...@mailbox.org) --- No I don't use an initrd. The kernel to boot the Talos is on a boot partition, modules are loaded from root partition. Which worked in 5.16 and before. Now I am getting this "could not

RE: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread David Laight
From: Xiaomeng Tong > Sent: 03 March 2022 07:27 > > On Thu, 3 Mar 2022 04:58:23 +, David Laight wrote: > > on 3 Mar 2022 10:27:29 +0800, Xiaomeng Tong wrote: > > > The problem is the mis-use of iterator outside the loop on exit, and > > > the iterator will be the HEAD's container_of pointer

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Dan Carpenter
On Wed, Mar 02, 2022 at 12:07:04PM -0800, Kees Cook wrote: > On Wed, Mar 02, 2022 at 10:29:31AM +0100, Rasmus Villemoes wrote: > > This won't help the current issue (because it doesn't exist and might > > never), but just in case some compiler people are listening, I'd like to > > have some sort

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Xiaomeng Tong
correct for typo: -for (struct list_head *list = head->next, cond = (struct list_head *)-1; cond == (struct list_head *)-1; cond = NULL) \ +for (struct list_head *list = head->next, *cond = (struct list_head *)-1; cond == (struct list_head *)-1; cond = NULL) \ -- Xiaomeng Tong

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-03 Thread Xiaomeng Tong
> I think this would make sense, it would mean you only assign the containing > element on valid elements. > > I was thinking something along the lines of: > > #define list_for_each_entry(pos, head, member) > \ > for (struct list_head *list =