rge.net, linux1394-de...@lists.sourceforge.net, linux-l...@vger.kernel.org,
rds-de...@oss.oracle.com, linux-...@vger.kernel.org, d...@vger.kernel.org,
intel-wired-...@lists.osuosl.org, linux-ser...@vger.kernel.org,
devicet...@vger.kernel.org, linux-...@lists.01.org,
In pcibios_alloc_controller(), 'phb' is allocated and escaped into
global 'hose_list'. So we should call of_node_get() when a new reference
created into 'phb->dn'. And when phb is freed, we should call
of_node_put() on it.
NOTE: This function is called in the iteration of for_each_xx in
We should call of_node_put() for the reference 'tsi' returned by
of_get_parent() which will increase the refcount.
Signed-off-by: Liang He
---
changelog:
v2: use more conservative way to call of_node_put()
v1: mov 'of_node_put()' into the 'if' condition
v1 Link:
On Wed, 29 Jun 2022 14:04:23 +0800, GONG, Ruiqi wrote:
> Fix the following Sparse warnings that got noticed when the PPC-dev
> patchwork was checking another patch (see the link below):
>
> init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not
> declared. Should it be static?
>
, Kevin Hilman , Pali Rohar
, heiner kallweit , ulf hansson
, Neil Armstrong , Lorenzo
Pieralisi , Al Cooper , linux-tegra
, Jiri Slaby , "moderated
list:ARM/ASPEED MACHINE SUPPORT" , Rob Herring
, Florian Fainelli , Mateusz Holenko
, Alexander Shiyan , kevin hilman
, Broadcom internal
On 7/1/22 12:47, Tyrel Datwyler wrote:
> On 7/1/22 06:17, Liang He wrote:
>> In pci_add_device_node_info(), we should use of_node_put() for the
>> reference 'parent' returned by of_get_parent() to keep refcount
>> balance.
>>
>> Fixes: cca87d303c85 ("powerpc/pci: Refactor pci_dn")
>>
At 2022-07-02 03:47:22, "Tyrel Datwyler" wrote:
>On 7/1/22 06:17, Liang He wrote:
>> In pci_add_device_node_info(), we should use of_node_put() for the
>> reference 'parent' returned by of_get_parent() to keep refcount
>> balance.
>>
>> Fixes: cca87d303c85 ("powerpc/pci: Refactor pci_dn")
>>
On 7/1/22 06:17, Liang He wrote:
> In pci_add_device_node_info(), we should use of_node_put() for the
> reference 'parent' returned by of_get_parent() to keep refcount
> balance.
>
> Fixes: cca87d303c85 ("powerpc/pci: Refactor pci_dn")
> Co-authored-by: Miaoqian Lin
> Signed-off-by: Liang He
>
In cell_iommu_init_disabled(), we should hold the reference returned
by of_find_node_by_name() and use it to call of_node_put() for reference
balance.
Signed-off-by: Liang He
---
changelog:
v2: (1) split v1's two files in to two commits
(2) using 'check-then-put' coding style
v1: hold
There are several bugs as following:
(1) In cbe_get_be_node(), we should hold the reference returned by
of_find_xxx and of_get_xxx OF APIs and use it to call of_node_put
(2) In cbe_fill_regs_map(), we should same as above
(3) In cbe_regs_init(), during the iteration of
for_each_node_by_type() will automatically increase and decrease
the refcount during the iteration. However, there is a reference
escaped into global 'fsl_pci_primary' and we need to handle it.
Signed-off-by: Liang He
---
arch/powerpc/platforms/85xx/ge_imp3a.c | 6 --
1 file changed, 4
In ppc47x_init_irq(), we need to call of_node_put() when there is
a break during the iteration of for_each_node_with_property() which
will automatically increase and decrease the refcount.
Signed-off-by: Liang He
---
arch/powerpc/platforms/44x/ppc476.c | 1 +
1 file changed, 1 insertion(+)
In pci_add_device_node_info(), we should use of_node_put() for the
reference 'parent' returned by of_get_parent() to keep refcount
balance.
Fixes: cca87d303c85 ("powerpc/pci: Refactor pci_dn")
Co-authored-by: Miaoqian Lin
Signed-off-by: Liang He
---
arch/powerpc/kernel/pci_dn.c | 1 +
1 file
We should call of_node_put() for the reference 'tsi' returned by
of_get_parent() which will increase the refcount.
Signed-off-by: Liang He
---
Inserting of_node_put() in the 'if' condition is learned from Orsan:
> Thanks for the report. I've already submitted a follow up patch:
> https://patchwork.kernel.org/project/linux-crypto/patch/20220630140506.904-1-ig...@cloudflare.com/
Thanks, the fix resolves the issue for me.
- Sachin
Hi Segher, your help might be welcome,
Le 01/07/2022 à 08:56, Sathvika Vasireddy a écrit :
> Hi Chen,
>
> Thanks for pitching in and providing your inputs :-)
>
> On 01/07/22 07:43, Chen Zhongjin wrote:
>> Hi everyone,
>>
>> Hope I'm not too late for this discussion.
>>
>> I'm not familiar with
Le 01/07/2022 à 11:41, Marco Elver a écrit :
> On Fri, 1 Jul 2022 at 10:54, Christophe Leroy
> wrote:
>>
>> Hi Marco,
>>
>> Le 28/06/2022 à 11:58, Marco Elver a écrit :
>>> Internal data structures (cpu_bps, task_bps) of powerpc's hw_breakpoint
>>> implementation have relied on nr_bp_mutex
Operators should be separated by spaces in tce_buildmulti_pSeriesLP
Signed-off-by: Deming Wang
---
arch/powerpc/platforms/pseries/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/iommu.c
b/arch/powerpc/platforms/pseries/iommu.c
index
There is a typo ('wont') in comments.
Fix it.
Signed-off-by: Zhang Jiaming
---
arch/powerpc/platforms/85xx/sgy_cts1000.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/85xx/sgy_cts1000.c
b/arch/powerpc/platforms/85xx/sgy_cts1000.c
index
We should avoid use the return value directly after call
iommu_pseries_alloc_group. Because it_may return a null.
Signed-off-by: Deming Wang
---
arch/powerpc/platforms/pseries/iommu.c | 12
1 file changed, 12 insertions(+)
diff --git a/arch/powerpc/platforms/pseries/iommu.c
Hi Marco,
Le 28/06/2022 à 11:58, Marco Elver a écrit :
> Internal data structures (cpu_bps, task_bps) of powerpc's hw_breakpoint
> implementation have relied on nr_bp_mutex serializing access to them.
>
> Before overhauling synchronization of kernel/events/hw_breakpoint.c,
> introduce 2
On POWER8 systems that don't have ibm,power-rng available, a guest that
ignores the KVM_CAP_PPC_HWRNG flag and calls H_RANDOM anyway will
dereference a NULL pointer. And on machines with darn instead of
ibm,power-rng, H_RANDOM won't work at all.
This patch kills two birds with one stone, by
The preferred nomenclature is pnv_, not powernv_, but rng.c used
powernv_ for some reason, which isn't consistent with the rest. A recent
commit added a few pnv_ functions to rng.c, making the file a bit of a
mishmash. This commit just replaces the rest of them.
Cc: Michael Ellerman
Fixes:
These are two small cleanups for -next.
This is meant to be atop
https://lore.kernel.org/all/20220630121654.1939181-1-ja...@zx2c4.com/
which is expected to land first.
v4 fixes up an inversion of thr DR flag.
Jason A. Donenfeld (2):
powerpc/powernv: rename remaining rng powernv_ functions to
On Fri, Jul 01, 2022 at 07:24:42AM +, Christophe Leroy wrote:
> When DR is set you are in virtual mode
> When DR is unset you are in real mode
>
> Extract from documentation:
>
> DR Data address translation
> 0 Data address translation is disabled.
> 1 Data address translation is enabled.
On Thu, Jun 30, 2022 at 11:10:13AM +1000, Andrew Donnellan wrote:
> On Wed, 2022-06-29 at 22:15 +1000, Michael Ellerman wrote:
> > On Tue, 21 Jun 2022 20:53:21 +0800, Jiang Jian wrote:
> > > there is an unexpected word "the" in the comments that need to be
> > > dropped
> > >
> > > file:
Le 30/06/2022 à 18:46, Jason A. Donenfeld a écrit :
> Hi Sachin, Michael,
>
> On Thu, Jun 30, 2022 at 6:12 PM Sachin Sant wrote:
>>> On 30-Jun-2022, at 7:31 PM, Jason A. Donenfeld wrote:
>>>
>>> These are two small cleanups for -next.
>>>
>>> I'm sending this v3 because very likely
>>>
Hi Chen,
Thanks for pitching in and providing your inputs :-)
On 01/07/22 07:43, Chen Zhongjin wrote:
Hi everyone,
Hope I'm not too late for this discussion.
I'm not familiar with ppc so it spent me some time to reproduce this.
But at last I didn't make it.
What I did:
1 checkout to
__set_pte_at() handles 3 main cases with #ifdefs plus the 'percpu'
subcase which leads to code duplication.
Rewrite the function using IS_ENABLED() to minimise the total number
of cases and remove duplicated code.
Signed-off-by: Christophe Leroy
---
arch/powerpc/include/asm/book3s/32/pgtable.h
Since commit 4291d085b0b0 ("powerpc/32s: Make pte_update() non
atomic on 603 core"), pte_update() has been using
mmu_has_feature(MMU_FTR_HPTE_TABLE) to avoid a useless atomic
operation on 603 cores.
When kasan_early_init() sets up the early zero shadow, it uses
__set_pte_at(). On book3s/32,
30 matches
Mail list logo
