Yury Norov writes:
> On Mon, Jul 25, 2022 at 10:22:13PM +1000, Michael Ellerman wrote:
>> Michael Ellerman writes:
>> > Yury Norov writes:
>> >> archrandom.h includes to refer ppc_md. This causes
>> >> circular header dependency, if generic nodemask.h includes random.h:
>> >>
>> >> In file
Hi all,
Today's linux-next merge of the amdgpu tree got a conflict in:
drivers/gpu/drm/amd/display/Kconfig
between commits:
c653c591789b ("drm/amdgpu: Re-enable DCN for 64-bit powerpc")
from the powerpc-fixes tree and commit:
3876a8b5e241 ("drm/amd/display: Enable building new display
The AER status of the device that reported the error rather than
the first downstream port is cleared after commit 7d7cbeaba5b7
("PCI/ERR: Clear status of the reporting device"). So "a bridge
may not exist" which commit aa344bc8b727 ("PCI/ERR: Clear AER
status only when we control AER") referring
From: Zhouyi Zhou
In ppc 64, invoke jump_label_init in setup_feature_keys is too late
because static key will be used in subroutine of parse_early_param
which is again subroutine of early_init_devtree.
So we invoke jump_label_init just before parse_early_param in
early_init_devtree.
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
topic/ppc-kvm
branch HEAD: 4008d54e29531813e800580f8309133b9b14a921 powerpc/kvm: Remove
comment related to moving PMU code to perf subsystem
elapsed time: 741m
configs tested: 91
configs skipped: 110
The following
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
next
branch HEAD: 95288b023d5fdd34f1e7f4a9e2826359f2d4659e powerpc: dts:
turris1x.dts: Add CPLD reboot node
elapsed time: 734m
configs tested: 57
configs skipped: 2
The following configs have been built
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
merge
branch HEAD: e1b85275d37739ed5d9be41eab1116b759f83391 Automatic merge of
'korg/next' into merge (2022-07-25 22:54)
elapsed time: 722m
configs tested: 63
configs skipped: 2
The following configs have been
Linus Torvalds writes:
> On Mon, Jul 25, 2022 at 5:39 AM Michael Ellerman wrote:
>>
>> Further digging shows that the build failures only occur with compilers
>> that default to 64-bit long double.
>
> Where the heck do we have 'long double' things anywhere in the kernel?
There's one or two
Guenter Roeck writes:
> On 7/25/22 13:42, Segher Boessenkool wrote:
>> On Mon, Jul 25, 2022 at 02:34:08PM -0500, Timothy Pearson wrote:
> Further digging shows that the build failures only occur with compilers
> that default to 64-bit long double.
Where the heck do we have 'long
Hi!
On Mon, Jul 25, 2022 at 03:40:40PM -0700, Guenter Roeck wrote:
> On 7/25/22 13:42, Segher Boessenkool wrote:
> >>What I'm wondering is if the compiler is getting confused between
> >>standard and long doubles when they are both the same bit length...
> >
> >The compiler emits the same code
On Mon, Jul 25, 2022 at 11:39:39PM +0200, Andy Shevchenko wrote:
> On Mon, Jul 25, 2022 at 6:19 PM Yury Norov wrote:
> > On Mon, Jul 25, 2022 at 09:28:12AM +0200, Andy Shevchenko wrote:
> > > On Sun, Jul 24, 2022 at 12:19 AM Yury Norov wrote:
>
> ...
>
> > > > EXPORT_SYMBOL_GPL(pm_power_off);
On 7/25/22 13:42, Segher Boessenkool wrote:
On Mon, Jul 25, 2022 at 02:34:08PM -0500, Timothy Pearson wrote:
Further digging shows that the build failures only occur with compilers
that default to 64-bit long double.
Where the heck do we have 'long double' things anywhere in the kernel?
I
On Mon, Jul 25, 2022 at 10:10:09PM +0200, Pali Rohár wrote:
> On Monday 25 July 2022 16:20:49 Christophe Leroy wrote:
> Now I did again clean test with same Debian 10 cross compiler.
>
> $ git clone
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git && cd linux
> $ git checkout
On Wed, Jun 08, 2022 at 04:27:27PM +0200, Peter Zijlstra wrote:
> Commit c227233ad64c ("intel_idle: enable interrupts before C1 on
> Xeons") wrecked intel_idle in two ways:
>
> - must not have tracing in idle functions
> - must return with IRQs disabled
>
> Additionally, it added a branch for
After commit 7d7cbeaba5b7 ("PCI/ERR: Clear status of the reporting
device"), the AER status of the device that reported the error
rather than the first downstream port is cleared. So the problem
in commit aa344bc8b727 ("PCI/ERR: Clear AER status only when we
control AER") is no longer existent,
On Mon, Jul 25, 2022 at 6:19 PM Yury Norov wrote:
> On Mon, Jul 25, 2022 at 09:28:12AM +0200, Andy Shevchenko wrote:
> > On Sun, Jul 24, 2022 at 12:19 AM Yury Norov wrote:
...
> > > EXPORT_SYMBOL_GPL(pm_power_off);
> >
> > ^^^ (Note this and read below)
> >
> > ...
> >
> > >
On Mon, Jul 25, 2022 at 11:11:41AM -0500, Scott Cheloha wrote:
> On Wed, Jul 13, 2022 at 01:50:14PM -0700, Guenter Roeck wrote:
> > On 7/13/22 13:23, Scott Cheloha wrote:
> > > PAPR v2.12 defines a new hypercall, H_WATCHDOG. The hypercall permits
> > > guest control of one or more virtual
On 25/07/2022 20:39, Andrew Morton wrote:
On Thu, 21 Jul 2022 20:55:09 +0100 Ben Dooks wrote:
The setup_profiling_timer() is mostly un-implemented by many
architectures. In many places it isn't guarded by CONFIG_PROFILE
which is needed for it to be used. Make it a weak symbol in
On Mon, 25 Jul 2022, Geert Uytterhoeven wrote:
JFYI, when comparing v5.19-rc8[1] to v5.19-rc7[3], the summaries are:
- build errors: +1/-5
+ /kisskb/src/include/ufs/ufshci.h: error: initializer element is not constant:
=> 245:36
v5.19-rc8/powerpc-gcc5/ppc64_book3e_allmodconfig
On Mon, Jul 25, 2022 at 02:34:08PM -0500, Timothy Pearson wrote:
> >> Further digging shows that the build failures only occur with compilers
> >> that default to 64-bit long double.
> >
> > Where the heck do we have 'long double' things anywhere in the kernel?
> >
> > I tried to grep for it,
Hi Jakub,
On 7/25/22 4:09 PM, Jakub Kicinski wrote:
> On Mon, 25 Jul 2022 11:10:14 -0400 Sean Anderson wrote:
>> This series contains several cleanup patches for dpaa/fman. While they
>> are intended to prepare for a phylink conversion, they stand on their
>> own. This series was originally
On Monday 25 July 2022 16:20:49 Christophe Leroy wrote:
> Le 25/07/2022 à 14:52, Pali Rohár a écrit :
> > On Monday 25 July 2022 18:20:01 Michael Ellerman wrote:
> >> Pali Rohár writes:
> >>> On Saturday 23 July 2022 14:42:22 Christophe Leroy wrote:
> Le 22/07/2022 à 11:09, Pali Rohár a
On Mon, 25 Jul 2022 11:10:14 -0400 Sean Anderson wrote:
> This series contains several cleanup patches for dpaa/fman. While they
> are intended to prepare for a phylink conversion, they stand on their
> own. This series was originally submitted as part of [1].
- Original Message -
> From: "Linus Torvalds"
> To: "Michael Ellerman"
> Cc: "linuxppc-dev" , "Alex Deucher"
> , "amd-gfx"
> , li...@roeck-us.net, "linux-kernel"
> , "Dan Horák"
> , "Timothy Pearson"
> Sent: Monday, July 25, 2022 2:19:57 PM
> Subject: Re: [PATCH] drm/amdgpu:
On Thu, 21 Jul 2022 20:55:09 +0100 Ben Dooks wrote:
> The setup_profiling_timer() is mostly un-implemented by many
> architectures. In many places it isn't guarded by CONFIG_PROFILE
> which is needed for it to be used. Make it a weak symbol in
> kernel/profile.c and remove the 'return -EINVAL'
On Mon, Jul 25, 2022 at 5:39 AM Michael Ellerman wrote:
>
> Further digging shows that the build failures only occur with compilers
> that default to 64-bit long double.
Where the heck do we have 'long double' things anywhere in the kernel?
I tried to grep for it, and failed miserably. I found
On 7/25/22 9:01 AM, Zhuo Chen wrote:
> After commit 7d7cbeaba5b7 ("PCI/ERR: Clear status of the reporting
> device"), the AER status of the device that reported the error
> rather than the first downstream port is cleared. So the problem
> in commit aa344bc8b727 ("PCI/ERR: Clear AER status only
[Public]
> -Original Message-
> From: amd-gfx On Behalf Of
> Michael Ellerman
> Sent: Monday, July 25, 2022 8:39 AM
> To: linuxppc-dev@lists.ozlabs.org
> Cc: d...@danny.cz; linux-ker...@vger.kernel.org; amd-
> g...@lists.freedesktop.org; tpear...@raptorengineering.com;
>
On Mon, Jul 25, 2022 at 10:22:13PM +1000, Michael Ellerman wrote:
> Michael Ellerman writes:
> > Yury Norov writes:
> >> archrandom.h includes to refer ppc_md. This causes
> >> circular header dependency, if generic nodemask.h includes random.h:
> >>
> >> In file included from
Le 25/07/2022 à 14:52, Pali Rohár a écrit :
> On Monday 25 July 2022 18:20:01 Michael Ellerman wrote:
>> Pali Rohár writes:
>>> On Saturday 23 July 2022 14:42:22 Christophe Leroy wrote:
Le 22/07/2022 à 11:09, Pali Rohár a écrit :
> Trying to boot mainline Linux kernel v5.15+, including
On 7/20/22 16:27, Thomas Zimmermann wrote:
> Move some of simpledrm's functionality into a helper library. Other
> drivers for firmware-provided framebuffers will also need functions
> to handle fixed modes and color formats, or update the back buffer.
>
> Signed-off-by: Thomas Zimmermann
> ---
On Mon, Jul 25, 2022 at 09:28:12AM +0200, Andy Shevchenko wrote:
> On Sun, Jul 24, 2022 at 12:19 AM Yury Norov wrote:
> >
> > archrandom.h includes to refer ppc_md. This causes
> > circular header dependency, if generic nodemask.h includes random.h:
> >
> > In file included from
On Mon, Jul 25, 2022 at 01:27:52PM +1000, Michael Ellerman wrote:
> Segher Boessenkool writes:
> > On Sat, Jul 23, 2022 at 03:34:05PM +0200, Michal Suchánek wrote:
> >> Hello,
> >>
> >> On Sat, Jul 23, 2022 at 05:24:36PM +0800, Jason Wang wrote:
> >> > Initialise global and static variable to 0
On Wed, Jul 13, 2022 at 01:50:14PM -0700, Guenter Roeck wrote:
> On 7/13/22 13:23, Scott Cheloha wrote:
> > PAPR v2.12 defines a new hypercall, H_WATCHDOG. The hypercall permits
> > guest control of one or more virtual watchdog timers. The timers have
> > millisecond granularity. The guest is
On 7/20/22 16:27, Thomas Zimmermann wrote:
> Replace the simple-KMS helpers with the regular atomic helpers. The
> regular helpers are better architectured and therefore allow for easier
> code sharing among drivers. No functional changes.
>
Acked-by: Javier Martinez Canillas
But I've a
On Mon, 25 Jul 2022 22:39:18 +1000
Michael Ellerman wrote:
> Commit d11219ad53dc ("amdgpu: disable powerpc support for the newer
> display engine") disabled the DCN driver for all of powerpc due to
> unresolved build failures with some compilers.
>
> Further digging shows that the build
Hello Geert,
On 7/21/22 16:46, Geert Uytterhoeven wrote:
> Hi Thomas,
>
> On Wed, Jul 20, 2022 at 4:27 PM Thomas Zimmermann wrote:
>> Compute the framebuffer's scanline stride length if not given by
>> the simplefb data.
>>
>> Signed-off-by: Thomas Zimmermann
>
> Thanks for your patch!
>
>>
This moves mac-specific initialization to mac-specific files. This will
make it easier to work with individual macs. It will also make it easier
to refactor the initialization to simplify the control flow. No
functional change intended.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
---
Instead of setting the queue depth once during probe, adjust it on the
fly whenever we configure the link. This is a bit unusal, since usually
the DPAA driver calls into the FMAN driver, but here we do the opposite.
We need to add a netdev to struct mac_device for this, but it will soon
live in
This adds a function to update a CGR with new parameters. qman_create_cgr
can almost be used for this (with flags=0), but it's not suitable because
it also registers the callback function. The _safe variant was modeled off
of qman_cgr_delete_safe. However, we handle multiple arguments and a return
This breaks out/combines get_affine_portal and the cgr sanity check in
preparation for the next commit. No functional change intended.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
---
(no changes since v2)
Changes in v2:
- New
drivers/soc/fsl/qbman/qman.c | 29
There are several references to mac_dev in dpaa_netdev_init. Make things a
bit more concise by adding a local variable for it.
Signed-off-by: Sean Anderson
---
Changes in v4:
- Use mac_dev for calling change_addr
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 9 +
1 file changed, 5
When disabling, there is nothing we can do about errors. In fact, the
only error which can occur is misuse of the API. Just warn in the mac
driver instead.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
---
(no changes since v1)
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 5
This removes the _return label, since something like
err = -EFOO;
goto _return;
can be replaced by the briefer
return -EFOO;
Additionally, this skips going to _return_of_node_put when dev_node has
already been put (preventing a double put).
Signed-off-by: Sean Anderson
Instead of using a void pointer for mac_dev, specify its type
explicitly.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
---
(no changes since v2)
Changes in v2:
- New
drivers/net/ethernet/freescale/fman/fman_dtsec.c | 2 +-
drivers/net/ethernet/freescale/fman/fman_mac.h | 5 +++--
Some params are already present in mac_dev. Use them directly instead of
passing them through params.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
---
(no changes since v1)
.../net/ethernet/freescale/fman/fman_dtsec.c| 16 +++-
Instead of having the mac init functions call back into the fman core to
get their params, just pass them directly to the init functions.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
---
(no changes since v1)
.../net/ethernet/freescale/fman/fman_dtsec.c | 10 ++
We don't need to remap the base address from the resource twice (once in
mac_probe() and again in set_fman_mac_params()). We still need the
resource to get the end address, but we can use a single function call
to get both at once.
While we're at it, use platform_get_mem_or_io and
This member was used to pass the phy node between mac_probe and the
mac-specific initialization function. But now that the phy node is
gotten in the initialization function, this parameter does not serve a
purpose. Remove it, and do the grabbing of the node/grabbing of the phy
in the same place.
These methods are no longer accessed outside of the driver file, so mark
them as static.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
---
(no changes since v1)
.../net/ethernet/freescale/fman/fman_dtsec.c | 48 ++-
.../net/ethernet/freescale/fman/fman_memac.c | 45
This option is present in params, so use it instead of the fman private
version.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
---
(no changes since v1)
drivers/net/ethernet/freescale/fman/mac.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
This converts the MAC portion of the FMan MAC bindings to yaml.
Signed-off-by: Sean Anderson
Reviewed-by: Rob Herring
---
(no changes since v3)
Changes in v3:
- Incorperate some minor changes into the first FMan binding commit
Changes in v2:
- New
.../bindings/net/fsl,fman-dtsec.yaml
There are several small functions which were only necessary because the
initialization functions didn't have access to the mac private data. Now
that they do, just do things directly.
Signed-off-by: Sean Anderson
---
Changes in v4:
- weer -> were
.../net/ethernet/freescale/fman/fman_dtsec.c
In preparation for moving each of the initialization functions to their
own file, export some common functions so they can be re-used. This adds
an fman prefix to set_multi to make it a bit less genericly-named.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
---
(no changes since v1)
memac is the only mac which parses fixed links. Move the
parsing/configuring to its initialization function.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
---
(no changes since v1)
drivers/net/ethernet/freescale/fman/mac.c | 93 +++
1 file changed, 46
Move the reference to our device to mac_device. This way, macs can use
it in their log messages.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
---
(no changes since v2)
Changes in v2:
- Remove some unused variables
drivers/net/ethernet/freescale/fman/mac.c | 31
Instead of re-matching the compatible string in order to determine the init
function, just store it in the match data. The separate setup functions
aren't needed anymore. Merge their content into init as well. To ensure
everything compiles correctly, we move them to the bottom of the file.
This moves the reading of the PCS property out of the generic probe and
into the mac-specific initialization function. This reduces the
mac-specific jobs done in the top-level probe function.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
---
(no changes since v1)
There are two ways that GRS can be set: graceful_stop and dtsec_isr. It
is cleared by graceful_start. If it is already set before calling
graceful_stop, then that means that dtsec_isr set it. In that case, we
will not set GRS nor will we clear it (which seems like a bug?). For GTS
the logic is
All macs use the same start/stop functions. The actual mac-specific code
lives in enable/disable. Move these functions to an appropriate struct,
and inline the phy enable/disable calls to the caller of start/stop.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
Tested-by: Camelia Groza
This converts the license text of files in the fman directory to use
SPDX license identifiers instead.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
Tested-by: Camelia Groza
---
(no changes since v1)
drivers/net/ethernet/freescale/fman/fman.c| 31 ++
mac_priv_s->enable() and ->disable() are always called with
a comm_mode of COMM_MODE_RX_AND_TX. Remove this parameter, and refactor
the macs appropriately.
Signed-off-by: Sean Anderson
Acked-by: Camelia Groza
Tested-by: Camelia Groza
---
(no changes since v1)
This series contains several cleanup patches for dpaa/fman. While they
are intended to prepare for a phylink conversion, they stand on their
own. This series was originally submitted as part of [1].
[1]
https://lore.kernel.org/netdev/20220715215954.1449214-1-sean.ander...@seco.com
Changes in
On 7/20/22 16:27, Thomas Zimmermann wrote:
> Replace the remaining uses of the field pdev by upcasts from the Linux
> device and remove the field.
>
> Signed-off-by: Thomas Zimmermann
Much better indeed.
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Linux
Hello Thomas,
On 7/20/22 16:27, Thomas Zimmermann wrote:
> Inline the helpers for initializing the hardware FB, the memory
> management and the modesetting into the device-creation function.
> No functional changes.
>
Could you please elaborate in the commit message why this change is
desirable?
On 7/20/22 16:27, Thomas Zimmermann wrote:
> Remove the unused mem field from struct simpledrm_device.
>
> Signed-off-by: Thomas Zimmermann
> ---
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
On Monday 25 July 2022 18:20:01 Michael Ellerman wrote:
> Pali Rohár writes:
> > On Saturday 23 July 2022 14:42:22 Christophe Leroy wrote:
> >> Le 22/07/2022 à 11:09, Pali Rohár a écrit :
> >> > Trying to boot mainline Linux kernel v5.15+, including current version
> >> > from master branch, on
Commit d11219ad53dc ("amdgpu: disable powerpc support for the newer
display engine") disabled the DCN driver for all of powerpc due to
unresolved build failures with some compilers.
Further digging shows that the build failures only occur with compilers
that default to 64-bit long double.
Both
Le 13/07/2022 à 22:17, Randy Dunlap a écrit :
> Hi Laurent,
>
> On 7/13/22 08:47, Laurent Dufour wrote:
>> diff --git a/Documentation/admin-guide/sysctl/kernel.rst
>> b/Documentation/admin-guide/sysctl/kernel.rst
>> index ddccd1077462..d73faa619c15 100644
>> ---
Dan Horák writes:
> On Fri, 22 Jul 2022 22:32:06 +1000
> Michael Ellerman wrote:
>> Dan Horák writes:
>> > Commit d11219ad53dc disabled the DCN driver for all platforms that
>> > define PPC64 due long build issues during "make allmodconfig" using
>> > cross-compilation. Cross-compilation
Bjorn Helgaas writes:
> On Wed, Jul 06, 2022 at 12:10:43PM +0200, Pali Rohár wrote:
>> By default old pre-3.0 Freescale PCIe controllers reports invalid PCI Class
>> Code 0x0b20 for PCIe Root Port. It can be seen by lspci -b output on P2020
>> board which has this pre-3.0 controller:
>>
>> $
Yury Norov writes:
> archrandom.h includes to refer ppc_md. This causes
> circular header dependency, if generic nodemask.h includes random.h:
>
> In file included from include/linux/cred.h:16,
> from include/linux/seq_file.h:13,
> from
Michael Ellerman writes:
> Yury Norov writes:
>> archrandom.h includes to refer ppc_md. This causes
>> circular header dependency, if generic nodemask.h includes random.h:
>>
>> In file included from include/linux/cred.h:16,
>> from include/linux/seq_file.h:13,
>>
On Tue, Jul 19, 2022 at 03:02:07PM +0200, Jason A. Donenfeld wrote:
> The archrandom interface was originally designed for x86, which supplies
> RDRAND/RDSEED for receiving random words into registers, resulting in
> one function to generate an int and another to generate a long. However,
> other
Julia Lawall writes:
> On Mon, 25 Jul 2022, Michael Ellerman wrote:
>> wangjianli writes:
>> > diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c
>> > b/arch/powerpc/kvm/book3s_64_mmu_hv.c
>> > index 514fd45c1994..73c6db20cd8a 100644
>> > --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
>> > +++
...
> More directly, the reason we don't want to error is because the use case
> has fallbacks meant to handle errors. The cascade looks like this
> (quoting from the other email):
>
> unsigned long array[whatever];
> for (i = 0; i < ARRAY_SIZE(array);) {
> longs =
On Tue, Jul 19, 2022 at 03:02:07PM +0200, Jason A. Donenfeld wrote:
> Since callers need to check this return value and loop anyway, each arch
> implementation does not bother implementing its own loop to try again to
> fill the maximum number of longs. Additionally, all existing callers
> pass in
On Mon, Jul 25, 2022 at 3:55 PM Michael Ellerman wrote:
>
> zhouzho...@gmail.com writes:
> > From: Zhouyi Zhou
> >
> > In ppc 64, invoke jump_label_init in setup_feature_keys is too late
> > because static key will be used in subroutine of early_init_devtree.
> >
> > So we can invoke
Yury Norov writes:
> archrandom.h includes to refer ppc_md. This causes
> circular header dependency, if generic nodemask.h includes random.h:
>
> In file included from include/linux/cred.h:16,
> from include/linux/seq_file.h:13,
> from
Pali Rohár writes:
> On Saturday 23 July 2022 14:42:22 Christophe Leroy wrote:
>> Le 22/07/2022 à 11:09, Pali Rohár a écrit :
>> > Trying to boot mainline Linux kernel v5.15+, including current version
>> > from master branch, on Freescale P2020 does not work. Kernel does not
>> > print anything
zhouzho...@gmail.com writes:
> From: Zhouyi Zhou
>
> In ppc 64, invoke jump_label_init in setup_feature_keys is too late
> because static key will be used in subroutine of early_init_devtree.
>
> So we can invoke jump_label_init earlier in early_setup.
> We can not move setup_feature_keys
On Sun, Jul 24, 2022 at 12:19 AM Yury Norov wrote:
>
> archrandom.h includes to refer ppc_md. This causes
> circular header dependency, if generic nodemask.h includes random.h:
>
> In file included from include/linux/cred.h:16,
> from include/linux/seq_file.h:13,
>
On Mon, 25 Jul 2022, Michael Ellerman wrote:
> wangjianli writes:
> > Signed-off-by: wangjianli
> > ---
> > arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c
> >
wangjianli writes:
> Signed-off-by: wangjianli
> ---
> arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c
> b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> index 514fd45c1994..73c6db20cd8a 100644
> ---
Zero GPRS r0, r2-r11, r14-r31, on entry into the kernel for all
other interrupt sources to limit influence of user-space values
in potential speculation gadgets. The remaining gprs are overwritten by
entry macros to interrupt handlers, irrespective of whether or not a
given handler consumes these
Interrupt handlers on 64s systems will often need to save register state
from the interrupted process to make space for loading special purpose
registers or for internal state.
Fix a comment documenting a common code path macro in the beginning of
interrupt handlers where r10 is saved to the PACA
Use the convenience macros for saving/clearing/restoring gprs in keeping
with syscall calling conventions. The plural variants of these macros
can store a range of registers for concision.
This works well when the save-to-stack logic is simple (a gpr is saved
to its corresponding offset in the
Clear user state in gprs (assign to zero) to reduce the influence of user
registers on speculation within kernel syscall handlers. Clears occur
at the very beginning of the sc and scv 0 interrupt handlers, with
restores occurring following the execution of the syscall handler.
One function of
Implement syscall wrapper as per s390, x86, arm64. When enabled
cause handlers to accept parameters from a stack frame rather than
from user scratch register state. This allows for user registers to be
safely cleared in order to reduce caller influence on speculation
within syscall routine. The
Macros for restoring and saving registers to and from the stack exist.
Provide macros with the same interface for clearing a range of gprs by
setting each register's value in that range to zero.
The resulting macros are called NULLIFY_GPRS and NULLIFY_NVGPRS, keeping
with the naming of the
Cause syscall handlers to be typed as follows when called indirectly
throughout the kernel.
typedef long (*syscall_fn)(unsigned long, unsigned long, unsigned long,
unsigned long, unsigned long, unsigned long);
Since both 32 and 64-bit abis allow for at least the first
The table of syscall handlers and registered compatibility syscall
handlers has in past been produced using assembly, with function
references resolved at link time. This moves link-time errors to
compile-time, by rewriting systbl.S in C, and including the
linux/syscalls.h, linux/compat.h and
Forward declare all syscall handler prototypes where a generic prototype
is not provided in either linux/syscalls.h or linux/compat.h in
asm/syscalls.h. This is required for compile-time type-checking for
syscall handlers, which is implemented later in this series.
32-bit compatibility syscall
The powerpc fallocate compat syscall handler is identical to the
generic implementation provided by commit 59c10c52f573f ("riscv:
compat: syscall: Add compat_sys_call_table implementation"), and as
such can be removed in favour of the generic implementation.
A future patch series will replace
Syscall #82 has been implemented for 32-bit platforms in a unique way on
powerpc systems. This hack will in effect guess whether the caller is
expecting new select semantics or old select semantics. It does so via a
guess, based off the first parameter. In new select, this parameter
represents the
Syscall handlers should not be invoked internally by their symbol names,
as these symbols defined by the architecture-defined SYSCALL_DEFINE
macro. Move the compatibility syscall definition for mmap2 to
syscalls.c, so that all mmap implementations can share an inline helper
function, as is done
Syscall handlers should not be invoked internally by their symbol names,
as these symbols defined by the architecture-defined SYSCALL_DEFINE
macro. Fortunately, in the case of ppc64_personality, its call to
sys_personality can be replaced with an invocation to the
equivalent ksys_personality
Arch-specific implementations of syscall handlers are currently used
over generic implementations for the following reasons:
1. Semantics unique to powerpc
2. Compatibility syscalls require 'argument padding' to comply with
64-bit argument convention in ELF32 abi.
3. Parameter types or
V1 available here:
Link: https://lore.kernel.org/all/20220601054850.250287-1-rmcl...@linux.ibm.com/
Implement a syscall wrapper, causing arguments to handlers to be passed
via a struct pt_regs on the stack. The syscall wrapper is implemented
for all platforms other than the Cell processor, from
99 matches
Mail list logo
