Re: [PATCH] KVM: fix repeated words in comments

On Wed, Aug 31, 2022 at 08:44:54AM +0800, Jilin Yuan wrote: > Delete the redundant word 'that'. Nack, having two "that"s in a row is intentional. It's "make sure that" (i.e. bring about the situation described in what follows) "that many HPTEs" (i.e. the number of HPTEs referenced previously)

Re: [PATCH v2 02/16] powerpc: override __ALIGN() and __ALIGN_STR() macros

On Mon Aug 29, 2022 at 3:52 PM AEST, Sathvika Vasireddy wrote: > Powerpc instructions must be word-aligned. Currently, > there is an alignment of 16 bytes (by default), and it is > much more than what is required for powerpc (4 bytes). > > The default expansion of __ALIGN() macro is: > #define

[PATCH] powerpc/xive: fix repeated words in comments

Delete the redundant word 'set'. Signed-off-by: Jilin Yuan --- arch/powerpc/sysdev/xive/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c index 61b9f98dfd4a..a289cb97c1d7 100644 ---

[PATCH] powerpc/mobility: fix repeated words in comments

Delete the redundant word 'the'. Signed-off-by: Jilin Yuan --- arch/powerpc/platforms/pseries/mobility.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c index 3d36a8955eaf..c92c78332303

[PATCH] powerpc/vas: fix repeated words in comments

Delete the redundant word 'the'. Signed-off-by: Jilin Yuan --- arch/powerpc/platforms/book3s/vas-api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/book3s/vas-api.c b/arch/powerpc/platforms/book3s/vas-api.c index c0799fb26b6d..40f5ae5e1238 100644

[PATCH] KVM: fix repeated words in comments

Delete the redundant word 'that'. Signed-off-by: Jilin Yuan --- arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c index e9744b41a226..8e4b42b5f37f 100644 ---

[PATCH v2 3/3] powerpc: dts: turris1x.dts: Set lower priority for CPLD syscon-reboot

Due to CPLD firmware bugs, set CPLD syscon-reboot priority level to 64 (between rstcr and watchdog) to ensure that rstcr's global-utilities reset method which is preferred stay as default one, and to ensure that CPLD syscon-reboot is more preferred than watchdog reset method. Fixes: 0531a4abd1c6

[PATCH v2 2/3] power: reset: syscon-reboot: Add support for specifying priority

Read new optional device tree property priority for specifying priority level of reset handler. Default value is 192 as before. Signed-off-by: Pali Rohár --- drivers/power/reset/syscon-reboot.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH v2 1/3] dt-bindings: reset: syscon-reboot: Add priority property

This new optional priority property allows to specify custom priority level of reset device. Default level was always 192. Signed-off-by: Pali Rohár --- Changes in v2: * Change sint32 to int32 * Add default --- .../devicetree/bindings/power/reset/syscon-reboot.yaml | 5 + 1 file

[PATCH] powerpc: dts: turris1x.dts: Fix NOR partitions labels

Partition partition@2 contains generic kernel image and it does not have to be used only for rescue purposes. Partition partition@1c contains bootable rescue system and partition partition@34 contains factory image/data for restoring to NAND. So change partition labels to better fit

Re: [PATCH] net: move from strlcpy with unused retval to strscpy

> Unfortunately looks like patchwork was unable to ingest this change :( > Not sure why. vger rejected this mail because the header was too big. I updated my scripts to estimate that before sending out. > Would you mind splitting it into 3 chunks - wireless, ethernet, > everything else, and

Re: [RFC PATCH 2/2] fs/xattr: wire up syscalls

On Tue, Aug 30, 2022 at 05:28:38PM +0200, Christian Göttsche wrote: > Enable the new added extended attribute related syscalls. > > Signed-off-by: Christian Göttsche > --- Fwiw, I think a while ago it was pointed out that for most syscall additions you can just fold the hookup patch in. It

Re: [PATCH v4 0/8] phy: Add support for Lynx 10G SerDes

On 8/4/22 6:05 PM, Sean Anderson wrote: > This adds support for the Lynx 10G SerDes found on the QorIQ T-series > and Layerscape series. Due to limited time and hardware, only support > for the LS1046ARDB is added in this initial series. There is a sketch > for LS1088ARDB support, but it is

Re: [PATCH 2/2] powerpc: remove old code for binutils < 2.25

On Tue, Aug 30, 2022 at 02:13:20PM -0700, Nick Desaulniers wrote: > On Tue, Aug 30, 2022 at 12:10 PM Masahiro Yamada wrote: > > > > The minimum supported version of binutils has been raised to 2.25.1. > > Drop the old code. > > > > PPC is the last user of ld-ifversion. With all the callers

[PATCH] vdso: Improve cmd_vdso_check to check all dynamic relocations

The actual intention is that no dynamic relocation exists. However, some GNU ld ports produce unneeded R_*_NONE. (If a port is not care enough to determine the exact .rel[a].dyn size, the trailing zeros become R_*_NONE relocations. E.g. powerpc64le ld as of 2.38 has the issue with defconfig.)

[PATCH 2/2] powerpc: remove old code for binutils < 2.25

The minimum supported version of binutils has been raised to 2.25.1. Drop the old code. PPC is the last user of ld-ifversion. With all the callers removed, the macro definition in scripts/Makefile.compiler can go away. Signed-off-by: Masahiro Yamada --- arch/powerpc/Makefile | 21

[PATCH 1/2] Documentation: raise minimum supported version of binutils to 2.25.1

Binutils 2.23 was released in 2012. Almost 10 years old. We already require GCC 5.1, which was released in 2015. Bump the binutils version to 2.25.1, which was also released in 2015. Suggested-by: Nick Desaulniers Signed-off-by: Masahiro Yamada --- Documentation/process/changes.rst | 4 ++--

[PATCH v5] livepatch: Clear relocation targets on a module removal

From: Miroslav Benes Josh reported a bug: When the object to be patched is a module, and that module is rmmod'ed and reloaded, it fails to load with: module: x86/modules: Skipping invalid relocation target, existing value is nonzero for type 2, loc ba0302e9, val a03e293c

Re: [PATCH v2 1/5] serial: ucc_uart: Remove custom frame size calculation

On Tue, Aug 30, 2022 at 3:49 AM Ilpo Järvinen wrote: > > The number of bits can be calculated using tty_get_frame_size(), no > need for the driver to do it on its own. > > Also remove a comment on number of bits that doesn't match the code nor > the comment on ucc_uart_pram's rx_length ("minus 1"

Re: [PATCH] powerpc: clean up binutils version check

On Tue, Aug 30, 2022 at 7:44 PM Michael Ellerman wrote: > > Christophe Leroy writes: > > Le 27/08/2022 à 20:03, Masahiro Yamada a écrit : > >> On Sun, Aug 28, 2022 at 2:37 AM Christophe Leroy > >> wrote: > >>> Le 27/08/2022 à 18:40, Masahiro Yamada a écrit : > The checkbin in

[PATCH] powerpc/papr_scm: Ensure rc is always initialized in papr_scm_pmu_register()

Clang warns: arch/powerpc/platforms/pseries/papr_scm.c:492:6: warning: variable 'rc' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (!p->stat_buffer_len) ^~~ arch/powerpc/platforms/pseries/papr_scm.c:523:64: note:

Re: [PATCH v2 03/16] powerpc: Fix objtool unannotated intra-function call warnings

Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > objtool throws unannotated intra-function call warnings > in the following assembly files: > > arch/powerpc/kernel/vector.o: warning: objtool: .text+0x53c: unannotated > intra-function call > > arch/powerpc/kvm/book3s_hv_rmhandlers.o:

Re: [PATCH] powerpc: clean up binutils version check

Christophe Leroy writes: > Le 27/08/2022 à 20:03, Masahiro Yamada a écrit : >> On Sun, Aug 28, 2022 at 2:37 AM Christophe Leroy >> wrote: >>> Le 27/08/2022 à 18:40, Masahiro Yamada a écrit : The checkbin in arch/powerpc/Makefile errors out if ld <= 2.24. So, the requirement on PPC is

Re: [PATCH v2] powerpc: Fix irq_soft_mask_set() and irq_soft_mask_return() with sanitizer

Le 30/08/2022 à 11:01, Nicholas Piggin a écrit : > On Tue Aug 30, 2022 at 3:24 PM AEST, Christophe Leroy wrote: >>> This is still slightly concerning to me. Is there any guarantee that the >>> compiler would not use a different sequence for the address here? >>> >>> Maybe explicit r13 is

Re: [PATCH v2] powerpc: Fix irq_soft_mask_set() and irq_soft_mask_return() with sanitizer

On Tue Aug 30, 2022 at 3:24 PM AEST, Christophe Leroy wrote: > > > Le 30/08/2022 à 07:15, Nicholas Piggin a écrit : > > On Wed Aug 24, 2022 at 2:39 AM AEST, Christophe Leroy wrote: > >> In ppc, compiler based sanitizer will generate instrument instructions > >> around statement

[PATCH v2 1/5] serial: ucc_uart: Remove custom frame size calculation

The number of bits can be calculated using tty_get_frame_size(), no need for the driver to do it on its own. Also remove a comment on number of bits that doesn't match the code nor the comment on ucc_uart_pram's rx_length ("minus 1" part differs). That comment seems a verbatim copy of that in

Re: [PATCH] tty: move from strlcpy with unused retval to strscpy

On 18. 08. 22, 23:01, Wolfram Sang wrote: Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Reviewed-by: Jiri Slaby Link:

Re: [PATCH v2 00/10] crypto: Kconfig - simplify menus and help text

Le 29/08/2022 à 15:59, Elliott, Robert (Servers) a écrit : > > >> -Original Message- >> From: Christophe Leroy >> Sent: Monday, August 29, 2022 3:53 AM >> To: Elliott, Robert (Servers) ; Nayna >> ; Andrew Donnellan >> Cc: linuxppc-dev@lists.ozlabs.org >> Subject: Re: [PATCH v2 00/10]

Re: [PATCH v2 16/16] objtool/powerpc: Add --mcount specific implementation

Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > This patch enables objtool --mcount on powerpc, and > adds implementation specific to powerpc. > > Signed-off-by: Sathvika Vasireddy > --- > arch/powerpc/Kconfig | 1 + > tools/objtool/arch/powerpc/decode.c

Re: [PATCH v2 15/16] objtool/powerpc: Enable objtool to be built on ppc

Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > This patch adds [stub] implementations for required > functions, inorder to enable objtool build on powerpc. Not all powerpc it seems, see below > > Signed-off-by: Sathvika Vasireddy > [Christophe Leroy: powerpc: Add missing asm/asm.h for

Re: [PATCH v2 14/16] objtool: Add arch specific function arch_ftrace_match()

Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > Add architecture specific function to look for > relocation records pointing to arch specific > symbols. > > Suggested-by: Christophe Leroy > Signed-off-by: Sathvika Vasireddy Reviewed-by: Christophe Leroy > --- >

Re: [PATCH v2 13/16] objtool: Use macros to define arch specific reloc types

Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > Make relocation types architecture specific. > > Signed-off-by: Sathvika Vasireddy Reviewed-by: Christophe Leroy > --- > tools/objtool/arch/x86/include/arch/elf.h | 2 ++ > tools/objtool/check.c | 2 +- > 2 files

Re: [PATCH v2 12/16] objtool: Read special sections with alts only when specific options are selected

Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > This patch reads special sections which have alternate > instructions, only when stackval or orc or uaccess or > noinstr options are passed to objtool. Unclear, I had to read it three time to understand. What about something like: --- >8

Re: [PATCH v2 11/16] objtool: Add --mnop as an option to --mcount

Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > Architectures can select HAVE_NOP_MCOUNT if they choose > to nop out mcount call sites. If that config option is > selected, then --mnop is passed as an option to objtool, > along with --mcount. > > Also, make sure that --mnop can be passed

Re: [PATCH v2 07/16] powerpc: Skip objtool from running on VDSO files

Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > Do not run objtool on VDSO files, by using > OBJECT_FILES_NON_STANDARD > > Suggested-by: Christophe Leroy > Signed-off-by: Sathvika Vasireddy Reviewed-by: Christophe Leroy > --- > arch/powerpc/kernel/vdso/Makefile | 2 ++ > 1 file

Re: [PATCH v2 05/16] powerpc: Skip objtool from running on drivers/crypto/vmx/aesp8-ppc.o

Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > With objtool enabled, below warnings are seen when trying to build: > > drivers/crypto/vmx/aesp8-ppc.o: warning: objtool: > aes_p8_set_encrypt_key+0x44: unannotated intra-function call > > drivers/crypto/vmx/aesp8-ppc.o: warning: objtool:

Re: [PATCH v2 04/16] powerpc: Curb objtool unannotated intra-function warnings

Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > objtool throws the following unannotated intra-function call > warnings: > > arch/powerpc/kernel/entry_64.o: warning: objtool: .text+0x4: unannotated > intra-function call > arch/powerpc/kvm/book3s_hv_rmhandlers.o: warning: objtool:

Re: [PATCH v2 03/16] powerpc: Fix objtool unannotated intra-function call warnings

Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > objtool throws unannotated intra-function call warnings > in the following assembly files: > > arch/powerpc/kernel/vector.o: warning: objtool: .text+0x53c: unannotated > intra-function call > > arch/powerpc/kvm/book3s_hv_rmhandlers.o:

Re: [PATCH v2 01/16] powerpc: Replace unreachable() with it's builtin variant in __WARN_FLAGS()

Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > objtool is throwing *unannotated intra-function call* warnings in > .c files with a few instructions that are marked unreachable. The > problem comes from the annotate_unreachable() macro that is > called by unreachable(). This annotation is