Re: [PATCH v2 13/24] sh/cpu: Make sure play_dead() doesn't return

2023-02-13 Thread Philippe Mathieu-Daudé
On 14/2/23 08:05, Josh Poimboeuf wrote: play_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be

Re: [PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return

2023-02-13 Thread Philippe Mathieu-Daudé
Hi Josh, On 14/2/23 08:05, Josh Poimboeuf wrote: cpu_die() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code

Re: [PATCH v2 16/24] sparc/cpu: Mark cpu_play_dead() __noreturn

2023-02-13 Thread Philippe Mathieu-Daudé
On 14/2/23 08:05, Josh Poimboeuf wrote: cpu_play_dead() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Signed-off-by: Josh Poimboeuf --- arch/sparc/include/asm/smp_64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by:

Re: [PATCH v2 11/24] mips/cpu: Mark play_dead() __noreturn

2023-02-13 Thread Philippe Mathieu-Daudé
On 14/2/23 08:05, Josh Poimboeuf wrote: play_dead() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Acked-by: Florian Fainelli Signed-off-by: Josh Poimboeuf --- arch/mips/include/asm/smp.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 10/24] mips/cpu: Make sure play_dead() doesn't return

2023-02-13 Thread Philippe Mathieu-Daudé
On 14/2/23 08:05, Josh Poimboeuf wrote: play_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be

Re: [PATCH v2 09/24] mips/cpu: Expose play_dead()'s prototype definition

2023-02-13 Thread Philippe Mathieu-Daudé
Hi Josh, On 14/2/23 08:05, Josh Poimboeuf wrote: Include to make sure play_dead() matches its prototype going forward. Acked-by: Florian Fainelli Signed-off-by: Josh Poimboeuf --- arch/mips/kernel/smp-bmips.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v2 12/24] powerpc/cpu: Mark start_secondary_resume() __noreturn

2023-02-13 Thread Christophe Leroy
Le 14/02/2023 à 08:05, Josh Poimboeuf a écrit : > start_secondary_resume() doesn't return. Annotate it as such. By > extension this also makes arch_cpu_idle_dead() noreturn. > > Acked-by: Michael Ellerman (powerpc) > Signed-off-by: Josh Poimboeuf Reviewed-by: Christophe Leroy > --- >

[PATCH v2 24/24] sched/idle: Mark arch_cpu_idle_dead() __noreturn

2023-02-13 Thread Josh Poimboeuf
Before commit 076cbf5d2163 ("x86/xen: don't let xen_pv_play_dead() return"), in Xen, when a previously offlined CPU was brought back online, it unexpectedly resumed execution where it left off in the middle of the idle loop. There were some hacks to make that work, but the behavior was surprising

[PATCH v2 23/24] init: Make arch_call_rest_init() and rest_init() __noreturn

2023-02-13 Thread Josh Poimboeuf
arch_call_rest_init() and rest_init() don't return. Annotate them as such. Fixes the following warning: init/main.o: warning: objtool: start_kernel+0x4ad: unreachable instruction Signed-off-by: Josh Poimboeuf --- arch/s390/kernel/setup.c | 2 +- include/linux/start_kernel.h | 4 ++--

[PATCH v2 22/24] objtool: Include weak functions in 'global_noreturns' check

2023-02-13 Thread Josh Poimboeuf
If a global __noreturn function prototype has a corresponding weak function, it should also be __noreturn. Signed-off-by: Josh Poimboeuf --- tools/objtool/check.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index

[PATCH v2 21/24] sched/idle: Make sure weak version of arch_cpu_idle_dead() doesn't return

2023-02-13 Thread Josh Poimboeuf
arch_cpu_idle_dead() should never return. Make it so. Signed-off-by: Josh Poimboeuf --- kernel/sched/idle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c index e9ef66be2870..56e152f06d0f 100644 --- a/kernel/sched/idle.c +++

[PATCH v2 20/24] xtensa/cpu: Mark cpu_die() __noreturn

2023-02-13 Thread Josh Poimboeuf
cpu_die() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Signed-off-by: Josh Poimboeuf --- arch/xtensa/include/asm/smp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/xtensa/include/asm/smp.h

[PATCH v2 19/24] xtensa/cpu: Make sure cpu_die() doesn't return

2023-02-13 Thread Josh Poimboeuf
cpu_die() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Signed-off-by: Josh Poimboeuf ---

[PATCH v2 18/24] x86/cpu: Mark play_dead() __noreturn

2023-02-13 Thread Josh Poimboeuf
play_dead() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Signed-off-by: Josh Poimboeuf --- arch/x86/include/asm/smp.h | 2 +- arch/x86/kernel/process.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 17/24] x86/cpu: Make sure play_dead() doesn't return

2023-02-13 Thread Josh Poimboeuf
After commit 076cbf5d2163 ("x86/xen: don't let xen_pv_play_dead() return"), play_dead() never returns. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function

[PATCH v2 16/24] sparc/cpu: Mark cpu_play_dead() __noreturn

2023-02-13 Thread Josh Poimboeuf
cpu_play_dead() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Signed-off-by: Josh Poimboeuf --- arch/sparc/include/asm/smp_64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/include/asm/smp_64.h

[PATCH v2 15/24] sh/cpu: Expose arch_cpu_idle_dead()'s prototype definition

2023-02-13 Thread Josh Poimboeuf
Include to make sure arch_cpu_idle_dead() matches its prototype going forward. Signed-off-by: Josh Poimboeuf --- arch/sh/kernel/idle.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sh/kernel/idle.c b/arch/sh/kernel/idle.c index 3418c40f0099..114f0c4abeac 100644 ---

[PATCH v2 14/24] sh/cpu: Mark play_dead() __noreturn

2023-02-13 Thread Josh Poimboeuf
play_dead() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Signed-off-by: Josh Poimboeuf --- arch/sh/include/asm/smp-ops.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/sh/include/asm/smp-ops.h

[PATCH v2 13/24] sh/cpu: Make sure play_dead() doesn't return

2023-02-13 Thread Josh Poimboeuf
play_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Signed-off-by: Josh Poimboeuf ---

[PATCH v2 12/24] powerpc/cpu: Mark start_secondary_resume() __noreturn

2023-02-13 Thread Josh Poimboeuf
start_secondary_resume() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Acked-by: Michael Ellerman (powerpc) Signed-off-by: Josh Poimboeuf --- arch/powerpc/include/asm/smp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 11/24] mips/cpu: Mark play_dead() __noreturn

2023-02-13 Thread Josh Poimboeuf
play_dead() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Acked-by: Florian Fainelli Signed-off-by: Josh Poimboeuf --- arch/mips/include/asm/smp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 10/24] mips/cpu: Make sure play_dead() doesn't return

2023-02-13 Thread Josh Poimboeuf
play_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Acked-by: Florian Fainelli

[PATCH v2 09/24] mips/cpu: Expose play_dead()'s prototype definition

2023-02-13 Thread Josh Poimboeuf
Include to make sure play_dead() matches its prototype going forward. Acked-by: Florian Fainelli Signed-off-by: Josh Poimboeuf --- arch/mips/kernel/smp-bmips.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/kernel/smp-bmips.c b/arch/mips/kernel/smp-bmips.c index

[PATCH v2 08/24] loongarch/cpu: Mark play_dead() __noreturn

2023-02-13 Thread Josh Poimboeuf
play_dead() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Signed-off-by: Josh Poimboeuf --- arch/loongarch/include/asm/smp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/loongarch/include/asm/smp.h

[PATCH v2 07/24] loongarch/cpu: Make sure play_dead() doesn't return

2023-02-13 Thread Josh Poimboeuf
play_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Signed-off-by: Josh Poimboeuf ---

[PATCH v2 06/24] ia64/cpu: Mark play_dead() __noreturn

2023-02-13 Thread Josh Poimboeuf
play_dead() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Signed-off-by: Josh Poimboeuf --- arch/ia64/kernel/process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/ia64/kernel/process.c

[PATCH v2 05/24] csky/cpu: Make sure arch_cpu_idle_dead() doesn't return

2023-02-13 Thread Josh Poimboeuf
arch_cpu_idle_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Acked-by: Guo Ren

[PATCH v2 04/24] arm64/cpu: Mark cpu_die() __noreturn

2023-02-13 Thread Josh Poimboeuf
cpu_die() doesn't return. Annotate it as such. By extension this also makes arch_cpu_idle_dead() noreturn. Signed-off-by: Josh Poimboeuf --- arch/arm64/include/asm/smp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/include/asm/smp.h

[PATCH v2 03/24] arm/cpu: Make sure arch_cpu_idle_dead() doesn't return

2023-02-13 Thread Josh Poimboeuf
arch_cpu_idle_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Signed-off-by: Josh

[PATCH v2 01/24] alpha/cpu: Expose arch_cpu_idle_dead()'s prototype declaration

2023-02-13 Thread Josh Poimboeuf
Include to make sure arch_cpu_idle_dead() matches its prototype going forward. Signed-off-by: Josh Poimboeuf --- arch/alpha/kernel/process.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/alpha/kernel/process.c b/arch/alpha/kernel/process.c index ce20c31828a0..d1f2e8b6b107 100644 ---

[PATCH v2 02/24] alpha/cpu: Make sure arch_cpu_idle_dead() doesn't return

2023-02-13 Thread Josh Poimboeuf
arch_cpu_idle_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Signed-off-by: Josh

[PATCH v2 00/24] cpu,sched: Mark arch_cpu_idle_dead() __noreturn

2023-02-13 Thread Josh Poimboeuf
v2: - make arch_call_rest_init() and rest_init() __noreturn - make objtool 'global_returns' work for weak functions - rebase on tip/objtool/core with dependencies merged in (mingo) - add acks v1.1: - add __noreturn to all arch_cpu_idle_dead() implementations (mpe) Josh Poimboeuf (24):

Re: [PATCH v6 7/7] powerpc: mm: Support page table check

2023-02-13 Thread Christophe Leroy
Le 14/02/2023 à 02:59, Rohan McLure a écrit : > On creation and clearing of a page table mapping, instrument such calls > by invoking page_table_check_pte_set and page_table_check_pte_clear > respectively. These calls serve as a sanity check against illegal > mappings. Please also explaing the

Re: linux-next: qemu boot log difference today

2023-02-13 Thread Stephen Rothwell
Hi Nathan, On Mon, 13 Feb 2023 23:19:43 -0600 Nathan Lynch wrote: > > Stephen Rothwell writes: > > > > Today's qemu boot log shows 256k extra in reserved memory: > > > > - Memory: 2046080K/2097152K available (14720K kernel code, 2944K rwdata, > > 18048K rodata, 5184K init, 1431K bss, 51072K

Re: [PATCH v6 24/26] powerpc/pseries: Implement secvars for dynamic secure boot

2023-02-13 Thread Andrew Donnellan
On Mon, 2023-02-13 at 22:32 +1100, Michael Ellerman wrote: > > > +   memcpy(, data, sizeof(flags)); > > > > conversion from bytestream to integer: I think in this case it > > would be better to use > > > > flags = cpu_to_be64p((__u64*)data); > > > > so that the flags always in

Re: [PATCH v6 2/7] powerpc/64s: mm: Introduce __pmdp_collapse_flush with mm_struct argument

2023-02-13 Thread Christophe Leroy
Le 14/02/2023 à 02:59, Rohan McLure a écrit : > pmdp_collapse_flush has references in generic code with just three > parameters, due to the choice of mm context being implied by the vm_area > context parameter. > > Define __pmdp_collapse_flush to accept an additional mm_struct * > parameter,

Re: [PATCH v6 1/7] powerpc: mm: Separate set_pte, set_pte_at for internal, external use

2023-02-13 Thread Christophe Leroy
Le 14/02/2023 à 02:59, Rohan McLure a écrit : > Produce separate symbols for set_pte, which is to be used in > arch/powerpc for reassignment of pte's, and set_pte_at, used in generic > code. > > The reason for this distinction is to support the Page Table Check > sanitiser. Having this

Re: [PATCH v2 3/8] powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c

2023-02-13 Thread Christophe Leroy
Le 13/02/2023 à 21:15, Pali Rohár a écrit : > On Monday 13 February 2023 20:05:09 Christophe Leroy wrote: >> Le 24/12/2022 à 22:14, Pali Rohár a écrit : >>> +#ifdef CONFIG_MPC85xx_RDB >>> +static void __init mpc85xx_rdb_pic_init(void) >>> +{ >>> + struct mpic *mpic; >>> + >>> + mpic =

Re: [PATCH v2 0/8] powerpc/85xx: p2020: Create one unified machine description

2023-02-13 Thread Christophe Leroy
Le 13/02/2023 à 21:11, Pali Rohár a écrit : > On Monday 13 February 2023 19:58:15 Christophe Leroy wrote: >> Le 09/02/2023 à 01:15, Pali Rohár a écrit : This patch moves all p2020 boards from mpc85xx_rdb.c and mpc85xx_ds.c files into new p2020.c file, and plus it copies all helper

Re: linux-next: qemu boot log difference today

2023-02-13 Thread Nathan Lynch
Stephen Rothwell writes: > > Today's qemu boot log shows 256k extra in reserved memory: > > - Memory: 2046080K/2097152K available (14720K kernel code, 2944K rwdata, > 18048K rodata, 5184K init, 1431K bss, 51072K reserved, 0K cma-reserved) > + Memory: 2045824K/2097152K available (14720K kernel

[powerpc:next-test] BUILD SUCCESS 631bb79c0c5654bdd79b6df186f9e41981a2b1fa

2023-02-13 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test branch HEAD: 631bb79c0c5654bdd79b6df186f9e41981a2b1fa powerpc/nohash: Fix build error with binutils >= 2.38 elapsed time: 900m configs tested: 42 configs skipped: 3 The following configs have been built

linux-next: qemu boot log difference today

2023-02-13 Thread Stephen Rothwell
Hi all, Today's qemu boot log shows 256k extra in reserved memory: - Memory: 2046080K/2097152K available (14720K kernel code, 2944K rwdata, 18048K rodata, 5184K init, 1431K bss, 51072K reserved, 0K cma-reserved) + Memory: 2045824K/2097152K available (14720K kernel code, 2944K rwdata, 18048K

[PATCH v6 7/7] powerpc: mm: Support page table check

2023-02-13 Thread Rohan McLure
On creation and clearing of a page table mapping, instrument such calls by invoking page_table_check_pte_set and page_table_check_pte_clear respectively. These calls serve as a sanity check against illegal mappings. Enable ARCH_SUPPORTS_PAGE_TABLE_CHECK for all ppc64, and 32-bit platforms

[PATCH v6 5/7] powerpc: mm: Add common pud_pfn stub for all platforms

2023-02-13 Thread Rohan McLure
Prior to this commit, pud_pfn was implemented with BUILD_BUG as the inline function for 64-bit Book3S systems but is never included, as its invocations in generic code are guarded by calls to pud_devmap which return zero on such systems. A future patch will provide support for page table checks,

[PATCH v6 6/7] powerpc: mm: Add p{te,md,ud}_user_accessible_page helpers

2023-02-13 Thread Rohan McLure
Add the following helpers for detecting whether a page table entry is a leaf and is accessible to user space. * pte_user_accessible_page * pmd_user_accessible_page * pud_user_accessible_page Also implement missing pud_user definitions for both Book3S/nohash 64-bit systems, and pmd_user for

[PATCH v6 4/7] powerpc: mm: Implement p{m,u,4}d_leaf on all platforms

2023-02-13 Thread Rohan McLure
The check that a higher-level entry in multi-level pages contains a page translation entry (pte) is performed by p{m,u,4}d_leaf stubs, which may be specialised for each choice of mmu. In a prior commit, we replace uses to the catch-all stubs, p{m,u,4}d_is_leaf with p{m,u,4}d_leaf. Replace the

[PATCH v6 3/7] powerpc: mm: Replace p{u,m,4}d_is_leaf with p{u,m,4}_leaf

2023-02-13 Thread Rohan McLure
Replace occurrences of p{u,m,4}d_is_leaf with p{u,m,4}_leaf, as the latter is the name given to checking that a higher-level entry in multi-level paging contains a page translation entry (pte) throughout all other archs. A future patch will implement p{u,m,4}_leaf stubs on all platforms so that

[PATCH v6 2/7] powerpc/64s: mm: Introduce __pmdp_collapse_flush with mm_struct argument

2023-02-13 Thread Rohan McLure
pmdp_collapse_flush has references in generic code with just three parameters, due to the choice of mm context being implied by the vm_area context parameter. Define __pmdp_collapse_flush to accept an additional mm_struct * parameter, with pmdp_collapse_flush a macro that unpacks the vma and

[PATCH v6 1/7] powerpc: mm: Separate set_pte, set_pte_at for internal, external use

2023-02-13 Thread Rohan McLure
Produce separate symbols for set_pte, which is to be used in arch/powerpc for reassignment of pte's, and set_pte_at, used in generic code. The reason for this distinction is to support the Page Table Check sanitiser. Having this distinction allows for set_pte_at to instrumented, but set_pte not

[PATCH v6 0/7] Support page table check

2023-02-13 Thread Rohan McLure
Support the page table check sanitiser on all PowerPC platforms. This sanitiser works by serialising assignments, reassignments and clears of page table entries at each level in order to ensure that anonymous mappings have at most one writable consumer, and likewise that file-backed mappings are

Re: Build regressions/improvements in v6.2-rc8

2023-02-13 Thread Michael Ellerman
Geert Uytterhoeven writes: > On Mon, 13 Feb 2023, Geert Uytterhoeven wrote: >> JFYI, when comparing v6.2-rc8[1] to v6.2-rc7[3], the summaries are: >> - build errors: +11/-1 > >+ {standard input}: Error: unrecognized opcode: `dcbfl': => 5736, 4743, > 4327, 4476, 4447, 5067, 4602, 5212,

Re: [PATCH AUTOSEL 6.1 17/38] powerpc/85xx: Fix unannotated intra-function call warning

2023-02-13 Thread Sasha Levin
On Fri, Feb 10, 2023 at 04:55:54PM +0530, Sathvika Vasireddy wrote: Hi Sasha, On 09/02/23 16:44, Sasha Levin wrote: From: Sathvika Vasireddy [ Upstream commit 8afffce6aa3bddc940ac1909627ff1e772b6cbf1 ] objtool throws the following warning: arch/powerpc/kernel/head_85xx.o: warning:

RE: [PATCH RFC] PCI/AER: Enable internal AER errors by default

2023-02-13 Thread David Laight
From: Bjorn Helgaas > Sent: 13 February 2023 21:38 > > On Fri, Feb 10, 2023 at 02:33:23PM -0800, Ira Weiny wrote: > > The CXL driver expects internal error reporting to be enabled via > > pci_enable_pcie_error_reporting(). It is likely other drivers expect the > > same. > > Dave submitted a

Re: [PATCH RFC] PCI/AER: Enable internal AER errors by default

2023-02-13 Thread Bjorn Helgaas
On Fri, Feb 10, 2023 at 02:33:23PM -0800, Ira Weiny wrote: > The CXL driver expects internal error reporting to be enabled via > pci_enable_pcie_error_reporting(). It is likely other drivers expect the > same. > Dave submitted a patch to enable the CXL side[1] but the PCI AER registers > still

Re: [PATCH v2] powerpc/machdep: warn when machine_is() used too early

2023-02-13 Thread Nathan Lynch
Christophe Leroy writes: > Le 13/02/2023 à 20:23, Nathan Lynch via B4 Submission Endpoint a écrit : >> From: Nathan Lynch >> >> machine_is() can't provide correct results before probe_machine() has >> run. Warn when it's used too early in boot, placing the WARN_ON() in a >> helper function so

Re: [PATCH v2 6/8] powerpc/85xx: p2020: Define just one machine description

2023-02-13 Thread Pali Rohár
On Monday 13 February 2023 20:08:52 Christophe Leroy wrote: > Le 24/12/2022 à 22:14, Pali Rohár a écrit : > > Combine machine descriptions and code of all P2020 boards into just one > > generic unified P2020 machine description. This allows kernel to boot on > > any P2020-based board with P2020

Re: [PATCH v2 4/8] powerpc/85xx: p2020: Move i8259 code into own function

2023-02-13 Thread Pali Rohár
On Monday 13 February 2023 20:06:27 Christophe Leroy wrote: > > > Le 24/12/2022 à 22:14, Pali Rohár a écrit : > > Splits mpic and i8259 initialization codes into separate functions. > > > > Signed-off-by: Pali Rohár > > --- > > arch/powerpc/platforms/85xx/p2020.c | 37

Re: [PATCH v2 3/8] powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c

2023-02-13 Thread Pali Rohár
On Monday 13 February 2023 20:05:09 Christophe Leroy wrote: > Le 24/12/2022 à 22:14, Pali Rohár a écrit : > > This moves machine descriptions and all related code for all P2020 boards > > into new p2020.c source file. This change also copies helper static > > functions from other mpc85xx*.c files

Re: [PATCH v2] powerpc/machdep: warn when machine_is() used too early

2023-02-13 Thread Christophe Leroy
Le 13/02/2023 à 20:23, Nathan Lynch via B4 Submission Endpoint a écrit : > From: Nathan Lynch > > machine_is() can't provide correct results before probe_machine() has > run. Warn when it's used too early in boot, placing the WARN_ON() in a > helper function so the reported file:line indicates

Re: [PATCH v2 0/8] powerpc/85xx: p2020: Create one unified machine description

2023-02-13 Thread Pali Rohár
On Monday 13 February 2023 19:58:15 Christophe Leroy wrote: > Le 09/02/2023 à 01:15, Pali Rohár a écrit : > >> > >> This patch moves all p2020 boards from mpc85xx_rdb.c and mpc85xx_ds.c > >> files into new p2020.c file, and plus it copies all helper functions > >> which p2020 boards requires. This

Re: [PATCH v2 6/8] powerpc/85xx: p2020: Define just one machine description

2023-02-13 Thread Christophe Leroy
Le 24/12/2022 à 22:14, Pali Rohár a écrit : > Combine machine descriptions and code of all P2020 boards into just one > generic unified P2020 machine description. This allows kernel to boot on > any P2020-based board with P2020 DTS file without need to patch kernel and > define a new machine

Re: [PATCH v2 4/8] powerpc/85xx: p2020: Move i8259 code into own function

2023-02-13 Thread Christophe Leroy
Le 24/12/2022 à 22:14, Pali Rohár a écrit : > Splits mpic and i8259 initialization codes into separate functions. > > Signed-off-by: Pali Rohár > --- > arch/powerpc/platforms/85xx/p2020.c | 37 - > 1 file changed, 21 insertions(+), 16 deletions(-) > > diff --git

Re: [PATCH v2 3/8] powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c

2023-02-13 Thread Christophe Leroy
Le 24/12/2022 à 22:14, Pali Rohár a écrit : > This moves machine descriptions and all related code for all P2020 boards > into new p2020.c source file. This change also copies helper static > functions from other mpc85xx*.c files into p2020.c, which are required for > machine descriptions. This

Re: [PATCH v2 0/8] powerpc/85xx: p2020: Create one unified machine description

2023-02-13 Thread Christophe Leroy
Le 09/02/2023 à 01:15, Pali Rohár a écrit : >> >> This patch moves all p2020 boards from mpc85xx_rdb.c and mpc85xx_ds.c >> files into new p2020.c file, and plus it copies all helper functions >> which p2020 boards requires. This patch does not introduce any new code >> or functional change. It

[PATCH v2] powerpc/machdep: warn when machine_is() used too early

2023-02-13 Thread Nathan Lynch via B4 Submission Endpoint
From: Nathan Lynch machine_is() can't provide correct results before probe_machine() has run. Warn when it's used too early in boot, placing the WARN_ON() in a helper function so the reported file:line indicates exactly what went wrong. checkpatch complains about __attribute__((weak)) in the

Re: [PATCH 04/11] drivers/ps3: Read video= option with fb_get_option()

2023-02-13 Thread Geoff Levand
Hi, On 2/13/23 03:29, Thomas Zimmermann wrote: > Am 12.02.23 um 17:53 schrieb Geoff Levand: >> On 2/9/23 05:55, Thomas Zimmermann wrote: >>> Get the kernel's global video= parameter with fb_get_option(). Done >>> to unexport the internal fbdev state fb_mode_config. No functional >>> changes. >>>

Re: [PATCH] powerpc/pseries/cpuhp: respect current SMT when adding new CPU

2023-02-13 Thread Nathan Lynch
Michal Suchánek writes: > On Mon, Feb 13, 2023 at 08:46:50AM -0600, Nathan Lynch wrote: >> Laurent Dufour writes: >> > When a new CPU is added, the kernel is activating all its threads. This >> > leads to weird, but functional, result when adding CPU on a SMT 4 system >> > for instance. >> > >>

Re: [PATCH] powerpc/pseries/cpuhp: respect current SMT when adding new CPU

2023-02-13 Thread Michal Suchánek
Hello, On Mon, Feb 13, 2023 at 08:46:50AM -0600, Nathan Lynch wrote: > Laurent Dufour writes: > > When a new CPU is added, the kernel is activating all its threads. This > > leads to weird, but functional, result when adding CPU on a SMT 4 system > > for instance. > > > > Here the newly added

[PATCH 6.1 024/114] of: Make OF framebuffer device names unique

2023-02-13 Thread Greg Kroah-Hartman
From: Michal Suchanek [ Upstream commit 241d2fb56a18473af5f2ff0d512992a996eb64dd ] Since Linux 5.19 this error is observed: sysfs: cannot create duplicate filename '/devices/platform/of-display' This is because multiple devices with the same name 'of-display' are created on the same bus.

Re: [PATCH] powerpc/pseries/cpuhp: respect current SMT when adding new CPU

2023-02-13 Thread Nathan Lynch
Laurent Dufour writes: > When a new CPU is added, the kernel is activating all its threads. This > leads to weird, but functional, result when adding CPU on a SMT 4 system > for instance. > > Here the newly added CPU 1 has 8 threads while the other one has 4 threads > active (system has been

Re: [PATCH v6 6/7] PCI: pciehp: Rely on `link_active_reporting'

2023-02-13 Thread Lukas Wunner
On Sun, Feb 05, 2023 at 03:49:21PM +, Maciej W. Rozycki wrote: > Use `link_active_reporting' to determine whether Data Link Layer Link > Active Reporting is available rather than re-retrieving the capability. > > Signed-off-by: Maciej W. Rozycki Reviewed-by: Lukas Wunner I believe this

Re: [PATCH v6 24/26] powerpc/pseries: Implement secvars for dynamic secure boot

2023-02-13 Thread Stefan Berger
On 2/13/23 06:32, Michael Ellerman wrote: Stefan Berger writes: On 2/10/23 03:03, Andrew Donnellan wrote: From: Russell Currey ... +static int plpks_set_variable(const char *key, u64 key_len, u8 *data, + u64 data_size) +{ + struct plpks_var var = {0}; +

Re: [PATCH] powerpc/machdep: warn when machine_is() used too early

2023-02-13 Thread Nathan Lynch
Michael Ellerman writes: > Christophe Leroy writes: >> Le 11/02/2023 à 00:56, Nathan Lynch via B4 Submission Endpoint a écrit : >>> From: Nathan Lynch >>> >>> machine_is() can't provide correct results before probe_machine() has >>> run. Warn when it's used too early in boot. >>> >>>

[PATCH] powerpc/pseries/cpuhp: respect current SMT when adding new CPU

2023-02-13 Thread Laurent Dufour
When a new CPU is added, the kernel is activating all its threads. This leads to weird, but functional, result when adding CPU on a SMT 4 system for instance. Here the newly added CPU 1 has 8 threads while the other one has 4 threads active (system has been booted with the 'smt-enabled=4' kernel

Re: [PATCH v6 24/26] powerpc/pseries: Implement secvars for dynamic secure boot

2023-02-13 Thread Michael Ellerman
Stefan Berger writes: > On 2/10/23 03:03, Andrew Donnellan wrote: >> From: Russell Currey ... >> +static int plpks_set_variable(const char *key, u64 key_len, u8 *data, >> + u64 data_size) >> +{ >> +struct plpks_var var = {0}; >> +int rc = 0; >> +u64 flags; >>

Re: [PATCH 04/11] drivers/ps3: Read video= option with fb_get_option()

2023-02-13 Thread Thomas Zimmermann
Hi Am 12.02.23 um 17:53 schrieb Geoff Levand: Hi Thomas, On 2/9/23 05:55, Thomas Zimmermann wrote: Get the kernel's global video= parameter with fb_get_option(). Done to unexport the internal fbdev state fb_mode_config. No functional changes. Signed-off-by: Thomas Zimmermann ---

[PATCH] powerpc/nohash: Fix build error with binutils >= 2.38

2023-02-13 Thread Michael Ellerman
With bintils >= 2.38 the ppc64_book3e_allmodconfig build fails: {standard input}: Assembler messages: {standard input}:196: Error: unrecognized opcode: `lbarx' {standard input}:196: Error: unrecognized opcode: `stbcx.' make[5]: *** [scripts/Makefile.build:252:

Re: [PATCH] powerpc/machdep: warn when machine_is() used too early

2023-02-13 Thread Michael Ellerman
Christophe Leroy writes: > Le 11/02/2023 à 00:56, Nathan Lynch via B4 Submission Endpoint a écrit : >> From: Nathan Lynch >> >> machine_is() can't provide correct results before probe_machine() has >> run. Warn when it's used too early in boot. >> >> Signed-off-by: Nathan Lynch >> --- >>

Re: Build regressions/improvements in v6.2-rc8

2023-02-13 Thread Geert Uytterhoeven
On Mon, 13 Feb 2023, Geert Uytterhoeven wrote: JFYI, when comparing v6.2-rc8[1] to v6.2-rc7[3], the summaries are: - build errors: +11/-1 + {standard input}: Error: unrecognized opcode: `dcbfl': => 5736, 4743, 4327, 4476, 4447, 5067, 4602, 5212, 5224, 4298, 5594, 4315, 5050, 5195, 4464,