Re: [PATCH] powerpc/embedded6xx: select MPC10X_BRIDGE only if PCI is set

2023-05-11 Thread Michael Ellerman
Randy Dunlap writes: > When CONFIG_SMP is not set, CONFIG_BROKEN_ON_SMP is set, and > CONFIG_PCI is not set, there can be a kconfig warning: > > WARNING: unmet direct dependencies detected for PPC_INDIRECT_PCI > Depends on [n]: PCI [=n] > Selected by [y]: > - MPC10X_BRIDGE [=y] > > To fix

Re: Fwd: Linux 6.3.1 + AMD RX 570 on ppc64le 4K: Kernel attempted to read user page (1128) - exploit attempt? (uid: 0)

2023-05-11 Thread Michael Ellerman
Bagas Sanjaya writes: > Hi, > > I notice a regression report on bugzilla ([1]). As many developers > don't keep an eye on it, I decide to forward it by email. Bugs filed against powerpc do get Cc'ed to linuxppc-dev, so we do see them. Though that doesn't always mean we have time to fix them :)

Re: [PATCH 00/23] arch: allow pte_offset_map[_lock]() to fail

2023-05-11 Thread Mike Rapoport
Hi, On Thu, May 11, 2023 at 03:02:55PM +0100, Matthew Wilcox wrote: > On Wed, May 10, 2023 at 09:35:44PM -0700, Hugh Dickins wrote: > > On Wed, 10 May 2023, Matthew Wilcox wrote: > > > > I don't really understand why you're going down a remove-CONFIG_HIGHPTE > > route: I thought you were

Re: [PATCH] powerpc/iommu: limit number of TCEs to 512 for H_STUFF_TCE hcall

2023-05-11 Thread Gaurav Batra
Hello Michael, System test hit the crash. I believe, it was PHYP that resulted in it due to number of TCEs passed in to be >512. I was wondering about the Fixes tag as well. But, this interface, in it's current form, is there from the day the file was created. So, in this case, should I

Re: [PATCH] powerpc: Drop MPC5200 LocalPlus bus FIFO driver

2023-05-11 Thread Michael Ellerman
Uwe Kleine-König writes: > On Thu, Apr 13, 2023 at 08:16:42AM +0200, Uwe Kleine-König wrote: >> While mpc5200b.dtsi contains a device that this driver can bind to, the >> only purpose of a bound device is to be used by the four exported functions >> mpc52xx_lpbfifo_submit(),

Re: [PATCH] powerpc/iommu: limit number of TCEs to 512 for H_STUFF_TCE hcall

2023-05-11 Thread Michael Ellerman
Gaurav Batra writes: > As of now, in tce_freemulti_pSeriesLP(), there is no limit on how many TCEs > are passed to H_STUFF_TCE hcall. PAPR is enforcing this to be limited to > 512 TCEs. Did you actually hit a bug here, or just noticed via code inspection? Can you provide a Fixes: tag ? cheers

Re: [PATCH v2 03/11] asm-generic/mmiowb: Mark accesses to fix KCSAN warnings

2023-05-11 Thread Michael Ellerman
Rohan McLure writes: > Prior to this patch, data races are detectable by KCSAN of the following > forms: > > [1] Asynchronous calls to mmiowb_set_pending() from an interrupt context > or otherwise outside of a critical section > [2] Interrupted critical sections, where the interrupt will

[powerpc:fixes-test] BUILD SUCCESS 66b2ca086210732954a7790d63d35542936fc664

2023-05-11 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git fixes-test branch HEAD: 66b2ca086210732954a7790d63d35542936fc664 powerpc/64s/radix: Fix soft dirty tracking elapsed time: 730m configs tested: 38 configs skipped: 156 The following configs have been built

[PATCH v6 3/3] PCI/DPC: Disable DPC interrupt during suspend

2023-05-11 Thread Kai-Heng Feng
PCIe services that share an IRQ with PME, such as AER or DPC, may cause a spurious wakeup on system suspend. Since DPC depends on AER to work, disable DPC interrupt notification during the system suspend process as AER interrupt notification is already disabled by previous patch. As Per PCIe Base

[PATCH v6 2/3] PCI/AER: Disable AER interrupt on suspend

2023-05-11 Thread Kai-Heng Feng
PCIe services that share an IRQ with PME, such as AER or DPC, may cause a spurious wakeup on system suspend. To prevent this, disable the AER interrupt notification during the system suspend process. As Per PCIe Base Spec 5.0, section 5.2, titled "Link State Power Management", TLP and DLLP

[PATCH v6 1/3] PCI/AER: Factor out interrupt toggling into helpers

2023-05-11 Thread Kai-Heng Feng
There are many places that enable and disable AER interrupt, so move them into helpers. Reviewed-by: Mika Westerberg Reviewed-by: Kuppuswamy Sathyanarayanan Reviewed-by: Jonathan Cameron Signed-off-by: Kai-Heng Feng --- v6: - No change. v5: - Fix misspelling. v4: - No change. v3: -

Re: [PATCH v5 2/3] PCI/AER: Disable AER interrupt on suspend

2023-05-11 Thread Kai-Heng Feng
On Fri, May 12, 2023 at 6:08 AM Sathyanarayanan Kuppuswamy wrote: > > > > On 5/11/23 6:36 AM, Kai-Heng Feng wrote: > > PCIe service that shares IRQ with PME may cause spurious wakeup on > > system suspend. > > > > This is very similar to previous attempts to suspend AER and DPC [1], > > but this

Re: [PATCH 00/23] arch: allow pte_offset_map[_lock]() to fail

2023-05-11 Thread Hugh Dickins
On Thu, 11 May 2023, Matthew Wilcox wrote: > > I was thinking that removing CONFIG_HIGHPTE might simplify the page > fault handling path a little, but now I've looked at it some more, and > I'm not sure there's any simplification to be had. It should probably > use kmap_local instead of

Re: [PATCH v5 2/3] PCI/AER: Disable AER interrupt on suspend

2023-05-11 Thread Sathyanarayanan Kuppuswamy
On 5/11/23 6:36 AM, Kai-Heng Feng wrote: > PCIe service that shares IRQ with PME may cause spurious wakeup on > system suspend. > > This is very similar to previous attempts to suspend AER and DPC [1], > but this time disabling AER IRQ is to prevent immediate PME wakeup when > AER shares the

Re: [PATCH] cachestat: wire up cachestat for other architectures

2023-05-11 Thread Nhat Pham
On Wed, May 10, 2023 at 8:23 PM Michael Ellerman wrote: > > Nhat Pham writes: > > cachestat is previously only wired in for x86 (and architectures using > > the generic unistd.h table): > > > > https://lore.kernel.org/lkml/20230503013608.2431726-1-npha...@gmail.com/ > > > > This patch wires

Re: [PATCH v13 3/3] selftests: Add selftests for cachestat

2023-05-11 Thread Nhat Pham
On Wed, May 10, 2023 at 8:21 PM Michael Ellerman wrote: > > Nhat Pham writes: > > Test cachestat on a newly created file, /dev/ files, and /proc/ files. > > Also test on a shmem file (which can also be tested with huge pages > > since tmpfs supports huge pages). > > > > Signed-off-by: Nhat Pham

Re: [PATCH v8 1/3] riscv: Introduce CONFIG_RELOCATABLE

2023-05-11 Thread Andreas Schwab
On Mai 09 2023, Alexandre Ghiti wrote: > On 5/9/23 21:07, Andreas Schwab wrote: >> That does not work with UEFI booting: >> >> Loading Linux 6.4.0-rc1-1.g668187d-default ... >> Loading initial ramdisk ... >> Unhandled exception: Instruction access fault >> EPC: 80016d56 RA:

Re: [PATCH v4 10/17] watchdog/hardlockup: Move perf hardlockup watchdog petting to watchdog.c

2023-05-11 Thread Petr Mladek
On Thu 2023-05-04 15:13:42, Douglas Anderson wrote: > In preparation for the buddy hardlockup detector, which wants the same > petting logic as the current perf hardlockup detector, move the code > to watchdog.c. While doing this, rename the global variable to match > others nearby. The

Re: [RFC PATCH v2] fs/xattr: add *at family syscalls

2023-05-11 Thread Geert Uytterhoeven
Hi Christian, On Thu, May 11, 2023 at 5:10 PM Christian Göttsche wrote: > Add the four syscalls setxattrat(), getxattrat(), listxattrat() and > removexattrat(). Those can be used to operate on extended attributes, > especially security related ones, either relative to a pinned directory > or on

Re: [PATCH v4 09/17] watchdog/hardlockup: Add a "cpu" param to watchdog_hardlockup_check()

2023-05-11 Thread Petr Mladek
On Thu 2023-05-04 15:13:41, Douglas Anderson wrote: > In preparation for the buddy hardlockup detector where the CPU > checking for lockup might not be the currently running CPU, add a > "cpu" parameter to watchdog_hardlockup_check(). > > --- a/kernel/watchdog.c > +++ b/kernel/watchdog.c > @@

Re: [PATCH 00/23] arch: allow pte_offset_map[_lock]() to fail

2023-05-11 Thread Matthew Wilcox
On Wed, May 10, 2023 at 09:35:44PM -0700, Hugh Dickins wrote: > On Wed, 10 May 2023, Matthew Wilcox wrote: > > On Tue, May 09, 2023 at 09:39:13PM -0700, Hugh Dickins wrote: > > > Two: pte_offset_map() will need to do an rcu_read_lock(), with the > > > corresponding rcu_read_unlock() in

[PATCH v5 3/3] PCI/DPC: Disable DPC interrupt during suspend

2023-05-11 Thread Kai-Heng Feng
PCIe service that shares IRQ with PME may cause spurious wakeup on system suspend. Since AER is conditionally disabled in previous patch, also apply the same logic to disable DPC which depends on AER to work. It's okay to disable DPC because PCIe Base Spec 5.0, section 5.2 "Link State Power

[PATCH v5 2/3] PCI/AER: Disable AER interrupt on suspend

2023-05-11 Thread Kai-Heng Feng
PCIe service that shares IRQ with PME may cause spurious wakeup on system suspend. This is very similar to previous attempts to suspend AER and DPC [1], but this time disabling AER IRQ is to prevent immediate PME wakeup when AER shares the same IRQ line with PME. It's okay to disable AER because

[PATCH v5 1/3] PCI/AER: Factor out interrupt toggling into helpers

2023-05-11 Thread Kai-Heng Feng
There are many places that enable and disable AER interrupt, so move them into helpers. Reviewed-by: Mika Westerberg Reviewed-by: Kuppuswamy Sathyanarayanan Reviewed-by: Jonathan Cameron Signed-off-by: Kai-Heng Feng --- v5 - Fix misspelling. v4: - No change. v3: - Correct subject. v2:

Re: [PATCH v4 2/3] PCI/AER: Disable AER interrupt on suspend

2023-05-11 Thread Kai-Heng Feng
On Tue, Apr 25, 2023 at 7:47 AM Sathyanarayanan Kuppuswamy wrote: > > > > On 4/23/23 10:52 PM, Kai-Heng Feng wrote: > > PCIe service that shares IRQ with PME may cause spurious wakeup on > > system suspend. > > > > PCIe Base Spec 5.0, section 5.2 "Link State Power Management" states > > that TLP

Re: [PATCH v4 2/3] PCI/AER: Disable AER interrupt on suspend

2023-05-11 Thread Kai-Heng Feng
On Sat, May 6, 2023 at 3:22 AM Bjorn Helgaas wrote: > > On Mon, Apr 24, 2023 at 01:52:48PM +0800, Kai-Heng Feng wrote: > > PCIe service that shares IRQ with PME may cause spurious wakeup on > > system suspend. > > > > PCIe Base Spec 5.0, section 5.2 "Link State Power Management" states > > that

Re: [PATCH v4 1/3] PCI/AER: Factor out interrupt toggling into helpers

2023-05-11 Thread Kai-Heng Feng
On Fri, May 5, 2023 at 11:37 PM Jonathan Cameron wrote: > > On Mon, 24 Apr 2023 13:52:47 +0800 > Kai-Heng Feng wrote: > > > There are many places that enable and disable AER interrput, so move > > interrupt Thanks, will correct that in next revision. Kai-Heng > > > them into helpers. > >

Re: [PATCH v4 08/17] watchdog/hardlockup: Style changes to watchdog_hardlockup_check() / ..._is_lockedup()

2023-05-11 Thread Petr Mladek
On Fri 2023-05-05 09:38:14, Doug Anderson wrote: > Hi, > > On Thu, May 4, 2023 at 8:02 PM Nicholas Piggin wrote: > > > > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > > These are tiny style changes: > > > - Add a blank line before a "return". > > > - Renames two globals to use

Re: a possible issue with radix MMU on P9

2023-05-11 Thread Michael Ellerman
Dan Horák writes: > Hi all, > > we have been struggling with an issue in the bdwgc project (garbage > collector) on P9 systems for a while [1]. There were some test failing > on P9, but not on P8 or other platforms (x86, s390x, aarch64). Recently > the upstream developer has found out there is

Re: [PATCH v4 07/17] watchdog/hardlockup: Move perf hardlockup checking/panic to common watchdog.c

2023-05-11 Thread Petr Mladek
On Fri 2023-05-05 09:37:50, Doug Anderson wrote: > Hi, > > On Thu, May 4, 2023 at 7:58 PM Nicholas Piggin wrote: > > > > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > > The perf hardlockup detector works by looking at interrupt counts and > > > seeing if they change from run to

[PATCH] powerpc/64s/radix: Fix soft dirty tracking

2023-05-11 Thread Michael Ellerman
It was reported that soft dirty tracking doesn't work when using the Radix MMU. The tracking is supposed to work by clearing the soft dirty bit for a mapping and then write protecting the PTE. If/when the page is written to, a page fault occurs and the soft dirty bit is added back via

Re: [PATCH v4 06/17] watchdog/perf: Rename watchdog_hld.c to watchdog_perf.c

2023-05-11 Thread Petr Mladek
On Thu 2023-05-04 15:13:38, Douglas Anderson wrote: > The code currently in "watchdog_hld.c" is for detecting hardlockups > using perf, as evidenced by the line in the Makefile that only > compiles this file if CONFIG_HARDLOCKUP_DETECTOR_PERF is > defined. Rename the file to prepare for the buddy

Re: [PATCH] cachestat: wire up cachestat for other architectures

2023-05-11 Thread Nhat Pham
On Thu, May 11, 2023 at 12:05 AM Arnd Bergmann wrote: > > On Wed, May 10, 2023, at 21:58, Nhat Pham wrote: > > cachestat is previously only wired in for x86 (and architectures using > > the generic unistd.h table): > > > > https://lore.kernel.org/lkml/20230503013608.2431726-1-npha...@gmail.com/ >

Re: [PATCH v4 05/17] watchdog/hardlockup: Rename touch_nmi_watchdog() to touch_hardlockup_watchdog()

2023-05-11 Thread Petr Mladek
On Fri 2023-05-05 09:37:35, Doug Anderson wrote: > Hi, > > On Thu, May 4, 2023 at 7:51 PM Nicholas Piggin wrote: > > > > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > > In preparation for the buddy hardlockup detector, rename > > > touch_nmi_watchdog() to

Re: [PATCH v14 03/15] dt-bindings: Convert gpio-mmio to yaml

2023-05-11 Thread Bartosz Golaszewski
On Thu, Apr 13, 2023 at 6:06 PM Sean Anderson wrote: > > This is a generic binding for simple MMIO GPIO controllers. Although we > have a single driver for these controllers, they were previously spread > over several files. Consolidate them. The register descriptions are > adapted from the

Re: [PATCH] cachestat: wire up cachestat for other architectures

2023-05-11 Thread Nhat Pham
On Thu, May 11, 2023 at 12:01 AM Geert Uytterhoeven wrote: > > Hi Nat, > > On Wed, May 10, 2023 at 9:58 PM Nhat Pham wrote: > > cachestat is previously only wired in for x86 (and architectures using > > the generic unistd.h table): > > > >

[Bug 217427] Linux 6.3.1 + AMD RX 570 on ppc64le 4K: Kernel attempted to read user page (1128) - exploit attempt? (uid: 0)

2023-05-11 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217427 --- Comment #3 from darkbasic (darkba...@linuxsystems.it) --- Gitlab issue: https://gitlab.freedesktop.org/drm/amd/-/issues/2553 -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the

Re: [PATCH v4 01/17] watchdog/perf: Define dummy watchdog_update_hrtimer_threshold() on correct config

2023-05-11 Thread Petr Mladek
On Fri 2023-05-05 12:43:49, Nicholas Piggin wrote: > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > The real watchdog_update_hrtimer_threshold() is defined in > > watchdog_hardlockup_perf.c. That file is included if > > In kernel/watchdog_hld.c. With this fixed path:

Fwd: Linux 6.3.1 + AMD RX 570 on ppc64le 4K: Kernel attempted to read user page (1128) - exploit attempt? (uid: 0)

2023-05-11 Thread Bagas Sanjaya
Hi, I notice a regression report on bugzilla ([1]). As many developers don't keep an eye on it, I decide to forward it by email. Quoting from it: > darkbasic 2023-05-10 13:36:37 UTC > > I'm using Gentoo Linux on a Raptor CS Talos 2 ppc64le, GPU is an AMD RX 570. > So far the past dozen of

a possible issue with radix MMU on P9

2023-05-11 Thread Dan Horák
Hi all, we have been struggling with an issue in the bdwgc project (garbage collector) on P9 systems for a while [1]. There were some test failing on P9, but not on P8 or other platforms (x86, s390x, aarch64). Recently the upstream developer has found out there is likely a problem in the kernel

Re: [PATCH] cachestat: wire up cachestat for other architectures

2023-05-11 Thread Heiko Carstens
On Wed, May 10, 2023 at 12:58:06PM -0700, Nhat Pham wrote: > cachestat is previously only wired in for x86 (and architectures using > the generic unistd.h table): > > https://lore.kernel.org/lkml/20230503013608.2431726-1-npha...@gmail.com/ > > This patch wires cachestat in for all the other

Re: [PATCH 21/23] x86: Allow get_locked_pte() to fail

2023-05-11 Thread Peter Zijlstra
On Wed, May 10, 2023 at 08:16:34PM -0700, Hugh Dickins wrote: > Thanks for looking so quickly, Peter: I didn't Cc you on this particular > series, but shall certainly be doing so on the ones that follow, because > a few of those patches go into interesting pmdp_get_lockless() territory. I'm in

Re: [PATCH] cachestat: wire up cachestat for other architectures

2023-05-11 Thread Arnd Bergmann
On Wed, May 10, 2023, at 21:58, Nhat Pham wrote: > cachestat is previously only wired in for x86 (and architectures using > the generic unistd.h table): > > https://lore.kernel.org/lkml/20230503013608.2431726-1-npha...@gmail.com/ > > This patch wires cachestat in for all the other architectures. >

Re: [PATCH] cachestat: wire up cachestat for other architectures

2023-05-11 Thread Geert Uytterhoeven
Hi Nat, On Wed, May 10, 2023 at 9:58 PM Nhat Pham wrote: > cachestat is previously only wired in for x86 (and architectures using > the generic unistd.h table): > > https://lore.kernel.org/lkml/20230503013608.2431726-1-npha...@gmail.com/ > > This patch wires cachestat in for all the other

Re: [PATCH 05/23] m68k: allow pte_offset_map[_lock]() to fail

2023-05-11 Thread Geert Uytterhoeven
Hi Hugh, On Thu, May 11, 2023 at 4:58 AM Hugh Dickins wrote: > On Wed, 10 May 2023, Geert Uytterhoeven wrote: > > On Wed, May 10, 2023 at 6:48 AM Hugh Dickins wrote: > > > In rare transient cases, not yet made possible, pte_offset_map() and > > > pte_offset_map_lock() may not find a page table: