Re: [PATCH v3 22/34] csky: Convert __pte_free_tlb() to use ptdescs

2023-05-31 Thread Guo Ren
Acked-by: Guo Ren On Thu, Jun 1, 2023 at 5:34 AM Vishal Moola (Oracle) wrote: > > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. > > Signed-off-by: Vishal Moola (Oracle) > --- > arch/csky/include/asm/pgalloc.h | 4 ++-- > 1 file changed, 2

Re: [PATCH 2/2] powerpc/xmon: use KSYM_NAME_LEN in array size

2023-05-31 Thread Michael Ellerman
Miguel Ojeda writes: > On Mon, May 29, 2023 at 1:14 PM Maninder Singh > wrote: >> >> +static char tmpstr[KSYM_NAME_LEN]; > > Reviewed-by: Miguel Ojeda > > Side-note: in `get_function_bounds()`, I see `kallsyms_lookup()` being > used, but the name seems discarded? Can >

Re: [PATCH] MAINTAINERS: Exclude m68k-only drivers from powerpc entry

2023-05-31 Thread Finn Thain
On Wed, 31 May 2023, Geert Uytterhoeven wrote: > On Wed, May 31, 2023 at 2:50 PM Michael Ellerman wrote: > > The powerpc section has a "F:" entry for drivers/macintosh, matching > > all files in or below drivers/macintosh. That is correct for the most > > part, but there are a couple of

Re: [PATCH mm-unstable v2 04/10] kvm/arm64: make stage2 page tables RCU safe

2023-05-31 Thread Yu Zhao
On Wed, May 31, 2023 at 5:23 PM Oliver Upton wrote: > > On Wed, May 31, 2023 at 05:10:52PM -0600, Yu Zhao wrote: > > On Wed, May 31, 2023 at 1:28 PM Oliver Upton wrote: > > > On Tue, May 30, 2023 at 02:06:55PM -0600, Yu Zhao wrote: > > > > On Tue, May 30, 2023 at 1:37 PM Oliver Upton > > > >

Re: [PATCH mm-unstable v2 04/10] kvm/arm64: make stage2 page tables RCU safe

2023-05-31 Thread Oliver Upton
On Wed, May 31, 2023 at 05:10:52PM -0600, Yu Zhao wrote: > On Wed, May 31, 2023 at 1:28 PM Oliver Upton wrote: > > On Tue, May 30, 2023 at 02:06:55PM -0600, Yu Zhao wrote: > > > On Tue, May 30, 2023 at 1:37 PM Oliver Upton > > > wrote: > > > > As it is currently implemented, yes. But, there's

Re: [PATCH mm-unstable v2 04/10] kvm/arm64: make stage2 page tables RCU safe

2023-05-31 Thread Yu Zhao
On Wed, May 31, 2023 at 1:28 PM Oliver Upton wrote: > > On Tue, May 30, 2023 at 02:06:55PM -0600, Yu Zhao wrote: > > On Tue, May 30, 2023 at 1:37 PM Oliver Upton wrote: > > > > > > Hi Yu, > > > > > > On Sat, May 27, 2023 at 02:13:07PM -0600, Yu Zhao wrote: > > > > On Sat, May 27, 2023 at 12:08 

Re: [PATCH 09/12] mm/khugepaged: retract_page_tables() without mmap or vma lock

2023-05-31 Thread Jann Horn
On Wed, May 31, 2023 at 10:54 PM Peter Xu wrote: > On Wed, May 31, 2023 at 05:34:58PM +0200, Jann Horn wrote: > > On Mon, May 29, 2023 at 8:25 AM Hugh Dickins wrote: > > > -static int retract_page_tables(struct address_space *mapping, pgoff_t > > > pgoff, > > > -

[PATCH v3 34/34] mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers

2023-05-31 Thread Vishal Moola (Oracle)
These functions are no longer necessary. Remove them and cleanup Documentation referencing them. Signed-off-by: Vishal Moola (Oracle) --- Documentation/mm/split_page_table_lock.rst| 12 +-- .../zh_CN/mm/split_page_table_lock.rst| 14 ++--- include/linux/mm.h

[PATCH v3 33/34] um: Convert {pmd, pte}_free_tlb() to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Also cleans up some spacing issues. Signed-off-by: Vishal Moola (Oracle) --- arch/um/include/asm/pgalloc.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH v3 32/34] sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents

2023-05-31 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable pte constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) --- arch/sparc/mm/srmmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c index

[PATCH v3 31/34] sparc64: Convert various functions to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Signed-off-by: Vishal Moola (Oracle) --- arch/sparc/mm/init_64.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff

[PATCH v3 30/34] sh: Convert pte_free_tlb() to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Also cleans up some spacing issues. Signed-off-by: Vishal Moola (Oracle) --- arch/sh/include/asm/pgalloc.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH v3 28/34] openrisc: Convert __pte_free_tlb() to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) --- arch/openrisc/include/asm/pgalloc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/openrisc/include/asm/pgalloc.h

[PATCH v3 29/34] riscv: Convert alloc_{pmd, pte}_late() to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH v3 27/34] nios2: Convert __pte_free_tlb() to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) --- arch/nios2/include/asm/pgalloc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/nios2/include/asm/pgalloc.h

[PATCH v3 26/34] mips: Convert various functions to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH v3 25/34] m68k: Convert various functions to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH v3 24/34] loongarch: Convert various functions to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH v3 23/34] hexagon: Convert __pte_free_tlb() to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) --- arch/hexagon/include/asm/pgalloc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/hexagon/include/asm/pgalloc.h

[PATCH v3 22/34] csky: Convert __pte_free_tlb() to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) --- arch/csky/include/asm/pgalloc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/csky/include/asm/pgalloc.h

[PATCH v3 21/34] arm64: Convert various functions to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Signed-off-by: Vishal Moola (Oracle) --- arch/arm64/include/asm/tlb.h | 14 -- arch/arm64/mm/mmu.c | 7 --- 2 files

[PATCH v3 20/34] arm: Convert various functions to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. late_alloc() also uses the __get_free_pages() helper function. Convert this to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH v3 19/34] pgalloc: Convert various functions to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH v3 18/34] mm: Remove page table members from struct page

2023-05-31 Thread Vishal Moola (Oracle)
The page table members are now split out into their own ptdesc struct. Remove them from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm_types.h | 14 -- include/linux/pgtable.h | 3 --- 2 files changed, 17 deletions(-) diff --git a/include/linux/mm_types.h

[PATCH v3 17/34] s390: Convert various pgalloc functions to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
As part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents, convert various page table functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize

[PATCH v3 16/34] s390: Convert various gmap functions to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
In order to split struct ptdesc from struct page, convert various functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola

[PATCH v3 15/34] x86: Convert various functions to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
In order to split struct ptdesc from struct page, convert various functions to use ptdescs. Some of the functions use the *get*page*() helper functions. Convert these to use pagetable_alloc() and ptdesc_address() instead to help standardize page tables further. Signed-off-by: Vishal Moola

[PATCH v3 14/34] powerpc: Convert various functions to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
In order to split struct ptdesc from struct page, convert various functions to use ptdescs. Signed-off-by: Vishal Moola (Oracle) --- arch/powerpc/mm/book3s64/mmu_context.c | 10 +++--- arch/powerpc/mm/book3s64/pgtable.c | 32 +- arch/powerpc/mm/pgtable-frag.c | 46

[PATCH v3 13/34] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor}

2023-05-31 Thread Vishal Moola (Oracle)
Creates pagetable_pte_ctor(), pagetable_pmd_ctor(), pagetable_pte_dtor(), and pagetable_pmd_dtor() and make the original pgtable constructor/destructors wrappers. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 56 ++ 1 file changed, 42

[PATCH v3 12/34] mm: Convert ptlock_free() to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 10 +- mm/memory.c| 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH v3 11/34] mm: Convert pmd_ptlock_free() to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h

[PATCH v3 10/34] mm: Convert ptlock_init() to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h

[PATCH v3 09/34] mm: Convert pmd_ptlock_init() to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h

[PATCH v3 08/34] mm: Convert ptlock_ptr() to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- arch/x86/xen/mmu_pv.c | 2 +- include/linux/mm.h| 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH v3 07/34] mm: Convert ptlock_alloc() to use ptdescs

2023-05-31 Thread Vishal Moola (Oracle)
This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 6 +++--- mm/memory.c| 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/linux/mm.h

[PATCH v3 06/34] mm: Convert pmd_pgtable_page() to pmd_ptdesc()

2023-05-31 Thread Vishal Moola (Oracle)
Converts pmd_pgtable_page() to pmd_ptdesc() and all its callers. This removes some direct accesses to struct page, working towards splitting out struct ptdesc from struct page. Signed-off-by: Vishal Moola (Oracle) --- include/linux/mm.h | 8 1 file changed, 4 insertions(+), 4

[PATCH v3 05/34] mm: add utility functions for ptdesc

2023-05-31 Thread Vishal Moola (Oracle)
Introduce utility functions setting the foundation for ptdescs. These will also assist in the splitting out of ptdesc from struct page. Functions that focus on the descriptor are prefixed with ptdesc_* while functions that focus on the pagetable are prefixed with pagetable_*. pagetable_alloc()

[PATCH v3 04/34] pgtable: Create struct ptdesc

2023-05-31 Thread Vishal Moola (Oracle)
Currently, page table information is stored within struct page. As part of simplifying struct page, create struct ptdesc for page table information. Signed-off-by: Vishal Moola (Oracle) --- include/linux/pgtable.h | 52 + 1 file changed, 52 insertions(+)

[PATCH v3 03/34] s390: Use pt_frag_refcount for pagetables

2023-05-31 Thread Vishal Moola (Oracle)
s390 currently uses _refcount to identify fragmented page tables. The page table struct already has a member pt_frag_refcount used by powerpc, so have s390 use that instead of the _refcount field as well. This improves the safety for _refcount and the page table tracking. This also allows us to

[PATCH v3 02/34] s390: Use _pt_s390_gaddr for gmap address tracking

2023-05-31 Thread Vishal Moola (Oracle)
s390 uses page->index to keep track of page tables for the guest address space. In an attempt to consolidate the usage of page fields in s390, replace _pt_pad_2 with _pt_s390_gaddr to replace page->index in gmap. This will help with the splitting of struct ptdesc from struct page, as well as

[PATCH v3 01/34] mm: Add PAGE_TYPE_OP folio functions

2023-05-31 Thread Vishal Moola (Oracle)
No folio equivalents for page type operations have been defined, so define them for later folio conversions. Also changes the Page##uname macros to take in const struct page* since we only read the memory here. Signed-off-by: Vishal Moola (Oracle) --- include/linux/page-flags.h | 20

[PATCH v3 00/34] Split ptdesc from struct page

2023-05-31 Thread Vishal Moola (Oracle)
happen. This is rebased on next-20230531. v3: Got an Acked-by Fixed the arm64 compilation issue Rename some ptdesc utility functions to be pagetable_* instead Add some comments to functions describing their uses Vishal Moola (Oracle) (34): mm: Add PAGE_TYPE_OP folio functions s390

Re: [PATCH mm-unstable v2 05/10] kvm/arm64: add kvm_arch_test_clear_young()

2023-05-31 Thread Yu Zhao
On Wed, May 31, 2023 at 1:56 PM Oliver Upton wrote: > > Hi Yu, > > On Fri, May 26, 2023 at 05:44:30PM -0600, Yu Zhao wrote: > > Implement kvm_arch_test_clear_young() to support the fast path in > > mmu_notifier_ops->test_clear_young(). > > > > It focuses on a simple case, i.e., hardware sets the

[powerpc:topic/cpu-smt] BUILD REGRESSION 7bb712baeffc4640f5511feec68add6f1767413f

2023-05-31 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git topic/cpu-smt branch HEAD: 7bb712baeffc4640f5511feec68add6f1767413f powerpc/pseries: Honour current SMT state when DLPAR onlining CPUs Error/Warning reports:

Re: [PATCH 09/12] mm/khugepaged: retract_page_tables() without mmap or vma lock

2023-05-31 Thread Peter Xu
On Wed, May 31, 2023 at 05:34:58PM +0200, Jann Horn wrote: > On Mon, May 29, 2023 at 8:25 AM Hugh Dickins wrote: > > -static int retract_page_tables(struct address_space *mapping, pgoff_t > > pgoff, > > - struct mm_struct *target_mm, > > -

Re: [PATCH mm-unstable v2 05/10] kvm/arm64: add kvm_arch_test_clear_young()

2023-05-31 Thread Oliver Upton
Hi Yu, On Fri, May 26, 2023 at 05:44:30PM -0600, Yu Zhao wrote: > Implement kvm_arch_test_clear_young() to support the fast path in > mmu_notifier_ops->test_clear_young(). > > It focuses on a simple case, i.e., hardware sets the accessed bit in > KVM PTEs and VMs are not protected, where it can

Re: [PATCH 08/12] mm/pgtable: add pte_free_defer() for pgtable as page

2023-05-31 Thread Jason Gunthorpe
On Sun, May 28, 2023 at 11:23:47PM -0700, Hugh Dickins wrote: > Add the generic pte_free_defer(), to call pte_free() via call_rcu(). > pte_free_defer() will be called inside khugepaged's retract_page_tables() > loop, where allocating extra memory cannot be relied upon. This version > suits all

Re: [PATCH 02/12] mm/pgtable: add PAE safety to __pte_offset_map()

2023-05-31 Thread Jason Gunthorpe
On Sun, May 28, 2023 at 11:16:16PM -0700, Hugh Dickins wrote: > There is a faint risk that __pte_offset_map(), on a 32-bit architecture > with a 64-bit pmd_t e.g. x86-32 with CONFIG_X86_PAE=y, would succeed on > a pmdval assembled from a pmd_low and a pmd_high which never belonged > together:

Re: [PATCH mm-unstable v2 04/10] kvm/arm64: make stage2 page tables RCU safe

2023-05-31 Thread Oliver Upton
On Tue, May 30, 2023 at 02:06:55PM -0600, Yu Zhao wrote: > On Tue, May 30, 2023 at 1:37 PM Oliver Upton wrote: > > > > Hi Yu, > > > > On Sat, May 27, 2023 at 02:13:07PM -0600, Yu Zhao wrote: > > > On Sat, May 27, 2023 at 12:08 PM Oliver Upton > > > wrote: > > > > diff --git

Re: [PATCH mm-unstable v2 02/10] mm/kvm: use mmu_notifier_ops->test_clear_young()

2023-05-31 Thread Jason Gunthorpe
On Fri, May 26, 2023 at 05:44:27PM -0600, Yu Zhao wrote: > Replace test_young() and clear_young() with test_clear_young(). > > Signed-off-by: Yu Zhao > --- > include/linux/mmu_notifier.h | 29 ++- > include/trace/events/kvm.h | 15 -- > mm/mmu_notifier.c|

Re: [PATCH] MAINTAINERS: Exclude m68k-only drivers from powerpc entry

2023-05-31 Thread Michael Schmitz
Hi Geert, On 1/06/23 00:59, Geert Uytterhoeven wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11916,6 +11916,8 @@ L: linuxppc-dev@lists.ozlabs.org S: Odd Fixes F: arch/powerpc/platforms/powermac/ F: drivers/macintosh/ +X: drivers/macintosh/adb-iop.c +X:

Re: [PATCH mm-unstable v2 01/10] mm/kvm: add mmu_notifier_ops->test_clear_young()

2023-05-31 Thread Jason Gunthorpe
On Fri, May 26, 2023 at 05:44:26PM -0600, Yu Zhao wrote: > @@ -122,6 +124,10 @@ struct mmu_notifier_ops { > struct mm_struct *mm, > unsigned long address); > > + int (*test_clear_young)(struct mmu_notifier *mn, struct mm_struct *mm, > +

Re: [PATCH v8 0/7] Add pci_dev_for_each_resource() helper and update users

2023-05-31 Thread Jonas Gorski
Hi, On Tue, 30 May 2023 at 23:34, Bjorn Helgaas wrote: > On Fri, May 12, 2023 at 02:48:51PM -0500, Bjorn Helgaas wrote: > > On Fri, May 12, 2023 at 01:56:29PM +0300, Andy Shevchenko wrote: > > > On Tue, May 09, 2023 at 01:21:22PM -0500, Bjorn Helgaas wrote: > > > > On Tue, Apr 04, 2023 at

Re: [PATCH 09/12] mm/khugepaged: retract_page_tables() without mmap or vma lock

2023-05-31 Thread Peter Xu
On Tue, May 30, 2023 at 05:38:25PM -0700, Hugh Dickins wrote: > Thanks for looking, Peter: I was well aware of you dropping several hints > that you wanted to see what's intended before passing judgment on earlier > series, and I preferred to get on with showing this series, than go into > detail

Re: [PATCH 00/12] mm: free retracted page table by RCU

2023-05-31 Thread Jann Horn
On Mon, May 29, 2023 at 8:11 AM Hugh Dickins wrote: > Here is the third series of patches to mm (and a few architectures), based > on v6.4-rc3 with the preceding two series applied: in which khugepaged > takes advantage of pte_offset_map[_lock]() allowing for pmd transitions. To clarify: Part of

Re: [PATCH 10/12] mm/khugepaged: collapse_pte_mapped_thp() with mmap_read_lock()

2023-05-31 Thread Jann Horn
On Mon, May 29, 2023 at 8:26 AM Hugh Dickins wrote: > Bring collapse_and_free_pmd() back into collapse_pte_mapped_thp(). > It does need mmap_read_lock(), but it does not need mmap_write_lock(), > nor vma_start_write() nor i_mmap lock nor anon_vma lock. All racing > paths are relying on

Re: [PATCH 01/12] mm/pgtable: add rcu_read_lock() and rcu_read_unlock()s

2023-05-31 Thread Jann Horn
On Mon, May 29, 2023 at 8:15 AM Hugh Dickins wrote: > Before putting them to use (several commits later), add rcu_read_lock() > to pte_offset_map(), and rcu_read_unlock() to pte_unmap(). Make this a > separate commit, since it risks exposing imbalances: prior commits have > fixed all the known

RE: [PATCH v2 RESEND] soc/fsl/qe: fix usb.c build errors

2023-05-31 Thread Leo Li
> -Original Message- > From: Randy Dunlap > Sent: Sunday, May 21, 2023 5:52 PM > To: linux-ker...@vger.kernel.org > Cc: Randy Dunlap ; kernel test robot > ; Michael Ellerman ; Christophe > Leroy ; Leo Li ; > Masahiro Yamada ; Nicolas Schier > ; Qiang Zhao ; linuxppc-dev > ;

Re: [PATCH 09/12] mm/khugepaged: retract_page_tables() without mmap or vma lock

2023-05-31 Thread Jann Horn
On Mon, May 29, 2023 at 8:25 AM Hugh Dickins wrote: > -static int retract_page_tables(struct address_space *mapping, pgoff_t pgoff, > - struct mm_struct *target_mm, > - unsigned long target_addr, struct page *hpage, > -

[powerpc:topic/cpu-smt 6/9] kernel/cpu.c:2583:36: error: 'cpu_smt_max_threads' undeclared; did you mean 'cpu_smt_num_threads'?

2023-05-31 Thread kernel test robot
/0day-ci/archive/20230531/202305312356.sfvj8iwh-...@intel.com/config) compiler: hppa-linux-gcc (GCC) 12.3.0 reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin

Re: [PATCH] MAINTAINERS: Exclude m68k-only drivers from powerpc entry

2023-05-31 Thread Geert Uytterhoeven
Hi Michael, CC Finn On Wed, May 31, 2023 at 2:50 PM Michael Ellerman wrote: > The powerpc section has a "F:" entry for drivers/macintosh, matching all > files in or below drivers/macintosh. That is correct for the most part, > but there are a couple of m68k-only drivers in the directory, so

[PATCH] MAINTAINERS: Exclude m68k-only drivers from powerpc entry

2023-05-31 Thread Michael Ellerman
The powerpc section has a "F:" entry for drivers/macintosh, matching all files in or below drivers/macintosh. That is correct for the most part, but there are a couple of m68k-only drivers in the directory, so exclude those. Signed-off-by: Michael Ellerman --- MAINTAINERS | 2 ++ 1 file

Re: [PATCH v2 RESEND] soc/fsl/qe: fix usb.c build errors

2023-05-31 Thread Nicolas Schier
On Sun, May 21, 2023 at 03:52:16PM -0700 Randy Dunlap wrote: > Fix build errors in soc/fsl/qe/usb.c when QUICC_ENGINE is not set. > This happens when PPC_EP88XC is set, which selects CPM1 & CPM. > When CPM is set, USB_FSL_QE can be set without QUICC_ENGINE > being set. When USB_FSL_QE is set,

Re: [PATCH v2 0/3] Remove iommu_group_remove_device() from fsl

2023-05-31 Thread Michael Ellerman
Jason Gunthorpe writes: > On Tue, May 30, 2023 at 10:03:53PM +1000, Michael Ellerman wrote: >> Jason Gunthorpe writes: >> > On Tue, May 23, 2023 at 08:26:32AM +0200, Joerg Roedel wrote: >> >> On Tue, May 16, 2023 at 09:35:25PM -0300, Jason Gunthorpe wrote: >> >> > With POWER SPAPR now having a