Re: [PATCH v2 14/16] powerpc/book3s64/vmemmap: Switch radix to use a different vmemmap handling function

2023-06-27 Thread Aneesh Kumar K V
On 6/28/23 7:03 AM, Ritesh Harjani (IBM) wrote: > "Aneesh Kumar K.V" writes: >> +int __meminit vmemmap_check_pmd(pmd_t *pmd, int node, >> +unsigned long addr, unsigned long next) >> +{ >> +int large = pmd_large(*pmd); >> + >> +if (pmd_large(*pmd)) > >

Re: [PATCH v2 13/16] powerpc/book3s64/mm: Enable transparent pud hugepage

2023-06-27 Thread Aneesh Kumar K V
On 6/28/23 6:53 AM, Ritesh Harjani (IBM) wrote: > "Aneesh Kumar K.V" writes: >> >> static inline pmd_t radix__pmd_mkdevmap(pmd_t pmd) >> @@ -292,9 +320,18 @@ static inline pmd_t radix__pmd_mkdevmap(pmd_t pmd) >> return __pmd(pmd_val(pmd) | (_PAGE_PTE | _PAGE_DEVMAP)); >> } >> >>

[PATCH net-next 10/10] net: wan: Remove unnecessary (void*) conversions

2023-06-27 Thread wuych
Pointer variables of void * type do not require type cast. Signed-off-by: wuych --- drivers/net/wan/fsl_ucc_hdlc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index 47c2ad7a3e42..91e37c3dcbee 100644 ---

[PATCH net-next 00/10] Remove unnecessary (void*) conversions

2023-06-27 Thread wuych
Remove (void*) conversions under "drivers/net" directory. According to the suggestion[1] of Jakub Kicinski, send these patches in series of 10. wuych (10): net: dsa: ar9331: remove unnecessary (void*) conversions net: dsa: qca8k: remove unnecessary (void*) conversions

[powerpc:next] BUILD SUCCESS 54a11654de163994e32b24e3aa90ef81f4a3184d

2023-06-27 Thread kernel test robot
successfully. More configs may be tested in the coming days. tested configs: alphaalldefconfig gcc alphaallyesconfig gcc alpha defconfig gcc alpharandconfig-r012-20230627 gcc alpha

Re: [PATCH v2 12/16] mm/vmemmap optimization: Split hugetlb and devdax vmemmap optimization

2023-06-27 Thread Aneesh Kumar K V
On 6/28/23 6:39 AM, Ritesh Harjani (IBM) wrote: > "Aneesh Kumar K.V" writes: > >> Arm disabled hugetlb vmemmap optimization [1] because hugetlb vmemmap >> optimization includes an update of both the permissions (writeable to >> read-only) and the output address (pfn) of the vmemmap ptes. That is

Re: [PATCH v2 14/16] powerpc/book3s64/vmemmap: Switch radix to use a different vmemmap handling function

2023-06-27 Thread IBM
"Aneesh Kumar K.V" writes: > This is in preparation to update radix to implement vmemmap optimization > for devdax. Below are the rules w.r.t radix vmemmap mapping > > 1. First try to map things using PMD (2M) > 2. With altmap if altmap cross-boundary check returns true, fall back to >

Re: [PATCH v2 13/16] powerpc/book3s64/mm: Enable transparent pud hugepage

2023-06-27 Thread IBM
"Aneesh Kumar K.V" writes: These are just some minor nits in case you are going to send another revision. > This is enabled only with radix translation and 1G hugepage size. This will > be used with devdax device memory with a namespace alignment of 1G. > > Anon transparent hugepage is not

Re: [PATCH v2 12/16] mm/vmemmap optimization: Split hugetlb and devdax vmemmap optimization

2023-06-27 Thread IBM
"Aneesh Kumar K.V" writes: > Arm disabled hugetlb vmemmap optimization [1] because hugetlb vmemmap > optimization includes an update of both the permissions (writeable to > read-only) and the output address (pfn) of the vmemmap ptes. That is not > supported without unmapping of pte(marking it

[powerpc:merge] BUILD SUCCESS 034451183057cb1f6d0089f86214a8f8171bcaca

2023-06-27 Thread kernel test robot
successfully. More configs may be tested in the coming days. tested configs: alphaallyesconfig gcc alpha defconfig gcc alpharandconfig-r002-20230627 gcc alpharandconfig-r016-20230627 gcc alpha

Re: [PATCH v5 26/33] nios2: Convert __pte_free_tlb() to use ptdescs

2023-06-27 Thread Guenter Roeck
(or the rest of the patchset). No, I did not try to apply this patch on its own. I tried to build yesterday's pending-fixes branch of linux-next. A quick check shows that the build fails with next-20230627. See log below. Ah it looks like this one slipped into -next on its own somehow? Stephen

Re: [PATCH v5 26/33] nios2: Convert __pte_free_tlb() to use ptdescs

2023-06-27 Thread Dinh Nguyen
). No, I did not try to apply this patch on its own. I tried to build yesterday's pending-fixes branch of linux-next. A quick check shows that the build fails with next-20230627. See log below. Ah it looks like this one slipped into -next on its own somehow? Stephen, please drop this patch

Re: [PATCH v5 26/33] nios2: Convert __pte_free_tlb() to use ptdescs

2023-06-27 Thread Guenter Roeck
. I tried to build yesterday's pending-fixes branch of linux-next. A quick check shows that the build fails with next-20230627. See log below. Ah it looks like this one slipped into -next on its own somehow? Stephen, please drop this patch from -next; it shouldn't be in without the rest

Re: [PATCH v2 05/12] powerpc: add pte_free_defer() for pgtables sharing page

2023-06-27 Thread Hugh Dickins
On Tue, 27 Jun 2023, Jason Gunthorpe wrote: > On Wed, Jun 21, 2023 at 07:36:11PM -0700, Hugh Dickins wrote: > > [PATCH v3 05/12] powerpc: add pte_free_defer() for pgtables sharing page ... > Yes, this makes sense to me, very simple.. > > I always for get these details but atomic_dec_and_test() is

Re: [PATCH v6 00/33] Split ptdesc from struct page

2023-06-27 Thread Hugh Dickins
On Tue, 27 Jun 2023, Matthew Wilcox wrote: > On Mon, Jun 26, 2023 at 09:44:08PM -0700, Hugh Dickins wrote: > > On Mon, 26 Jun 2023, Vishal Moola (Oracle) wrote: > > > > > The MM subsystem is trying to shrink struct page. This patchset > > > introduces a memory descriptor for page table tracking -

Re: [PATCH v6 00/33] Split ptdesc from struct page

2023-06-27 Thread Hugh Dickins
On Tue, 27 Jun 2023, David Hildenbrand wrote: > On 27.06.23 06:44, Hugh Dickins wrote: > > On Mon, 26 Jun 2023, Vishal Moola (Oracle) wrote: > > > >> The MM subsystem is trying to shrink struct page. This patchset > >> introduces a memory descriptor for page table tracking - struct ptdesc. > >

Re: [PATCH v5 26/33] nios2: Convert __pte_free_tlb() to use ptdescs

2023-06-27 Thread Dinh Nguyen
-fixes branch of linux-next. A quick check shows that the build fails with next-20230627. See log below. Ah it looks like this one slipped into -next on its own somehow? Stephen, please drop this patch from -next; it shouldn't be in without the rest of the patchset which I intend to have Andrew

Re: [PATCH v5 26/33] nios2: Convert __pte_free_tlb() to use ptdescs

2023-06-27 Thread Vishal Moola
s architecture and it worked, but let me know if something fails > >> when its applied on top of those patches (or the rest of the patchset). > > > > > > No, I did not try to apply this patch on its own. I tried to build > > yesterday's > > pending-fixes branch of

Re: [PATCH v5 26/33] nios2: Convert __pte_free_tlb() to use ptdescs

2023-06-27 Thread Guenter Roeck
and it worked, but let me know if something fails when its applied on top of those patches (or the rest of the patchset). No, I did not try to apply this patch on its own. I tried to build yesterday's pending-fixes branch of linux-next. A quick check shows that the build fails with next-20230627. See log

Re: [PATCH 3/3] mm/lru_gen: Don't build multi-gen LRU page table walk code on architecture not supported

2023-06-27 Thread Yu Zhao
On Tue, Jun 27, 2023 at 5:48 AM Aneesh Kumar K V wrote: > > On 6/26/23 10:34 PM, Yu Zhao wrote: > > On Mon, Jun 26, 2023 at 4:52 AM Aneesh Kumar K V > > wrote: > >> > >> On 6/26/23 1:04 AM, Yu Zhao wrote: > >>> On Sat, Jun 24, 2023 at 8:54 AM Aneesh Kumar K.V > >>> wrote: > > Hi Yu

Re: [PATCH v5 26/33] nios2: Convert __pte_free_tlb() to use ptdescs

2023-06-27 Thread Guenter Roeck
On 6/27/23 10:42, Vishal Moola wrote: On Mon, Jun 26, 2023 at 10:47 PM Guenter Roeck wrote: On Thu, Jun 22, 2023 at 01:57:38PM -0700, Vishal Moola (Oracle) wrote: Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle)

Re: [PATCH v6 03/33] pgtable: Create struct ptdesc

2023-06-27 Thread Vishal Moola
On Tue, Jun 27, 2023 at 9:07 AM Peter Xu wrote: > > On Mon, Jun 26, 2023 at 08:14:01PM -0700, Vishal Moola (Oracle) wrote: > > Currently, page table information is stored within struct page. As part > > of simplifying struct page, create struct ptdesc for page table > > information. > > > >

Re: [PATCH v5 26/33] nios2: Convert __pte_free_tlb() to use ptdescs

2023-06-27 Thread Vishal Moola
On Mon, Jun 26, 2023 at 10:47 PM Guenter Roeck wrote: > > On Thu, Jun 22, 2023 at 01:57:38PM -0700, Vishal Moola (Oracle) wrote: > > Part of the conversions to replace pgtable constructor/destructors with > > ptdesc equivalents. > > > > Signed-off-by: Vishal Moola (Oracle) > > Acked-by: Mike

Re: [PATCH v2 05/12] powerpc: add pte_free_defer() for pgtables sharing page

2023-06-27 Thread Jason Gunthorpe
On Wed, Jun 21, 2023 at 07:36:11PM -0700, Hugh Dickins wrote: > [PATCH v3 05/12] powerpc: add pte_free_defer() for pgtables sharing page > > Add powerpc-specific pte_free_defer(), to free table page via call_rcu(). > pte_free_defer() will be called inside khugepaged's retract_page_tables() >

Re: [PATCH 21/21] dma-mapping: replace custom code with generic implementation

2023-06-27 Thread Geert Uytterhoeven
On Thu, Apr 13, 2023 at 2:52 PM Arnd Bergmann wrote: > On Thu, Apr 13, 2023, at 14:13, Biju Das wrote: > > FYI, this patch breaks on RZ/G2L SMARC EVK board and Arnd will send V2 > > for fixing this issue. > > > > [10:53] [3.384408] Unable to handle kernel paging request at > > virtual

Re: [PATCH v6 03/33] pgtable: Create struct ptdesc

2023-06-27 Thread Peter Xu
On Mon, Jun 26, 2023 at 08:14:01PM -0700, Vishal Moola (Oracle) wrote: > Currently, page table information is stored within struct page. As part > of simplifying struct page, create struct ptdesc for page table > information. > > Signed-off-by: Vishal Moola (Oracle) > Acked-by: Mike Rapoport

Re: [PATCH v6 00/33] Split ptdesc from struct page

2023-06-27 Thread Matthew Wilcox
On Mon, Jun 26, 2023 at 09:44:08PM -0700, Hugh Dickins wrote: > On Mon, 26 Jun 2023, Vishal Moola (Oracle) wrote: > > > The MM subsystem is trying to shrink struct page. This patchset > > introduces a memory descriptor for page table tracking - struct ptdesc. > ... > > 39 files changed, 686

Re: [PATCH] powerpc: remove checks for binutils older than 2.25

2023-06-27 Thread Michael Ellerman
Masahiro Yamada writes: > On Thu, Jan 19, 2023 at 9:37 PM Masahiro Yamada wrote: >> >> On Thu, Jan 19, 2023 at 9:12 PM Joel Stanley wrote: >> > >> > On Thu, 19 Jan 2023 at 08:24, Masahiro Yamada wrote: >> > > >> > > Commit e4412739472b ("Documentation: raise minimum supported version of >> > >

Re: objtool: Seeking help for improving switch table processing

2023-06-27 Thread Peter Zijlstra
On Sat, Jun 24, 2023 at 10:06:23AM +, Christophe Leroy wrote: > Hello Josh and Peter, > > As mentionned in the cover letter of my series "powerpc/objtool: uaccess > validation for PPC32 (v3)" [1], a few switch table lookup fail, and it > would help if you had ideas on how to handle them. >

Re: [PATCH 13/22] tools/perf/tests: Fix shellcheck warning for coresight.sh shell script

2023-06-27 Thread James Clark
On 21/06/2023 09:30, Athira Rajeev wrote: > From: Kajol Jain > > Running shellcheck on coresight.sh throws below warning: > > In lib/coresight.sh line 1: > ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a > shebang or a 'shell' directive. > > In lib/coresight.sh

Re: [PATCH v6 00/33] Split ptdesc from struct page

2023-06-27 Thread David Hildenbrand
On 27.06.23 06:44, Hugh Dickins wrote: On Mon, 26 Jun 2023, Vishal Moola (Oracle) wrote: The MM subsystem is trying to shrink struct page. This patchset introduces a memory descriptor for page table tracking - struct ptdesc. ... 39 files changed, 686 insertions(+), 455 deletions(-) I

Re: [PATCH 00/22] tools/perf: Fix shellcheck coding/formatting issues of perf tool shell scripts

2023-06-27 Thread Athira Rajeev
> On 24-Jun-2023, at 5:10 AM, Namhyung Kim wrote: > > Hello, > > On Wed, Jun 21, 2023 at 1:30 AM Athira Rajeev > wrote: >> >> Patchset covers a set of fixes for coding/formatting issues observed while >> running shellcheck tool on the perf shell scripts. >> >> This cleanup is a