Re: [PATCH v7 1/3 RESEND] block:sed-opal: SED Opal keystore

2023-08-16 Thread Hannes Reinecke
On 7/21/23 23:19, gjo...@linux.vnet.ibm.com wrote: From: Greg Joyce Add read and write functions that allow SED Opal keys to stored in a permanent keystore. Probably state that these are dummy functions only. Signed-off-by: Greg Joyce Reviewed-by: Jonathan Derrick --- block/Makefile

Re: [PATCH v7 3/3 RESEND] powerpc/pseries: PLPKS SED Opal keystore support

2023-08-16 Thread Hannes Reinecke
On 7/21/23 23:19, gjo...@linux.vnet.ibm.com wrote: From: Greg Joyce Define operations for SED Opal to read/write keys from POWER LPAR Platform KeyStore(PLPKS). This allows non-volatile storage of SED Opal keys. Signed-off-by: Greg Joyce Reviewed-by: Jonathan Derrick ---

Re: [PATCH v7 2/3 RESEND] block: sed-opal: keystore access for SED Opal keys

2023-08-16 Thread Hannes Reinecke
On 7/21/23 23:19, gjo...@linux.vnet.ibm.com wrote: From: Greg Joyce Allow for permanent SED authentication keys by reading/writing to the SED Opal non-volatile keystore. Signed-off-by: Greg Joyce Reviewed-by: Jonathan Derrick --- block/sed-opal.c | 18 -- 1 file changed,

Re: [PATCH] treewide: drop CONFIG_EMBEDDED

2023-08-16 Thread Michael Ellerman
Randy Dunlap writes: > There is only one Kconfig user of CONFIG_EMBEDDED and it can be > switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). > > Signed-off-by: Randy Dunlap ... > arch/powerpc/configs/40x/klondike_defconfig |2 +- >

Re: [PATCH v3 5/6] KVM: PPC: Add support for nestedv2 guests

2023-08-16 Thread Michael Ellerman
Jordan Niethe writes: > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > index 2357545dffd7..7d5edbc6ecd9 100644 > --- a/arch/powerpc/kvm/book3s_hv.c > +++ b/arch/powerpc/kvm/book3s_hv.c > @@ -4165,7 +4231,10 @@ static int kvmhv_p9_guest_entry(struct kvm_vcpu *vcpu, >

Re: [PATCH v3 1/6] KVM: PPC: Use getters and setters for vcpu register state

2023-08-16 Thread Michael Ellerman
Jordan Niethe writes: > There are already some getter and setter functions used for accessing > vcpu register state, e.g. kvmppc_get_pc(). There are also more > complicated examples that are generated by macros like > kvmppc_get_sprg0() which are generated by the SHARED_SPRNG_WRAPPER() > macro. >

Re: [PATCH] treewide: drop CONFIG_EMBEDDED

2023-08-16 Thread Randy Dunlap
Hi Jesse, On 8/16/23 15:45, Jesse Taube wrote: > Hi, Randy > >> diff -- a/init/Kconfig b/init/Kconfig >> --- a/init/Kconfig >> +++ b/init/Kconfig >> @@ -1790,14 +1790,6 @@ config DEBUG_RSEQ >> >>    If unsure, say N. >> >> -config EMBEDDED >> -    bool "Embedded system" >> -    select EXPERT

Re: [PATCH] powerpc/ps3: refactor strncpy usage

2023-08-16 Thread Kees Cook
On Wed, Aug 16, 2023 at 09:39:24PM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > `make_first_field()` should use similar implementation to `make_field()` > due to memcpy having more obvious behavior here. The end result yields > the

[PATCH v2 4/4] arch/powerpc/configs/*_defconfig cleanup

2023-08-16 Thread Trevor Woerner
Drop CONFIG_IP_NF_TARGET_CLUSTERIP as it was removed in commit 57f8e00d8a82 ("usb: 71 musb: Drop old unused am35x glue layer"). Signed-off-by: Trevor Woerner --- arch/powerpc/configs/ppc6xx_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/configs/ppc6xx_defconfig

[PATCH v2 3/4] arch/mips/configs/*_defconfig cleanup

2023-08-16 Thread Trevor Woerner
Drop CONFIG_IP_NF_TARGET_CLUSTERIP from any remaining mips defconfigs as it was removed in commit 57f8e00d8a82 ("usb: 71 musb: Drop old unused am35x glue layer"). Signed-off-by: Trevor Woerner --- arch/mips/configs/ip22_defconfig| 1 - arch/mips/configs/malta_defconfig | 1 -

[PATCH v2 2/4] arch/loongarch/configs/*_defconfig cleanup

2023-08-16 Thread Trevor Woerner
Drop CONFIG_IP_NF_TARGET_CLUSTERIP as it was removed in commit 57f8e00d8a82 ("usb: 71 musb: Drop old unused am35x glue layer"). Drop CONFIG_NFT_OBJREF as it was removed in commit d037abc2414b ("netfilter: nft_objref: make it builtin"). Signed-off-by: Trevor Woerner ---

[PATCH v2 0/4] general defconfig cleanups

2023-08-16 Thread Trevor Woerner
Drop config options from defconfigs whose code has been removed. v2: Generate arch-specific patches. In v1 I organized the patches by CONFIG_ option which caused some of the patches to cross architectural lines. This requires cross-arch consensus before they can be applied. Therefore organize the

[PATCH v2 1/4] arch/arm/configs/*_defconfig cleanup

2023-08-16 Thread Trevor Woerner
Drop CONFIG_NF_LOG_NETDEV as it was removed in commit 1510618e45cb ("netfilter: nf_log_netdev: merge with nf_log_syslog"). Drop CONFIG_NFT_COUNTER as it was removed in commit 023223dfbfb3 ("netfilter: nf_tables: make counter support built-in"). Drop CONFIG_NF_FLOW_TABLE_IPV6 and

Re: [PATCH v2] powerpc/rtas_flash: allow user copy to flash block cache objects

2023-08-16 Thread Michael Ellerman
On Thu, 10 Aug 2023 22:37:55 -0500, Nathan Lynch wrote: > With hardened usercopy enabled (CONFIG_HARDENED_USERCOPY=y), using the > /proc/powerpc/rtas/firmware_update interface to prepare a system > firmware update yields a BUG(): > > kernel BUG at mm/usercopy.c:102! > Oops: Exception in kernel

Re: [PATCH] treewide: drop CONFIG_EMBEDDED

2023-08-16 Thread Jesse Taube
Hi, Randy > diff -- a/init/Kconfig b/init/Kconfig > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -1790,14 +1790,6 @@ config DEBUG_RSEQ > > If unsure, say N. > > -config EMBEDDED > - bool "Embedded system" > - select EXPERT > - help > -This option should be enabled if compiling the

Re: [PATCH 00/17] -Wmissing-prototype warning fixes

2023-08-16 Thread Palmer Dabbelt
On Thu, 10 Aug 2023 07:19:18 PDT (-0700), a...@kernel.org wrote: From: Arnd Bergmann Most of the patches I sent so far for the -Wmissing-prototype warnings have made it into linux-next now. There are a few that I'm resending now as nobody has picked them up, and then a number of fixes that I

Re: [PATCH] treewide: drop CONFIG_EMBEDDED

2023-08-16 Thread Jason A. Donenfeld
On Wed, Aug 16, 2023 at 7:50 AM Randy Dunlap wrote: > > There is only one Kconfig user of CONFIG_EMBEDDED and it can be > switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). > > Signed-off-by: Randy Dunlap > Cc: Russell King > Cc: linux-arm-ker...@lists.infradead.org > Cc: Arnd

Re: [PATCH] treewide: drop CONFIG_EMBEDDED

2023-08-16 Thread Greg Ungerer
On 16/8/23 15:50, Randy Dunlap wrote: There is only one Kconfig user of CONFIG_EMBEDDED and it can be switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). Signed-off-by: Randy Dunlap Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org Cc: Arnd Bergmann Cc: Jason A.

[PATCH] powerpc/ps3: refactor strncpy usage

2023-08-16 Thread Justin Stitt
; + u64 n = 0; - strncpy((char *), text, 8); + memcpy((char *), text, strnlen(text, sizeof(n))); return PS3_VENDOR_ID_NONE + (n >> 32) + index; } --- base-commit: 2ccdd1b13c591d306f0401d98dedc4bdcd02b421 change-id: 20230816-strncpy-arch-powerpc-platfor

Re: [PATCH v4 6/6] integrity: PowerVM support for loading third party code signing keys

2023-08-16 Thread Jarkko Sakkinen
On Thu Aug 17, 2023 at 12:06 AM EEST, Mimi Zohar wrote: > On Wed, 2023-08-16 at 23:36 +0300, Jarkko Sakkinen wrote: > > On Tue Aug 15, 2023 at 2:27 PM EEST, Nayna Jain wrote: > > > On secure boot enabled PowerVM LPAR, third party code signing keys are > > > needed during early boot to verify

Re: [PATCH v2] powerpc/rtas_flash: allow user copy to flash block cache objects

2023-08-16 Thread Kees Cook
On Thu, Aug 10, 2023 at 10:37:55PM -0500, Nathan Lynch via B4 Relay wrote: > From: Nathan Lynch > > With hardened usercopy enabled (CONFIG_HARDENED_USERCOPY=y), using the > /proc/powerpc/rtas/firmware_update interface to prepare a system > firmware update yields a BUG(): > > kernel BUG at

Re: [PATCH v4 6/6] integrity: PowerVM support for loading third party code signing keys

2023-08-16 Thread Mimi Zohar
On Wed, 2023-08-16 at 23:36 +0300, Jarkko Sakkinen wrote: > On Tue Aug 15, 2023 at 2:27 PM EEST, Nayna Jain wrote: > > On secure boot enabled PowerVM LPAR, third party code signing keys are > > needed during early boot to verify signed third party modules. These > > third party keys are stored in

Re: [PATCH v3 2/6] integrity: ignore keys failing CA restrictions on non-UEFI platform

2023-08-16 Thread Jarkko Sakkinen
On Wed Aug 16, 2023 at 3:58 PM EEST, Mimi Zohar wrote: > On Mon, 2023-08-14 at 20:38 +0300, Jarkko Sakkinen wrote: > > On Sun Aug 13, 2023 at 5:15 AM EEST, Nayna Jain wrote: > > > On non-UEFI platforms, handle restrict_link_by_ca failures differently. > > > > > > Certificates which do not satisfy

Re: [PATCH v5 0/3 RESEND] sed-opal: keyrings, discovery, revert, key store

2023-08-16 Thread Jarkko Sakkinen
On Wed Aug 16, 2023 at 10:45 PM EEST, Greg Joyce wrote: > It's been almost 4 weeks since the last resend and there haven't been > any comments. Is there anything that needs to be changed for > acceptance? > > Thanks for your input. > > Greg > > On Fri, 2023-07-21 at 16:15 -0500,

Re: [PATCH v4 6/6] integrity: PowerVM support for loading third party code signing keys

2023-08-16 Thread Jarkko Sakkinen
On Tue Aug 15, 2023 at 2:27 PM EEST, Nayna Jain wrote: > On secure boot enabled PowerVM LPAR, third party code signing keys are > needed during early boot to verify signed third party modules. These > third party keys are stored in moduledb object in the Platform > KeyStore (PKS). > > Load third

Re: [PATCH v4 1/6] integrity: PowerVM support for loading CA keys on machine keyring

2023-08-16 Thread Jarkko Sakkinen
On Tue Aug 15, 2023 at 2:27 PM EEST, Nayna Jain wrote: > Keys that derive their trust from an entity such as a security officer, > administrator, system owner, or machine owner are said to have "imputed > trust". CA keys with imputed trust can be loaded onto the machine keyring. > The mechanism

Re: [PATCH v5 0/3 RESEND] sed-opal: keyrings, discovery, revert, key store

2023-08-16 Thread Greg Joyce
It's been almost 4 weeks since the last resend and there haven't been any comments. Is there anything that needs to be changed for acceptance? Thanks for your input. Greg On Fri, 2023-07-21 at 16:15 -0500, gjo...@linux.vnet.ibm.com wrote: > From: Greg Joyce > > This patchset has gone through

Re: [PATCH v8 1/2] powerpc/rtas: Rename rtas_error_rc to rtas_generic_errno

2023-08-16 Thread Mahesh J Salgaonkar
On 2023-08-15 13:52:14 Tue, Michael Ellerman wrote: > Mahesh Salgaonkar writes: > > rtas_generic_errno() function will convert the generic rtas return codes > > into errno. > > I don't see the point of renaming it, it just creates unnecessary churn. > The existing name seems OK to me. Sure.

Re: KASAN debug kernel fails to boot at early stage when CONFIG_SMP=y is set (kernel 6.5-rc5, PowerMac G4 3,6)

2023-08-16 Thread Christophe Leroy
Le 15/08/2023 à 22:01, Erhard Furtner a écrit : > On Tue, 15 Aug 2023 17:25:13 + > Christophe Leroy wrote: > >> I just sent a patch with additional pr_info() in order to help locate >> the issue, please provide output with that patch. >> >> Thanks >> Christophe > > Thanks for your efforts

Re: [PATCH v4 1/2] PCI: layerscape: Add support for Link down notification

2023-08-16 Thread Frank Li
On Mon, Jul 31, 2023 at 11:06:31AM -0400, Frank Li wrote: > On Thu, Jul 20, 2023 at 09:58:33AM -0400, Frank Li wrote: > > Add support to pass Link down notification to Endpoint function driver > > so that the LINK_DOWN event can be processed by the function. > > > > Acked-by: Manivannan

Re: [PATCH v3 22/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-08-16 Thread Herve Codina
Hi Linus, On Thu, 10 Aug 2023 10:53:04 +0200 Linus Walleij wrote: > Hi Herve, > > thanks for your patch! > > On Wed, Aug 9, 2023 at 3:28 PM Herve Codina wrote: > > > The Lantiq PEF2256 is a framer and line interface component designed to > > fulfill all required interfacing between an

[PATCH 2/2] powerpc/83xx: Split usb.c

2023-08-16 Thread Christophe Leroy
usb.c contains three independent parts with no common part. Split it. Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/83xx/Makefile | 3 + .../platforms/83xx/{usb.c => usb_831x.c} | 118 -- arch/powerpc/platforms/83xx/usb_834x.c| 90

[PATCH 1/2] powerpc/83xx: Fix style problems in usb.c and remove unneccessary includes from mpc83xx.h

2023-08-16 Thread Christophe Leroy
Replace printk(KERN_WARN with pr_warn( Remove a couple of blank lines Re-align multi-line code. Replace asm/io.h by linux/io.h mpc83xx.h doesn't need linux/device.h or asm/pci-bridge.h Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/83xx/mpc83xx.h | 2 --

[PATCH] powerpc/512x: Make mpc512x_select_reset_compat() static

2023-08-16 Thread Christophe Leroy
mpc512x_select_reset_compat() is only used in the file it is defined. Make it static. Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/512x/mpc512x.h| 1 - arch/powerpc/platforms/512x/mpc512x_shared.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH] powerpc/fsl_pci: Make fsl_add_bridge() static

2023-08-16 Thread Christophe Leroy
Since commit 905e75c46dba ("powerpc/fsl-pci: Unify pci/pcie initialization code") fsl_add_bridge() is not used anymore outside of fsl_pci.c Make it static. Signed-off-by: Christophe Leroy --- arch/powerpc/sysdev/fsl_pci.c | 2 +- arch/powerpc/sysdev/fsl_pci.h | 1 - 2 files changed, 1

Re: [PATCH v4 5/6] integrity: PowerVM machine keyring enablement

2023-08-16 Thread R Nageswara Sastry
On 15/08/23 4:57 pm, Nayna Jain wrote: Update Kconfig to enable machine keyring and limit to CA certificates on PowerVM. Only key signing CA keys are allowed. Signed-off-by: Nayna Jain Reviewed-and-tested-by: Mimi Zohar Reviewed-by: Jarkko Sakkinen Tested with trustedcadb, moduledb

Re: [PATCH v4 6/6] integrity: PowerVM support for loading third party code signing keys

2023-08-16 Thread R Nageswara Sastry
On 15/08/23 4:57 pm, Nayna Jain wrote: On secure boot enabled PowerVM LPAR, third party code signing keys are needed during early boot to verify signed third party modules. These third party keys are stored in moduledb object in the Platform KeyStore (PKS). Load third party code signing keys

Re: [PATCH v4 4/6] integrity: check whether imputed trust is enabled

2023-08-16 Thread R Nageswara Sastry
On 15/08/23 4:57 pm, Nayna Jain wrote: trust_moklist() is specific to UEFI enabled systems. Other platforms rely only on the Kconfig. Define a generic wrapper named imputed_trust_enabled(). Signed-off-by: Nayna Jain Reviewed-off-by: Mimi Zohar Tested with trustedcadb, moduledb scenarios

Re: [PATCH v4 3/6] integrity: remove global variable from machine_keyring.c

2023-08-16 Thread R Nageswara Sastry
On 15/08/23 4:57 pm, Nayna Jain wrote: trust_mok variable is accessed within a single function locally. Change trust_mok from global to local static variable. Signed-off-by: Nayna Jain Reviewed-and-tested-by: Mimi Zohar Reviewed-by: Jarkko Sakkinen Tested with trustedcadb, moduledb

Re: [PATCH v4 2/6] integrity: ignore keys failing CA restrictions on non-UEFI platform

2023-08-16 Thread R Nageswara Sastry
On 15/08/23 4:57 pm, Nayna Jain wrote: On non-UEFI platforms, handle restrict_link_by_ca failures differently. Certificates which do not satisfy CA restrictions on non-UEFI platforms are ignored. Signed-off-by: Nayna Jain Reviewed-and-tested-by: Mimi Zohar Acked-by: Jarkko Sakkinen

Re: [PATCH v4 1/6] integrity: PowerVM support for loading CA keys on machine keyring

2023-08-16 Thread R Nageswara Sastry
On 15/08/23 4:57 pm, Nayna Jain wrote: Keys that derive their trust from an entity such as a security officer, administrator, system owner, or machine owner are said to have "imputed trust". CA keys with imputed trust can be loaded onto the machine keyring. The mechanism for loading these

[powerpc:topic/ppc-kvm] BUILD SUCCESS WITH WARNING c95bf4c16099f2ed29a7f6949559bc4187d30710

2023-08-16 Thread kernel test robot
defconfig gcc alpharandconfig-r025-20230816 gcc arc allyesconfig gcc arc defconfig gcc arc nsimosci_hs_smp_defconfig gcc arc randconfig-r022-20230816 gcc arc

[powerpc:next-test] BUILD SUCCESS bfe97da993208d067b676553a494019688e9f405

2023-08-16 Thread kernel test robot
successfully. More configs may be tested in the coming days. tested configs: alphaallyesconfig gcc alpha defconfig gcc alpharandconfig-r006-20230816 gcc arc allyesconfig gcc arc

Re: [PATCH] treewide: drop CONFIG_EMBEDDED

2023-08-16 Thread Palmer Dabbelt
On Tue, 15 Aug 2023 22:50:10 PDT (-0700), rdun...@infradead.org wrote: There is only one Kconfig user of CONFIG_EMBEDDED and it can be switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). Signed-off-by: Randy Dunlap Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org Cc:

Re: [PATCH] treewide: drop CONFIG_EMBEDDED

2023-08-16 Thread Arnd Bergmann
On Wed, Aug 16, 2023, at 07:50, Randy Dunlap wrote: > There is only one Kconfig user of CONFIG_EMBEDDED and it can be > switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). > > Signed-off-by: Randy Dunlap > Cc: Russell King > Cc: linux-arm-ker...@lists.infradead.org > Cc: Arnd

Re: [PATCH v3 2/6] integrity: ignore keys failing CA restrictions on non-UEFI platform

2023-08-16 Thread Mimi Zohar
On Mon, 2023-08-14 at 20:38 +0300, Jarkko Sakkinen wrote: > On Sun Aug 13, 2023 at 5:15 AM EEST, Nayna Jain wrote: > > On non-UEFI platforms, handle restrict_link_by_ca failures differently. > > > > Certificates which do not satisfy CA restrictions on non-UEFI platforms > > are ignored. > > > >

Re: [PATCH v6 08/25] iommu: Reorganize iommu_get_default_domain_type() to respect def_domain_type()

2023-08-16 Thread Jason Gunthorpe
On Tue, Aug 15, 2023 at 09:18:59AM +0800, Baolu Lu wrote: > > /* > > * Try to recover, drivers are allowed to force IDENITY or DMA, IDENTITY > > * takes precedence. > > */ > > if (cur_type || type == IOMMU_DOMAIN_IDENTITY) > > return IOMMU_DOMAIN_IDENTITY; > >

Re: [PATCH] treewide: drop CONFIG_EMBEDDED

2023-08-16 Thread Geert Uytterhoeven
Hi Randy, On Wed, Aug 16, 2023 at 7:50 AM Randy Dunlap wrote: > There is only one Kconfig user of CONFIG_EMBEDDED and it can be > switched to EXPERT or "if !ARCH_MULTIPLATFORM" (suggested by Arnd). > > Signed-off-by: Randy Dunlap Makes perfect sense to me. Acked-by: Geert Uytterhoeven

[powerpc:topic/ppc-kvm 5/6] arch/powerpc/kvm/book3s_hv_nestedv2.c:465:29: warning: variable 'amor' set but not used

2023-08-16 Thread kernel test robot
/archive/20230816/202308161433.p1l5wedy-...@intel.com/config) compiler: powerpc64-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230816/202308161433.p1l5wedy-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version