On Tue, Oct 10, 2023 at 10:46 PM Greg Kroah-Hartman
wrote:
>
> On Tue, Oct 10, 2023 at 10:35:01PM +0530, Anup Patel wrote:
> > We extend the existing RISC-V SBI earlycon support to use the new
> > RISC-V SBI debug console extension.
> >
> > Signed-off-by: Anup Patel
> > ---
> >
On Tue, Oct 10, 2023 at 10:42 PM Greg Kroah-Hartman
wrote:
>
> On Tue, Oct 10, 2023 at 10:35:02PM +0530, Anup Patel wrote:
> > --- a/drivers/tty/hvc/hvc_riscv_sbi.c
> > +++ b/drivers/tty/hvc/hvc_riscv_sbi.c
> > @@ -15,6 +15,7 @@
> >
> > #include "hvc_console.h"
> >
> > +#ifdef
On 10/9/23 1:09 PM, Nathan Lynch wrote:
Hi Haren,
Haren Myneni writes:
The hypervisor returns migration failure if all VAS windows are not
closed. During pre-migration stage, vas_migration_handler() sets
migration_in_progress flag and closes all windows from the list.
The allocate VAS
Sparse reports endianness mismatches in the KVM shared regs getter and
setter helpers.
This code has dynamic endianness behind a safe interface, so a force is
warranted here to tell sparse this is OK.
Signed-off-by: Benjamin Gray
---
arch/powerpc/include/asm/kvm_ppc.h | 8
1 file
Sparse reports an endianness error with the else case of
val = (cpu_endian ? be64_to_cpu(reg_entry->reg_val) :
(u64)(reg_entry->reg_val));
This is a safe operation because the code is explicitly working with
dynamic endianness, so add the __force annotation to tell Sparse to
ignore
Sparse reports dereference of a __user pointer. copy_mc_to_user() takes
a __user pointer, verifies it, then calls the generic copy routine
copy_mc_generic().
As we have verified the pointer, cast out the __user annotation when
passing to copy_mc_generic().
Signed-off-by: Benjamin Gray
---
Sparse reports a warning when casting to an int. There is no need to
cast in the first place, so drop them.
Signed-off-by: Benjamin Gray
---
arch/powerpc/kernel/eeh_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/eeh_driver.c
Sparse reports dereferencing an __iomem pointer. These routines
are clearly low level handlers for IO memory, so force cast away
the __iomem annotation to tell sparse the dereferences are safe.
Signed-off-by: Benjamin Gray
---
arch/powerpc/kernel/io.c | 12 ++--
1 file changed, 6
Sparse reports an endian mismatch with args to opal_int_get_xirr().
Checking the skiboot source[1] shows the function takes a __be32*
(as expected), so update the function declaration to reflect this.
[1]: https://github.com/open-power/skiboot/blob/80e2b1dc73/hw/xive.c#L3479
Signed-off-by:
Sparse reports several function implementations annotated with extern.
This is clearly incorrect, likely just copied from an actual extern
declaration in another file.
Fix the sparse warnings by removing extern.
Signed-off-by: Benjamin Gray
---
arch/powerpc/kernel/iommu.c | 8
Sparse reports several uses of 0 for pointer arguments and comparisons.
Replace with NULL to better convey the intent. Remove entirely if a
comparison to follow the kernel style of implicit boolean conversions.
Signed-off-by: Benjamin Gray
---
arch/powerpc/kernel/setup_64.c| 2 +-
There are many Sparse warnings in the kernel, including the powerpc
directory. This series provides fixes for some low-hanging fruit found
when trying to triage the warnings earlier this year. It addresses about
100 warnings (many have the same root cause).
I know there's concerns about making it
Sparse reports a size mismatch in the endian swap. The Opal
implementation[1] passes the value as a __be64, and the receiving
variable out_qsize is a u64, so the use of be32_to_cpu() appears to be
an error.
[1]: https://github.com/open-power/skiboot/blob/80e2b1dc73/hw/xive.c#L3854
Fixes:
Sparse reports an invalid endian cast here. The code is written for
big endian platforms, so le32_to_cpu() acts as a byte reversal.
This file is checked by sparse on a little endian build though, so
replace the reverse function with the dedicated swab32() function to
better express the intent of
Sparse reports an endian mismatch in hvc_get_chars().
At first it seemed like the retbuf should be __be64[], but actually
retbuf holds serialized registers returned by the hypervisor call, so
it's correctly CPU endian typed.
Instead, it is the be64_to_cpu() that's misleading. The intent is to do
allnoconfig gcc
arc allyesconfig gcc
arc defconfig gcc
arc randconfig-001-20231010 gcc
arm allmodconfig gcc
arm
On Tue, Oct 10, 2023 at 04:07:00PM +0530, Hari Bathini wrote:
>
>
> On 09/10/23 5:00 pm, Pingfan Liu wrote:
> > *** Idea ***
> > For kexec -p, the boot cpu can be not the cpu0, this causes the problem
> > of allocating memory for paca_ptrs[]. However, in theory, there is no
> > requirement to
On Tue, Oct 10, 2023 at 01:56:13PM +0530, Hari Bathini wrote:
>
>
> On 09/10/23 5:00 pm, Pingfan Liu wrote:
> > If the boot_cpuid is smaller than nr_cpus, it requires extra effort to
> > ensure the boot_cpu is in cpu_present_mask. This can be achieved by
> > reserving the last quota for the boot
On Tue, Oct 10, 2023 at 02:38:40PM +0530, Sourabh Jain wrote:
> Hello Pingfan,
>
> >
> > With this patch series applied, the kdump kernel fails to boot on
> > powerpc with nr_cpus=1.
> >
> > Console logs:
> > ---
> > [root]# echo c > /proc/sysrq-trigger
> > [ 74.783235] sysrq:
On Mon, Oct 09, 2023 at 11:19:57PM +, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> NUL-padding is not required as the buffer is already memset to 0:
> |
On Mon, Oct 02, 2023 at 10:55:17AM +0200, Joel Granados via B4 Relay wrote:
> Changes in v2:
> - Left the dangling comma in the ctl_table arrays.
> - Link to v1:
> https://lore.kernel.org/r/20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca...@samsung.com
Thanks! Pushed onto
On Mon, Oct 02, 2023 at 01:30:35PM +0200, Joel Granados via B4 Relay wrote:
> V3:
> * Removed the ia64 patch to avoid conflicts with the ia64 removal
> * Rebased onto v6.6-rc4
> * Kept/added the trailing comma for the ctl_table arrays. This was a comment
> that we received "drivers/*" patch set.
Hi Sourabh,
kernel test robot noticed the following build errors:
[auto build test ERROR on powerpc/next]
[also build test ERROR on powerpc/fixes linus/master v6.6-rc5 next-20231010]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest
: eddc90ea2af5933249ea1a78119f2c8ef8d07156
patch link:
https://lore.kernel.org/r/20231006-papr-sys_rtas-vs-lockdown-v1-5-3a36bfb66e2e%40linux.ibm.com
patch subject: [PATCH 5/7] powerpc/pseries/papr-sysparm: expose chardev API to
user space
config: powerpc64-randconfig-002-20231010
(https://download.01.org
> + unsigned int aborting_passthru:1;
> + unsigned int scan_complete:1;
> int scan_timeout;
> int events_to_log;
> #define IBMVFC_AE_LINKUP 0x0001
>
> ---
> base-commit: b6f2e063017b92491976a40c32a0e4b3c13e7d2f
> change-id: 20231010-ibmvfc-fix-bitfields-type-971a07c64ec6
>
> Best regards,
> --
> Nathan Chancellor
>
>
--
Thanks,
~Nick Desaulniers
unsigned int scan_complete:1;
int scan_timeout;
int events_to_log;
#define IBMVFC_AE_LINKUP 0x0001
---
base-commit: b6f2e063017b92491976a40c32a0e4b3c13e7d2f
change-id: 20231010-ibmvfc-fix-bitfields-type-971a07c64ec6
Best regards,
--
Nathan Chancellor
On Fri, 06 Oct 2023 15:09:09 -0500, Rob Herring wrote:
> (trimmed the recipient list due to bounces on v1)
>
> This is a series is part of ongoing clean-ups related to device
> matching and DT related implicit includes. Essentially of_device.h has
> a bunch of implicit includes and generally
On Wed, 04 Oct 2023 10:58:04 -0500, Rob Herring wrote:
> (trimmed the recipient list due to bounces on v1)
>
> This is a series is part of ongoing clean-ups related to device
> matching and DT related implicit includes. Essentially of_device.h has
> a bunch of implicit includes and generally
On Tue, 03 Oct 2023 13:13:09 -0500, Rob Herring wrote:
> (Got a bunch of bounces on the first try. Something weird going on with
> the To header best I can tell. Retrying with git-send-email instead of
> b4.)
>
> This is a series is part of ongoing clean-ups related to device
> matching and DT
https://bugzilla.kernel.org/show_bug.cgi?id=216156
--- Comment #16 from Erhard F. (erhar...@mailbox.org) ---
Your newest patch fixes the issue. Thanks!
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
Le 28/09/2023 à 21:48, Hari Bathini a écrit :
> patch_instruction() entails setting up pte, patching the instruction,
> clearing the pte and flushing the tlb. If multiple instructions need
> to be patched, every instruction would have to go through the above
> drill unnecessarily. Instead,
On Tue, Oct 10, 2023 at 10:35:01PM +0530, Anup Patel wrote:
> We extend the existing RISC-V SBI earlycon support to use the new
> RISC-V SBI debug console extension.
>
> Signed-off-by: Anup Patel
> ---
> drivers/tty/serial/Kconfig | 2 +-
> drivers/tty/serial/earlycon-riscv-sbi.c
On Tue, Oct 10, 2023 at 10:35:00PM +0530, Anup Patel wrote:
> The SBI DBCN extension needs to be emulated in user-space
Why?
> so let
> us forward console_puts() call to user-space.
What could go wrong!
Why does userspace have to get involved in a console message? Why is
this needed at all?
On Tue, Oct 10, 2023 at 10:34:59PM +0530, Anup Patel wrote:
> We will be implementing SBI DBCN extension for KVM RISC-V so let
> us change the KVM RISC-V SBI specification version to v2.0.
>
> Signed-off-by: Anup Patel
> ---
> arch/riscv/include/asm/kvm_vcpu_sbi.h | 2 +-
> 1 file changed, 1
On Tue, Oct 10, 2023 at 10:35:02PM +0530, Anup Patel wrote:
> --- a/drivers/tty/hvc/hvc_riscv_sbi.c
> +++ b/drivers/tty/hvc/hvc_riscv_sbi.c
> @@ -15,6 +15,7 @@
>
> #include "hvc_console.h"
>
> +#ifdef CONFIG_RISCV_SBI_V01
Please no #ifdef in a .c file, that's not a good style for Linux code
Let us enable SBI based earlycon support in defconfigs for both RV32
and RV64 so that "earlycon=sbi" can be used again.
Signed-off-by: Anup Patel
---
arch/riscv/configs/defconfig | 1 +
arch/riscv/configs/rv32_defconfig | 1 +
2 files changed, 2 insertions(+)
diff --git
From: Atish Patra
RISC-V SBI specification supports advanced debug console
support via SBI DBCN extension.
Extend the HVC SBI driver to support it.
Signed-off-by: Atish Patra
Signed-off-by: Anup Patel
---
drivers/tty/hvc/Kconfig | 2 +-
drivers/tty/hvc/hvc_riscv_sbi.c | 80
We extend the existing RISC-V SBI earlycon support to use the new
RISC-V SBI debug console extension.
Signed-off-by: Anup Patel
---
drivers/tty/serial/Kconfig | 2 +-
drivers/tty/serial/earlycon-riscv-sbi.c | 35 ++---
2 files changed, 32 insertions(+), 5
The SBI DBCN extension needs to be emulated in user-space so let
us forward console_puts() call to user-space.
Signed-off-by: Anup Patel
---
arch/riscv/include/asm/kvm_vcpu_sbi.h | 1 +
arch/riscv/include/uapi/asm/kvm.h | 1 +
arch/riscv/kvm/vcpu_sbi.c | 4
We will be implementing SBI DBCN extension for KVM RISC-V so let
us change the KVM RISC-V SBI specification version to v2.0.
Signed-off-by: Anup Patel
---
arch/riscv/include/asm/kvm_vcpu_sbi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
We add SBI debug console extension related defines/enum to the
asm/sbi.h header.
Signed-off-by: Anup Patel
---
arch/riscv/include/asm/sbi.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h
index 5b4a1bf5f439..12dfda6bb924
This series adds support for SBI debug console extension in KVM RISC-V
and Linux RISC-V.
To try these patches with KVM RISC-V, use KVMTOOL from riscv_sbi_dbcn_v1
branch at: https://github.com/avpatel/kvmtool.git
These patches can also be found in the riscv_sbi_dbcn_v1 branch at:
On Tue, Oct 10, 2023 at 05:44:23PM +0200, Lorenzo Pieralisi wrote:
> On Tue, 26 Sep 2023 10:04:45 -0400, Frank Li wrote:
> > Set DMA mask and coherent DMA mask to enable 64-bit addressing.
> >
> >
>
> Read this:
>
On Tue, Oct 10, 2023 at 10:20:12AM -0400, Frank Li wrote:
> On Wed, Oct 04, 2023 at 10:23:51AM -0400, Frank Li wrote:
> > On Fri, Sep 15, 2023 at 02:43:05PM -0400, Frank Li wrote:
> > > ls1021a add suspend/resume support.
> > >
> > > Signed-off-by: Frank Li
> > > ---
> >
> > ping
> >
> > Frank
On Tue, 26 Sep 2023 10:04:45 -0400, Frank Li wrote:
> Set DMA mask and coherent DMA mask to enable 64-bit addressing.
>
>
Read this:
https://lore.kernel.org/linux-pci/20171026223701.ga25...@bhelgaas-glaptop.roam.corp.google.com
Find the issue with the commit log (that I fixed).
This does not
On Wed, Oct 04, 2023 at 10:23:51AM -0400, Frank Li wrote:
> On Fri, Sep 15, 2023 at 02:43:05PM -0400, Frank Li wrote:
> > ls1021a add suspend/resume support.
> >
> > Signed-off-by: Frank Li
> > ---
>
> ping
>
> Frank
Ping
Frank
>
> > drivers/pci/controller/dwc/pci-layerscape.c | 88
On Wed, Sep 27, 2023 at 02:46:21PM +0200, Manivannan Sadhasivam wrote:
> On Tue, Sep 26, 2023 at 10:04:45AM -0400, Frank Li wrote:
> > From: Guanhua Gao
> >
> > Set DMA mask and coherent DMA mask to enable 64-bit addressing.
> >
> > Signed-off-by: Guanhua Gao
> > Signed-off-by: Hou Zhiqiang
>
Le 10/10/2023 à 13:47, Michael Ellerman a écrit :
> Eddie reported that newer kernels were crashing during boot on his 476
> FSP2 system:
>
>kernel tried to execute user page (b7ee2000) - exploit attempt? (uid: 0)
>BUG: Unable to handle kernel instruction fetch
>Faulting instruction
On Tue, Oct 10, 2023 at 01:48:07PM +0200, Daniel Vetter wrote:
> On Mon, Oct 09, 2023 at 11:18:36PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > v3 changelog
> >
> > No real changes, just rebased for context changes, and picked up the Acks.
> >
> > This now conflicts with the
https://bugzilla.kernel.org/show_bug.cgi?id=216156
--- Comment #15 from Michael Ellerman (mich...@ellerman.id.au) ---
Yeah, facepalm. Calling kmemleak_no_scan() later doesn't help, because it's the
early allocation that is ignored, leading to the warning.
So we can just drop the call to
On Mon, Oct 09, 2023 at 11:18:36PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> v3 changelog
>
> No real changes, just rebased for context changes, and picked up the Acks.
>
> This now conflicts with the ia64 removal and introduces one new dependency
> on IA64, but that is harmless
Eddie reported that newer kernels were crashing during boot on his 476
FSP2 system:
kernel tried to execute user page (b7ee2000) - exploit attempt? (uid: 0)
BUG: Unable to handle kernel instruction fetch
Faulting instruction address: 0xb7ee2000
Oops: Kernel access of bad area, sig: 11
On 09/10/23 10:30 am, Athira Rajeev wrote:
Simple expression parser test fails in powerpc as below:
4: Simple expression parser
test child forked, pid 170385
Using CPUID 004e2102
division by zero
syntax error
syntax error
FAILED tests/expr.c:65 parse test
On 09/10/2023 16:37, Christian Marangi wrote:
Now that napi_schedule return a bool, we can drop napi_reschedule that
does the same exact function. The function comes from a very old commit
bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct
net_device") and the purpose
Christophe Leroy writes:
> Le 09/10/2023 à 17:12, Eddie James a écrit :
>>
>> On 10/9/23 08:14, Michael Ellerman wrote:
>>> Eddie James writes:
Hi,
I'm attempting to run linux 6.1 on my FSP2, but my kernel crashes
attempting to get into userspace. The init script works, but
Eddie James writes:
> On 10/9/23 08:14, Michael Ellerman wrote:
>> Eddie James writes:
>>> Hi,
>>>
>>> I'm attempting to run linux 6.1 on my FSP2, but my kernel crashes
>>> attempting to get into userspace. The init script works, but the first
>>> binary (mount) I run results in oops. Can anyone
Le 10/10/2023 à 12:45, Michael Ellerman a écrit :
> Christophe Leroy writes:
>> Booting mpc85xx_defconfig kernel on QEMU leads to:
>
> What machine/CPU model are you using for that?
If I remember correctly, it was machine mpc8544ds.
Christophe
>
> I tried ppce500/e500 and that is working
Christophe Leroy writes:
> Booting mpc85xx_defconfig kernel on QEMU leads to:
What machine/CPU model are you using for that?
I tried ppce500/e500 and that is working OK for me, ie. boots to
userspace and I see math instructions being emulated via the emulated
stats.
cheers
> Bad trap at PC:
On 09/10/23 5:00 pm, Pingfan Liu wrote:
*** Idea ***
For kexec -p, the boot cpu can be not the cpu0, this causes the problem
of allocating memory for paca_ptrs[]. However, in theory, there is no
requirement to assign cpu's logical id as its present sequence in the
device tree. But there is
Hi Arnd,
On Mon, Oct 9, 2023 at 11:19 PM Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The list of dependencies here is phrased as an opt-out, but this is missing
> a lot of architectures that don't actually support VGA consoles, and some
> of the entries are stale:
>
> - powerpc used to
On Mon, Oct 09, 2023 at 11:18:45PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> After the vga console no longer relies on global screen_info, there are
> only two remaining use cases:
>
> - on the x86 architecture, it is used for multiple boot methods
>(bzImage, EFI, Xen, kexec)
Hello Pingfan,
With this patch series applied, the kdump kernel fails to boot on
powerpc with nr_cpus=1.
Console logs:
---
[root]# echo c > /proc/sysrq-trigger
[ 74.783235] sysrq: Trigger a crash
[ 74.783244] Kernel panic - not syncing: sysrq triggered crash
[
Hi Jakub,
On Fri, 6 Oct 2023 15:02:52 -0700
Jakub Kicinski wrote:
> On Thu, 28 Sep 2023 09:06:44 +0200 Herve Codina wrote:
> > + for (i = 0; i < count; i++) {
> > + (audio_devs + i)->name = "framer-codec";
> > + (audio_devs + i)->of_compatible = compatible;
> > +
On 09/10/23 5:00 pm, Pingfan Liu wrote:
If the boot_cpuid is smaller than nr_cpus, it requires extra effort to
ensure the boot_cpu is in cpu_present_mask. This can be achieved by
reserving the last quota for the boot cpu.
Note: the restriction on nr_cpus will be lifted with more effort in
Hello Pingfan,
With this patch series applied, the kdump kernel fails to boot on
powerpc with nr_cpus=1.
Console logs:
---
[root]# echo c > /proc/sysrq-trigger
[ 74.783235] sysrq: Trigger a crash
[ 74.783244] Kernel panic - not syncing: sysrq triggered crash
[
Hi Jakub
On Fri, 6 Oct 2023 15:08:10 -0700
Jakub Kicinski wrote:
> On Thu, 28 Sep 2023 09:06:42 +0200 Herve Codina wrote:
> > +menu "Framer Subsystem"
> > +
> > +config GENERIC_FRAMER
> > + bool "Framer Core"
> > + help
> > + Generic Framer support.
> > + A framer is a component in
66 matches
Mail list logo
