Re: [kvm-unit-tests PATCH v8 05/35] arch-run: Add a "continuous" migration option for tests

2024-04-15 Thread Thomas Huth
On 05/04/2024 10.35, Nicholas Piggin wrote: The cooperative migration protocol is very good to control precise pre and post conditions for a migration event. However in some cases its intrusiveness to the test program, can mask problems and make analysis more difficult. For example to stress

Re: [kvm-unit-tests PATCH v8 03/35] migration: Add a migrate_skip command

2024-04-15 Thread Thomas Huth
On 16/04/2024 05.22, Nicholas Piggin wrote: On Tue Apr 9, 2024 at 1:59 AM AEST, Nico Boehr wrote: Quoting Nicholas Piggin (2024-04-05 10:35:04) [...] diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash index 39419d4e2..4a1aab48d 100644 --- a/scripts/arch-run.bash +++

[PATCH v8 3/3] PCI/DPC: Disable DPC service on suspend

2024-04-15 Thread Kai-Heng Feng
When the power rail gets cut off, the hardware can create some electric noise on the link that triggers AER. If IRQ is shared between AER with PME, such AER noise will cause a spurious wakeup on system suspend. When the power rail gets back, the firmware of the device resets itself and can create

[PATCH v8 2/3] PCI/AER: Disable AER service on suspend

2024-04-15 Thread Kai-Heng Feng
When the power rail gets cut off, the hardware can create some electric noise on the link that triggers AER. If IRQ is shared between AER with PME, such AER noise will cause a spurious wakeup on system suspend. When the power rail gets back, the firmware of the device resets itself and can create

[PATCH v8 1/3] PCI: Add helper to check if any of ancestor device support D3cold

2024-04-15 Thread Kai-Heng Feng
In addition to nearest upstream bridge, driver may want to know if the entire hierarchy can be powered off to perform different action. So walk higher up the hierarchy to find out if any device has valid _PR3. The user will be introduced in next patch. Signed-off-by: Kai-Heng Feng --- v8: -

Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup

2024-04-15 Thread Chris Packham
On 16/04/24 08:54, Andi Shyti wrote: > Hi Abhinav, > >> /* Enable I2C interrupts for mpc5121 */ >> -node_ctrl = of_find_compatible_node(NULL, NULL, >> -"fsl,mpc5121-i2c-ctrl"); >> +struct device_node *node_ctrl __free(device_node) = > How have

Re: [kvm-unit-tests PATCH v8 03/35] migration: Add a migrate_skip command

2024-04-15 Thread Nicholas Piggin
On Tue Apr 9, 2024 at 1:59 AM AEST, Nico Boehr wrote: > Quoting Nicholas Piggin (2024-04-05 10:35:04) > [...] > > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash > > index 39419d4e2..4a1aab48d 100644 > > --- a/scripts/arch-run.bash > > +++ b/scripts/arch-run.bash > [...] > > @@ -179,8

Re: [RFC PATCH] powerpc: Optimise barriers for fully ordered atomics

2024-04-15 Thread Nicholas Piggin
On Sat Apr 13, 2024 at 7:48 PM AEST, Michael Ellerman wrote: > Nicholas Piggin writes: > > "Fully ordered" atomics (RMW that return a value) are said to have a > > full barrier before and after the atomic operation. This is implemented > > as: > > > > hwsync > > larx > > ... > > stcx. > >

[powerpc:next-test] BUILD SUCCESS 0db880fc865ffb522141ced4bfa66c12ab1fbb70

2024-04-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test branch HEAD: 0db880fc865ffb522141ced4bfa66c12ab1fbb70 powerpc: Avoid nmi_enter/nmi_exit in real mode interrupt. elapsed time: 728m configs tested: 50 configs skipped: 157 The following configs have been

[powerpc:fixes] BUILD SUCCESS 210cfef579260ed6c3b700e7baeae51a5e183f43

2024-04-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git fixes branch HEAD: 210cfef579260ed6c3b700e7baeae51a5e183f43 selftests/powerpc/papr-vpd: Fix missing variable initialization elapsed time: 726m configs tested: 154 configs skipped: 3 The following configs have been

[powerpc:merge] BUILD SUCCESS 77dff0c0552b56a696445badc84d6284395fb465

2024-04-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git merge branch HEAD: 77dff0c0552b56a696445badc84d6284395fb465 Merge tag 'v6.9-rc3' into merge elapsed time: 725m configs tested: 179 configs skipped: 3 The following configs have been built successfully. More

[PATCH] PCI/AER: Print error message as per the TODO

2024-04-15 Thread Abhinav Jain
Add a pr_err() to print the add device error in find_device_iter() Signed-off-by: Abhinav Jain --- drivers/pci/pcie/aer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index ac6293c24976..0e1ad2998116 100644 ---

Re: [RFC PATCH 0/8] Reimplement huge pages without hugepd on powerpc 8xx

2024-04-15 Thread Christophe Leroy
Le 12/04/2024 à 16:30, Peter Xu a écrit : > On Fri, Apr 12, 2024 at 02:08:03PM +, Christophe Leroy wrote: >> >> >> Le 11/04/2024 à 18:15, Peter Xu a écrit : >>> On Mon, Mar 25, 2024 at 01:38:40PM -0300, Jason Gunthorpe wrote: On Mon, Mar 25, 2024 at 03:55:53PM +0100, Christophe Leroy

Re: [PATCH 0/1] Replace the macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig

2024-04-15 Thread Kees Cook
On Fri, 12 Apr 2024 11:51:37 +0530, Vignesh Balasubramanian wrote: > This patch replaces the macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig > as discussed here > https://lore.kernel.org/lkml/ca+55afxdk9_cmo4spymgg_wq+_g5e_v6o-hetq_nts-q1zj...@mail.gmail.com/ > It is a pre-requisite patch for the

Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free()

2024-04-15 Thread Mark Rutland
On Mon, Apr 15, 2024 at 09:52:41AM +0200, Peter Zijlstra wrote: > On Thu, Apr 11, 2024 at 07:00:41PM +0300, Mike Rapoport wrote: > > +/** > > + * enum execmem_type - types of executable memory ranges > > + * > > + * There are several subsystems that allocate executable memory. > > + *

Re: [PATCH] bug: Fix no-return-statement warning with !CONFIG_BUG

2024-04-15 Thread Arnd Bergmann
On Mon, Apr 15, 2024, at 19:07, Christophe Leroy wrote: > Le 15/04/2024 à 17:35, Arnd Bergmann a écrit : >> >> I haven't seen a good solution here. Ideally we'd just define >> the functions unconditionally and have IS_ENABLED() take care >> of letting the compiler drop them silently, but that

Re: [PATCH] bug: Fix no-return-statement warning with !CONFIG_BUG

2024-04-15 Thread Christophe Leroy
Le 15/04/2024 à 17:35, Arnd Bergmann a écrit : > On Mon, Apr 15, 2024, at 04:19, Michael Ellerman wrote: >> "Arnd Bergmann" writes: >>> On Thu, Apr 11, 2024, at 11:27, Adrian Hunter wrote: On 11/04/24 11:22, Christophe Leroy wrote: That is fragile because it depends on

Re: [RFC PATCH 5/7] x86/module: perpare module loading for ROX allocations of text

2024-04-15 Thread Mike Rapoport
On Mon, Apr 15, 2024 at 12:43:16PM +0200, Peter Zijlstra wrote: > On Thu, Apr 11, 2024 at 07:05:24PM +0300, Mike Rapoport wrote: > > diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c > > index 45a280f2161c..b4d6868df573 100644 > > --- a/arch/x86/kernel/alternative.c > >

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-15 Thread Sean Christopherson
On Sat, Apr 13, 2024, Marc Zyngier wrote: > On Fri, 12 Apr 2024 15:54:22 +0100, Sean Christopherson > wrote: > > > > On Fri, Apr 12, 2024, Marc Zyngier wrote: > > > On Fri, 12 Apr 2024 11:44:09 +0100, Will Deacon wrote: > > > > On Fri, Apr 05, 2024 at 07:58:12AM -0400, Paolo Bonzini wrote: > >

Re: [RFC PATCH 6/7] execmem: add support for cache of large ROX pages

2024-04-15 Thread Mike Rapoport
On Mon, Apr 15, 2024 at 12:47:50PM +0200, Peter Zijlstra wrote: > On Thu, Apr 11, 2024 at 07:05:25PM +0300, Mike Rapoport wrote: > > > To populate the cache, a writable large page is allocated from vmalloc with > > VM_ALLOW_HUGE_VMAP, filled with invalid instructions and then remapped as > > ROX.

Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free()

2024-04-15 Thread Mike Rapoport
On Mon, Apr 15, 2024 at 09:52:41AM +0200, Peter Zijlstra wrote: > On Thu, Apr 11, 2024 at 07:00:41PM +0300, Mike Rapoport wrote: > > +/** > > + * enum execmem_type - types of executable memory ranges > > + * > > + * There are several subsystems that allocate executable memory. > > + *

Re: [PATCH] PCI/AER: Print error message as per the TODO

2024-04-15 Thread Joe Perches
On Mon, 2024-04-15 at 16:10 +, Abhinav Jain wrote: > Add a pr_err() to print the add device error in find_device_iter() [] > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c [] > @@ -885,7 +885,8 @@ static int find_device_iter(struct pci_dev *dev, void > *data) > /*

Re: [PATCH] bug: Fix no-return-statement warning with !CONFIG_BUG

2024-04-15 Thread Arnd Bergmann
On Mon, Apr 15, 2024, at 04:19, Michael Ellerman wrote: > "Arnd Bergmann" writes: >> On Thu, Apr 11, 2024, at 11:27, Adrian Hunter wrote: >>> On 11/04/24 11:22, Christophe Leroy wrote: >>> >>> That is fragile because it depends on defined(__OPTIMIZE__), >>> so it should still be: >> >> If there

Re: [PATCH v12 2/8] PCI: dwc: ep: Add Kernel-doc comments for APIs

2024-04-15 Thread Bjorn Helgaas
On Mon, Apr 15, 2024 at 07:30:15PM +0530, Manivannan Sadhasivam wrote: > On Fri, Apr 12, 2024 at 02:58:36PM -0500, Bjorn Helgaas wrote: > > On Wed, Mar 27, 2024 at 02:43:31PM +0530, Manivannan Sadhasivam wrote: > > > All of the APIs are missing the Kernel-doc comments. Hence, add them. > > > > >

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-15 Thread Sean Christopherson
On Mon, Apr 15, 2024, Geert Uytterhoeven wrote: > Hi Michael, > > On Sat, Apr 13, 2024 at 11:38 AM Michael Ellerman wrote: > > Michael Ellerman writes: > > > Stephen Rothwell writes: > > ... > > >> On Tue, 9 Apr 2024 10:51:05 -0700 Sean Christopherson > > >> wrote: > > ... > > >>> diff

Re: [kvm-unit-tests PATCH v8 05/35] arch-run: Add a "continuous" migration option for tests

2024-04-15 Thread Thomas Huth
On 05/04/2024 10.35, Nicholas Piggin wrote: The cooperative migration protocol is very good to control precise pre and post conditions for a migration event. However in some cases its intrusiveness to the test program, can mask problems and make analysis more difficult. For example to stress

Re: [PATCH v12 2/8] PCI: dwc: ep: Add Kernel-doc comments for APIs

2024-04-15 Thread Manivannan Sadhasivam
On Fri, Apr 12, 2024 at 02:58:36PM -0500, Bjorn Helgaas wrote: > On Wed, Mar 27, 2024 at 02:43:31PM +0530, Manivannan Sadhasivam wrote: > > All of the APIs are missing the Kernel-doc comments. Hence, add them. > > > + * dw_pcie_ep_reset_bar - Reset endpoint BAR > > Apparently this resets @bar

Re: [PATCH v2] KVM: PPC: Book3S HV nestedv2: Cancel pending DEC exception

2024-04-15 Thread Michael Ellerman
Vaibhav Jain writes: > This reverts commit 180c6b072bf3 ("KVM: PPC: Book3S HV nestedv2: Do not > cancel pending decrementer exception") [1] which prevented canceling a > pending HDEC exception for nestedv2 KVM guests. It was done to avoid > overhead of a H_GUEST_GET_STATE hcall to read the 'DEC

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-15 Thread Geert Uytterhoeven
Hi Michael, On Sat, Apr 13, 2024 at 11:38 AM Michael Ellerman wrote: > Michael Ellerman writes: > > Stephen Rothwell writes: > ... > >> On Tue, 9 Apr 2024 10:51:05 -0700 Sean Christopherson > >> wrote: > ... > >>> diff --git a/kernel/cpu.c b/kernel/cpu.c > >>> index

Re: [RFC PATCH 6/7] execmem: add support for cache of large ROX pages

2024-04-15 Thread Peter Zijlstra
On Thu, Apr 11, 2024 at 07:05:25PM +0300, Mike Rapoport wrote: > To populate the cache, a writable large page is allocated from vmalloc with > VM_ALLOW_HUGE_VMAP, filled with invalid instructions and then remapped as > ROX. > +static void execmem_invalidate(void *ptr, size_t size, bool writable)

Re: [RFC PATCH 5/7] x86/module: perpare module loading for ROX allocations of text

2024-04-15 Thread Peter Zijlstra
On Thu, Apr 11, 2024 at 07:05:24PM +0300, Mike Rapoport wrote: > diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c > index 45a280f2161c..b4d6868df573 100644 > --- a/arch/x86/kernel/alternative.c > +++ b/arch/x86/kernel/alternative.c > @@ -504,17 +513,17 @@ void

Re: [PATCH v4 07/15] mm/execmem, arch: convert remaining overrides of module_alloc to execmem

2024-04-15 Thread Peter Zijlstra
On Thu, Apr 11, 2024 at 07:00:43PM +0300, Mike Rapoport wrote: > +static struct execmem_info execmem_info __ro_after_init = { > + .ranges = { > + [EXECMEM_DEFAULT] = { > + .flags = EXECMEM_KASAN_SHADOW, > + .alignment = MODULE_ALIGN, > +

[PATCH v3] tty: hvc: wakeup hvc console immediately when needed

2024-04-15 Thread li.hao40
From: Li Hao Cancel the do_wakeup flag in hvc_struct, and change it to immediately wake up tty when hp->n_outbuf is 0 in hvc_push(). When we receive a key input character, the interrupt handling function hvc_handle_interrupt() will be executed, and the echo thread flush_to_ldisc() will be added

Re: [PATCH v4 06/15] mm/execmem, arch: convert simple overrides of module_alloc to execmem

2024-04-15 Thread Peter Zijlstra
On Thu, Apr 11, 2024 at 07:00:42PM +0300, Mike Rapoport wrote: > +static struct execmem_info execmem_info __ro_after_init = { > + .ranges = { > + [EXECMEM_DEFAULT] = { > + .start = MODULES_VADDR, > + .end = MODULES_END, > +

Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free()

2024-04-15 Thread Peter Zijlstra
On Thu, Apr 11, 2024 at 07:00:41PM +0300, Mike Rapoport wrote: > +/** > + * enum execmem_type - types of executable memory ranges > + * > + * There are several subsystems that allocate executable memory. > + * Architectures define different restrictions on placement, > + * permissions, alignment

Re: [0/2] powerpc/powernv/vas: Adjustments for two function implementations

2024-04-15 Thread Markus Elfring
> A few update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): I would appreciate a bit more information about the reasons why this patch series was rejected. > One function call less in vas_window_alloc() after error detection

[PATCH 2/2] ASoC: dt-bindings: fsl-asoc-card: Add compatbile string for wm8904 codec

2024-04-15 Thread Shengjiu Wang
The wm8904 codec is used on an i.MX95 Toradex board. Signed-off-by: Shengjiu Wang --- Documentation/devicetree/bindings/sound/fsl-asoc-card.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/sound/fsl-asoc-card.yaml

[PATCH 1/2] ASoC: fsl-asoc-card: add wm8904 codec support

2024-04-15 Thread Shengjiu Wang
wm8904 codec is used on i.MX95 Toradex board Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl-asoc-card.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c index bc07f26ba303..f6d2564864c6 100644 ---

[PATCH 0/2] ASoC: fsl-asoc-card: add wm8904 codec support

2024-04-15 Thread Shengjiu Wang
add wm8904 codec support in fsl-asoc-card. Shengjiu Wang (2): ASoC: fsl-asoc-card: add wm8904 codec support ASoC: dt-bindings: fsl-asoc-card: Add compatbile string for wm8904 codec .../devicetree/bindings/sound/fsl-asoc-card.yaml | 1 + sound/soc/fsl/fsl-asoc-card.c

Re: [PATCH v2] tty: hvc: wakeup hvc console immediately when needed

2024-04-15 Thread Greg KH
On Mon, Apr 15, 2024 at 03:26:17PM +0800, li.ha...@zte.com.cn wrote: > From: Li Hao > > Cancel the do_wakeup flag in hvc_struct, and change it to immediately > wake up tty when hp->n_outbuf is 0 in hvc_push(). > > When we receive a key input character, the interrupt handling function >

[PATCH v2] tty: hvc: wakeup hvc console immediately when needed

2024-04-15 Thread li.hao40
From: Li Hao Cancel the do_wakeup flag in hvc_struct, and change it to immediately wake up tty when hp->n_outbuf is 0 in hvc_push(). When we receive a key input character, the interrupt handling function hvc_handle_interrupt() will be executed, and the echo thread flush_to_ldisc() will be added

Re: [PATCH v3 2/2] powerpc/bpf: enable kfunc call

2024-04-15 Thread Naveen N Rao
On Tue, Apr 02, 2024 at 04:28:06PM +0530, Hari Bathini wrote: > Currently, bpf jit code on powerpc assumes all the bpf functions and > helpers to be kernel text. This is false for kfunc case, as function > addresses can be module addresses as well. So, ensure module addresses > are supported to

Re: [PATCH] powerpc/eeh: Permanently disable the removed device

2024-04-15 Thread Ganesh G R
On 4/9/24 14:37, Michael Ellerman wrote: Hi Ganesh, Ganesh Goudar writes: When a device is hot removed on powernv, the hotplug driver clears the device's state. However, on pseries, if a device is removed by phyp after reaching the error threshold, the kernel remains unaware, leading to the