Re: [PATCH v4 0/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-10-27 Thread Alexander Popov
On 27.10.2015 05:22, Vinod Koul wrote: > On Thu, Oct 22, 2015 at 01:15:03AM +0300, Alexander Popov wrote: >> On 12.10.2015 00:08, Alexander Popov wrote: >>> This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC >>> in the Reference Manual) allows Dir

Re: [PATCH v4 0/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-10-21 Thread Alexander Popov
On 12.10.2015 00:08, Alexander Popov wrote: > This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC > in the Reference Manual) allows Direct Memory Access transfers > between RAM and peripheral devices on LocalPlus Bus. > Changes in v4: > - the race condition is fix

[PATCH v4 0/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-10-11 Thread Alexander Popov
xp0p0...@gmail.com" is changed to a more pleasant alias "alex.po...@linux.com". Changes in v4: - the race condition is fixed; - plenty of style fixes are made; - devm_* functions and EPROBE_DEFER are used in probe(). Alexander Popov (2): powerpc/512x: add LocalPlus Bus FIFO device d

[PATCH v4 1/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-10-11 Thread Alexander Popov
This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC in the Reference Manual) allows Direct Memory Access transfers between RAM and peripheral devices on LocalPlus Bus. Signed-off-by: Alexander Popov <alex.po...@linux.com> --- arch/powerpc/configs/mpc512x_defconfig

[PATCH v4 2/2] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO

2015-10-11 Thread Alexander Popov
Add a device tree binding for Freescale MPC512x LocalPlus Bus FIFO and introduce the document describing that binding. Signed-off-by: Alexander Popov <alex.po...@linux.com> --- .../bindings/powerpc/fsl/mpc512x_lpbfifo.txt| 21 + arch/powerpc/boot/dts/mpc512

Re: [PATCH v3 3/3] dmaengine: mpc512x: initialize with subsys_initcall()

2015-10-07 Thread Alexander Popov
On 07.10.2015 17:17, Vinod Koul wrote: > On Thu, Sep 24, 2015 at 08:28:57PM +0300, Alexander Popov wrote: >> Initialize Freescale MPC512x DMA driver with subsys_initcall() >> to allow the depending drivers to call dma_request_slave_channel() >> during their probe. > &g

Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-10-05 Thread Alexander Popov
On 01.10.2015 20:11, Timur Tabi wrote: > On 09/30/2015 04:24 PM, Alexander Popov wrote: >>> Driver code that has to parse #address-cells or #size-cells >>> is usually wrong. >> >> I would not call it "parsing", I just check whether the dts-file is go

Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-09-30 Thread Alexander Popov
Hello Timur, thanks again for your review. On 25.09.2015 04:01, Timur Tabi wrote: > Alexander Popov wrote: >> + >> +for (i = 0; i < lpbfifo.cs_n; i++) { >> +phys_addr_t cs_start; >> +phys_addr_t cs_end; >> + >> +cs_start = lpb

Re: [PATCH v3 2/3] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO

2015-09-29 Thread Alexander Popov
On 28.09.2015 16:26, Timur Tabi wrote: > Alexander Popov wrote: >> I've just followed devicetree/bindings/dma/dma.txt... >> This "rx-tx" doesn't mean much but it could show that LocalPlus Bus FIFO >> uses a single DMA read-write channel. Should I really d

Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-09-29 Thread Alexander Popov
On 28.09.2015 16:18, Timur Tabi wrote: > Alexander Popov wrote: >> The only question I have: why calling dma_unmap_single() from within >> a spinlock is a bad practice? > > I don't know, but usually functions that allocate or free memory cannot be > called from with

Re: [PATCH v3 3/3] dmaengine: mpc512x: initialize with subsys_initcall()

2015-09-28 Thread Alexander Popov
On 25.09.2015 03:16, Timur Tabi wrote: > Alexander Popov wrote: >> Initialize Freescale MPC512x DMA driver with subsys_initcall() >> to allow the depending drivers to call dma_request_slave_channel() >> during their probe. >> >> Signed-off-by: Ale

Re: [PATCH v3 2/3] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO

2015-09-28 Thread Alexander Popov
On 25.09.2015 03:18, Timur Tabi wrote: > Alexander Popov wrote: >> +- dma-names: should be "rx-tx"; > > Why bother, if it can only be one value? I've just followed devicetree/bindings/dma/dma.txt... This "rx-tx" doesn't mean much but it could show that LocalP

Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-09-28 Thread Alexander Popov
Hello, Timur, thanks a lot for your review. I'll fix all the issues you pointed at and return with v4. The only question I have: why calling dma_unmap_single() from within a spinlock is a bad practice? Best regards, Alexander ___ Linuxppc-dev mailing

[PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-09-24 Thread Alexander Popov
This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC in the Reference Manual) allows Direct Memory Access transfers between RAM and peripheral devices on LocalPlus Bus. Signed-off-by: Alexander Popov <alex.po...@linux.com> --- arch/powerpc/configs/mpc512x_defconfig

[PATCH v3 0/3] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-09-24 Thread Alexander Popov
xp0p0...@gmail.com" is changed to a more pleasant alias "alex.po...@linux.com"; Alexander Popov (3): powerpc/512x: add LocalPlus Bus FIFO device driver powerpc/512x: add a device tree binding for LocalPlus Bus FIFO dmaengine: mpc512x: initialize with subsys_initcall() .../

[PATCH v3 2/3] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO

2015-09-24 Thread Alexander Popov
Add a device tree binding for Freescale MPC512x LocalPlus Bus FIFO and introduce the document describing that binding. Signed-off-by: Alexander Popov <alex.po...@linux.com> --- .../bindings/powerpc/fsl/mpc512x_lpbfifo.txt| 21 + arch/powerpc/boot/dts/mpc512

[PATCH v3 3/3] dmaengine: mpc512x: initialize with subsys_initcall()

2015-09-24 Thread Alexander Popov
Initialize Freescale MPC512x DMA driver with subsys_initcall() to allow the depending drivers to call dma_request_slave_channel() during their probe. Signed-off-by: Alexander Popov <alex.po...@linux.com> --- drivers/dma/mpc512x_dma.c | 12 +++- 1 file changed, 11 insertions

[PATCH v2 1/1] net: fs_enet: Fix NETIF_F_SG feature for Freescale MPC5121

2015-06-20 Thread Alexander Popov
tx_skb_align_workaround() and use skb_linearize() in it. Signed-off-by: Alexander Popov alex.po...@linux.com --- .../net/ethernet/freescale/fs_enet/fs_enet-main.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b

Re: [PATCH 1/1] net: fs_enet: Disable NETIF_F_SG feature for Freescale MPC5121

2015-06-14 Thread Alexander Popov
10.06.2015 03:14, David Miller пишет: From: Alexander Popov alex.po...@linux.com Date: Wed, 10 Jun 2015 02:57:42 +0300 skb_copy_from_linear_data() which doesn't work well for non-linear sk_buff: The correct fix is to use an SKB copy routine which can handle non-linear data. Thanks, David

[PATCH 1/1] net: fs_enet: Disable NETIF_F_SG feature for Freescale MPC5121

2015-06-09 Thread Alexander Popov
might be better than handling improper alignment for sk_buff.data and all the fragments. Signed-off-by: Alexander Popov alex.po...@linux.com --- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/fs_enet

Re: Disabled LocalPlus Controller (LPC) clock on MPC512x

2015-02-10 Thread Alexander Popov
Hello Matteo, sorry for such a long delay in replying, now I have my board back again. 19.12.2014 12:38, Matteo Facchinetti пишет: On 16/12/2014 13:00, Alexander Popov wrote: In fact clk_ignore_unused bootparam helps to avoid disabling NFC clock. The board crash is reproduced again if I

Re: Disabled LocalPlus Controller (LPC) clock on MPC512x

2014-12-16 Thread Alexander Popov
02.12.2014 13:47, Matteo Facchinetti пишет: On 26/11/2014 12:49, Alexander Popov wrote: Hello. Hi. Thanks for your reply, Matteo. I've looked deeper and have more information about the crash. My Freescale TWR-MPC5125 board instantly reboots if I touch any physical address on the LocalPlus

Disabled LocalPlus Controller (LPC) clock on MPC512x

2014-11-26 Thread Alexander Popov
Hello. My Freescale TWR-MPC5125 board instantly reboots if I touch any physical address on the LocalPlus Bus (LPB) for the first time when Linux has already booted. This effect is reproduced by using /dev/mem or loading a kernel module which works with any peripherals on LPB. It took me some

Re: [PATCH v3 0/3] dmaengine: mpc512x: add device tree binding document and DMA channel lookup

2014-07-20 Thread Alexander Popov
Hello! 2014-06-25 14:52 GMT+04:00 Alexander Popov a13xp0p0...@gmail.com: This patch series introduces a device tree binding document for the MPC512x DMA controller and adds device tree based DMA channel lookup for it. This version contains the improved device tree binding document: #dma

[PATCH v3 0/3] dmaengine: mpc512x: add device tree binding document and DMA channel lookup

2014-06-25 Thread Alexander Popov
. Alexander Popov (3): dmaengine: mpc512x: add device tree binding document dmaengine: of: add common xlate function for matching by channel id dmaengine: mpc512x: register for device tree channel lookup .../devicetree/bindings/dma/mpc512x-dma.txt| 29 ++ arch/powerpc

[PATCH v3 1/3] dmaengine: mpc512x: add device tree binding document

2014-06-25 Thread Alexander Popov
Introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- .../devicetree/bindings/dma/mpc512x-dma.txt| 29 ++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v3 2/3] dmaengine: of: add common xlate function for matching by channel id

2014-06-25 Thread Alexander Popov
-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/of-dma.c | 35 +++ include/linux/of_dma.h | 4 2 files changed, 39 insertions(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index e8fe9dc..d5fbeaa 100644 --- a/drivers/dma/of-dma.c +++ b/drivers

[PATCH v3 3/3] dmaengine: mpc512x: register for device tree channel lookup

2014-06-25 Thread Alexander Popov
Register the controller for device tree based lookup of DMA channels (non-fatal for backwards compatibility with older device trees) and provide the '#dma-cells' property in the shared mpc5121.dtsi file Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- arch/powerpc/boot/dts/mpc5121.dtsi

Re: [PATCH v2 1/3] dmaengine: mpc512x: add device tree binding document

2014-06-19 Thread Alexander Popov
2014-06-18 18:56 GMT+04:00 Alexander Popov a13xp0p0...@gmail.com: 2014-06-18 17:37 GMT+04:00 Mark Rutland mark.rutl...@arm.com: On Wed, Jun 18, 2014 at 11:48:10AM +0100, Alexander Popov wrote: Introduce a device tree binding document for the MPC512x DMA controller +Optional properties

[PATCH v2 0/3] dmaengine: mpc512x: add device tree binding document and DMA channel lookup

2014-06-18 Thread Alexander Popov
This patch series introduces a device tree binding document for the MPC512x DMA controller and adds device tree based DMA channel lookup for it. This version has improved device tree binding document. Alexander Popov (3): dmaengine: mpc512x: add device tree binding document dmaengine

[PATCH v2 1/3] dmaengine: mpc512x: add device tree binding document

2014-06-18 Thread Alexander Popov
Introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- .../devicetree/bindings/dma/mpc512x-dma.txt| 31 ++ 1 file changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v2 2/3] dmaengine: of: add common xlate function for matching by channel id

2014-06-18 Thread Alexander Popov
-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/of-dma.c | 35 +++ include/linux/of_dma.h | 4 2 files changed, 39 insertions(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index e8fe9dc..d5fbeaa 100644 --- a/drivers/dma/of-dma.c +++ b/drivers

[PATCH v2 3/3] dmaengine: mpc512x: register for device tree channel lookup

2014-06-18 Thread Alexander Popov
Register the controller for device tree based lookup of DMA channels (non-fatal for backwards compatibility with older device trees) and provide the '#dma-cells' property in the shared mpc5121.dtsi file Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- arch/powerpc/boot/dts/mpc5121.dtsi

Re: [PATCH v2 1/3] dmaengine: mpc512x: add device tree binding document

2014-06-18 Thread Alexander Popov
Hello Mark, thanks for your reply! 2014-06-18 17:37 GMT+04:00 Mark Rutland mark.rutl...@arm.com: On Wed, Jun 18, 2014 at 11:48:10AM +0100, Alexander Popov wrote: Introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Alexander Popov a13xp0p0...@gmail.com

Re: [PATCH 0/3] dmaengine: mpc512x: add device tree binding document and DMA channel lookup

2014-06-08 Thread Alexander Popov
2014-05-24 13:33 GMT+04:00 Alexander Popov a13xp0p0...@gmail.com: This patch series introduces a device tree binding document for the MPC512x DMA controller and adds device tree based DMA channel lookup for it. Hello, excuse me, could I have a feedback? Should I fix anything? Thanks a lot

Re: [PATCH RFC v13 0/5] MPC512x DMA slave s/g support, OF DMA lookup

2014-05-24 Thread Alexander Popov
Thank you, Vinod 2014-05-22 9:10 GMT+04:00 Vinod Koul vinod.k...@intel.com: On Thu, May 15, 2014 at 06:15:30PM +0400, Alexander Popov wrote: Changes in v13: A new patch (part 1/5) is added to this series. Part 2/5: - fix style issue; - improve comments; You need to cc DT- list for 3

[PATCH 0/3] dmaengine: mpc512x: add device tree binding document and DMA channel lookup

2014-05-24 Thread Alexander Popov
This patch series introduces a device tree binding document for the MPC512x DMA controller and adds device tree based DMA channel lookup for it. Alexander Popov (3): dmaengine: mpc512x: add device tree binding document dmaengine: of: add common xlate function for matching by channel id

[PATCH 2/3] dmaengine: of: add common xlate function for matching by channel id

2014-05-24 Thread Alexander Popov
-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/of-dma.c | 35 +++ include/linux/of_dma.h | 4 2 files changed, 39 insertions(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index e8fe9dc..d5fbeaa 100644 --- a/drivers/dma/of-dma.c +++ b/drivers

[PATCH 1/3] dmaengine: mpc512x: add device tree binding document

2014-05-24 Thread Alexander Popov
Introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- .../devicetree/bindings/dma/mpc512x-dma.txt| 40 ++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH 3/3] dmaengine: mpc512x: register for device tree channel lookup

2014-05-24 Thread Alexander Popov
Register the controller for device tree based lookup of DMA channels (non-fatal for backwards compatibility with older device trees) and provide the '#dma-cells' property in the shared mpc5121.dtsi file Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- arch/powerpc/boot/dts/mpc5121.dtsi

[PATCH RFC v13 0/5] MPC512x DMA slave s/g support, OF DMA lookup

2014-05-15 Thread Alexander Popov
use slave support or whether the DMA controller's driver shall actively reject it, the information that's available so far suggests that peripheral transfers to IP bus attached I/O is useful and shall not get blocked right away Alexander Popov (5): dmaengine: fix comment typo dma

[PATCH RFC v13 1/5] dmaengine: fix comment typo

2014-05-15 Thread Alexander Popov
Fix comment typo. Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- include/linux/dmaengine.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h index 8300fb8..cbb168e 100644 --- a/include/linux/dmaengine.h +++ b

[PATCH RFC v13 2/5] dma: mpc512x: add support for peripheral transfers

2014-05-15 Thread Alexander Popov
Introduce support for slave s/g transfer preparation and the associated device control callback in the MPC512x DMA controller driver, which adds support for data transfers between memory and peripheral I/O to the previously supported mem-to-mem transfers. Signed-off-by: Alexander Popov a13xp0p0

[PATCH RFC v13 3/5] dma: of: add common xlate function for matching by channel id

2014-05-15 Thread Alexander Popov
-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/of-dma.c | 35 +++ include/linux/of_dma.h | 4 2 files changed, 39 insertions(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index e8fe9dc..d5fbeaa 100644 --- a/drivers/dma/of-dma.c +++ b/drivers

[PATCH RFC v13 4/5] dma: mpc512x: add device tree binding document

2014-05-15 Thread Alexander Popov
Introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- .../devicetree/bindings/dma/mpc512x-dma.txt| 40 ++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH RFC v13 5/5] dma: mpc512x: register for device tree channel lookup

2014-05-15 Thread Alexander Popov
Register the controller for device tree based lookup of DMA channels (non-fatal for backwards compatibility with older device trees) and provide the '#dma-cells' property in the shared mpc5121.dtsi file Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- arch/powerpc/boot/dts/mpc5121.dtsi

Re: [PATCH RFC v12 3/7] dma: mpc512x: add support for peripheral transfers

2014-05-08 Thread Alexander Popov
Hello, Vinod. Thanks for your feedback. 2014-05-02 21:03 GMT+04:00 Vinod Koul vinod.k...@intel.com: On Wed, Apr 23, 2014 at 05:53:25PM +0400, Alexander Popov wrote: +static struct dma_async_tx_descriptor * +mpc_dma_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl

Re: [PATCH RFC v12 0/7] MPC512x DMA slave s/g support, OF DMA lookup

2014-04-29 Thread Alexander Popov
Hello 2014-04-23 17:53 GMT+04:00 Alexander Popov a13xp0p0...@gmail.com: Changes in v12: A new patch (part 2/7) is added to this series. Part 6/7: - change the description of 'compatible' property according part 2/7; - improve the document according Gerhard's feedback; Could I have

[PATCH RFC v12 1/7] dma: mpc512x: reorder mpc8308 specific instructions

2014-04-23 Thread Alexander Popov
Concentrate the specific code for MPC8308 in the 'if' branch and handle MPC512x in the 'else' branch. This modification only reorders instructions but doesn't change behaviour. Signed-off-by: Alexander Popov a13xp0p0...@gmail.com Acked-by: Anatolij Gustschin ag...@denx.de --- drivers/dma

[PATCH RFC v12 2/7] dma: mpc512x: separate 'compatible' values for MPC512x and MPC8308

2014-04-23 Thread Alexander Popov
MPC512x and MPC8308 have similar DMA controllers, but are independent SoCs. DMA controller driver should have separate 'compatible' values for these SoCs. Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- arch/powerpc/boot/dts/mpc8308_p1m.dts | 2 +- arch/powerpc/boot/dts/mpc8308rdb.dts

[PATCH RFC v12 3/7] dma: mpc512x: add support for peripheral transfers

2014-04-23 Thread Alexander Popov
Introduce support for slave s/g transfer preparation and the associated device control callback in the MPC512x DMA controller driver, which adds support for data transfers between memory and peripheral I/O to the previously supported mem-to-mem transfers. Signed-off-by: Alexander Popov a13xp0p0

[PATCH RFC v12 4/7] dma: mpc512x: fix freeing resources in mpc_dma_probe() and mpc_dma_remove()

2014-04-23 Thread Alexander Popov
with devm_free_irq(). Replace devm_free_irq() with free_irq() accordingly. Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/mpc512x_dma.c | 55 --- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/drivers/dma/mpc512x_dma.c b/drivers

[PATCH RFC v12 5/7] dma: of: add common xlate function for matching by channel id

2014-04-23 Thread Alexander Popov
-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/of-dma.c | 35 +++ include/linux/of_dma.h | 4 2 files changed, 39 insertions(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index e8fe9dc..d5fbeaa 100644 --- a/drivers/dma/of-dma.c +++ b/drivers

[PATCH RFC v12 6/7] dma: mpc512x: add device tree binding document

2014-04-23 Thread Alexander Popov
Introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- .../devicetree/bindings/dma/mpc512x-dma.txt| 40 ++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH RFC v12 7/7] dma: mpc512x: register for device tree channel lookup

2014-04-23 Thread Alexander Popov
Register the controller for device tree based lookup of DMA channels (non-fatal for backwards compatibility with older device trees) and provide the '#dma-cells' property in the shared mpc5121.dtsi file Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- arch/powerpc/boot/dts/mpc5121.dtsi

[PATCH RFC v12 0/7] MPC512x DMA slave s/g support, OF DMA lookup

2014-04-23 Thread Alexander Popov
increment the RAM address or do increment the peripheral port's address is easy with this implementation; but which options of the common API should be used for specifying such transfers? Alexander Popov (7): dma: mpc512x: reorder mpc8308 specific instructions dma: mpc512x: separate

Re: [PATCH RFC v11 5/6] dma: mpc512x: add device tree binding document

2014-04-18 Thread Alexander Popov
Thanks for your reply, Gerhard 2014-04-17 0:44 GMT+04:00 Gerhard Sittig g...@denx.de: On Tue, 2014-04-15 at 14:54 +0400, Alexander Popov wrote: Introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Gerhard Sittig g...@denx.de Signed-off-by: Alexander Popov

[PATCH RFC v11 0/6] MPC512x DMA slave s/g support, OF DMA lookup

2014-04-15 Thread Alexander Popov
? Alexander Popov (6): dma: mpc512x: reorder mpc8308 specific instructions dma: mpc512x: add support for peripheral transfers dma: mpc512x: fix freeing resources in mpc_dma_probe() and mpc_dma_remove() dma: of: Add common xlate function for matching by channel id dma: mpc512x: add device tree

[PATCH RFC v11 2/6] dma: mpc512x: add support for peripheral transfers

2014-04-15 Thread Alexander Popov
Introduce support for slave s/g transfer preparation and the associated device control callback in the MPC512x DMA controller driver, which adds support for data transfers between memory and peripheral I/O to the previously supported mem-to-mem transfers. Signed-off-by: Alexander Popov a13xp0p0

[PATCH RFC v11 1/6] dma: mpc512x: reorder mpc8308 specific instructions

2014-04-15 Thread Alexander Popov
Concentrate the specific code for MPC8308 in the 'if' branch and handle MPC512x in the 'else' branch. This modification only reorders instructions but doesn't change behaviour. Signed-off-by: Alexander Popov a13xp0p0...@gmail.com Acked-by: Anatolij Gustschin ag...@denx.de Acked-by: Gerhard Sittig

[PATCH RFC v11 3/6] dma: mpc512x: fix freeing resources in mpc_dma_probe() and mpc_dma_remove()

2014-04-15 Thread Alexander Popov
with devm_free_irq(). Replace devm_free_irq() with free_irq() accordingly. Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/mpc512x_dma.c | 55 --- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/drivers/dma/mpc512x_dma.c b/drivers

[PATCH RFC v11 4/6] dma: of: Add common xlate function for matching by channel id

2014-04-15 Thread Alexander Popov
-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/of-dma.c | 35 +++ include/linux/of_dma.h | 4 2 files changed, 39 insertions(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index e8fe9dc..d5fbeaa 100644 --- a/drivers/dma/of-dma.c +++ b/drivers

[PATCH RFC v11 5/6] dma: mpc512x: add device tree binding document

2014-04-15 Thread Alexander Popov
Introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Gerhard Sittig g...@denx.de Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- .../devicetree/bindings/dma/mpc512x-dma.txt| 51 ++ 1 file changed, 51 insertions(+) create

[PATCH RFC v11 6/6] dma: mpc512x: register for device tree channel lookup

2014-04-15 Thread Alexander Popov
Register the controller for device tree based lookup of DMA channels (non-fatal for backwards compatibility with older device trees) and provide the '#dma-cells' property in the shared mpc5121.dtsi file Signed-off-by: Gerhard Sittig g...@denx.de Signed-off-by: Alexander Popov a13xp0p0

Re: [PATCH RFC v10 0/6] MPC512x DMA slave s/g support, OF DMA lookup

2014-04-03 Thread Alexander Popov
Hello, 2014-03-20 18:47 GMT+04:00 Alexander Popov a13xp0p0...@gmail.com: Changes in v10: Part 2/6: - don't use direction field of dma_slave_config in mpc_dma_device_control() but store settings in mpc_dma_chan for both DMA_DEV_TO_MEM and DMA_MEM_TO_DEV cases; then retrieve

Re: [PATCH RFC v10 0/6] MPC512x DMA slave s/g support, OF DMA lookup

2014-04-02 Thread Alexander Popov
Hello 20.03.2014 18:48 Alexander Popov a13xp0p0...@gmail.com wrote: Changes in v10: Part 2/6: - don't use direction field of dma_slave_config in mpc_dma_device_control() but store settings in mpc_dma_chan for both DMA_DEV_TO_MEM and DMA_MEM_TO_DEV cases; then retrieve the needed

[PATCH RFC v10 0/6] MPC512x DMA slave s/g support, OF DMA lookup

2014-03-20 Thread Alexander Popov
support it. Alexander Popov (5): dma: mpc512x: reorder mpc8308 specific instructions dma: mpc512x: add support for peripheral transfers dma: mpc512x: fix freeing resources in mpc_dma_probe() and mpc_dma_remove() dma: of: Add common xlate function for matching by channel id dma: mpc512x

[PATCH RFC v10 1/6] dma: mpc512x: reorder mpc8308 specific instructions

2014-03-20 Thread Alexander Popov
Concentrate the specific code for MPC8308 in the 'if' branch and handle MPC512x in the 'else' branch. This modification only reorders instructions but doesn't change behaviour. Signed-off-by: Alexander Popov a13xp0p0...@gmail.com Acked-by: Anatolij Gustschin ag...@denx.de Acked-by: Gerhard Sittig

[PATCH RFC v10 2/6] dma: mpc512x: add support for peripheral transfers

2014-03-20 Thread Alexander Popov
Introduce support for slave s/g transfer preparation and the associated device control callback in the MPC512x DMA controller driver, which adds support for data transfers between memory and peripheral I/O to the previously supported mem-to-mem transfers. Signed-off-by: Alexander Popov a13xp0p0

[PATCH RFC v10 3/6] dma: mpc512x: fix freeing resources in mpc_dma_probe() and mpc_dma_remove()

2014-03-20 Thread Alexander Popov
with devm_free_irq(). Replace devm_free_irq() with free_irq() accordingly. Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/mpc512x_dma.c | 55 --- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/drivers/dma/mpc512x_dma.c b/drivers

[PATCH RFC v10 4/6] dma: of: Add common xlate function for matching by channel id

2014-03-20 Thread Alexander Popov
-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/of-dma.c | 35 +++ include/linux/of_dma.h | 4 2 files changed, 39 insertions(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index e8fe9dc..d5fbeaa 100644 --- a/drivers/dma/of-dma.c +++ b/drivers

[PATCH RFC v10 5/6] dma: mpc512x: add device tree binding document

2014-03-20 Thread Alexander Popov
From: Gerhard Sittig g...@denx.de introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Gerhard Sittig g...@denx.de [ a13xp0p0...@gmail.com: turn this into a separate patch ] --- .../devicetree/bindings/dma/mpc512x-dma.txt| 55 ++ 1

[PATCH RFC v10 6/6] dma: mpc512x: register for device tree channel lookup

2014-03-20 Thread Alexander Popov
Register the controller for device tree based lookup of DMA channels (non-fatal for backwards compatibility with older device trees) and provide the '#dma-cells' property in the shared mpc5121.dtsi file Signed-off-by: Gerhard Sittig g...@denx.de Signed-off-by: Alexander Popov a13xp0p0

Re: [PATCH RFC v9 2/6] dma: mpc512x: add support for peripheral transfers

2014-03-19 Thread Alexander Popov
Hello Andy 2014-03-14 13:47 GMT+04:00 Andy Shevchenko andriy.shevche...@linux.intel.com: On Wed, 2014-03-12 at 15:47 +0400, Alexander Popov wrote: + case DMA_SLAVE_CONFIG: + /* Constraints: + * - only transfers between a peripheral device

[PATCH RFC v9 0/6] MPC512x DMA slave s/g support, OF DMA lookup

2014-03-12 Thread Alexander Popov
the feature, regardless of whether all implementations support it. Alexander Popov (5): dma: mpc512x: reorder mpc8308 specific instructions dma: mpc512x: add support for peripheral transfers dma: mpc512x: replace devm_request_irq() with request_irq() dma: of: Add common xlate function

[PATCH RFC v9 1/6] dma: mpc512x: reorder mpc8308 specific instructions

2014-03-12 Thread Alexander Popov
Concentrate the specific code for MPC8308 in the 'if' branch and handle MPC512x in the 'else' branch. This modification only reorders instructions but doesn't change behaviour. Signed-off-by: Alexander Popov a13xp0p0...@gmail.com Acked-by: Anatolij Gustschin ag...@denx.de Acked-by: Gerhard Sittig

[PATCH RFC v9 2/6] dma: mpc512x: add support for peripheral transfers

2014-03-12 Thread Alexander Popov
Introduce support for slave s/g transfer preparation and the associated device control callback in the MPC512x DMA controller driver, which adds support for data transfers between memory and peripheral I/O to the previously supported mem-to-mem transfers. Signed-off-by: Alexander Popov a13xp0p0

[PATCH RFC v9 3/6] dma: mpc512x: replace devm_request_irq() with request_irq()

2014-03-12 Thread Alexander Popov
Replace devm_request_irq() with request_irq() since there is no need to use it because the original code always frees IRQ manually with devm_free_irq(). Replace devm_free_irq() with free_irq() accordingly. Signed-off-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/mpc512x_dma.c | 11

[PATCH RFC v9 4/6] dma: of: Add common xlate function for matching by channel id

2014-03-12 Thread Alexander Popov
-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/of-dma.c | 35 +++ include/linux/of_dma.h | 4 2 files changed, 39 insertions(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index e8fe9dc..d5fbeaa 100644 --- a/drivers/dma/of-dma.c +++ b/drivers

[PATCH RFC v9 5/6] dma: mpc512x: add device tree binding document

2014-03-12 Thread Alexander Popov
From: Gerhard Sittig g...@denx.de introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Gerhard Sittig g...@denx.de [ a13xp0p0...@gmail.com: turn this into a separate patch ] --- .../devicetree/bindings/dma/mpc512x-dma.txt| 55 ++ 1

[PATCH RFC v9 6/6] dma: mpc512x: register for device tree channel lookup

2014-03-12 Thread Alexander Popov
Register the controller for device tree based lookup of DMA channels (non-fatal for backwards compatibility with older device trees) and provide the '#dma-cells' property in the shared mpc5121.dtsi file Signed-off-by: Gerhard Sittig g...@denx.de Signed-off-by: Alexander Popov a13xp0p0

Re: [PATCH RFC v8 5/5] dma: mpc512x: register for device tree channel lookup

2014-03-06 Thread Alexander Popov
Hello Andy. 2014-02-24 17:08 GMT+04:00 Andy Shevchenko andriy.shevche...@linux.intel.com: On Mon, 2014-02-24 at 15:09 +0400, Alexander Popov wrote: @@ -1018,11 +1019,23 @@ static int mpc_dma_probe(struct platform_device *op) /* Register DMA engine */ dev_set_drvdata(dev, mdma

Re: [PATCH RFC v8 2/5] dma: mpc512x: add support for peripheral transfers

2014-03-01 Thread Alexander Popov
Hello Andy. 2014-02-24 17:03 GMT+04:00 Andy Shevchenko andriy.shevche...@linux.intel.com: On Mon, 2014-02-24 at 15:09 +0400, Alexander Popov wrote: Introduce support for slave s/g transfer preparation and the associated device control callback in the MPC512x DMA controller driver, which adds

[PATCH RFC v8 1/5] dma: mpc512x: reorder mpc8308 specific instructions

2014-02-24 Thread Alexander Popov
Concentrate the specific code for MPC8308 in the 'if' branch and handle MPC512x in the 'else' branch. This modification only reorders instructions but doesn't change behaviour. Signed-off-by: Alexander Popov a13xp0p0...@gmail.com Acked-by: Anatolij Gustschin ag...@denx.de Acked-by: Gerhard Sittig

[PATCH RFC v8 0/5] MPC512x DMA slave s/g support, OF DMA lookup

2014-02-24 Thread Alexander Popov
, which should be stated. - The Linux implementation currently has no OF based channel lookup support, so '#dma-cells' is a future feature. I guess the binding can and should already discuss the feature, regardless of whether all implementations support it. Alexander Popov (3): dma

[PATCH RFC v8 2/5] dma: mpc512x: add support for peripheral transfers

2014-02-24 Thread Alexander Popov
Introduce support for slave s/g transfer preparation and the associated device control callback in the MPC512x DMA controller driver, which adds support for data transfers between memory and peripheral I/O to the previously supported mem-to-mem transfers. Signed-off-by: Alexander Popov a13xp0p0

[PATCH RFC v8 3/5] dma: of: Add common xlate function for matching by channel id

2014-02-24 Thread Alexander Popov
-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/of-dma.c | 35 +++ include/linux/of_dma.h | 4 2 files changed, 39 insertions(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index e8fe9dc..d5fbeaa 100644 --- a/drivers/dma/of-dma.c +++ b/drivers

[PATCH RFC v8 4/5] dma: mpc512x: add device tree binding document

2014-02-24 Thread Alexander Popov
From: Gerhard Sittig g...@denx.de introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Gerhard Sittig g...@denx.de [ a13xp0p0...@gmail.com: turn this into a separate patch ] --- .../devicetree/bindings/dma/mpc512x-dma.txt| 55 ++ 1

[PATCH RFC v8 5/5] dma: mpc512x: register for device tree channel lookup

2014-02-24 Thread Alexander Popov
From: Gerhard Sittig g...@denx.de register the controller for device tree based lookup of DMA channels (non-fatal for backwards compatibility with older device trees) and provide the '#dma-cells' property in the shared mpc5121.dtsi file Signed-off-by: Gerhard Sittig g...@denx.de [

Re: [PATCH RFC v7 0/6] MPC512x DMA slave s/g support, OF DMA lookup

2014-02-19 Thread Alexander Popov
Hello, Gerhard 2014-02-13 4:32 GMT+04:00 Gerhard Sittig g...@denx.de: For some reason you have kept the DMA maintainers, but dropped the dmaengine ML from Cc: -- was this intentional, given that the series is specifically about DMA and you want to get feedback? No, it was not done by

Re: [PATCH RFC v7 2/6] dma: mpc512x: add support for peripheral transfers

2014-02-19 Thread Alexander Popov
[ adding dmaengine ML to Cc: ] Thanks for your feedback, Gerhard 2014-02-13 4:07 GMT+04:00 Gerhard Sittig g...@denx.de: On Wed, Feb 12, 2014 at 17:25 +0400, Alexander Popov wrote: /* - * This is initial version of MPC5121 DMA driver. Only memory to memory - * transfers are supported (tested

[PATCH RFC v7 1/6] dma: mpc512x: reorder mpc8308 specific instructions

2014-02-12 Thread Alexander Popov
Concentrate the specific code for MPC8308 in the 'if' branch and handle MPC512x in the 'else' branch. This modification only reorders instructions but doesn't change behaviour. Signed-off-by: Alexander Popov a13xp0p0...@gmail.com Acked-by: Anatolij Gustschin ag...@denx.de Acked-by: Gerhard Sittig

[PATCH RFC v7 0/6] MPC512x DMA slave s/g support, OF DMA lookup

2014-02-12 Thread Alexander Popov
tree binding document for the MPC512x DMA controller needs to be improved. Alexander Popov (3): dma: mpc512x: reorder mpc8308 specific instructions dma: mpc512x: add support for peripheral transfers dma: of: Add common xlate function for matching by channel id Gerhard Sittig (3): dma

[PATCH RFC v7 2/6] dma: mpc512x: add support for peripheral transfers

2014-02-12 Thread Alexander Popov
Introduce support for slave s/g transfer preparation and the associated device control callback in the MPC512x DMA controller driver, which adds support for data transfers between memory and peripheral I/O to the previously supported mem-to-mem transfers. Signed-off-by: Alexander Popov a13xp0p0

[PATCH RFC v7 3/6] dma: of: Add common xlate function for matching by channel id

2014-02-12 Thread Alexander Popov
-by: Alexander Popov a13xp0p0...@gmail.com --- drivers/dma/of-dma.c | 35 +++ include/linux/of_dma.h | 4 2 files changed, 39 insertions(+) diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index e8fe9dc..d5fbeaa 100644 --- a/drivers/dma/of-dma.c +++ b/drivers

[PATCH RFC v7 4/6] dma: mpc512x: add device tree binding document

2014-02-12 Thread Alexander Popov
From: Gerhard Sittig g...@denx.de introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Gerhard Sittig g...@denx.de [ a13xp0p0...@gmail.com: turn this into a separate patch ] --- .../devicetree/bindings/dma/mpc512x-dma.txt| 55 ++ 1

[PATCH RFC v7 5/6] dma: mpc512x: register for device tree channel lookup

2014-02-12 Thread Alexander Popov
From: Gerhard Sittig g...@denx.de register the controller for device tree based lookup of DMA channels (non-fatal for backwards compatibility with older device trees) and provide the '#dma-cells' property in the shared mpc5121.dtsi file Signed-off-by: Gerhard Sittig g...@denx.de [

[PATCH RFC v7 6/6] HACK mmc: mxcmmc: enable clocks for the MPC512x

2014-02-12 Thread Alexander Popov
From: Gerhard Sittig g...@denx.de QD HACK to enable SD card support without correct COMMON_CLK support, best viewed with 'git diff -w -b', NOT acceptable for mainline (NAKed) Signed-off-by: Gerhard Sittig g...@denx.de [ a13xp0p0...@gmail.com: resolve little patch conflict ] ---

Re: [PATCH RFC v6 4/5] dma: mpc512x: register for device tree channel lookup

2014-01-13 Thread Alexander Popov
one DMA channel is fully dedicated to DDR). All DMA channels of MPC512x DMA controller belong to one dma_device. So we _don't_ need setting DMA_PRIVATE flag for this dma_device at all, do we? On Sat, Jan 04, 2014 at 00:54 +0400, Alexander Popov wrote: I've involved DMA_PRIVATE flag because new

Re: [PATCH RFC v6 4/5] dma: mpc512x: register for device tree channel lookup

2014-01-03 Thread Alexander Popov
Hello Gerhard. Thanks for your review. 2013/12/26 Gerhard Sittig g...@denx.de: [ dropping devicetree, we're DMA specific here ] On Tue, Dec 24, 2013 at 16:06 +0400, Alexander Popov wrote: --- a/drivers/dma/mpc512x_dma.c +++ b/drivers/dma/mpc512x_dma.c [ ... ] @@ -950,6 +951,7 @@ static

  1   2   >