Re: Calculating array sizes in C - was: Re: Build regressions/improvements in v6.2-rc1

2023-01-17 Thread Geert Uytterhoeven
Hi Adrian, On Tue, Jan 17, 2023 at 5:42 PM John Paul Adrian Glaubitz wrote: > On 1/6/23 16:17, Geert Uytterhoeven wrote: > >> I'm not seeing this one, but I am getting this one instead: > >> > >> In file included from ./arch/sh/include/asm/hw_irq.h:6, > >>

Re: [PATCH v4] arch: rename all internal names __xchg to __arch_xchg

2023-01-16 Thread Geert Uytterhoeven
v4: adjusted indentation (Heiko) > arch/m68k/include/asm/cmpxchg.h | 6 +++--- Acked-by: Geert Uytterhoeven [m68k] Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with tech

Re: Build regressions/improvements in v6.2-rc1

2023-01-06 Thread Geert Uytterhoeven
On Fri, Jan 6, 2023 at 4:17 PM Geert Uytterhoeven wrote: > > Hi John, Bummer, "Hi Adrian", ofc ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technica

Re: Build regressions/improvements in v6.2-rc1

2023-01-06 Thread Geert Uytterhoeven
Hi John, On Fri, Jan 6, 2023 at 4:10 PM John Paul Adrian Glaubitz wrote: > On 12/27/22 09:35, Geert Uytterhoeven wrote: > >+ /kisskb/src/include/linux/compiler_types.h: error: call to > > '__compiletime_assert_262' declared with attribute error: Unsupported > > access

Re: [PATCH v2] arch: rename all internal names __xchg to __arch_xchg

2023-01-02 Thread Geert Uytterhoeven
On Thu, Dec 29, 2022 at 12:34 PM Andrzej Hajda wrote: > __xchg will be used for non-atomic xchg macro. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Arnd Bergmann Acked-by: Geert Uytterhoeven [m68k] Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven --

Re: Build regressions/improvements in v6.2-rc1

2022-12-27 Thread Geert Uytterhoeven
On Tue, 27 Dec 2022, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v6.2-rc1[1] compared to v6.1[2]. Summarized: - build errors: +11/-13 amd-...@lists.freedesktop.org linux-arm-ker...@lists.infradead.org linux-me...@vger.kernel.org linux-wirel

Re: [PATCH 00/19] Introduce __xchg, non-atomic xchg

2022-12-22 Thread Geert Uytterhoeven
to answer: > > 1. Name of the helper, __xchg follows kernel conventions, > but for me Rust names are also OK. Before I realized the missing "&", I wondered how this is different from swap(), so naming is important. https://elixir.bootlin.com/linux/latest/source/incl

[PATCH 08/11] arm64: dts: marvell: Fix pca954x i2c-mux node names

2022-12-02 Thread Geert Uytterhoeven
I2C bus multiplexer/switch DT bindings and the Generic Names Recommendation in the Devicetree Specification. Signed-off-by: Geert Uytterhoeven --- arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 2 +- arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts | 2 +- 2 files changed

[PATCH 02/11] ARM: dts: aspeed: Fix pca954x i2c-mux node names

2022-12-02 Thread Geert Uytterhoeven
to match the I2C bus multiplexer/switch DT bindings and the Generic Names Recommendation in the Devicetree Specification. Note that a few nodes are moved, to preserve sort order. Signed-off-by: Geert Uytterhoeven --- .../boot/dts/aspeed-bmc-bytedance-g220a.dts | 18 .../dts/aspeed-bmc-face

[PATCH 01/11] ARM: dts: ti: Fix pca954x i2c-mux node names

2022-12-02 Thread Geert Uytterhoeven
to match the I2C bus multiplexer/switch DT bindings and the Generic Names Recommendation in the Devicetree Specification. Signed-off-by: Geert Uytterhoeven --- arch/arm/boot/dts/am3874-iceboard.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/am3874-

[PATCH 05/11] ARM: dts: socfpga: Fix pca9548 i2c-mux node name

2022-12-02 Thread Geert Uytterhoeven
o "i2c-mux", to match the I2C bus multiplexer/switch DT bindings and the Generic Names Recommendation in the Devicetree Specification. Signed-off-by: Geert Uytterhoeven --- arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH 00/11] Fix pca954x i2c-mux node names

2022-12-02 Thread Geert Uytterhoeven
2c/i2c-mux-pca954x.yaml Please apply where appropriate. Thanks! Geert Uytterhoeven (11): ARM: dts: ti: Fix pca954x i2c-mux node names ARM: dts: aspeed: Fix pca954x i2c-mux node names ARM: dts: imx: Fix pca9547 i2c-mux node name ARM: dts: nuvoton: Fix pca954x i2c-mux node names ARM: dts: so

[PATCH 04/11] ARM: dts: nuvoton: Fix pca954x i2c-mux node names

2022-12-02 Thread Geert Uytterhoeven
-mux", to match the I2C bus multiplexer/switch DT bindings and the Generic Names Recommendation in the Devicetree Specification. Signed-off-by: Geert Uytterhoeven --- arch/arm/boot/dts/nuvoton-npcm730-gbs.dts| 16 arch/arm/boot/dts/nuvoton-npcm730-gsj.dts| 2 +

[PATCH 06/11] ARM: dts: vf610: Fix pca9548 i2c-mux node names

2022-12-02 Thread Geert Uytterhoeven
o "i2c-mux", to match the I2C bus multiplexer/switch DT bindings and the Generic Names Recommendation in the Devicetree Specification. Signed-off-by: Geert Uytterhoeven --- arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 2 +- arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +- 2 files changed

[PATCH 10/11] MIPS: mscc: jaguar2: Fix pca9545 i2c-mux node names

2022-12-02 Thread Geert Uytterhoeven
ultiplexer/switch DT bindings and the Generic Names Recommendation in the Devicetree Specification. Signed-off-by: Geert Uytterhoeven --- arch/mips/boot/dts/mscc/jaguar2_pcb110.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/boot/dts/mscc/jaguar2_pcb110.dts

[PATCH 03/11] ARM: dts: imx: Fix pca9547 i2c-mux node name

2022-12-02 Thread Geert Uytterhoeven
to match the I2C bus multiplexer/switch DT bindings and the Generic Names Recommendation in the Devicetree Specification. Signed-off-by: Geert Uytterhoeven --- arch/arm/boot/dts/imx53-ppd.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx53-ppd.dts b/arch/arm/bo

[PATCH 07/11] arm64: dts: freescale: Fix pca954x i2c-mux node names

2022-12-02 Thread Geert Uytterhoeven
r/switch DT bindings and the Generic Names Recommendation in the Devicetree Specification. Signed-off-by: Geert Uytterhoeven --- arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts| 2 +- arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts| 2 +- arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts

[PATCH 11/11] powerpc: dts: fsl: Fix pca954x i2c-mux node names

2022-12-02 Thread Geert Uytterhoeven
r/switch DT bindings and the Generic Names Recommendation in the Devicetree Specification. Signed-off-by: Geert Uytterhoeven --- arch/powerpc/boot/dts/fsl/t1024qds.dts | 2 +- arch/powerpc/boot/dts/fsl/t1024rdb.dts | 2 +- arch/powerpc/boot/dts/fsl/t104xqds.dtsi | 2 +- arch/powerpc/boot/dts/fsl/t104xr

[PATCH 09/11] arm64: dts: renesas: ulcb-kf: Fix pca9548 i2c-mux node names

2022-12-02 Thread Geert Uytterhoeven
s multiplexer/switch DT bindings and the Generic Names Recommendation in the Devicetree Specification. While at it, rename the labels too, for uniformity. Signed-off-by: Geert Uytterhoeven --- To be queued in renesas-devel for v6.3. --- arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 4 ++-- 1 file c

Re: [PATCH 2/5] arm: dts: remove label = "cpu" from DSA dt-binding

2022-11-30 Thread Geert Uytterhoeven
CC cleger On Wed, Nov 30, 2022 at 3:33 PM Arınç ÜNAL wrote: > This is not used by the DSA dt-binding, so remove it from all devicetrees. > > Signed-off-by: Arınç ÜNAL > arch/arm/boot/dts/r9a06g032.dtsi | 1 - Acked-by: Geert Uytterhoeven > --- a/ar

Re: [PATCH] mm: remove kern_addr_valid() completely

2022-10-18 Thread Geert Uytterhoeven
, so no need kern_addr_valid(), > let's remove unneeded kern_addr_valid() completely. > > Signed-off-by: Kefeng Wang > arch/m68k/include/asm/pgtable_mm.h| 2 - > arch/m68k/include/asm/pgtable_no.h | 1 - Acked-by: Geert Uytterhoeven [m68k] Gr{oetje,eeting}s,

Re: [PATCH net-next v5 05/14] net: fman: Map the base address once

2022-10-17 Thread Geert Uytterhoeven
Hi Sean, On Mon, Oct 17, 2022 at 5:34 PM Sean Anderson wrote: > On 10/17/22 11:15 AM, Geert Uytterhoeven wrote: > > On Sat, Sep 3, 2022 at 12:00 AM Sean Anderson > > wrote: > >> We don't need to remap the base address from the resource twice (once in &g

Re: [PATCH net-next v5 05/14] net: fman: Map the base address once

2022-10-17 Thread Geert Uytterhoeven
tual addresses are useless in user space. Moreover, addresses printed by "%p" are obfuscated, as this is considered a security issue. Likewise for working around this by casting to an integer. What's the real purpose of dpaa_eth_show_addr()? Perhaps it should be removed? >

Re: [PATCH v3 4/4] drm/ofdrm: Support color management

2022-09-23 Thread Geert Uytterhoeven
io_of_addr[3] = { 0x0001, 0x0, 0x0 }; > +#endif You can easily get rid of the #ifdef: static const __be32 io_of_addr[3] = { cpu_to_be32(0x0100), 0x0, 0x0 }; And probably sparse ("make C=2") will complain about the plain zeros, so "cpu_to_be32(0x0)" as well. Gr

Re: [PATCH v3 1/4] drm/ofdrm: Add ofdrm for Open Firmware framebuffers

2022-09-23 Thread Geert Uytterhoeven
e_legacy_fb_format(32, 24); Shouldn't all of these use drm_driver_legacy_fb_format() (and the driver set drm_mode_config.quirk_addfb_prefer_host_byte_order) to have a chance of working on traditional big-endian PPC? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux bey

Re: [PATCH v2 10/10] drm/ofdrm: Support color management

2022-09-21 Thread Geert Uytterhoeven
t; > These guys could just be replaced with readb/writel/readl respectively > > (beware of the argument swap). > > I only added them for COMPILE_TEST. There appears to be no portable > interface that implements out_le32() and in_le32()? iowrite32() and ioread32()? Gr{oetje,eeting}s,

Re: [PATCH] kernel: exit: cleanup release_thread()

2022-08-19 Thread Geert Uytterhoeven
*leader; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [PATCH] arch: mm: rename FORCE_MAX_ZONEORDER to ARCH_FORCE_MAX_ORDER

2022-08-16 Thread Geert Uytterhoeven
| 2 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalist

Re: Build regressions/improvements in v6.0-rc1

2022-08-15 Thread Geert Uytterhoeven
On Mon, 15 Aug 2022, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v6.0-rc1[1] compared to v5.19[2]. Summarized: - build errors: +26/-15 + /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: .cfi_endproc without corresponding

Re: [PATCH v5] random: remove CONFIG_ARCH_RANDOM

2022-08-12 Thread Geert Uytterhoeven
.g. RDRAND), if supported and available. These This change means everyone configuring a kernel will be asked this question, even when configuring for an architecture that does not support RNG instructions. Perhaps this question should be hidden behind EXPERT? Gr{oetje,eeting}s,

Re: Build regressions/improvements in v5.19-rc8

2022-07-25 Thread Geert Uytterhoeven
On Mon, 25 Jul 2022, Geert Uytterhoeven wrote: JFYI, when comparing v5.19-rc8[1] to v5.19-rc7[3], the summaries are: - build errors: +1/-5 + /kisskb/src/include/ufs/ufshci.h: error: initializer element is not constant: => 245:36 v5.19-rc8/powerpc-gcc5/ppc64_book3e_allmodconfig v5.19-

Re: [PATCH v4 2/3] PCI: Move isa_dma_bridge_buggy out of dma.h

2022-07-20 Thread Geert Uytterhoeven
: Christoph Hellwig > Signed-off-by: Stafford Horne > --- > Since v3: > - New patch. > arch/m68k/include/asm/dma.h | 6 -- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

Re: [PATCH] powerpc/ps3: Fix comment typo

2022-07-19 Thread Geert Uytterhoeven
On Mon, Jul 18, 2022 at 3:48 PM Jason Wang wrote: > The double `when' is duplicated in line 1069, remove one. > > Signed-off-by: Jason Wang Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond i

Re: [PATCH v3 1/2] asm-generic: Remove pci.h copying remaining code to x86

2022-07-18 Thread Geert Uytterhoeven
l.org/lkml/CAK8P3a0JmPeczfmMBE__vn=Jbvf=nkbpvazcycyv40pzncj...@mail.gmail.com/ > Signed-off-by: Stafford Horne > --- > Since v2: > - Remove pci_get_legacy_ide_irq in m68k > Since v1: > - Remove pci_get_legacy_ide_irq for most architectures as its not needed. > arch/m68k/inc

Re: [PATCH v2 1/2] asm-generic: Remove pci.h copying remaining code to x86

2022-07-17 Thread Geert Uytterhoeven
nel) > +{ > + return channel ? 15 : 14; > +} > + I thought you were not going to add this? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I cal

Re: [PATCH 19/36] objtool/idle: Validate __cpuidle code as noinstr

2022-07-06 Thread Geert Uytterhoeven
/kernel/vmlinux-nommu.lds |1 - > arch/m68k/kernel/vmlinux-std.lds |1 - > arch/m68k/kernel/vmlinux-sun3.lds |1 - FWIW Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge

Re: [PATCH V6 26/26] mm/mmap: Drop ARCH_HAS_VM_GET_PAGE_PROT

2022-07-06 Thread Geert Uytterhoeven
/m68k/Kconfig | 1 - Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But wh

Re: [PATCH V6 21/26] m68k/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT

2022-07-06 Thread Geert Uytterhoeven
lying read and execute) and writeable. > These > * are as close as we can get... > */ The comment above should be removed, too. > -#define __P000 PAGE_NONE > -#define __P001 PAGE_READONLY With the above fixed: Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-28 Thread Geert Uytterhoeven
Hi Michael, On Tue, Jun 28, 2022 at 5:26 AM Michael Schmitz wrote: > Am 28.06.2022 um 09:12 schrieb Michael Schmitz: > > On 27/06/22 20:26, Geert Uytterhoeven wrote: > >> On Sat, Jun 18, 2022 at 3:06 AM Michael Schmitz > >> wrote: > >>> Am 18.06.2022 um 0

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-27 Thread Geert Uytterhoeven
e at all. FTR, the sgiwd93 driver use dma_map_single(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. Bu

Re: [PATCH 1/4] hugetlb: skip to end of PT page mapping when pte not present

2022-06-17 Thread Geert Uytterhoeven
return PGDIR_SIZE - P4D_SIZE; > > + case PUD_SIZE: > > + return P4D_SIZE - PUD_SIZE; > > + case PMD_SIZE: > > + return PUD_SIZE - PMD_SIZE; > > + default: > > Should we add a WARN_ON_ONCE() if it should never tr

Re: [PATCH 6/6] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-07 Thread Geert Uytterhoeven
letely. > > Signed-off-by: Arnd Bergmann > arch/m68k/Kconfig | 1 - > arch/m68k/include/asm/virtconvert.h | 4 +- Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeve

Re: Build regressions/improvements in v5.19-rc1

2022-06-06 Thread Geert Uytterhoeven
On Mon, 6 Jun 2022, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v5.19-rc1[1] compared to v5.18[2]. Summarized: - build errors: +9/-10 [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/f2906aa863381afb0015a9eb7fefad885d4e5a56/ (all

Re: [PATCH net-next] eth: de4x5: remove support for Generic DECchip & DIGITAL EtherWORKS PCI/EISA

2022-05-26 Thread Geert Uytterhoeven
(UDB/Multia) or PPC (CHRP), but switched to the TULIP driver later (that was before the dc2104x/dc2114x driver split, hence a lng time ago). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux

Re: [PATCH v3] mm: Avoid unnecessary page fault retires on shared memory types

2022-05-25 Thread Geert Uytterhoeven
VM_FAULT_RETRY even with existing code, so I'm literally keeping > them as-is. > > Signed-off-by: Peter Xu > arch/m68k/mm/fault.c | 4 Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linu

Re: [PATCH 2/2] drm/tiny: Add ofdrm for Open Firmware framebuffers

2022-05-19 Thread Geert Uytterhoeven
amp; MMU && PPC > > Does this build with !PCI? > > The driver uses some PCI functions, so it might possibly break with > randconfig. I don't think there are practical !PCI PPC configurations. IIRC, the first PowerMacs didn't have PCI. Gr{oetje,eeting}s,

Re: [RFC v2 01/39] Kconfig: introduce HAS_IOPORT option and select it as necessary

2022-05-06 Thread Geert Uytterhoeven
Hi David On Fri, May 6, 2022 at 4:05 PM David Laight wrote: > From: Geert Uytterhoeven > > Sent: 06 May 2022 14:09 > > > The same is really true for other bus type - including ISA and EISA. > > > (Ignoring the horrid of probing ISI bus devices - hopefully they &

Re: [RFC v2 01/39] Kconfig: introduce HAS_IOPORT option and select it as necessary

2022-05-06 Thread Geert Uytterhoeven
uire a single CPU instruction to read or write from > the configuration space. To access the conventional PCI configuration > space in a direct linear manner you need 256 * 21 * 8 * 256 = 10.5MiB of > address space. Such amount of address space seems affordable even with > 32-

Re: [RFC v2 01/39] Kconfig: introduce HAS_IOPORT option and select it as necessary

2022-05-06 Thread Geert Uytterhoeven
that return tokens appropriate for the specific bus. > > That is all a different load of churn. A lng time ago, it was suggested to add register accessor functions to struct device, so e.g. readl(dev, offset) would call into these accessors, which would implement the bus-specific behavi

Re: [PATCH] net: unexport csum_and_copy_{from,to}_user

2022-04-23 Thread Geert Uytterhoeven
.c | 2 -- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I ju

Re: Build regressions/improvements in v5.17

2022-03-21 Thread Geert Uytterhoeven
On Mon, Mar 21, 2022 at 3:00 PM Geert Uytterhoeven wrote: > JFYI, when comparing v5.17[1] to v5.17-rc8[3], the summaries are: > - build errors: +5/-0 + /kisskb/src/crypto/blake2b_generic.c: error: the frame size of 2288 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]: =&

Re: [PATCH] macintosh/via-pmu: Fix build failure when CONFIG_INPUT is disabled

2022-03-21 Thread Geert Uytterhoeven
> > via-pmu-event.c:(.init.text+0xd4): undefined reference to > > > `input_free_device' > > > make[1]: *** [Makefile:1155: vmlinux] Error 1 > > > make: *** [Makefile:350: __build_one_by_one] Error 2 > > > > > > Don't call into the input subsystem unle

Re: [PATCH] macintosh/via-pmu: Fix build failure when CONFIG_INPUT is disabled

2022-03-19 Thread Geert Uytterhoeven
into the input subsystem unless CONFIG_INPUT is built-in. > > Reported-by: kernel test robot > Cc: Michael Ellerman > Cc: Geert Uytterhoeven > Signed-off-by: Finn Thain Thanks for your patch! > --- a/drivers/macintosh/Makefile > +++ b/drivers/macintosh/Makefile > @@ -12

Re: Build regressions/improvements in v5.17-rc7

2022-03-07 Thread Geert Uytterhoeven
On Mon, Mar 7, 2022 at 10:21 AM Geert Uytterhoeven wrote: > JFYI, when comparing v5.17-rc7[1] to v5.17-rc6[3], the summaries are: > - build errors: +4/-1 + /kisskb/src/arch/powerpc/kernel/stacktrace.c: error: implicit declaration of function 'nmi_cpu_backtrace' [-Werror=implicit-fu

Re: [PATCH V3 09/30] arm/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT

2022-03-02 Thread Geert Uytterhoeven
Hi Anshuman, On Wed, Mar 2, 2022 at 12:07 PM Anshuman Khandual wrote: > On 3/2/22 3:35 PM, Geert Uytterhoeven wrote: > > On Wed, Mar 2, 2022 at 10:51 AM Anshuman Khandual > > wrote: > >> On 3/2/22 12:35 PM, Christophe Leroy wrote: > >>> Le 02/03/202

Re: [PATCH V3 09/30] arm/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT

2022-03-02 Thread Geert Uytterhoeven
ion. > > > > As this is bad for ARM and bad for PPC32, do we have any evidence that > > your change is good for any other architecture ? > > > > I checked PPC64 and there is exactly the same drawback. With the current > > implementation it is a small function performing ta

Re: [PATCH V3 09/30] arm/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT

2022-02-28 Thread Geert Uytterhoeven
ifferent) cases is offset by a 16-bit jump table (which is to be credited to the compiler). In terms of CPU cycles, it's indeed worse than before. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal co

Re: [PATCH v2 13/18] uaccess: generalize access_ok()

2022-02-18 Thread Geert Uytterhoeven
h/m68k/Kconfig.cpu | 1 + > arch/m68k/include/asm/uaccess.h | 19 +---- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations wit

Re: [PATCH v2 10/18] m68k: fix access_ok for coldfire

2022-02-18 Thread Geert Uytterhoeven
pilers that warn (or worse with -Werror) about "condition always true" for TASK_SIZE = 0xUL? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversat

Re: [PATCH v2 08/18] uaccess: add generic __{get,put}_kernel_nofault

2022-02-18 Thread Geert Uytterhoeven
ormal > copy_{from,to}_kernel_nofault() code based on these, removing the last > use of get_fs()/set_fs() from architecture-independent code. > > Reviewed-by: Christoph Hellwig > Signed-off-by: Arnd Bergmann > arch/m68k/include/asm/uaccess.h | 2 - Acked-by: Ge

Re: Build regressions/improvements in v5.17-rc4

2022-02-14 Thread Geert Uytterhoeven
On Mon, 14 Feb 2022, Geert Uytterhoeven wrote: JFYI, when comparing v5.17-rc4[1] to v5.17-rc3[3], the summaries are: - build errors: +1/-0 + error: arch/powerpc/kvm/book3s_64_entry.o: relocation truncated to fit: R_PPC64_REL14 (stub) against symbol `system_reset_common' defined in .text

Re: Build regressions/improvements in v5.17-rc2

2022-02-01 Thread Geert Uytterhoeven
On Mon, 31 Jan 2022, Geert Uytterhoeven wrote: JFYI, when comparing v5.17-rc2[1] to v5.17-rc1[3], the summaries are: - build errors: +1/-3 + error: arch/powerpc/kvm/book3s_64_entry.o: relocation truncated to fit: R_PPC64_REL14 (stub) against symbol `system_reset_common' defined in .text

Re: Build regressions/improvements in v5.17-rc1

2022-01-24 Thread Geert Uytterhoeven
Hi Alex, On Mon, Jan 24, 2022 at 7:52 PM Alex Deucher wrote: > On Mon, Jan 24, 2022 at 5:25 AM Geert Uytterhoeven > wrote: > > On Sun, 23 Jan 2022, Geert Uytterhoeven wrote: > > > + /kisskb/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: > > > error: c

Re: Build regressions/improvements in v5.17-rc1

2022-01-24 Thread Geert Uytterhoeven
On Sun, 23 Jan 2022, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v5.17-rc1[1] compared to v5.16[2]. Summarized: - build errors: +17/-2 - build warnings: +23/-25 Note that there may be false regressions, as some logs are incomplete. Still

Re: [RFC 02/32] Kconfig: introduce HAS_IOPORT option and select it as necessary

2021-12-29 Thread Geert Uytterhoeven
ks way too broad to me: most m68k platform do not have I/O port access support. My gut feeling says: select HAS_IOPORT if PCI || ISA but that might miss some intricate details... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32

Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority

2021-12-13 Thread Geert Uytterhoeven
because invocation order of > > >> the call chain depends on the registration order > > > > > > It doesn't if unique priorities are required and isn't that what you want? > > > > > >> and some of current > > >> users may rely on that

Re: [PATCH 1/1] futex: Wireup futex_waitv syscall

2021-11-24 Thread Geert Uytterhoeven
On Wed, Nov 24, 2021 at 2:21 PM André Almeida wrote: > Wireup futex_waitv syscall for all remaining archs. > > Signed-off-by: André Almeida > arch/m68k/kernel/syscalls/syscall.tbl | 1 + Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Gee

Re: Build regressions/improvements in v5.16-rc2

2021-11-22 Thread Geert Uytterhoeven
On Mon, Nov 22, 2021 at 12:28 PM Geert Uytterhoeven wrote: > Below is the list of build error/warning regressions/improvements in > v5.16-rc2[1] compared to v5.15[2]. > > Summarized: > - build errors: +13/-12 > - build warnings: +3/-26 > > JFYI, when comparing v5.

Re: Build regressions/improvements in v5.16-rc1

2021-11-17 Thread Geert Uytterhoeven
e, as I > didn't see anything about it in the maintainer guide. All patches must be sent to public mailing lists for review. You might get away with not doing that for a simple and trivial fix, but be prepared to end up on people's "special" lists if you did get it wrong. We are Legion

Re: Build regressions/improvements in v5.16-rc1

2021-11-15 Thread Geert Uytterhoeven
On Mon, Nov 15, 2021 at 4:54 PM Geert Uytterhoeven wrote: > Below is the list of build error/warning regressions/improvements in > v5.16-rc1[1] compared to v5.15[2]. > > Summarized: > - build errors: +20/-13 > - build warnings: +3/-28 > > Happy fixing! ;-) > >

Re: [PATCH/RFC] of: Shrink struct of_device_id

2021-11-10 Thread Geert Uytterhoeven
Hi Rasmus, On Wed, Nov 10, 2021 at 5:51 PM Rasmus Villemoes wrote: > On 10/11/2021 17.23, Geert Uytterhoeven wrote: > > Currently struct of_device_id is 196 (32-bit) or 200 (64-bit) bytes > > large. It contains fixed-size strings for a name, a type, and a > > compatible val

[PATCH/RFC] of: Shrink struct of_device_id

2021-11-10 Thread Geert Uytterhoeven
is used... Reduce kernel size by reducing the sizes of the fixed strings by one half. This reduces the size of an ARM multi_v7_defconfig kernel by ca. 400 KiB. For a typical kernel supporting a single board, you can expect to save 50-100 KiB. Signed-off-by: Geert Uytterhoeven --- Notes: - While

Re: [PATCH v0 42/42] notifier: Return an error when callback is already registered

2021-11-08 Thread Geert Uytterhoeven
Hi Borislav, On Mon, Nov 8, 2021 at 4:59 PM Borislav Petkov wrote: > On Mon, Nov 08, 2021 at 04:25:47PM +0100, Geert Uytterhoeven wrote: > > I'm not against returning proper errors codes. I'm against forcing > > callers to check things that cannot fail and to add individual err

Re: [PATCH v0 42/42] notifier: Return an error when callback is already registered

2021-11-08 Thread Geert Uytterhoeven
Hi Borislav, On Mon, Nov 8, 2021 at 3:21 PM Borislav Petkov wrote: > On Mon, Nov 08, 2021 at 03:07:03PM +0100, Geert Uytterhoeven wrote: > > I think the addition of __must_check is overkill, leading to the > > addition of useless error checks and message printing. &

Re: [PATCH v0 42/42] notifier: Return an error when callback is already registered

2021-11-08 Thread Geert Uytterhoeven
age printing. Many callers call this where it cannot fail, and where nothing can be done in the very unlikely event that the call would ever start to fail. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In

Re: [PATCH v3 21/25] m68k: Switch to new sys-off handler API

2021-11-07 Thread Geert Uytterhoeven
n fact it does nothing], > while it's machine_power_off() that should invoke the pm_power_off(), and > thus, we can't convert platforms to the new API separately. There are only > two platforms changed here, so it's not a big deal. > > Signed-off-by: Dmitry Osipenko Acked-by: Geert Uytterhoeven

[PATCH] usb: gadget: Mark USB_FSL_QE broken on 64-bit

2021-10-27 Thread Geert Uytterhoeven
ddr); |^ The driver assumes physical and virtual addresses are 32-bit, hence it cannot work on 64-bit platforms. Signed-off-by: Geert Uytterhoeven --- One more casualty of CONFIG_WERROR=y. http://kisskb.ellerman.id.au/kisskb/buildresult/14652936/ --- drivers/usb/gadget/udc/Kconfig | 1 + 1 file changed

[PATCH] serial: cpm_uart: Protect udbg definitions by CONFIG_SERIAL_CPM_CONSOLE

2021-10-27 Thread Geert Uytterhoeven
to CONFIG_CONSOLE_POLL. Fixes: a60526097f42eb98 ("tty: serial: cpm_uart: Add udbg support for enabling xmon") Signed-off-by: Geert Uytterhoeven --- One more casualty of CONFIG_WERROR=y. http://kisskb.ellerman.id.au/kisskb/buildresult/14652935/ --- drivers/tty/serial/cpm_uart/cpm_uart_core.c

Re: [PATCH 21/20] signal: Replace force_sigsegv(SIGSEGV) with force_fatal_sig(SIGSEGV)

2021-10-21 Thread Geert Uytterhoeven
e clearer. > > Signed-off-by: "Eric W. Biederman" > arch/m68k/kernel/traps.c | 2 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations w

Re: [PATCH 2/2] kbuild: use more subdir- for visiting subdirectories while cleaning

2021-10-13 Thread Geert Uytterhoeven
;), we can use the "subdir- += boot" trick for > all architectures. This can take advantage of the parallel option (-j) > for "make clean". > > I also cleaned up the comments. The "archdep" target does not exist. > > Signed-off-by: Masahiro Yamada >

Re: [PATCH 1/2] firmware: include drivers/firmware/Kconfig unconditionally

2021-10-11 Thread Geert Uytterhoeven
> ARM System Control and Management Interface Protocol > [ ] Add firmware-provided memory map to sysfs > [ ] Google Firmware Drivers > Tegra firmware driver GOOGLE_FIRMWARE should probably depend on something. I highly doubt Google is ru

Re: [PATCH 1/4] crypto: nintendo-aes - add a new AES driver

2021-09-28 Thread Geert Uytterhoeven
e compile tested for > non-powerpc, which will fail on the dcbf instructions. > > Perhaps use this instead: > >depends on WII || WIIU || (COMPILE_TEST && PPC) Or: depends on PPC depends on WII || WIIU || COMPILE_TEST to distinguish between hard and soft depend

[PATCH v2 2/2] serial: 8250: SERIAL_8250_FSL should depend on Freescale platforms

2021-09-24 Thread Geert Uytterhoeven
The Freescale 16550-style UART is only present on some Freescale SoCs. Hence tighten the dependencies to prevent asking the user about this driver, and possibly defaulting it to be enabled, when configuring a kernel without appropriate Freescale SoC or ACPI support. Signed-off-by: Geert

[PATCH v2 1/2] serial: 8250: SERIAL_8250_FSL should not default to y when compile-testing

2021-09-24 Thread Geert Uytterhoeven
ault again, but making the SERIAL_8250_FSL symbol visible instead. Fixes: b1442c55ce8977aa ("serial: 8250: extend compile-test coverage") Signed-off-by: Geert Uytterhoeven --- v2: - Split in two parts. --- drivers/tty/serial/8250/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 dele

Re: Build regressions/improvements in v5.15-rc2

2021-09-20 Thread Geert Uytterhoeven
On Mon, 20 Sep 2021, Geert Uytterhoeven wrote: JFYI, when comparing v5.15-rc2[1] to v5.15-rc1[3], the summaries are: - build errors: +9/-49 + /kisskb/src/arch/sparc/lib/iomap.c: error: redefinition of 'pci_iounmap': => 22:6 sparc64/sparc64-allnoconfig + /kisskb/src/drivers/iio/t

Re: [PATCH] serial: 8250: SERIAL_8250_FSL should not default to y when compile-testing

2021-09-16 Thread Geert Uytterhoeven
Hi Johan, On Thu, Sep 16, 2021 at 10:46 AM Johan Hovold wrote: > On Wed, Sep 15, 2021 at 02:56:52PM +0200, Geert Uytterhoeven wrote: > > Commit b1442c55ce8977aa ("serial: 8250: extend compile-test coverage") > > added compile-test support to the Freesca

[PATCH] serial: 8250: SERIAL_8250_FSL should not default to y when compile-testing

2021-09-15 Thread Geert Uytterhoeven
. Tighten the dependencies to prevent asking the user about this driver when configuring a kernel without appropriate Freescale SoC or ACPI support. Fixes: b1442c55ce8977aa ("serial: 8250: extend compile-test coverage") Signed-off-by: Geert Uytterhoeven --- Yes, it's ugly, but I see no bet

[PATCH] nvmem: NVMEM_NINTENDO_OTP should depend on WII

2021-09-14 Thread Geert Uytterhoeven
river for the Wii and Wii U OTP") Signed-off-by: Geert Uytterhoeven --- drivers/nvmem/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig index 39854d43758be3fb..da414617a54d4b99 100644 --- a/drivers/nvmem/Kconfig +++ b/drivers/nvm

Re: [PATCH printk v4 3/6] printk: remove safe buffers

2021-09-02 Thread Geert Uytterhoeven
very much for reducing kernel size by ca. 8 KiB! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journ

Re: [PATCH] arch: Kconfig: clean up obsolete use of HAVE_IDE

2021-07-30 Thread Geert Uytterhoeven
eed to mention > HAVE_IDE in all those arch-specific Kconfig files. > > The issue was identified with ./scripts/checkkconfigsymbols.py. > > Fixes: b7fb14d3ac63 ("ide: remove the legacy ide driver") > Suggested-by: Randy Dunlap > Signed-off-by: Lukas Bulwahn > arch/m

Re: [PATCH v4 5/5] bus: Make remove callback return void

2021-07-14 Thread Geert Uytterhoeven
ted buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > drivers/zorro/zorro-driver.c | 3 +-- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Li

Re: powerpc/spider-pci: Remove set but not used variable 'val'

2021-07-02 Thread Geert Uytterhoeven
https://lore.kernel.org/r/20210601085319.140461-1-libaok...@huawei.com Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalist

Re: [PATCH v19 05/13] of: Add a common kexec FDT setup function

2021-06-15 Thread Geert Uytterhoeven
goto out; > + > + ret = fdt_add_mem_rsv(fdt, initrd_load_addr, initrd_len); > + if (ret) > + goto out; > + > + } else { > + ret = fdt_delprop(fdt, chosen_node, FDT_PROP_INITRD_START); > + if (r

Re: [PATCH v2 1/2] mm: rename pud_page_vaddr to pud_pgtable and make it return pmd_t *

2021-06-15 Thread Geert Uytterhoeven
On Tue, Jun 15, 2021 at 1:32 PM Aneesh Kumar K.V wrote: > No functional change in this patch. > Signed-off-by: Aneesh Kumar K.V > arch/m68k/include/asm/motorola_pgtable.h | 2 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uyt

Re: [PATCH v2 8/9] mm: replace CONFIG_NEED_MULTIPLE_NODES with CONFIG_NUMA

2021-06-07 Thread Geert Uytterhoeven
pnr; - EXPORT_SYMBOL(max_mapnr); - Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to jo

Re: [PATCH v2 0/9] Remove DISCINTIGMEM memory model

2021-06-07 Thread Geert Uytterhoeven
Hi Mike, You may want to fix the DISCINTIGMEM typo in the subject for v3, unless you think that makes tracking series versions more complicated ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal

Re: [PATCH 4/9] m68k: remove support for DISCONTIGMEM

2021-06-02 Thread Geert Uytterhoeven
or your patch! Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven > --- a/arch/m68k/include/asm/page_mm.h > +++ b/arch/m68k/include/asm/page_mm.h > @@ -126,25 +126,7 @@ static inline void *__va(unsigned long x) > > extern int m68k_virt_to_node_shift; > > -#ifndef

Re: [PATCH] mm: generalize ZONE_[DMA|DMA32]

2021-05-27 Thread Geert Uytterhoeven
e both ZONE_DMA and > ZONE_DMA32 if EXPERT, add ARCH_HAS_ZONE_DMA_SET to make dma zone > configurable and visible on the two architectures. > > Cc: Andrew Morton > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Geert Uytterhoeven > Cc: Thomas Bogendoerfer > Cc: "Davi

Re: [PATCH 19/26] nfblock: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-21 Thread Geert Uytterhoeven
On Fri, May 21, 2021 at 7:52 AM Christoph Hellwig wrote: > Convert the nfblock driver to use the blk_alloc_disk and blk_cleanup_disk > helpers to simplify gendisk and request_queue allocation. > > Signed-off-by: Christoph Hellwig Acked-by: Geert Uytterhoeven Gr{oe

Re: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems

2021-04-20 Thread Geert Uytterhoeven
, dma_addr_t addr) > +{ > + page->dma_addr[0] = addr; > + if (sizeof(dma_addr_t) > sizeof(unsigned long)) > + page->dma_addr[1] = addr >> 16 >> 16; ... but we do have upper_32_bits() for a 32-bit right shift.

<    1   2   3   4   5   6   7   8   9   10   >