Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-19 Thread Geert Uytterhoeven
ed on multiple platforms, some of them registering an SoC device, some of them not registering an SoC device. So there is no way to know the difference between "SoC device not registered, intentionally", and "SoC device not yet registered". soc_device_match() should only be

Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER

2021-04-19 Thread Geert Uytterhoeven
_type.p && !early_soc_dev_attr) > + return ERR_PTR(-EPROBE_DEFER); > + > while (!ret) { > if (!(matches->machine || matches->family || > matches->revision || matches->soc_id)) Gr{oetje,eeting}s,

Re: [PATCH 4/9] sh: intc: Drop the use of irq_create_identity_mapping()

2021-04-06 Thread Geert Uytterhoeven
n, irq)) > + continue; > > intc_irq_xlate_set(irq, vect->enum_id, d); > intc_register_irq(desc, d, vect->enum_id, irq); Otherwise this seems to work fine on real hardware (landisk) and qemu (rts7751r2d). I did verify that the new fun

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread Geert Uytterhoeven
compatible RTC. http://users.telenet.be/geertu/Linux/PPC/DeviceTree.html confirms that, showing that nvram is a different device node than rtc. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.o

Re: [PATCH RFC 2/3] mm: remove xlate_dev_kmem_ptr()

2021-03-19 Thread Geert Uytterhoeven
On Fri, Mar 19, 2021 at 3:36 PM David Hildenbrand wrote: > Since /dev/kmem has been removed, let's remove the xlate_dev_kmem_ptr() > leftovers. > Signed-off-by: David Hildenbrand > arch/m68k/include/asm/io_mm.h | 5 - Acked-by: Geert Uytterhoeven Gr{oe

Re: Build regressions/improvements in v5.12-rc3

2021-03-15 Thread Geert Uytterhoeven
Hi Christophe, On Mon, Mar 15, 2021 at 11:55 AM Christophe Leroy wrote: > Le 15/03/2021 à 11:49, Geert Uytterhoeven a écrit : > > On Mon, Mar 15, 2021 at 11:46 AM Geert Uytterhoeven > > wrote: > >> JFYI, when comparing v5.12-rc3[1] to v5.12-rc2[3], the summaries are: &g

Re: Build regressions/improvements in v5.12-rc3

2021-03-15 Thread Geert Uytterhoeven
On Mon, Mar 15, 2021 at 11:46 AM Geert Uytterhoeven wrote: > JFYI, when comparing v5.12-rc3[1] to v5.12-rc2[3], the summaries are: > - build errors: +2/-2 > 2 error regressions: > + /kisskb/src/include/linux/compiler_types.h: error: call to > '__compiletime_asser

Re: [PATCH] powerpc: Fix missing declaration of [en/dis]able_kernel_vsx()

2021-03-09 Thread Geert Uytterhoeven
Hi Christophe, On Tue, Mar 9, 2021 at 10:58 AM Christophe Leroy wrote: > Le 09/03/2021 à 10:16, Geert Uytterhoeven a écrit : > > On Tue, Mar 9, 2021 at 9:52 AM Christophe Leroy > > wrote: > >> Le 09/03/2021 à 09:45, Geert Uytterhoeven a écrit : > >>> On Tu

Re: [PATCH] powerpc: Fix missing declaration of [en/dis]able_kernel_vsx()

2021-03-09 Thread Geert Uytterhoeven
Hi Christophe, On Tue, Mar 9, 2021 at 9:52 AM Christophe Leroy wrote: > Le 09/03/2021 à 09:45, Geert Uytterhoeven a écrit : > > On Tue, Mar 9, 2021 at 9:39 AM Christophe Leroy > > wrote: > >> Add stub instances of enable_kernel_vsx() and disable_kernel_vsx() > &g

Re: [PATCH] powerpc: Fix missing declaration of [en/dis]able_kernel_vsx()

2021-03-09 Thread Geert Uytterhoeven
g how this is any better than the current situation: using BUILD_BUG() will still cause a build failure? What about adding "depends on !POWERPC || VSX" instead, to prevent the issue from happening in the first place? Gr{oetje,eeting}s, Geert -- Geert Uytterho

Re: Build regressions/improvements in v5.12-rc1

2021-03-02 Thread Geert Uytterhoeven
Hi Alex, On Tue, Mar 2, 2021 at 8:30 PM Alex Deucher wrote: > On Mon, Mar 1, 2021 at 9:21 AM Geert Uytterhoeven > wrote: > > On Mon, 1 Mar 2021, Geert Uytterhoeven wrote: > > > Below is the list of build error/warning regressions/improvements in > > > v5

Re: Build regressions/improvements in v5.12-rc1

2021-03-01 Thread Geert Uytterhoeven
On Mon, 1 Mar 2021, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v5.12-rc1[1] compared to v5.11[2]. Summarized: - build errors: +2/-0 [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8/ (all

[PATCH] powerpc/chrp: Make hydra_init() static

2021-02-23 Thread Geert Uytterhoeven
Commit 407d418f2fd4c20a ("powerpc/chrp: Move PHB discovery") moved the sole call to hydra_init() to the source file where it is defined, so it can be made static. Signed-off-by: Geert Uytterhoeven --- Compile-tested only. My LongTrail died in 2004. --- arch/powerpc/include/asm/hy

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-28 Thread Geert Uytterhoeven
Hi Saravana, On Wed, Jan 27, 2021 at 6:11 PM Saravana Kannan wrote: > On Wed, Jan 27, 2021 at 8:56 AM Geert Uytterhoeven > wrote: > > On Wed, Jan 27, 2021 at 5:42 PM Saravana Kannan > > wrote: > > > On Tue, Jan 26, 2021 at 11:43 PM Geert Uytterhoeven > >

Re: [PATCH 12/27] m68k: syscalls: switch to generic syscalltbl.sh

2021-01-28 Thread Geert Uytterhoeven
to use scripts/syscalltbl.sh. > > Signed-off-by: Masahiro Yamada Thanks a lot! Tested-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In p

Re: [PATCH 11/27] m68k: add missing FORCE and fix 'targets' to make if_changed work

2021-01-27 Thread Geert Uytterhoeven
wrong; the file paths in > 'targets' must be relative to the current Makefile. > > Fix all of them so the if_changed rules work correctly. > > Signed-off-by: Masahiro Yamada Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-27 Thread Geert Uytterhoeven
Hi Saravana, On Wed, Jan 27, 2021 at 5:42 PM Saravana Kannan wrote: > On Tue, Jan 26, 2021 at 11:43 PM Geert Uytterhoeven > wrote: > > On Wed, Jan 27, 2021 at 1:44 AM Saravana Kannan > > wrote: > > > On Tue, Jan 26, 2021 at 12:50 AM Geert Uytterhoeven > >

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Geert Uytterhoeven
Hi Saravana, On Wed, Jan 27, 2021 at 1:44 AM Saravana Kannan wrote: > On Tue, Jan 26, 2021 at 12:50 AM Geert Uytterhoeven > wrote: > > On Mon, Jan 25, 2021 at 11:42 PM Saravana Kannan > > wrote: > > > On Mon, Jan 25, 2021 at 11:49 AM Michael Walle wrote: > >

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Geert Uytterhoeven
commit in 5.11. Definitely not v5.11. And I sincerely doubt it will be applied for v5.12. It's already way too late to implement all changes to existing drivers needed, and get them accepted for v5.12. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's l

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Geert Uytterhoeven
Hi Saravana, On Mon, Jan 25, 2021 at 11:42 PM Saravana Kannan wrote: > On Mon, Jan 25, 2021 at 11:49 AM Michael Walle wrote: > > Am 2021-01-21 12:01, schrieb Geert Uytterhoeven: > > > On Thu, Jan 21, 2021 at 1:05 AM Saravana Kannan > > > wrote: > > >>

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-21 Thread Geert Uytterhoeven
ould look into that. > > > > > > Yup. That's pretty much it AFAICT. > > > > > > builtin_platform_driver_probe() also makes sure the driver doesn't ask > > > for async probe, etc. But I doubt anyone is actually setting async > > > flags and still using builtin_platform_driver_probe(). > > > > Hasn't module_platform_driver_probe() the same problem? And there > > are ~80 drivers which uses that. > > Yeah. The biggest problem with all of these is the __init markers. > Maybe some familiar with coccinelle can help? And dropping them will increase memory usage. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [PATCH] arch: consolidate pm_power_off callback

2020-12-23 Thread Geert Uytterhoeven
Hi Enrico, On Tue, Dec 22, 2020 at 9:15 PM Enrico Weigelt, metux IT consult wrote: > On 22.12.20 19:54, Geert Uytterhoeven wrote: > > On Tue, Dec 22, 2020 at 7:46 PM Enrico Weigelt, metux IT consult > > wrote: > >> Move the pm_power_off callback into one g

Re: [PATCH] arch: consolidate pm_power_off callback

2020-12-22 Thread Geert Uytterhoeven
ny > - */ > -void (*pm_power_off)(void) = machine_power_off; Assignments like these are lost in the conversion. > -EXPORT_SYMBOL(pm_power_off); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal c

Re: [PATCH] powerpc/ps3: use dma_mapping_error()

2020-12-13 Thread Geert Uytterhoeven
ed-off-by: Vincent Stehlé Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalis

Re: [PATCH 2/2] powerpc/64s: Trim offlined CPUs from mm_cpumasks

2020-12-10 Thread Geert Uytterhoeven
es_cpu_disable(void) > xive_smp_disable_cpu(); > else > xics_migrate_irqs_away(); > + > + cleanup_cpu_mmu_context(); > + > return 0; > } > > -- > 2.23.0 > -- Gr{oetje,eeting}s, Geert

Re: Build regressions/improvements in v5.10-rc7

2020-12-07 Thread Geert Uytterhoeven
On Mon, Dec 7, 2020 at 1:08 PM Geert Uytterhoeven wrote: > JFYI, when comparing v5.10-rc7[1] to v5.10-rc6[3], the summaries are: > - build errors: +1/-0 + /kisskb/src/arch/powerpc/platforms/powermac/smp.c: error: implicit declaration of function 'cleanup_cpu_mmu_context' [-Werror=im

Re: [PATCH] MAINTAINERS: Update 68k Mac entry

2020-12-06 Thread Geert Uytterhoeven
ners to deal with. Update the "M68K ON APPLE MACINTOSH" section > accordingly. > > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Joshua Thompson > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-m...@lists.linux-m68k.org > Signed-off-by: Finn Thain Re

Re: [PATCH v2] clk: renesas: r9a06g032: Drop __packed for portability

2020-12-05 Thread Geert Uytterhoeven
Hi Stephen, On Sat, Dec 5, 2020 at 7:24 AM Stephen Boyd wrote: > Quoting Geert Uytterhoeven (2020-11-30 00:57:43) > > The R9A06G032 clock driver uses an array of packed structures to reduce > > kernel size. However, this array contains pointers, which are no longer > &

Re: [PATCH] macintosh/adb-iop: Always wait for reply message from IOP

2020-12-04 Thread Geert Uytterhoeven
pecting a reply. It's ignored. Just wondering: what kind of messages are being dropped? If reply packets from different ADB commands become mixed up, they are still (expected?) replies to messages we sent before. Why shouldn't we depend on receiving the replies? > >

Re: [PATCH] macintosh/adb-iop: Send correct poll command

2020-12-04 Thread Geert Uytterhoeven
Implement idle -> sending state > transition") WARNING: Unknown commit id 'fa3b5a9929fc', maybe rebased or not pulled? 32226e817043? > Tested-by: Stan Johnson > Signed-off-by: Finn Thain Thanks, will queue in the m68k for-v5.11 branch. Gr{oetje,eeting}s,

Re: [PATCH] powerpc: fix the allyesconfig build

2020-11-30 Thread Geert Uytterhoeven
bad relocations > ce56510b R_PPC64_UADDR64 .rodata+0x01c72378 > ce565126 R_PPC64_UADDR64 .rodata+0x01c723c0 > > They are not drivers that are used on PowerPC (I assume), so mark them > to not be built on PPC64 when CONFIG_RELOCATABLE is enabled. &g

[PATCH v2] clk: renesas: r9a06g032: Drop __packed for portability

2020-11-30 Thread Geert Uytterhoeven
: 4c3d88526eba2143 ("clk: renesas: Renesas R9A06G032 clock driver") Signed-off-by: Geert Uytterhoeven --- v2: - Fix authorship. --- drivers/clk/renesas/r9a06g032-clocks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas

[PATCH] clk: renesas: r9a06g032: Drop __packed for portability

2020-11-30 Thread Geert Uytterhoeven
: 4c3d88526eba2143 ("clk: renesas: Renesas R9A06G032 clock driver") Signed-off-by: Geert Uytterhoeven --- Please take directly (ppc or clk), as this is a build fix. https://lore.kernel.org/linux-clk/20201128122819.32187...@canb.auug.org.au/ Compile-tested only due to lack of hardware. drivers/c

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-11-27 Thread Geert Uytterhoeven
gt; accordingly. > > Signed-off-by: Uwe Kleine-König Thanks for your patch! Reviewed-by: Geert Uytterhoeven Note that the same can be done for ps3_vuart_port_driver.remove(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

Re: [PATCH 1/2] ALSA: ppc: drop if block with always false condition

2020-11-27 Thread Geert Uytterhoeven
check this here. > > Signed-off-by: Uwe Kleine-König Thanks for your patch! Reviewed-by: Geert Uytterhoeven Note that there are similar checks in snd_ps3_driver_probe(), which can be removed, too: if (WARN_ON(!firmware_has_feature(FW_FEATURE_PS3_LV1))) return -ENODEV

Re: [PATCH v2] m68k: Fix WARNING splat in pmac_zilog driver

2020-11-22 Thread Geert Uytterhoeven
esirable. Instead of that comparison, just test for resource existence. > > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Joshua Thompson > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: sta...@vger.kernel.org # v5.8+ &g

Re: [PATCH] m68k: Fix WARNING splat in pmac_zilog driver

2020-11-21 Thread Geert Uytterhoeven
Hi Finn, On Sat, Nov 21, 2020 at 12:47 AM Finn Thain wrote: > On Fri, 20 Nov 2020, Geert Uytterhoeven wrote: > > On Fri, Nov 20, 2020 at 5:51 AM Finn Thain > > wrote: > > > Don't add platform resources that won't be used. This avoids a > > > recently-a

Re: [PATCH] m68k: Fix WARNING splat in pmac_zilog driver

2020-11-19 Thread Geert Uytterhoeven
RQ, 0); > + if (!r_ports || !r_irq) > return -ENODEV; > > uap->port.mapbase = r_ports->start; > uap->port.membase = (unsigned char __iomem *) r_ports->start; > uap->port.iotype = UPIO_MEM; > - uap->port

[PATCH] media: fsl-viu: Use proper check for presence of {out, in}_be32()

2020-11-19 Thread Geert Uytterhoeven
_be32()/in_be32() for CONFIG_M68K") Reported-by: kernel test robot Signed-off-by: Geert Uytterhoeven Reviewed-by: Hans Verkuil --- Compile-tested on m68k, microblaze, and powerpc. Assembler output before/after compared for powerpc. v2: - Add Reviewed-by, - s/definions/definitions/,

Re: Build regressions/improvements in v5.10-rc1

2020-10-26 Thread Geert Uytterhoeven
On Mon, Oct 26, 2020 at 10:46 AM Geert Uytterhoeven wrote: > Below is the list of build error/warning regressions/improvements in > v5.10-rc1[1] compared to v5.9[2]. > > Summarized: > - build errors: +3/-7 > - build warnings: +26/-28 > > Happy fixing! ;-) > >

Re: [PATCH] serial: pmac_zilog: don't init if zilog is not available

2020-10-22 Thread Geert Uytterhoeven
g.c > +++ b/drivers/tty/serial/pmac_zilog.c > @@ -1697,18 +1697,17 @@ extern struct platform_device scc_a_pdev, scc_b_pdev; The real issue is this "extern struct platform_device scc_a_pdev, scc_b_pdev", circumventing the driver framework. Can we get rid of that? Gr{oetje,eeting

Re: [PATCH v2] kbuild: preprocess module linker script

2020-09-08 Thread Geert Uytterhoeven
ested-by: Jessica Yu > Acked-by: Will Deacon > arch/m68k/Makefile | 1 - > .../{kernel/module.lds => include/asm/module.lds.h}| 0 Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -

Re: Build regressions/improvements in v5.9-rc2

2020-08-25 Thread Geert Uytterhoeven
On Tue, Aug 25, 2020 at 10:23 AM Geert Uytterhoeven wrote: > JFYI, when comparing v5.9-rc2[1] to v5.9-rc1[3], the summaries are: > - build errors: +12/-0 + /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dcn_calcs.c: error: implicit declaration of function 'disable_kern

Re: [PATCH] powerpc/boot: Use address-of operator on section symbols

2020-08-03 Thread Geert Uytterhoeven
Hi Michael, On Mon, Aug 3, 2020 at 1:09 PM Michael Ellerman wrote: > Geert Uytterhoeven writes: > > On Mon, Jul 20, 2020 at 11:03 PM Segher Boessenkool > > wrote: > >> On Sat, Jul 18, 2020 at 09:50:50AM +0200, Geert Uytterhoeven wrote: > >> > On Wed, Jun 2

Re: [PATCH] powerpc/boot: Use address-of operator on section symbols

2020-08-03 Thread Geert Uytterhoeven
Hi Segher, On Mon, Jul 20, 2020 at 11:03 PM Segher Boessenkool wrote: > On Sat, Jul 18, 2020 at 09:50:50AM +0200, Geert Uytterhoeven wrote: > > On Wed, Jun 24, 2020 at 6:02 AM Nathan Chancellor > > wrote: > > > /* If we have an image attached to u

Re: Build regressions/improvements in v5.8

2020-08-03 Thread Geert Uytterhoeven
On Mon, Aug 3, 2020 at 11:53 AM Geert Uytterhoeven wrote: > JFYI, when comparing v5.8[1] to v5.8-rc7[3], the summaries are: > - build errors: +2/-3 + /kisskb/src/arch/powerpc/include/asm/mmu.h: error: unknown type name 'next_tlbcam_idx': => 139:22 v5.8/power

Re: [PATCH] powerpc/boot: Use address-of operator on section symbols

2020-07-18 Thread Geert Uytterhoeven
the result of their comparison is a constant, as the addresses are constant. If clangs warns about it, perhaps that warning should be moved to W=1? But adding "&" is not correct, according to C. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots

Re: [PATCH 01/20] nfblock: stop using ->queuedata

2020-06-29 Thread Geert Uytterhoeven
On Mon, Jun 29, 2020 at 9:40 PM Christoph Hellwig wrote: > Instead of setting up the queuedata as well just use one private data > field. > > Signed-off-by: Christoph Hellwig Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 6/8] asm-generic: pgalloc: provide generic pgd_free()

2020-06-29 Thread Geert Uytterhoeven
Rapoport For the m68k part: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking t

Re: [PATCH 1/8] mm: remove unneeded includes of

2020-06-29 Thread Geert Uytterhoeven
\.h/d' \ > $(grep -L -w -f /tmp/xx \ > $(git grep -E -l '[<"]asm/pgalloc\.h')) > > where /tmp/xx contains all the symbols defined in > arch/*/include/asm/pgalloc.h. > > Signed-off-by: Mike Rapoport For the m68k part: Acke

Re: [PATCH 17/17] arch: rename copy_thread_tls() back to copy_thread()

2020-06-23 Thread Geert Uytterhoeven
gt; creation work since we've added clone3(). > Signed-off-by: Christian Brauner > arch/m68k/kernel/process.c | 2 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68

Re: [PATCH 16/17] arch: remove HAVE_COPY_THREAD_TLS

2020-06-23 Thread Geert Uytterhoeven
y_thread_tls() and struct kernel_clone_args. This will make it easier to > maintain the core process creation code under kernel/, simplifies the > callpaths and makes the identical for all architectures. > Signed-off-by: Christian Brauner > arch/m68k/Kconfig | 1 - Acked-by: Geert

Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling

2020-06-01 Thread Geert Uytterhoeven
Hi Finn, On Mon, Jun 1, 2020 at 2:15 AM Finn Thain wrote: > On Sun, 31 May 2020, Geert Uytterhoeven wrote: > > On Sun, May 31, 2020 at 1:20 AM Finn Thain > > wrote: > > > arch/m68k/include/asm/adb_iop.h | 1 + > > > dri

Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling

2020-06-01 Thread Geert Uytterhoeven
Hi Brad, On Sun, May 31, 2020 at 10:01 PM Brad Boyer wrote: > On Sun, May 31, 2020 at 10:38:04AM +0200, Geert Uytterhoeven wrote: > > > arch/m68k/include/asm/adb_iop.h | 1 + > > As this header file is used by a single source file only, perhaps it should > > just b

Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling

2020-05-31 Thread Geert Uytterhoeven
ling. > > Cc: Joshua Thompson > Cc: Geert Uytterhoeven > Tested-by: Stan Johnson > Signed-off-by: Finn Thain Thanks for your patch! Acked-by: Geert Uytterhoeven > arch/m68k/include/asm/adb_iop.h | 1 + > drivers/macintosh/adb-iop.c | 32 ++--

Re: [PATCH] media: omap3isp: Shuffle cacheflush.h and include mm.h

2020-05-27 Thread Geert Uytterhoeven
on arm32). Perhaps it was included at the top intentionally, to override the definitions of copy_{to,from}_user_page()? Fortunately that doesn't seem to be the case, from a quick look at the assembler output. So let's just remove the #include instead? Gr{oetje,eeting}s, Geert -- Geert

Re: sort out the flush_icache_range mess

2020-05-11 Thread Geert Uytterhoeven
Hi Christoph, On Mon, May 11, 2020 at 5:14 PM Christoph Hellwig wrote: > On Mon, May 11, 2020 at 09:46:17AM +0200, Geert Uytterhoeven wrote: > > On Sun, May 10, 2020 at 9:55 AM Christoph Hellwig wrote: > > > none of which really are used by a typical MMU enabled kernel, a

Re: [PATCH 31/31] module: move the set_fs hack for flush_icache_range to m68k

2020-05-11 Thread Geert Uytterhoeven
Hi Christoph, On Mon, May 11, 2020 at 5:11 PM Christoph Hellwig wrote: > On Mon, May 11, 2020 at 09:40:39AM +0200, Geert Uytterhoeven wrote: > > On Sun, May 10, 2020 at 9:57 AM Christoph Hellwig wrote: > > > > > > flush_icache_range generally operates on ker

Re: sort out the flush_icache_range mess

2020-05-11 Thread Geert Uytterhoeven
m68k." http://lore.kernel.org/r/camuhmdw+m0q+j3rsqdmxnrepm+xb5y2aqrxw5sd1mzakgme...@mail.gmail.com Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call

Re: [PATCH 31/31] module: move the set_fs hack for flush_icache_range to m68k

2020-05-11 Thread Geert Uytterhoeven
Hellwig Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talkin

Re: [PATCH 26/31] m68k: implement flush_icache_user_range

2020-05-11 Thread Geert Uytterhoeven
gt; flush_icache_range around it that for now is a no-op. > > Signed-off-by: Christoph Hellwig Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with tec

Re: [PATCH 21/31] mm: rename flush_icache_user_range to flush_icache_user_page

2020-05-11 Thread Geert Uytterhoeven
ristoph Hellwig > arch/m68k/include/asm/cacheflush_mm.h | 4 ++-- > arch/m68k/mm/cache.c | 2 +- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In p

Re: [PATCH 01/15] nfblock: use gendisk private_data

2020-05-09 Thread Geert Uytterhoeven
t;disk->queue = dev->queue; > + dev->disk->private_data = dev; This is already set above, just before the quoted sprintf() call. > > add_disk(dev->disk); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyon

Re: Build regressions/improvements in v5.7-rc4

2020-05-04 Thread Geert Uytterhoeven
On Mon, May 4, 2020 at 9:24 AM Geert Uytterhoeven wrote: > JFYI, when comparing v5.7-rc4[1] to v5.7-rc3[3], the summaries are: > - build errors: +3/-123 > [1] > http://kisskb.ellerman.id.au/kisskb/branch/linus/head/0e698dfa282211e414076f9dc7e83c1c288314fd/ > (all 239 configs

Re: [PATCH] powerpc/ps3: Move static keyword to the front of declaration

2020-04-29 Thread Geert Uytterhoeven
arning: ‘static’ is not at beginning of > declaration [-Wold-style-declaration] > } static vuart_bus_priv; > ^ > > Reported-by: Hulk Robot > Signed-off-by: Xiongfeng Wang Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven --

Re: [PATCH 24/29] mm: remove __vmalloc_node_flags_caller

2020-04-20 Thread Geert Uytterhoeven
e: > FAILED linux-next/m5272c3_defconfig/m68k-gcc8 Mon Apr 20, 18:38 > > http://kisskb.ellerman.id.au/kisskb/buildresult/14213623/ > > mm/nommu.c:164:25: error: 'flags' undeclared (first use in this function); > did you mean 'class'? "return __vmalloc(size, gfp_mask);" Gr

Re: [PATCH 26/29] mm: remove vmalloc_user_node_flags

2020-04-20 Thread Geert Uytterhoeven
.id.au/kisskb/buildresult/14213623/ > > mm/nommu.c:158:25: error: 'flags' undeclared (first use in this function); > did you mean 'class'? "return __vmalloc(size, gfp_mask);", I assume? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux b

Re: [PATCH V2] vhost: do not enable VHOST_MENU by default

2020-04-17 Thread Geert Uytterhoeven
> > > not set". So this patch tries to enable CONFIG_VHOST > > > > > > > > > > explicitly in > > > > > > > > > > defconfigs that enables CONFIG_VHOST_NET and > > > > > > > > > > CONF

Re: Build regressions/improvements in v5.7-rc1

2020-04-13 Thread Geert Uytterhoeven
On Mon, 13 Apr 2020, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v5.7-rc1[1] compared to v5.6[2]. Summarized: - build errors: +132/-3 - build warnings: +257/-79 Happy fixing! ;-) Thanks to the linux-next team for providing the build service

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-08 Thread Geert Uytterhoeven
l see if > > > > anyone > > > > speaks up. > > > > > > We shouldn't remove 40x completely. Just remove the Xilinx 405 > > > stuff. > > > > Congratulations on becoming the 40x maintainer! > > Didn't I give you my last 40x system ? :-) IBM

Re: [PATCH 7/9] powerpc/ps3: Add check for otheros image size

2020-03-29 Thread Geert Uytterhoeven
' _end$' | cut > -d' ' -f1) > +bld="otheros.bld" > +[ $size -le 16777216 ] || bld="otheros-too-big.bld" > +gzip -n --force -9 --stdout "$ofile.bin" > "$odir/$bld" > ;; > esac Why not print an error message and exit 1 instead,

Re: [RFC 1/3] mm/vma: Define a default value for VM_DATA_DEFAULT_FLAGS

2020-03-02 Thread Geert Uytterhoeven
ith standard VMA access flag combinations that are used frequently across > many platforms. Apart from simplification, this reduces code duplication > as well. > Signed-off-by: Anshuman Khandual > arch/m68k/include/asm/page.h | 3 --- For m68k: Acked-by: Geert Uytterho

Re: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)

2020-02-24 Thread Geert Uytterhoeven
; bring except longer code to read? > > Because the argument is an int: > > drivers/net/wireless/ath/ath5k/ahb.c: In function ‘ath_ahb_probe’: > drivers/net/wireless/ath/ath5k/ahb.c:141:18: warning: passing argument 1 of > ‘ioread32’ makes pointer from integer without a cast [-Wint-co

Re: [PATCH 2/5] mm/vma: Make vma_is_accessible() available for general use

2020-02-16 Thread Geert Uytterhoeven
@kvack.org > Signed-off-by: Anshuman Khandual > arch/m68k/mm/fault.c| 2 +- For m68k: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with tech

[PATCH v2] powerpc/time: Replace by

2020-02-13 Thread Geert Uytterhoeven
The PowerPC time code is not a clock provider, and just needs to call of_clk_init(). Hence it can include instead of . Remove the #ifdef protecting the of_clk_init() call, as a stub is available for the !CONFIG_COMMON_CLK case. Signed-off-by: Geert Uytterhoeven Reviewed-by: Stephen Boyd

[PATCH] powerpc/time: Replace by

2020-02-12 Thread Geert Uytterhoeven
The PowerPC time code is not a clock provider, and just needs to call of_clk_init(). Hence it can include instead of . Signed-off-by: Geert Uytterhoeven --- arch/powerpc/kernel/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc

Re: [PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-09 Thread Geert Uytterhoeven
he memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Suggested-by: Geert Uytterhoeven > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Geert Uytterhoeven Reviewed

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-08 Thread Geert Uytterhoeven
Hi Christophe, On Wed, Jan 8, 2020 at 9:35 AM Christophe Leroy wrote: > Le 08/01/2020 à 09:18, Krzysztof Kozlowski a écrit : > > On Wed, 8 Jan 2020 at 09:13, Geert Uytterhoeven > > wrote: > >> On Wed, Jan 8, 2020 at 9:07 AM Geert Uytterhoeven > >> wrote: >

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-08 Thread Geert Uytterhoeven
Hi Krzysztof, On Wed, Jan 8, 2020 at 9:07 AM Geert Uytterhoeven wrote: > On Tue, Jan 7, 2020 at 5:53 PM Krzysztof Kozlowski wrote: > > The ioread8/16/32() and others have inconsistent interface among the > > architectures: some taking address as const, some not. &

Re: [RFT 02/13] alpha: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-08 Thread Geert Uytterhoeven
adw, const volatile) > REMAP1(u32, readl, const volatile) Same for REMAP2() macro below, for iowrite*(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I ca

Re: [RFT 00/13] iomap: Constify ioreadX() iomem argument

2020-01-08 Thread Geert Uytterhoeven
nto one. Yes, they should be squashed, cfr. Arnd's comment. I also wouldn't bother doing the updates in patches 6-10. The rest looks good to me. Thanks a lot! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In p

Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)

2019-12-03 Thread Geert Uytterhoeven
mmit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter > > fixed rw") clears the failure. > > > > Most likely an #include is missing. > > Huh weird how the build bots didn't catch that. Does the below work? Thanks, this fixes the same issue on SuperH: Tested-

Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA

2019-11-12 Thread Geert Uytterhoeven
Hi Borislav, On Tue, Nov 12, 2019 at 10:08 AM Borislav Petkov wrote: > On Mon, Nov 11, 2019 at 07:08:51PM +0100, Geert Uytterhoeven wrote: > > vmlinux-std.lds: All other classic 680x0 targets with an MMU, e.g. plain > > defconfig aka multi_defconfig. > >

Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA

2019-11-11 Thread Geert Uytterhoeven
Hi Kees, On Mon, Nov 11, 2019 at 6:23 PM Kees Cook wrote: > On Mon, Nov 11, 2019 at 05:58:06PM +0100, Geert Uytterhoeven wrote: > > On Fri, Oct 11, 2019 at 2:07 AM Kees Cook wrote: > > > There's no reason to keep the RODATA macro: replace the callers with > > >

Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA

2019-11-11 Thread Geert Uytterhoeven
tax error make[1]: *** [/kisskb/src/Makefile:1075: vmlinux] Error 1 Reported-by: nore...@ellerman.id.au http://kisskb.ellerman.id.au/kisskb/buildresult/14022846/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org I

[PATCH trivial resend] powerpc/booke: Spelling s/date/data/

2019-10-25 Thread Geert Uytterhoeven
Caching dates is never a good idea ;-) Fixes: e7affb1dba0e9068 ("powerpc/cache: add cache flush operation for various e500") Signed-off-by: Geert Uytterhoeven --- arch/powerpc/kernel/cpu_setup_fsl_booke.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powe

Re: [PATCH 00/10] Add support for OpenCAPI SCM devices

2019-10-25 Thread Geert Uytterhoeven
list is a sign of get_maintainter.pl-considered-harmful. Please trim it (by removing me, a.o. ;-) for next submission. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical

[PATCH 1/5] crypto: nx - Improve debugfs_create_u{32, 64}() handling for atomics

2019-10-21 Thread Geert Uytterhoeven
Variables of type atomic{,64}_t can be used fine with debugfs_create_u{32,64}, when passing a pointer to the embedded counter. This allows to get rid of the casts, which prevented compiler checks. Signed-off-by: Geert Uytterhoeven --- drivers/crypto/nx/nx_debugfs.c | 18 +- 1

[PATCH 5/5] ionic: Use debugfs_create_bool() to export bool

2019-10-21 Thread Geert Uytterhoeven
Currently bool ionic_cq.done_color is exported using debugfs_create_u8(), which requires a cast, preventing further compiler checks. Fix this by switching to debugfs_create_bool(), and dropping the cast. Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/pensando/ionic/ionic_debugfs.c

[PATCH 2/5] cxgb4/cxgb4vf: Remove superfluous void * cast in debugfs_create_file() call

2019-10-21 Thread Geert Uytterhoeven
There is no need to cast a typed pointer to a void pointer when calling a function that accepts the latter. Remove it, as the cast prevents further compiler checks. Signed-off-by: Geert Uytterhoeven --- drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 2 +- 1 file changed, 1 insertion

[PATCH 3/5] drm/amdgpu: Remove superfluous void * cast in debugfs_create_file() call

2019-10-21 Thread Geert Uytterhoeven
There is no need to cast a typed pointer to a void pointer when calling a function that accepts the latter. Remove it, as the cast prevents further compiler checks. Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 0/5] debugfs: Remove casts in debugfs_create_*() callers

2019-10-21 Thread Geert Uytterhoeven
comments! Geert Uytterhoeven (5): crypto: nx - Improve debugfs_create_u{32,64}() handling for atomics cxgb4/cxgb4vf: Remove superfluous void * cast in debugfs_create_file() call drm/amdgpu: Remove superfluous void * cast in debugfs_create_file() call power: avs: smartreflex: Remove

[PATCH 4/5] power: avs: smartreflex: Remove superfluous cast in debugfs_create_file() call

2019-10-21 Thread Geert Uytterhoeven
There is no need to cast a typed pointer to a void pointer when calling a function that accepts the latter. Remove it, as the cast prevents further compiler checks. Signed-off-by: Geert Uytterhoeven --- drivers/power/avs/smartreflex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] powerpc/security: Fix debugfs data leak on 32-bit

2019-10-21 Thread Geert Uytterhoeven
"u64". This also allows to drop the cast. Fixes: 398af571128fe75f ("powerpc/security: Show powerpc_security_features in debugfs") Signed-off-by: Geert Uytterhoeven --- Compile-tested only. Alternatively, powerpc_security_features could be changed to u32. However, that would require u

Re: [PATCH v2 12/29] vmlinux.lds.h: Replace RO_DATA_SECTION with RO_DATA

2019-10-11 Thread Geert Uytterhoeven
ernel/vmlinux-nommu.lds | 2 +- For m68k: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talki

Re: [PATCH v2 13/29] vmlinux.lds.h: Replace RW_DATA_SECTION with RW_DATA

2019-10-11 Thread Geert Uytterhoeven
mu.lds | 2 +- > arch/m68k/kernel/vmlinux-std.lds | 2 +- > arch/m68k/kernel/vmlinux-sun3.lds | 2 +- For m68k: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In per

Re: [RESEND TRIVIAL 3/3] treewide: arch: Fix Kconfig indentation

2019-10-07 Thread Geert Uytterhoeven
| 2 +- > arch/m68k/Kconfig.debug| 16 > arch/m68k/Kconfig.machine | 8 ---- For m68k: Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32

Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware

2019-09-26 Thread Geert Uytterhoeven
, can't it? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.

[PATCH] powerpc/booke: Spelling s/date/data/

2019-08-28 Thread Geert Uytterhoeven
Caching dates is never a good idea ;-) Fixes: e7affb1dba0e9068 ("powerpc/cache: add cache flush operation for various e500") Signed-off-by: Geert Uytterhoeven --- arch/powerpc/kernel/cpu_setup_fsl_booke.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powe

Re: [PATCH 4/6] dma-mapping: remove arch_dma_mmap_pgprot

2019-08-16 Thread Geert Uytterhoeven
f-by: Christoph Hellwig > arch/m68k/Kconfig | 1 - > arch/m68k/include/asm/pgtable_mm.h | 3 +++ > arch/m68k/kernel/dma.c | 3 +-- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of

<    1   2   3   4   5   6   7   8   9   10   >