t; Note that the code looks a little odd with the various conditionals
> because we have to support platform_device structures that are
> statically allocated.
>
> Signed-off-by: Christoph Hellwig
> ---
> arch/m68k/kernel/dma.c | 9 ---
Acked-by: Geert U
a mapping
> implementation including its own mmap method, which is handled by moving
> the CONFIG_MMU check in dma_can_mmap so that is only applies to the
> dma-direct case, just as the other ifdefs for it.
>
> Signed-off-by: Christoph Hellwig
> arch/m68k/Kconfig | 1 -
For m68k:
A
1tmjbheu29agleynwbvzbsbb-rrh7yyun...@mail.gmail.com/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalist
On Tue, Jul 23, 2019 at 5:22 PM Geert Uytterhoeven wrote:
> Below is the list of build error/warning regressions/improvements in
> v5.3-rc1[1] compared to v5.2[2].
> [1]
> http://kisskb.ellerman.id.au/kisskb/branch/linus/head/5f9e832c137075045d15cd6899ab0505cfb2ca4b/
> (241 out
Hi Michael,
On Tue, Jun 18, 2019 at 2:23 PM Michael Ellerman wrote:
> Geert Uytterhoeven writes:
> > "git diff" says:
> >
> > \ No newline at end of file
> >
> > after modifying the file.
>
> Is that a problem?
>
> Just curious becaus
"git diff" says:
\ No newline at end of file
after modifying the file.
Signed-off-by: Geert Uytterhoeven
---
tools/testing/selftests/powerpc/mm/.gitignore | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/powerpc/mm/.gitignore
b/too
Flexible array members should be denoted using [] instead of [0], else
gcc will not warn when they are no longer at the end of a struct.
Signed-off-by: Geert Uytterhoeven
---
drivers/net/ethernet/toshiba/ps3_gelic_net.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Flexible array members should be denoted using [] instead of [0], else
gcc will not warn when they are no longer at the end of the structure.
Signed-off-by: Geert Uytterhoeven
---
arch/powerpc/include/asm/ps3stor.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc
c:770:23: warning: format ‘%lu’ expects argument of
type ‘long unsigned int’, but argument 4 has type ‘sector_t {aka long long
unsigned int}’ [-Wformat=]
Fix this by using "%llu" instead.
Fixes: 72deb455b5ec619f ("block: remove CONFIG_LBDAF")
Signed-off-by: Geert Uytterhoeven
---
d to x86 and powerpc.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "
down the system and confuses udev").
>
> Signed-off-by: Krzysztof Kozlowski
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical peop
rchitectures, I have added the pidfd_open() syscall to all architectures
> at the same time.
>
> Signed-off-by: Christian Brauner
> Reviewed-by: Oleg Nesterov
> arch/m68k/kernel/syscalls/syscall.tbl | 1 +
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
ch is requested to be included before
rc1.
Note that none of this is part of linux-next.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself
(arg, "auto"))
> + cpu_mitigations = CPU_MITIGATIONS_AUTO;
Perhaps
else
pr_crit("mitigations=%s is not supported\n", arg);
?
Actually that makes sense on mainline, too.
Cooking a patch...
> +
> + return 0;
> +}
> +early_par
across
> architectures, I have added the pidfd_open() syscall to all architectures
> at the same time.
>
> Signed-off-by: Christian Brauner
> arch/m68k/kernel/syscalls/syscall.tbl | 1 +
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uy
Hi Steve,
On Tue, May 14, 2019 at 9:35 PM Steven Rostedt wrote:
> On Tue, 14 May 2019 21:13:06 +0200
> Geert Uytterhoeven wrote:
> > > > Do we care about the value? "(-E%u)"?
> > >
> > > That too could be confusing. What would (-E22) be conside
Hi Steve,
On Tue, May 14, 2019 at 8:37 PM Steven Rostedt wrote:
> On Tue, 14 May 2019 11:02:17 +0200
> Geert Uytterhoeven wrote:
> > On Tue, May 14, 2019 at 10:29 AM David Laight
> > wrote:
> > > > And I like Steven's "(fault)" idea.
> > &g
(fault)"
> >
> > -ss
>
> Or:
> if (ptr < PAGE_SIZE)
> return ptr ? "(null+)" : "(null)";
> if IS_ERR_VALUE(ptr)
> return "(errno)"
Do we care about the value? "(-E%u)"?
Gr{oe
((1 << (width)) - 1)
What's the purpose of adding this definition?
It does not seem to be used.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
he generic tale still use an old format.
>
> Signed-off-by: Arnd Bergmann
> arch/m68k/kernel/syscalls/syscall.tbl | 4
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@lin
de are removed.
>
> Suggested-by: Peter Zijlstra
> Signed-off-by: Waiman Long
Note that this conflicts with "[PATCH 03/11] kernel/locks: consolidate
RWSEM_GENERIC_* options"
https://lore.kernel.org/lkml/20190213174005.28785-4-...@lst.de/
Gr{oetje,eeting}s,
lock version.
>
> Signed-off-by: Christoph Hellwig
Note that this conflicts with "[PATCH v4 2/3] locking/rwsem: Remove
rwsem-spinlock.c & use rwsem-xadd.c for all archs"
https://lore.kernel.org/lkml/1550095217-12047-3-git-send-email-long...@redhat.com/
Gr{oetje,eeting}s,
On Thu, Feb 14, 2019 at 3:11 AM Christoph Hellwig wrote:
> Introduce a new ARCH_HAS_HWEIGHT symbol for alpha and ia64, and just
> default to the generic version otherwise.
>
> Signed-off-by: Christoph Hellwig
> arch/m68k/Kconfig | 4 ----
Acked-by: Geert Uytterhoeven
Gr
On Thu, Feb 14, 2019 at 3:25 AM Christoph Hellwig wrote:
> Add one definition to lib/Kconfig and let the architectures
> select if it supported.
>
> Signed-off-by: Christoph Hellwig
> arch/m68k/Kconfig | 3 ---
Acked-by: Geert Uytterhoeven
Gr
.
>
> Signed-off-by: Christoph Hellwig
> arch/m68k/Kconfig | 5 +----
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical
lock version.
>
> Signed-off-by: Christoph Hellwig
> arch/m68k/Kconfig | 7 -------
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with tec
PPC_47x
> select SWIOTLB
> select 476FPE
> + select FORCE_PCI
> select PPC4xx_PCI_EXPRESS
Would "select PPC4xx_PCI_EXPRESS if PCI" be a suitable alternative?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux
Hi Rob,
On Mon, Jan 28, 2019 at 4:35 PM Rob Herring wrote:
> On Mon, Jan 28, 2019 at 3:43 AM Geert Uytterhoeven
> wrote:
> > On Tue, Dec 11, 2018 at 9:24 PM Rob Herring wrote:
> > > This adds the build infrastructure for checking DT binding schema
> > > docu
CHKDT Documentation/devicetree/bindings/arm/primecell.yaml
...
CHKDT Documentation/devicetree/bindings/trivial-devices.yaml
make[1]: *** No rule to make target
'Documentation/devicetree/bindings/arm/primecell.example.dtb', needed
by '__build'. Stop.
Obviously it does work for arm/ar
Hi Rob,
On Sun, Jan 27, 2019 at 4:00 AM Rob Herring wrote:
> On Wed, Jan 23, 2019 at 9:33 AM Geert Uytterhoeven
> wrote:
> > On Tue, Dec 11, 2018 at 9:24 PM Rob Herring wrote:
> > > This adds the build infrastructure for checking DT binding schema
> > > docu
0' value
and
DTC arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dt.yaml
FATAL ERROR: No markers present in property 'audio_clk_a' value
Do you have a clue?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
.header.id = VFIO_REGION_INFO_CAP_NVLINK2_SSATGT,
> > + .header.version = 1,
> > + .tgt = data->gpu_tgt
> > + };
I think the simpler change
- struct vfio_region_info_cap_nvlink2_ssatgt cap = { 0 };
+ struct vfio_regio
counts elapsed time, not time since the epoch. They
> will be dealt with later.
>
> Signed-off-by: Arnd Bergmann
> arch/m68k/kernel/syscalls/syscall.tbl | 20 +
For m68k:
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven --
| 4 ++--
> arch/m68k/kernel/syscalls/syscall.tbl | 10 +-
For m68k:
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technica
es it a little easier to check that the changes are the same
> in each table.
>
> Signed-off-by: Arnd Bergmann
> arch/m68k/kernel/syscalls/syscall.tbl | 42 +--
For m68k:
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There'
other time64 calls.
> Three 64-bit architectures (powerpc, s390 and sparc) get semtimedop().
>
> Signed-off-by: Arnd Bergmann
> arch/m68k/kernel/syscalls/syscall.tbl | 11 +++
For m68k:
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
G
sys_pkey_alloc
> +382common pkey_free sys_pkey_free
> +383common pkey_mprotect sys_pkey_mprotect
> +384common rseqsys_rseq
Note that all architectures that already define pkey syscalls, list
pkey_mprotect
f
ystem call just
> returns -ENOSYS.
>
> Signed-off-by: Arnd Bergmann
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call m
/mm/motorola.c | 9 +
> arch/m68k/mm/sun3mmu.c| 6 ++
> arch/m68k/sun3/sun3dvma.c | 3 +++
For m68k:
Reviewed-by: Geert Uytterhoeven
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterh
t;.
When is a syscall really arch-specific, and can it be added there, and
when does it turn out (later) that it isn't, breaking the
synchronization again?
The pkey syscalls may be a bad example, as AFAIU they can be implemented
on some architectures, but not on some others. Still, I had skipp
ents.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer"
C
to enable compile-testing. The same is true when handling this in asm-generic.
> On 6/15/18 10:10 AM, Hans Verkuil wrote:
> > On 08/06/18 11:48, Geert Uytterhoeven wrote:
> >> When compile-testing on m68k or microblaze:
> >>
> >> drivers/media/platform/fsl
es\n", __func__,
%zu, as sizeof() returns size_t.
Probably there are more. Yes, it's hard to get them right in all callers.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In
On Wed, Jan 16, 2019 at 2:45 PM Mike Rapoport wrote:
> memblock_alloc() already clears the allocated memory, no point in doing it
> twice.
>
> Signed-off-by: Mike Rapoport
> arch/m68k/mm/mcfmmu.c | 1 -
For m68k part:
Acked-by: Geert Uytterhoeven
> --- a/arch/m68k/m
pu64" would mean "spu + 64"?
That makes it more difficult to read, and to grep.
What about allowing multiple ABIs, separated by commas?
So that line would become:
245 spu,64 clock_settime sys_clock_settime
Gr{oetje,eeting}s,
Geert
--
On Mon, Jan 14, 2019 at 1:59 PM David Hildenbrand wrote:
> The PG_reserved flag is cleared from memory that is part of the kernel
> image (and therefore marked as PG_reserved). Avoid using PG_reserved
> directly.
>
> Cc: Geert Uytterhoeven
> Cc: Andrew Morton
> Cc: Michal
Hi Arnd,
On Thu, Jan 10, 2019 at 11:43 PM Arnd Bergmann wrote:
> On Thu, Jan 10, 2019 at 7:11 PM Geert Uytterhoeven
> wrote:
> > On Thu, Jan 10, 2019 at 6:06 PM Arnd Bergmann wrote:
> > > On Thu, Jan 10, 2019 at 5:59 PM Geert Uytterhoeven
> > > wrote:
> >
Hi Arnd,
On Thu, Jan 10, 2019 at 6:06 PM Arnd Bergmann wrote:
> On Thu, Jan 10, 2019 at 5:59 PM Geert Uytterhoeven
> wrote:
> > On Thu, Jan 10, 2019 at 5:26 PM Arnd Bergmann wrote:
> > > The system call tables have diverged a bit over the years, and a number
> >
onal?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
en applying the .txt change
> and if I knew the base for this patch it would be rather easy to work
> out what has changed.
>
> Also, should we do an s/shmobile.txt/shmobile.yaml/ in MAINTAINERS?
Probably even s/shmobile.yaml/renesas.yaml/, while at it?
Gr{oetje,eeting}s,
g
> Cc: linux-renesas-...@vger.kernel.org
> Signed-off-by: Rob Herring
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call my
he
> rest in drivers/pci.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Palmer Dabbelt
> Acked-by: Max Filippov
> Acked-by: Thomas Gleixner
> Acked-by: Bjorn Helgaas
For m68k:
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterh
Signed-off-by: Geert Uytterhoeven
---
arch/powerpc/include/asm/nohash/32/pte-40x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/nohash/32/pte-40x.h
b/arch/powerpc/include/asm/nohash/32/pte-40x.h
index 661f4599f2fc54a7..12c6811e344bc5ea 100644
Hi Iwai-san,
On Tue, Nov 6, 2018 at 5:18 PM Takashi Iwai wrote:
> On Tue, 06 Nov 2018 02:04:47 +0100,
> Randy Dunlap wrote:
> >
> > On 11/5/18 2:12 PM, Geert Uytterhoeven wrote:
> > > On Mon, Nov 5, 2018 at 11:07 PM Geert Uytterhoeven
> > > wrote:
>
this module will never be used unless they follow the
> same path of enabling ASoC to deal with the HDaudio codecs instead of
> the legacy.
>
> Likewise HDAC_HDMI will only work on Intel platforms for now.
>
> >
> > That still leaves the issue that pci_iomap() on SH should be
Hi Randy,
On Tue, Nov 6, 2018 at 2:06 AM Randy Dunlap wrote:
> On 11/5/18 2:12 PM, Geert Uytterhoeven wrote:
> > On Mon, Nov 5, 2018 at 11:07 PM Geert Uytterhoeven
> > wrote:
> >> Below is the list of build error/warning regressions/improvements in
> >>
On Mon, Nov 5, 2018 at 11:07 PM Geert Uytterhoeven wrote:
> Below is the list of build error/warning regressions/improvements in
> v4.20-rc1[1] compared to v4.19[2].
>
> Summarized:
> - build errors: +3/-0
> - build warnings: +449/-2712
>
> Happy fixing! ;-)
>
>
.make_sensor_label().
This is often because .create_device_attrs lacks a __init
annotation or the annotation of .make_sensor_label is wrong.
As .probe() can be called after freeing of __init memory, all __init
annotiations in the driver are bogus, and should be removed.
Signed-off-by: Geert
Hi Christoph,
On Fri, Oct 19, 2018 at 9:10 AM Christoph Hellwig wrote:
> On Fri, Oct 19, 2018 at 09:07:51AM +0200, Geert Uytterhoeven wrote:
> > Without this:
> > - It's hard to visually match your untagged cover letter with the
> > actual patches,
> > - Y
Hi Christoph,
On Fri, Oct 19, 2018 at 9:00 AM Christoph Hellwig wrote:
> On Wed, Oct 17, 2018 at 10:30:49AM +0200, Geert Uytterhoeven wrote:
> > Please use "git format-patch -v --cover" to prepare patch series
> > for sending with git-send-email.
> >
> > &q
l.
"-v" to prefix all patches with version number ,
"--cover" to have a "[PATCH 0/]" prefix in the cover letter.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal
Hi Bart,
CC debian-68k, linux-m68k
On Tue, Oct 9, 2018 at 5:00 PM Bart Van Assche wrote:
> On Tue, 2018-10-09 at 13:51 +, Christophe Leroy wrote:
> > _PAGE_WRITETHRU is a target specific flag. Prefer generic functions.
> >
> > Acked-by: Geert Uytterhoeven
> >
Hi Rob,
On Mon, Oct 8, 2018 at 4:57 PM Rob Herring wrote:
> On Mon, Oct 8, 2018 at 2:47 AM Geert Uytterhoeven
> wrote:
> > On Fri, Oct 5, 2018 at 6:59 PM Rob Herring wrote:
> > > Convert Renesas SoC bindings to DT schema format using json-schema.
> > > --- /dev/
ve an SPDX header, so it was GPL-2.0, implicitly?
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bindings/arm/shmobile.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings
> +
g
> Cc: linux-renesas-...@vger.kernel.org
> Signed-off-by: Rob Herring
Looks good to me, but needs a rebase, as the PRR section has been extended
in -next.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
the problematic WARN_ON which was introduced in commit 22db552b50fa
> ("powerpc/powermac: Fix rtc read/write functions").
>
> Tested-by: Stan Johnson
> Signed-off-by: Finn Thain
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterh
On Fri, Sep 28, 2018 at 8:42 PM Rob Herring wrote:
> On Fri, Sep 28, 2018 at 12:21 PM Andreas Färber wrote:
> > Am 13.09.18 um 17:51 schrieb Geert Uytterhoeven:
> > > On Wed, Sep 12, 2018 at 3:02 AM Masahiro Yamada
> > > wrote:
> > >>
s
> >> + $(Q)$(MAKE) $(dtbinst)=$(dtstree)
> >> +
> >> +all: dtbs
> >> +
> >> +endif
>
>
> Ah, right.
> Even x86 can enable OF and OF_UNITTEST.
>
>
>
> Another solution might be,
> guard it by 'depends on ARCH_SUPPORTS_OF'.
>
>
latile unsigned long *addr)
{
unsigned long mask = BIT_MASK(nr);
unsigned long *p = ((unsigned long *)addr) + BIT_WORD(nr);
*p |= mask;
}
include/linux/bits.h:
#define BIT_MASK(nr)(1UL << ((nr) % BITS_PER_LONG))
Looks like native endianness to
On Mon, Aug 27, 2018 at 6:10 PM Christophe Leroy
wrote:
> _PAGE_WRITETHRU is a target specific flag. Prefer generic functions.
>
> Signed-off-by: Christophe Leroy
>From a Zorro bus point of view:
Acked-by: Geert Uytterhoeven
> --- a/drivers/block/z2ram.c
> +++ b/dri
On Mon, Aug 27, 2018 at 11:50 AM Geert Uytterhoeven
wrote:
> Below is the list of build error/warning regressions/improvements in
> v4.19-rc1[1] compared to v4.18[2].
>
> Summarized:
> - build errors: +5/-3
> - build warnings: +14732/-179
>
> Note that there may be fa
on case of missing section mismatch warnings is when some
versions of the compiler inline the called function, while other versions don't.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversati
ail died in 2004. I haven't heard since even longer about active
use from any of the other people I know that had one.
So:
Acked-by: Geert Uytterhoeven
However, recently Dominik (CC) send me an enquiry about it, so perhaps
he is a happy user?
Gr{oetje,eeting}s,
Geer
CC Dan, Michael, AKPM, powerpc
On Mon, Apr 16, 2018 at 3:10 PM Geert Uytterhoeven wrote:
> Below is the list of build error/warning regressions/improvements in
> v4.17-rc1[1] compared to v4.16[2].
I'd like to point your attention to:
> + warning: vmlinux.o(.text+0x376518): Section
used for configuring drivers for peripheral
> RapidIO devices if/when such device drivers will be published.
Everything in drivers/rapidio/Kconfig depends on RAPIDIO (probably it should
use a big if RAPIDIO/endif instead), so it can just be included from
drivers/Kconfig now.
The sooner you do tha
me(void)
> +static time64_t pmu_read_time(void)
> {
> struct adb_request req;
> - long time;
> + time64_t time;
>
> if (pmu_request(, NULL, 1, PMU_READ_RTC) < 0)
> return 0;
Thanks, looks good to me!
Gr{oetje,eeting}s,
Hi Michael,
On Mon, Jul 30, 2018 at 8:47 AM Michael Ellerman wrote:
> Finn Thain writes:
> > Now that the PowerMac via-pmu driver supports m68k PowerBooks,
> > switch over to that driver and remove the via-pmu68k driver.
> >
> > Cc: Geert Uytterhoeven
> > Te
On Mon, Jul 30, 2018 at 9:26 AM Geert Uytterhoeven wrote:
> On Mon, Jul 2, 2018 at 10:21 AM Finn Thain wrote:
> > Now that the PowerMac via-pmu driver supports m68k PowerBooks,
> > switch over to that driver and remove the via-pmu68k driver.
> >
> > Cc: Geert Uytter
On Mon, Jul 2, 2018 at 10:21 AM Finn Thain wrote:
> Now that the PowerMac via-pmu driver supports m68k PowerBooks,
> switch over to that driver and remove the via-pmu68k driver.
>
> Cc: Geert Uytterhoeven
> Tested-by: Stan Johnson
> Signed-off-by: Finn Thain
Acked-by: Geert
On Mon, Jul 2, 2018 at 10:21 AM Finn Thain wrote:
> Don't load the via-pmu68k driver on early PowerBooks. The M50753 PMU
> device found in those models was never supported by this driver.
> Attempting to load the driver usually causes a boot hang.
>
> Cc: Geert Uytterhoeven
> S
I'd really like
> to resolve this before the merge window opens, since my PMU patch series
> is affected.
+1. If it's not resolved (a few days) before the merge window opens, I may have
to revert the patch instead.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytt
ministicly invisible kernel prints would be painful, I believe.
Unfortunately AFAIK the PS3 doesn't have any other "synchronous" output we
can use for debugging (like flashing the power LED).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
I, so that the console is synchronously updated? Would
> > that be acceptable?
>
> I'm not sure if that would work or not. Maybe Geert is more familiar with
> it.
That sounds like a complex solution, slowing down the console a lot.
What about letting ps3fb register a panic notifier to sync th
t callback,
> which are equally unused.
>
> This removes all of those as well.
>
> Acked-by: Greg Ungerer
> Signed-off-by: Arnd Bergmann
Thanks, applied and queued for v4.19.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linu
Applied and queued for v4.19, with the WARN_ON() dropped.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journ
what Mathieu suggested and kept the
> original Mac behavior, but added the WARN_ON().
So, is this safe to apply?
Especially in light of the warnings seen by Meelis with the PPC version.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There
Hi Michael,
On Tue, Jun 19, 2018 at 8:35 AM Michael Ellerman wrote:
> Geert Uytterhoeven writes:
> > On Mon, Jun 18, 2018 at 11:18 AM Geert Uytterhoeven
> > wrote:
> >> Below is the list of build error/warning regressions/improvements in
> >>
On Mon, Jun 18, 2018 at 11:18 AM Geert Uytterhoeven
wrote:
> Below is the list of build error/warning regressions/improvements in
> v4.18-rc1[1] compared to v4.17[2].
>
> Summarized:
> - build errors: +11/-1
> [1]
> http://kisskb.eller
K PMU, version 2 */
> };
That's bad. But as long as the NuBus-PMac project is out-of-tree, the
enum values it uses are not part of the Linux ABI, IMHO.
During upstreaming, PMU_NUBUS_BASED should be moved to the bottom.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There
_be32().
As PowerPC implements the be32 accessors using inline functions instead
of macros, identity definions are added for all accessors to make the
above checks work.
Fixes: 29d750686331a1a9 ("media: fsl-viu: allow building it with COMPILE_TEST")
Signed-off-by: Geert Uytterhoeven
---
Comp
Hi Finn,
On Wed, Jun 6, 2018 at 8:57 AM, Finn Thain wrote:
> On Mon, 4 Jun 2018, Geert Uytterhoeven wrote:
>> > Don't call pmu_shutdown() or pmu_restart() on early PowerBooks: the
>> > PMU device found in these PowerBooks isn't supported.
>>
>> S
nks for your patch!
Reviewed-by: Geert Uytterhoeven
A few minor nits below...
> --- a/drivers/macintosh/via-pmu.c
> +++ b/drivers/macintosh/via-pmu.c
> @@ -1470,25 +1470,25 @@ pmu_handle_data(unsigned char *data, int len)
> adb_input(data+1, len-
>adb_type == MAC_ADB_PB1
> - || macintosh_config->adb_type == MAC_ADB_PB2) {
> +#ifdef CONFIG_ADB_PMU
> + } else if (macintosh_config->adb_type == MAC_ADB_PB2) {
> pmu_restart();
> #endif
> } else if (CPU_IS_030) {
Gr{oetje,ee
-by: Stan Johnson
> Signed-off-by: Finn Thain
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker.
ng: dereference of noderef expression
> drivers/macintosh/via-pmu.c:1455:17: warning: dereference of noderef
> expression
> drivers/macintosh/via-pmu.c:1456:69: warning: dereference of noderef
> expression
>
> Tested-by: Stan Johnson
> Signed-off-by: Finn Thain
Reviewed-by: Ge
they cannot be __init.
Probably the long term fix is to change the ADB subsystem from the
centralized approach of letting adb_init() call all subdrivers, to making the
subdrivers platform drivers registering with the ADB core.
> Tested-by: Stan Johnson
> Signed-off-by: Finn Thain
Anyway:
Reviewed-
Hi Christophe,
On Tue, May 29, 2018 at 10:56 AM, Christophe LEROY
wrote:
> Le 29/05/2018 à 09:47, Geert Uytterhoeven a écrit :
>> On Tue, May 29, 2018 at 8:03 AM, Christophe Leroy
>> wrote:
>>>
>>>CC arch/powerpc/kernel/nvram_64.o
>>> a
and (2) not need a zero
terminator if there are 8 characters in the buffer, so probably the
original code is correct, and the "fixed" code isn't.
Has this been tested on a PS3?
> return n + index;
> }
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoev
ompt, and from
>> > what I can see, nothing selects it. Therefore, the symbol is always
>> > disabled, and so the feature never gets used in mainline kernels.
>> >
>> > Brings up the obvious question - why is it there if it's completely
>> > unused?
rs of CONFIG_HAVE_ARCH_FREE_INITRD_MEM will be removed.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
301 - 400 of 1107 matches
Mail list logo
