Re: [PATCH] macintosh: Switch i2c drivers back to use .probe()

2023-06-01 Thread Jean Delvare
r.c | 2 +- > drivers/macintosh/windfarm_fcu_controls.c | 2 +- > drivers/macintosh/windfarm_lm75_sensor.c| 2 +- > drivers/macintosh/windfarm_lm87_sensor.c| 2 +- > drivers/macintosh/windfarm_max6690_sensor.c | 2 +- > drivers/macintosh/windfarm_smu_sat.c| 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) > (...) Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support

Re: [PATCH 6/6] i2c: Make remove callback return void

2022-07-05 Thread Jean Delvare
| 3 +-- > drivers/i2c/muxes/i2c-mux-ltc4306.c | 4 +--- > drivers/i2c/muxes/i2c-mux-pca9541.c | 3 +-- > drivers/i2c/muxes/i2c-mux-pca954x.c | 3 +-- Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-10-05 Thread Jean Delvare
ers/i2c/busses/i2c-xgene-slimpro.c | 1 - > drivers/i2c/busses/i2c-xiic.c | 1 - > drivers/i2c/busses/i2c-xlp9xx.c | 4 +--- > drivers/i2c/busses/i2c-xlr.c| 4 +--- > 55 files changed, 44 insertions(+), 161 deletions(-) > (...) I like the idea. For i2c-amd756, i2c-diolan-u2c, i2c-i801, i2c-isch, i2c-ismt, i2c-nforce and i2c-piix4: Reviewed-by: Jean Delvare <jdelv...@suse.de> -- Jean Delvare SUSE L3 Support

Re: therm_adt746x: -3 invalid for parameter limit_adjust

2013-09-26 Thread Jean Delvare
your problem: From: Jean Delvare kh...@linux-fr.org Subject: kernel/params: Fix handling of signed integer types Commit 6072ddc8520b86adfac6939ca32fb6e6c4de017a broke the handling of signed integer types, fix it. Reported-by: Christian Kujau li...@nerdbynature.de Signed-off-by: Jean Delvare kh

Re: [PATCH 5/7] rapidio: add modular build option for the subsystem core

2013-07-26 Thread Jean Delvare
...@kernel.crashing.org Cc: Andre van Herk andre.van.h...@prodrive.nl Cc: Micha Nelissen micha.nelis...@prodrive.nl Cc: Stef van Os stef.van...@prodrive.nl Cc: Jean Delvare jdelv...@suse.de --- arch/x86/Kconfig |4 ++-- drivers/rapidio/Makefile |4 +++- drivers/rapidio/rio.c| 27

Re: [PATCH 0/7] rapidio: modularize rapidio subsystem

2013-07-25 Thread Jean Delvare
. (...) Thanks to this patch set, I was finally able to make all RapidIO support modular in openSUSE kernels. This is very appreciated, thanks a lot! -- Jean Delvare Suse L3 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls

2013-02-16 Thread Jean Delvare
--- (...) For i2c-taos-evm: Reviewed-by: Jean Delvare kh...@linux-fr.org Also a note: --- a/drivers/i2c/busses/i2c-octeon.c +++ b/drivers/i2c/busses/i2c-octeon.c @@ -595,7 +595,7 @@ static int octeon_i2c_probe(struct platform_device *pdev) result = i2c_add_adapter(i2c-adap

Re: [PATCH 207/493] i2c: remove use of __devinit

2012-11-20 Thread Jean Delvare
easily understand that we want to drop CONFIG_HOTPLUG and always enable hot-plug support, I don't see where we are going with removing __devinit annotations and the like. Thanks, -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [PATCH 207/493] i2c: remove use of __devinit

2012-11-20 Thread Jean Delvare
On Tue, 20 Nov 2012 13:23:42 +, Russell King - ARM Linux wrote: On Tue, Nov 20, 2012 at 09:20:46AM +0100, Jean Delvare wrote: Hi Bill, On Mon, 19 Nov 2012 13:22:36 -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devinit is no longer needed. Can

Re: [PATCH 065/493] i2c: remove use of __devexit_p

2012-11-20 Thread Jean Delvare
CONTROLLER DRIVERS FOR PC in MAINTAINERS for examples of meaningful groups.) -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-14 Thread Jean Delvare
should not depend on OF.) -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 00/15] PowerMac i2c API conversions windfarm updates

2012-04-19 Thread Jean Delvare
are very welcome. The earliest we can get these changes upstream, the better. Christian, can you please test this series? I'm sure Benjamin can send the patches to you directly if needed. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH 00/15] PowerMac i2c API conversions windfarm updates

2012-04-19 Thread Jean Delvare
Hallo Andreas, On Thu, 19 Apr 2012 12:11:25 +0200, Andreas Schwab wrote: Jean Delvare kh...@linux-fr.org writes: These drivers were the last ones blocking the removal of the legacy binding model in i2c-core. There are also still some uses in snd-aoa. You're right, there are still 3

Re: [PATCH 1/3] i2c: move of_i2c_register_devices call into core

2011-09-02 Thread Jean Delvare
and leave i2c device registration broken for 1 commit. Thinking some more about it, perhaps that is a bit better than broken module loading. Guess it depends if you are doing modules or built-in. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc

Re: [PATCH] Move ams driver to macintosh

2010-11-16 Thread Jean Delvare
Hi Benjamin, On Tue, 16 Nov 2010 15:33:25 +1100, Benjamin Herrenschmidt wrote: On Tue, 2010-10-05 at 12:10 +0200, Jean Delvare wrote: The ams driver isn't a hardware monitoring driver, so it shouldn't live under driver/hwmon. drivers/macintosh seems much more appropriate, as the driver

[PATCH] Move ams driver to macintosh

2010-10-05 Thread Jean Delvare
The ams driver isn't a hardware monitoring driver, so it shouldn't live under driver/hwmon. drivers/macintosh seems much more appropriate, as the driver is only useful on PowerBooks and iBooks. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Guenter Roeck guenter.ro...@ericsson.com Cc: Stelian

Re: [PATCH (Option 1)] of/i2c: fix module load order issue caused by of_i2c.c

2010-09-29 Thread Jean Delvare
of_i2c_register_devices(), as it used to be until 2.6.35. 2 extra functions calls doesn't seem a high price to pay to keep the code logically separated. This also make things consistent, with all OF registration functions living under drivers/of. Thanks, -- Jean Delvare

Re: [PATCH (Option 2)] of/i2c: fix module load order issue caused by of_i2c.c

2010-09-29 Thread Jean Delvare
this variant, thanks. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [BUG 2.6.36-rc5] of_i2c.ko - i2c-core.ko dependency loop

2010-09-24 Thread Jean Delvare
/linux-2.6.git;a=commitdiff;h=959e85f7751c33d1a2dabc5cc3fe2ed0db7052e5 Mikael, can you please try reverting this patch and see if it solves your problem? -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org

Re: [BUG 2.6.36-rc5] of_i2c.ko - i2c-core.ko dependency loop

2010-09-24 Thread Jean Delvare
Hi Mikael, On Fri, 24 Sep 2010 12:50:01 +0200, Mikael Pettersson wrote: Jean Delvare writes: As far as I can see this is caused by this commit from Grant: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=959e85f7751c33d1a2dabc5cc3fe2ed0db7052e5

Re: [lm-sensors] [PATCH] hwmon: (tmp421) Add nfactor support (2nd attempt)

2010-08-14 Thread Jean Delvare
my ack for any non-standard feature, sorry. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 0/6] Remove owner field from sysfs attribute structure

2010-08-10 Thread Jean Delvare
this in linux-next? It will show up in linux-next tomorrow. Related bug? https://bugzilla.kernel.org/show_bug.cgi?id=16544 -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] rtc: add support for DS3232 RTC

2010-07-05 Thread Jean Delvare
(-) create mode 100644 drivers/rtc/rtc-ds3232.c You're sending this patch to the wrong list. Please read MAINTAINERS again. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-06-01 Thread Jean Delvare
e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers. As there is no need anymore to clear the clientdata-pointer, remove all current occurrences in the drivers to simplify the code and prevent confusion. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Jean Delvare kh...@linux-fr.org

Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-05-31 Thread Jean Delvare
it all in one go. If I take the patch in my i2c tree, the aim is to merge it upstream immediately, so merge issues won't exist. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [lm-sensors] [PATCH] hwmon: (tmp421) Add nfactor support (2nd attempt)

2010-05-19 Thread Jean Delvare
) then yes, it would be nice to have a standard interface described for these files. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] hwmon: (tmp421) Add nfactor support.

2010-05-12 Thread Jean Delvare
shouldn't be accessible by regular users (i.e. change the mode from 0644 to 0640). An alternative is to slit the cache into short-lived (~ 1 or 2 seconds) and long-lived (1 to 5 minutes.) A number of drivers do this. -- Jean Delvare ___ Linuxppc-dev

Re: [PATCH] hwmon: (tmp421) Add nfactor support.

2010-05-11 Thread Jean Delvare
, sensor_dev_attr_temp4_fault.dev_attr.attr, + sensor_dev_attr_temp4_nfactor.dev_attr.attr, NULL }; Any hope to standardize on the sysfs attribute files and units? So that other drivers can implement the same interface. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH 33/37] sound/soc: use .dev.of_node instead of .node in struct of_device

2010-03-12 Thread Jean Delvare
to somewhere the full series can be seen and downloaded for the interested. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: i2c_powermac: Kernel access of bad area

2010-01-31 Thread Jean Delvare
and headers now. Thanks for the fixes, Jean! You're welcome. -- Jean Delvare http://khali.linux-fr.org/wishlist.html ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: i2c_powermac: Kernel access of bad area

2010-01-30 Thread Jean Delvare
they should still be referened on patchwork, I'll dig there and pick them up. Well, basically I pick patches that touch drivers/i2c/*, and I don't pick patches that touch drivers/macintosh/*. When I can't build the drivers, I don't really feel like pushing the patches myself. -- Jean Delvare

Re: i2c_powermac: Kernel access of bad area

2010-01-29 Thread Jean Delvare
Ben, Christian, On Thu, 7 Jan 2010 17:17:38 +0100, Jean Delvare wrote: On Wed, 6 Jan 2010 19:41:05 -0800 (PST), Christian Kujau wrote: Hi Jean, On Wed, 6 Jan 2010 at 17:37, Jean Delvare wrote: I think that sysfs files creation should be moved to the end of probe_thermostat

Re: i2c_powermac: Kernel access of bad area

2010-01-06 Thread Jean Delvare
); - of_device_unregister(of_dev); } +} + +static void __exit +thermostat_exit(void) +{ i2c_del_driver(thermostat_driver); + of_device_unregister(of_dev); } module_init(thermostat_init); -- Jean Delvare ___ Linuxppc-dev

Re: i2c-powermac fails

2009-10-16 Thread Jean Delvare
On Thu, 15 Oct 2009 16:05:13 +0200, Jean Delvare wrote: On Thu, 15 Oct 2009 22:19:19 +1100, Benjamin Herrenschmidt wrote: On Thu, 2009-10-15 at 12:49 +0200, Jean Delvare wrote: Oh. Well, if that was the case, we would see errors all the time, not just during initialization, right? Or does

Re: i2c-powermac fails

2009-10-15 Thread Jean Delvare
On Thu, 15 Oct 2009 08:26:15 +1100, Benjamin Herrenschmidt wrote: On Wed, 2009-10-14 at 23:02 +0200, Jean Delvare wrote: Hi all, On Tue, 13 Oct 2009 11:49:48 +0200, Jean Delvare wrote: I2C bus being setup too fast sounds more likely. It might be worth adding an arbitrary delay after

Re: i2c-powermac fails

2009-10-15 Thread Jean Delvare
On Thu, 15 Oct 2009 22:19:19 +1100, Benjamin Herrenschmidt wrote: On Thu, 2009-10-15 at 12:49 +0200, Jean Delvare wrote: Oh. Well, if that was the case, we would see errors all the time, not just during initialization, right? Or does the I2C clock frequency change over time somehow

[PATCH] therm_adt746x: Don't access non-existing register

2009-10-14 Thread Jean Delvare
The ADT746x don't have any register at sub-address 0, so better use an existing register for the initial test read. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Colin Leroy co...@colino.net Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org --- Tim, I

Re: i2c-powermac fails

2009-10-14 Thread Jean Delvare
Hi all, On Tue, 13 Oct 2009 11:49:48 +0200, Jean Delvare wrote: I2C bus being setup too fast sounds more likely. It might be worth adding an arbitrary delay after initialization, just to see if it helps. Not sure where though, as I'm not familiar with the Powermac initialization steps. Maybe

i2c-powermac fails

2009-10-13 Thread Jean Delvare
to debug it further? -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: i2c-powermac fails

2009-10-13 Thread Jean Delvare
On Tue, 13 Oct 2009 20:32:28 +1100, Benjamin Herrenschmidt wrote: On Tue, 2009-10-13 at 11:23 +0200, Jean Delvare wrote: Hi Ben, Paul, I had a report by Tim Shepard (Cc'd) that the therm_adt746x driver sometimes fails to initialize on his PowerBook G4 running kernel 2.6.31

Re: [PATCH] sound: Don't assume i2c device probing always succeeds

2009-10-04 Thread Jean Delvare
Hi Takashi, On Thu, 01 Oct 2009 08:52:59 +0200, Takashi Iwai wrote: At Wed, 30 Sep 2009 18:55:05 +0200, Jean Delvare wrote: On Wed, 30 Sep 2009 17:15:49 +0200, Takashi Iwai wrote: Yes, indeed I prefer NULL check because the user can know the error at the right place. I share your

[PATCH] macintosh: Don't assume i2c device probing always succeeds

2009-09-30 Thread Jean Delvare
If i2c device probing fails, then there is no driver to dereference after calling i2c_new_device(). Stop assuming that probing will always succeed, to avoid NULL pointer dereferences. We have an easier access to the driver anyway. Signed-off-by: Jean Delvare kh...@linux-fr.org Tested-by: Tim

[PATCH] sound: Don't assume i2c device probing always succeeds

2009-09-30 Thread Jean Delvare
); + keywest_driver.clients); return 0; } -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] sound: Don't assume i2c device probing always succeeds

2009-09-30 Thread Jean Delvare
Hi Takashi, Thanks for the swift reply. On Wed, 30 Sep 2009 16:13:49 +0200, Takashi Iwai wrote: At Wed, 30 Sep 2009 15:25:42 +0200, Jean Delvare wrote: If i2c device probing fails, then there is no driver to dereference after calling i2c_new_device(). Stop assuming that probing

Re: [PATCH] sound: Don't assume i2c device probing always succeeds

2009-09-30 Thread Jean Delvare
On Wed, 30 Sep 2009 17:05:11 +0200, Johannes Berg wrote: On Wed, 2009-09-30 at 17:00 +0200, Jean Delvare wrote: The NULL check of client-driver, if followed by a call to i2c_unregister_device(), would indeed be enough. But unlike the onyx driver which we know we sometimes load erroneously

Re: [PATCH] sound: Don't assume i2c device probing always succeeds

2009-09-30 Thread Jean Delvare
binding failed, and then there * is no point in keeping the device instantiated. */ Otherwise it's a little difficult to understand why the check is there. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [PATCH] i2c-mpc: Do not generate STOP after read.

2009-09-28 Thread Jean Delvare
On Mon, 28 Sep 2009 09:30:32 +0200, Joakim Tjernlund wrote: Jean Delvare kh...@linux-fr.org wrote on 28/09/2009 09:28:09: On Mon, 28 Sep 2009 00:26:54 +0200, Joakim Tjernlund wrote: Jean, I just noticed you pull request for i2c on LKML but I didn't see this patch nor have I got any

Re: [PATCH] i2c-mpc: Do not generate STOP after read.

2009-09-28 Thread Jean Delvare
attention to it. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: Removing deprecated drivers from drivers/i2c/chips

2009-09-10 Thread Jean Delvare
guess I shall pick it too? Thanks, -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] keywest: Get rid of useless i2c_device_name() macro

2009-05-14 Thread Jean Delvare
The i2c_device_name() macro is used only once and doesn't have much value, it hurts redability more than it helps. Get rid of it. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org --- sound/ppc/keywest.c |6 +- 1 file changed, 1 insertion

Re: Need a patch tested on a windtunnel powermac

2009-05-05 Thread Jean Delvare
the information to the wiki. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Need a patch tested on a windtunnel powermac

2009-05-04 Thread Jean Delvare
, as I see you built the driver as a module, could you try unloading and reloading it? Thanks, -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Need a patch tested on a windtunnel powermac

2009-05-04 Thread Jean Delvare
On Mon, 4 May 2009 11:42:08 -0400, Josh Boyer wrote: On Mon, May 04, 2009 at 05:40:01PM +0200, Jean Delvare wrote: For completeness, as I see you built the driver as a module, could you try unloading and reloading it? Sure: [jwbo...@localhost macintosh]$ sudo rmmod therm_windtunnel [jwbo

Re: [PATCH] windfarm: Convert to a new-style i2c drivers

2009-05-02 Thread Jean Delvare
On Sat, 2 May 2009 15:07:12 +1000, Paul Mackerras wrote: Jean Delvare writes: The legacy i2c binding model is going away soon, so convert the macintosh windfarm drivers to the new model or they will break. All works OK on my quad G5 (PowerMac11,2). Tested-by: Paul Mackerras pau

Re: [PATCH] therm_windtunnel: Convert to a new-style i2c driver

2009-04-29 Thread Jean Delvare
On Thu, 16 Apr 2009 23:01:01 +0200, Jean Delvare wrote: The legacy i2c binding model is going away soon, so convert the ppc therm_windtunnel driver to the new model or it will break. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul

Re: [PATCH] therm_adt746x: Convert to a new-style i2c driver

2009-04-22 Thread Jean Delvare
On Thu, 16 Apr 2009 22:59:27 +0200, Jean Delvare wrote: The legacy i2c binding model is going away soon, so convert the ppc therm_adt746x driver to the new model or it will break. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul

Re: [PATCH] therm_windtunnel: Convert to a new-style i2c driver

2009-04-22 Thread Jean Delvare
On Thu, 16 Apr 2009 23:01:01 +0200, Jean Delvare wrote: The legacy i2c binding model is going away soon, so convert the ppc therm_windtunnel driver to the new model or it will break. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-21 Thread Jean Delvare
On Tue, 21 Apr 2009 11:23:00 +0200, Jean Delvare wrote: On Tue, 21 Apr 2009 08:31:00 +0200, Takashi Iwai wrote: At Mon, 20 Apr 2009 22:56:59 +0200, Jean Delvare wrote: The legacy i2c binding model is going away soon, so convert the ppc keywest sound driver to the new model

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-21 Thread Jean Delvare
Hi Paul, Takashi, On Tue, 21 Apr 2009 08:33:43 +0200, Takashi Iwai wrote: At Tue, 21 Apr 2009 08:34:02 +1000, Paul Mackerras wrote: Jean Delvare writes: Takashi, please push this patch to Linus quickly, as this is blocking the removal of the legacy i2c binding model, which

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-21 Thread Jean Delvare
Hi Johannes, On Mon, 20 Apr 2009 23:04:52 +0200, Johannes Berg wrote: On Mon, 2009-04-20 at 22:54 +0200, Jean Delvare wrote: The legacy i2c binding model is going away soon, so convert the AOA codec drivers to the new model or they'll break. Signed-off-by: Jean Delvare kh...@linux

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-21 Thread Jean Delvare
On Tue, 21 Apr 2009 08:31:00 +0200, Takashi Iwai wrote: At Mon, 20 Apr 2009 22:56:59 +0200, Jean Delvare wrote: The legacy i2c binding model is going away soon, so convert the ppc keywest sound driver to the new model or it will break. Signed-off-by: Jean Delvare kh...@linux-fr.org

[PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-20 Thread Jean Delvare
The legacy i2c binding model is going away soon, so convert the AOA codec drivers to the new model or they'll break. Signed-off-by: Jean Delvare kh...@linux-fr.org Tested-by: Johannes Berg johan...@sipsolutions.net Tested-by: Andreas Schwab sch...@linux-m68k.org Cc: Benjamin Herrenschmidt b

[PATCH] keywest: Convert to new-style i2c driver

2009-04-20 Thread Jean Delvare
The legacy i2c binding model is going away soon, so convert the ppc keywest sound driver to the new model or it will break. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Takashi Iwai ti...@suse.de --- Takashi, please push this patch

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-16 Thread Jean Delvare
On Tue, 14 Apr 2009 16:45:38 +0200, Takashi Iwai wrote: Johannes, please let me know if the patch works. Then I'll merge them. Note if it matters: the new I2C binding model my patch uses is only available since kernel 2.6.26. -- Jean Delvare

Question about windfarm drivers

2009-04-16 Thread Jean Delvare
is still registered with i2c-core, this looks wrong. Am I missing something? Or is this clean-up path broken and nobody ever noticed? I am also curious why wf_unregister_sensor() calls wf_put_sensor() while wf_register_sensor() doesn't call wf_get_sensor(). Thanks, -- Jean Delvare

[PATCH] windfarm: Convert to a new-style i2c drivers

2009-04-16 Thread Jean Delvare
The legacy i2c binding model is going away soon, so convert the macintosh windfarm drivers to the new model or they will break. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org --- Can someone please test

[PATCH] therm_adt746x: Convert to a new-style i2c driver

2009-04-16 Thread Jean Delvare
The legacy i2c binding model is going away soon, so convert the ppc therm_adt746x driver to the new model or it will break. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org --- Can someone please test this patch

[PATCH] therm_windtunnel: Convert to a new-style i2c driver

2009-04-16 Thread Jean Delvare
The legacy i2c binding model is going away soon, so convert the ppc therm_windtunnel driver to the new model or it will break. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org --- Can someone please test

Re: [PATCH 1/2] keywest: Convert to new-style i2c driver

2009-04-15 Thread Jean Delvare
Hi Paul, On Wed, 15 Apr 2009 14:57:30 +1000, Paul Mackerras wrote: Jean Delvare writes: The legacy i2c binding model is going away soon, But not before 2.6.30, right? Ideally, yes, before 2.6.30. This is what Documentation/feature-removal-schedule.txt says

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-15 Thread Jean Delvare
On Wed, 15 Apr 2009 00:48:08 +0200, Andreas Schwab wrote: Jean Delvare kh...@linux-fr.org writes: Hi Johannes, On Tue, 14 Apr 2009 19:41:55 +0200, Johannes Berg wrote: Alright, with the patch Andreas pointed out it loads, but segfaults, as below. Works fine without your patch

[PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers (v3)

2009-04-15 Thread Jean Delvare
The legacy i2c binding model is going away soon, so convert the AOA codec drivers to the new model or they'll break. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Johannes Berg johan...@sipsolutions.net Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Tested-by: Andreas Schwab sch

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-15 Thread Jean Delvare
of doing this. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-15 Thread Jean Delvare
On Wed, 15 Apr 2009 15:18:10 +0200, Johannes Berg wrote: On Wed, 2009-04-15 at 15:06 +0200, Jean Delvare wrote: Yes, i2c core or even driver core. I'll see if I can reproduce it. Alright. Hmm, couldn't reproduce it. Maybe it is fixed in rc2. I don't have too much time to spend on this, so

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers (v3)

2009-04-15 Thread Jean Delvare
On Wed, 15 Apr 2009 15:00:44 +0200, Johannes Berg wrote: On Wed, 2009-04-15 at 14:22 +0200, Jean Delvare wrote: The legacy i2c binding model is going away soon, so convert the AOA codec drivers to the new model or they'll break. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc

Re: [PATCH] therm_pm72: Convert to a new-style i2c driver

2009-04-14 Thread Jean Delvare
Hi Paul, On Tue, 14 Apr 2009 09:07:35 +1000, Paul Mackerras wrote: Jean Delvare writes: The legacy i2c binding model is going away soon, so convert the macintosh therm_pm72 driver to the new model or it will break. This is really a quick and dirty conversion, that should do the trick

Re: [PATCH] therm_pm72: Convert to a new-style i2c driver

2009-04-14 Thread Jean Delvare
On Mon, 13 Apr 2009 16:51:00 +0200, Jean Delvare wrote: On Mon, 13 Apr 2009 16:09:27 +0200, Jean Delvare wrote: The legacy i2c binding model is going away soon, so convert the macintosh therm_pm72 driver to the new model or it will break. This is really a quick and dirty conversion

Re: [PATCH 1/2] keywest: Convert to new-style i2c driver

2009-04-14 Thread Jean Delvare
On Fri, 10 Apr 2009 17:09:51 +0200, Jean Delvare wrote: Ah, I forgot. You need the following patch applied before testing: ftp://ftp.kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-i2c/i2c-loosen-driver-check.patch This patch is is Linus' tree now: http://git.kernel.org/?p=linux

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-14 Thread Jean Delvare
On Fri, 10 Apr 2009 17:02:38 +0200, Jean Delvare wrote: On Thu, 9 Apr 2009 14:19:45 +0200, Jean Delvare wrote: From: Jean Delvare kh...@linux-fr.org Subject: AOA: Convert onyx and tas codecs to new-style i2c drivers The legacy i2c binding model is going away soon, so convert the AOA

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-14 Thread Jean Delvare
=935298696f469c0e07c73be687bd055878074ce0 Thanks, -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-14 Thread Jean Delvare
[ 10.268328] [c001e19a3e30] [c0007554] syscall_exit+0x0/0x40 [ 10.268331] ---[ end trace dbcf63aa775331e7 ]--- -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] therm_pm72: Convert to a new-style i2c driver

2009-04-13 Thread Jean Delvare
-by: Jean Delvare kh...@linux-fr.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org --- Can anyone please run-test this patch? I could only build-test it. drivers/macintosh/therm_pm72.c | 95 +++- 1 file changed, 47 insertions(+), 48 deletions(-) --- linux

Re: [PATCH] therm_pm72: Convert to a new-style i2c driver

2009-04-13 Thread Jean Delvare
On Mon, 13 Apr 2009 16:09:27 +0200, Jean Delvare wrote: The legacy i2c binding model is going away soon, so convert the macintosh therm_pm72 driver to the new model or it will break. This is really a quick and dirty conversion, that should do the trick for now, but no doubt that something

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-10 Thread Jean Delvare
On Thu, 9 Apr 2009 14:19:45 +0200, Jean Delvare wrote: From: Jean Delvare kh...@linux-fr.org Subject: AOA: Convert onyx and tas codecs to new-style i2c drivers The legacy i2c binding model is going away soon, so convert the AOA codec drivers to the new model or they'll break. Signed-off

[PATCH 1/2] keywest: Convert to new-style i2c driver

2009-04-10 Thread Jean Delvare
The legacy i2c binding model is going away soon, so convert the ppc keywest sound driver to the new model or it will break. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org --- sound/ppc/keywest.c | 81

[PATCH 2/2] keywest: Get rid of useless i2c_device_name macro

2009-04-10 Thread Jean Delvare
The i2c_device_name macro doesn't have much value, get rid of it. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org --- sound/ppc/keywest.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) --- linux-2.6.30-rc1.orig/sound/ppc

Re: [PATCH 1/2] keywest: Convert to new-style i2c driver

2009-04-10 Thread Jean Delvare
On Fri, 10 Apr 2009 17:07:26 +0200, Jean Delvare wrote: The legacy i2c binding model is going away soon, so convert the ppc keywest sound driver to the new model or it will break. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org --- sound

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-09 Thread Jean Delvare
() instead of i2c_attach_client()) and that's about it. (Once again this is only build-tested and I would like people with the hardware to give it a try.) From: Jean Delvare kh...@linux-fr.org Subject: AOA: Convert onyx and tas codecs to new-style i2c drivers The legacy i2c binding model is going

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-09 Thread Jean Delvare
week that I can test anything. OK, thanks. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-08 Thread Jean Delvare
clarifications about this. Thanks. * * * * * The legacy i2c binding model is going away soon, so convert the AOA codec drivers to the new model or they'll break. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Johannes Berg johan...@sipsolutions.net Cc: Benjamin Herrenschmidt b...@kernel.crashing.org

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

2009-04-08 Thread Jean Delvare
avoid using mere chip names for non-generic drivers. The aoa drivers are powermac-specific, we don't want the names we pick to collide with another driver, that's why I chose to keep the aoa prefix. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Jean Delvare
) or the powerpc tree. -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Jean Delvare
On Tue, 10 Feb 2009 10:01:54 -0600, Timur Tabi wrote: Jean Delvare wrote: No, that's something for either Ben Dooks (Cc'd) or the powerpc tree. This patch has nothing to do with ARM, so Kumar will pick it up, if you ACK it. Why are you mentioning ARM? From MAINTAINERS: I2C SUBSYSTEM P

Re: [PATCH] i2c: i2c-ibm_iic message can be confusing

2009-02-03 Thread Jean Delvare
Hi Ben, On Wed, 04 Feb 2009 14:55:33 +1100, Benjamin Herrenschmidt wrote: Acked-by: Jean Delvare kh...@linux-fr.org Jean, you'll take that in your tree or should I take it in mine ? No, I'm not taking it, i2c-ibm_iic is under Ben Dooks' jurisdiction. So it's up to either him or you

Re: [PATCH] i2c: i2c-ibm_iic message can be confusing

2009-02-02 Thread Jean Delvare
. Acked-by: Jean Delvare kh...@linux-fr.org -- Jean Delvare ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/

2009-01-13 Thread Jean Delvare
On Tue, 13 Jan 2009 08:39:37 -0600, Kumar Gala wrote: On Jan 11, 2009, at 10:55 AM, Anton Vorontsov wrote: This patch is used to help Jean Delvare to get rid of drivers/i2c/ chips/ directory. The new location suggested by Kumar Gala: as the driver is 83xx specific it's placed

Re: [PATCH] powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/

2009-01-11 Thread Jean Delvare
Hi Anton, On Sun, 11 Jan 2009 19:51:36 +0300, Anton Vorontsov wrote: This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ directory. The new location suggested by Kumar Gala: as the driver is 83xx specific it's placed into arch/powerpc/platforms/83xx/. Signed-off

Re: [PATCH] powerpc/83xx: Move mcu_mpc8349emitx driver out of drivers/i2c/chips/

2009-01-11 Thread Jean Delvare
On Sun, 11 Jan 2009 20:24:10 +0300, Anton Vorontsov wrote: On Sun, Jan 11, 2009 at 06:10:55PM +0100, Jean Delvare wrote: Hi Anton, On Sun, 11 Jan 2009 19:51:36 +0300, Anton Vorontsov wrote: This patch is used to help Jean Delvare to get rid of drivers/i2c/chips/ directory. The new

Re: [PATCH 2/7] i2c: add info-archdata field

2008-10-22 Thread Jean Delvare
On Wed, 22 Oct 2008 11:27:34 +1100, Benjamin Herrenschmidt wrote: On Fri, 2008-10-17 at 11:21 +0200, Jean Delvare wrote: Hi Anton, On Thu, 16 Oct 2008 21:12:53 +0400, Anton Vorontsov wrote: If present the info-archdata is copied into the dev-archdata. Some (OpenFirmware) platforms

Re: [PATCH 2/7] i2c: add info-archdata field

2008-10-22 Thread Jean Delvare
On Wed, 22 Oct 2008 14:08:13 +0400, Anton Vorontsov wrote: On Wed, Oct 22, 2008 at 06:37:55PM +1100, Benjamin Herrenschmidt wrote: On Wed, 2008-10-22 at 08:50 +0200, Jean Delvare wrote: On Wed, 22 Oct 2008 11:27:34 +1100, Benjamin Herrenschmidt wrote: On Fri, 2008-10-17 at 11:21 +0200

Re: [PATCH] [RESEND] i2c-cpm: Suppress autoprobing for devices

2008-10-17 Thread Jean Delvare
__devinit cpm_i2c_setup(struct cpm_i2c *cpm) Acked-by: Jean Delvare [EMAIL PROTECTED] I guess you do _not_ want me to push this patch upstream now and it better goes through the powerpc tree to allow a synchronization with dts file changes? If I'm wrong and you want me to take this patch in my tree

  1   2   3   >