There are error parameters should be corrected when
calling dma_free_coherent to free rmu rx-ring buffers
in fsl_open_inb_mbox() function.
Signed-off-by: Liu Gang gang@freescale.com
Reported-by: Dan Carpenter dan.carpen...@oracle.com
---
arch/powerpc/sysdev/fsl_rmu.c | 6 +++---
1 file
* defined as output cannot be determined by reading GPDAT register,
* so we use shadow data register instead. The status of input pins
* is determined by reading GPDAT register.
*/
Best Regards,
Liu Gang
___
Linuxppc-dev mailing list
Linuxppc-dev
. Then reading the pin status will
always return high even if the actual pin status is low.
The code should eliminate the effects of the shadow data to
the input pins, and the status of those pins should be
read directly from GPDAT.
Signed-off-by: Liu Gang gang@freescale.com
---
changes in v2:
- Added
()
function, and also with the comments from Anatolij.
Best Regards,
Liu Gang
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On Tue, 2013-11-19 at 16:32 +0100, Anatolij Gustschin wrote:
On Fri, 15 Nov 2013 15:16:29 +0800
Liu Gang gang@freescale.com wrote:
For MPC8572/MPC8536, the status of GPIOs defined as output
cannot be determined by reading GPDAT register, so the code
use shadow data register instead
you think so?
Best Regards,
Liu Gang
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
should be read directly from GPDAT, not
the shadow data.
Signed-off-by: Liu Gang gang@freescale.com
---
drivers/gpio/gpio-mpc8xxx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index 9ae29cc..1d4ac75 100644
--- a/drivers/gpio/gpio
Hi, Kumar,
Can you help to apply the two patches?
powerpc/srio: Fix the compile errors when building with 64bit
http://patchwork.ozlabs.org/patch/145687/
powerpc/srio: Fix the relocation errors when building with 64bit
http://patchwork.ozlabs.org/patch/144829/
Thanks a lot.
Best Regards,
Liu
'
.../fsl_rmu.c:985: error: cast from pointer to integer of different size
.../fsl_rmu.c:997: error: cast to pointer from integer of different size
Rewrote the corresponding code with the support of 64bit building.
Signed-off-by: Liu Gang gang@freescale.com
Signed-off-by: Shaohui Xie shaohui
-dqdpar) 0xfff);
Than you can git rid of the DBELL_* macros.
Yes, this can really git rid of the DBELL_* macros and some other code.
I'll update the patch based on your comments.
Thanks a lot.
Liu Gang
___
Linuxppc-dev mailing list
Linuxppc-dev
'
.../fsl_rmu.c:985: error: cast from pointer to integer of different size
.../fsl_rmu.c:997: error: cast to pointer from integer of different size
Rewrote the corresponding code with the support of 64bit building.
Signed-off-by: Liu Gang gang@freescale.com
Signed-off-by: Shaohui Xie shaohui
long)buffer, len);
Should 'buffer' be printed with %p ??
Yes, printing with %p can get rid of the cast, although they have the
same print results.
Thanks a lot.
Liu Gang
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https
,
Liu Gang
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
of 64bit building.
Signed-off-by: Liu Gang gang@freescale.com
---
arch/powerpc/sysdev/fsl_rio.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c
index a4c4f4a..5b6f556 100644
--- a/arch/powerpc/sysdev
Hi, Paul,
On Fri, 2012-03-02 at 09:30 -0500, Paul Gortmaker wrote:
Signed-off-by: Liu Gang gang@freescale.com
Signed-off-by: Shaohui Xie shaohui@freescale.com
Signed-off-by: Paul Gortmaker paul.gortma...@windriver.com
Hi Liu,
You can't just go adding a Signed-off-by: line
'
.../fsl_rmu.c:985: error: cast from pointer to integer of different size
.../fsl_rmu.c:997: error: cast to pointer from integer of different size
Rewrote the corresponding code with the support of 64bit building.
Signed-off-by: Liu Gang gang@freescale.com
Signed-off-by: Shaohui Xie shaohui
issues. I also found
these errors of 64bit building last week. I'll provide patch for this
issue as soon as possible.
Thanks.
Best Regards,
Liu Gang
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc
Yeah, send binding first should be better for reviewing entire set of patches.
Thanks!
-Original Message-
From: Wood Scott-B07421
Sent: Tuesday, November 15, 2011 1:37 AM
To: Liu Gang-B34182
Cc: Li Yang-R58472; Jiang Kai-B18973; linux-ker...@vger.kernel.org; Zang
Roy-R61911
From: Kai Jiang kai.ji...@freescale.com
Update of_platform_bus_probe() RapidIO node to be compitable with
new RapidIO dts compatible property.
Signed-off-by: Kai Jiang kai.ji...@freescale.com
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
---
arch/powerpc/platforms/85xx/corenet_ds.c |
can work simultaneously.
Signed-off-by: Li Yang le...@freescale.com
Signed-off-by: Jin Qing b24...@freescale.com
Signed-off-by: Liu Gang gang@freescale.com
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
---
arch/powerpc/sysdev/fsl_rio.c | 391 +---
arch/powerpc
...@freescale.com
Signed-off-by: Liu Gang gang@freescale.com
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
---
.../devicetree/bindings/powerpc/fsl/srio-rmu.txt | 163
.../devicetree/bindings/powerpc/fsl/srio.txt | 103
2 files changed, 266
From: Kumar Gala ga...@kernel.crashing.org
Update all dts files that support SRIO controllers to match the new
fsl,srio device tree binding.
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
---
arch/powerpc/boot/dts/mpc8568mds.dts | 66 ++---
: error: implicit declaration of function
'search_exception_tables'.
The file fsl_rio.c needs the declaration of function search_exception_tables
in the header file linux/module.h.
Signed-off-by: Liu Gang gang@freescale.com
---
arch/powerpc/sysdev/fsl_rio.c |2 +-
1 files changed, 1
Yes, I'm afraid srio was not enabled when you compiled.
Regards,
Liu Gang
-Original Message-
From: Paul Gortmaker [mailto:paul.gortma...@windriver.com]
Sent: Friday, November 11, 2011 11:48 PM
To: Liu Gang-B34182
Cc: linuxppc-dev@lists.ozlabs.org; alexandre.boun...@idt.com;
a...@linux
-Original Message-
From: Bounine, Alexandre [mailto:alexandre.boun...@idt.com]
Sent: Monday, October 24, 2011 9:51 PM
To: Liu Gang-B34182; Kumar Gala; linuxppc-...@ozlabs.org; Zang Roy-R61911
Cc: Andrew Morton; linux-ker...@vger.kernel.org
Subject: RE: [PATCH 3/5][v2] fsl-rio: Add two
Hi, Alex,
Thanks for your comments, please find my replies inlines.
-Original Message-
From: Bounine, Alexandre [mailto:alexandre.boun...@idt.com]
Sent: Thursday, October 20, 2011 3:54 AM
To: Kumar Gala; linuxppc-...@ozlabs.org
Cc: Andrew Morton; Liu Gang-B34182; linux-ker
Thanks Kumar! I'll update these SRIO patches following all your comments.
Regards,
Liu Gang
-Original Message-
From: Kumar Gala [mailto:ga...@kernel.crashing.org]
Sent: Thursday, September 29, 2011 10:21 PM
To: Liu Gang-B34182
Cc: linuxppc-dev@lists.ozlabs.org; a...@linux-foundation.org
Add two message units and number of ports according to the p4080 reference
manual.
Signed-off-by: Li Yang le...@freescale.com
Signed-off-by: Jin Qing b24...@freescale.com
Signed-off-by: Liu Gang gang@freescale.com
---
arch/powerpc/boot/dts/p4080ds.dts |4 +-
arch/powerpc/boot/dts
units can work simultaneously.
Signed-off-by: Li Yang le...@freescale.com
Signed-off-by: Jin Qing b24...@freescale.com
Signed-off-by: Liu Gang gang@freescale.com
---
arch/powerpc/sysdev/fsl_rio.c | 336 +--
arch/powerpc/sysdev/fsl_rio.h | 73 +++-
arch/powerpc
...@freescale.com
Signed-off-by: Liu Gang gang@freescale.com
---
.../devicetree/bindings/powerpc/fsl/srio.txt | 85
1 files changed, 85 insertions(+), 0 deletions(-)
create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/srio.txt
diff --git a/Documentation
before freeing
allocated
rio_mport structure.
Signed-off-by: Liu Gang gang@freescale.com
---
arch/powerpc/sysdev/fsl_rio.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c
index c65f75a..22ffccd 100644
!
Regards,
Liu Gang
-Original Message-
From: Liu Gang-B34182
Sent: Monday, August 08, 2011 6:14 PM
To: linuxppc-...@ozlabs.org
Cc: a...@linux-foundation.org; Li Yang-R58472; Gala Kumar-B11780; Zang
Roy-R61911; Liu Gang-B34182; Liu Gang-B34182
Subject: [PATCH] fsl-rio: Correct IECSR register
be called persistently.
Thanks again!
Regards,
Liu Gang
-Original Message-
From: Andrew Morton [mailto:a...@linux-foundation.org]
Sent: Thursday, August 25, 2011 2:54 AM
To: Liu Gang-B34182
Cc: 'linuxppc-dev@lists.ozlabs.org'; Li Yang-R58472; Gala Kumar-B11780; Zang
Roy-R61911
Subject: Re
Hi, Andrew,
Could you please apply this patch into your tree?
Thanks a lot!
Regards,
Liu Gang
-Original Message-
From: Bounine, Alexandre [mailto:alexandre.boun...@idt.com]
Sent: Tuesday, August 09, 2011 8:36 PM
To: Liu Gang-B34182; linux-ker...@vger.kernel.org
Cc: Li Yang-R58472
The RETE bit in IECSR is cleared by writing a 1 to it.
Signed-off-by: Liu Gang gang@freescale.com
---
arch/powerpc/sysdev/fsl_rio.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c
index b3fd081
The discovered bit in PGCCSR register indicates if the device has
been discovered by system host. In Rapidio system, some agent devices
can also be master devices. They can issue requests into the system.
Signed-off-by: Liu Gang gang@freescale.com
---
drivers/rapidio/rio-scan.c |4
36 matches
Mail list logo
