Re: [PATCH v2 1/4] scsi: cxlflash: Access interrupt trigger page from xive directly

On Fri, Apr 03, 2020 at 05:38:35PM +0200, Frederic Barrat wrote: > xive is already mapping the trigger page in kernel space and it can be > accessed through standard APIs, so let's reuse it and simplify the code. > > Signed-off-by: Frederic Barrat Looks good! Acked-by: Mat

Re: [PATCH 1/4] scsi: cxlflash: Access interrupt trigger page from xive directly

On Thu, Apr 02, 2020 at 05:43:49PM +0200, Frederic Barrat wrote: > xive is already mapping the trigger page in kernel space and it can be > accessed through standard APIs, so let's reuse it and simplify the code. > > Signed-off-by: Frederic Barrat > --- > drivers/scsi/cxlflash/ocxl_hw.c | 17

Re: [PATCH 7/7] cxlflash: Isolate external module dependencies

f > to avoid compilation errors. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 6/7] cxlflash: Abstract hardware dependent assignments

> Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 5/7] cxlflash: Add include guards to backend.h

On Fri, May 11, 2018 at 02:05:51PM -0500, Uma Krishnan wrote: > The new header file, backend.h, that was recently added is missing > the include guards. This commit adds the guards. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 3/7] cxlflash: Acquire semaphore before invoking ioctl services

leading > to the hang. > > To support the current design point of holding the semaphore on the > ioctl() paths, the release fop should acquire it before invoking any > ioctl services. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 2/7] cxlflash: Limit the debug logs in the IO path

to debug issues that involve command > tracking, the abundance of data can overwrite other useful data in the > log. The best option available is to limit the messages that should > serve most of the common use cases. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com

Re: [PATCH 1/7] cxlflash: Yield to active send threads

ter can > also be used for the active send threads. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH v3 41/41] cxlflash: Handle spurious interrupts

lem, a boolean will indicate if the hardware queue is > ready to process interrupts or not. This can be evaluated in the interrupt > handler before proessing an interrupt. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH v3 40/41] cxlflash: Remove commmands from pending list on timeout

ing command list > before freeing the buffer. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH v3 39/41] cxlflash: Synchronize reset and remove ops

evice state and yield to any active reset or probing threads. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Looks good! Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 00/38] cxlflash: OpenCXL transport support

and agree that the OpenCXL terminology should be consistent throughout the kernel. So...contingent upon a V2 with OpenCXL references being replaced by OCXL: Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > > Matthew R. Ochs (1): > cxlflash: Avoid clobbering context co

Re: [PATCH] scsi: cxlflash: Select SCSI_SCAN_ASYNC

On Tue, Feb 20, 2018 at 07:56:35PM +1100, Michael Ellerman wrote: > Vaibhav Jain writes: > > > The cxlflash driver uses "Asynchronous SCSI scanning" enabled by > > CONFIG_SCSI_SCAN_ASYNC. Without this enabled the modprobe of cxlflash > > module gets hung with

Re: [PATCH 5/6] cxlflash: Adapter context init can return error

On Wed, Jan 03, 2018 at 04:55:04PM -0600, Uma Krishnan wrote: > Adapter context creation can return either NULL or an error pointer. > Updating the check condition to reflect this. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 2/6] cxlflash: Update cxl-specific arguments to generic cookie

On Wed, Jan 03, 2018 at 04:54:25PM -0600, Uma Krishnan wrote: > Convert cxl-specific pointers to generic cookies to facilitate future > enhancements. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 1/6] cxlflash: Reset command ioasc

On Thu, Jan 04, 2018 at 05:33:48PM +1100, Andrew Donnellan wrote: > On 04/01/18 09:54, Uma Krishnan wrote: > >In the event of a command failure, cxlflash returns the failure to the > >upper layers to process. After processing the error, when the command is > >queued again, the private command

Re: [PATCH 1/6] cxlflash: Reset command ioasc

a hang or IO failure. > > To fix the issue, clear the ioasc before queuing any command. > > Fixes: 479ad8e9d48c ("scsi: cxlflash: Remove zeroing of private command > data") > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

[PATCH 3/3] cxlflash: Update debug prints in reset handlers

and associated CDB. This is not necessary as the SCSI command is simply the messenger in these scenarios. Refactor the debug prints in the host and reset handlers to only present information that is applicable given the function scope. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.

[PATCH 2/3] cxlflash: Update send_tmf() parameters

. As a nice side effect, this will ease the burden of converting caller routines to be based solely off of a SCSI device reference. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 27 +-- 1 file changed, 13 insertions(

[PATCH 1/3] cxlflash: Avoid double free of character device

ement interface") Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c index 7a787b6..455564f 100644 --- a/drivers/scsi/cxlflash/main.c ++

[PATCH 0/3] cxlflash: Minor fix and EH refactoring

This small series fixes a recently injected double free and also includes two patches to refactor the host and reset handlers to ease the burden of making this driver compatible with an updated SCSI EH framework. This series is intended for 4.13 and is bisectable. Matthew R. Ochs (3): cxlflash

Re: [PATCH 09/17] cxlflash: Create character device to provide host management interface

gt; manage the adapter. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 08/17] cxlflash: Add scsi command abort handler

support to process command timeouts > and abort requests. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 07/17] cxlflash: Flush pending commands in cleanup path

-layer and indicating that the command > can be retried. > > Once the card has been quiesced, the hardware send queue lock is acquired > to prevent any data movement while the pending commands are processed. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 06/17] cxlflash: Track pending scsi commands in each hardware queue

> > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 05/17] cxlflash: Handle AFU sync failures

> > Update documentation to reflect behavior in the event of an AFU sync > failure. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 04/17] cxlflash: Schedule asynchronous reset of the host

o recoverable actions. > > To avoid this situation, context reset failures will be escalated to a host > reset operation. This will be done asynchronously to allow the acting > thread to return to the user with a failure. > > Signed-off-by: Uma Krishnan <ukri...@linux.vne

Re: [PATCH 03/17] cxlflash: Reset hardware queue context via specified register

ue > reference instead of a single command to better reflect that the entire > queue associated with the context is impacted by the reset. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 02/17] cxlflash: Update cxlflash_afu_sync() to return errno

rly indicate the failure cause to the > caller. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 01/17] cxlflash: Combine the send queue locks

mplification and to support serialization with enqueue > operations, move to only a single lock that is used for enqueueing > regardless of the queueing model. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH v4] cxl: Force context lock during EEH flow

gt; Reported-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> > Signed-off-by: Vaibhav Jain <vaib...@linux.vnet.ibm.com> Looks good. Uma should be following up later today after testing completes. Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH v2] cxl: Enable PCI device IDs for future IBM CXL adapters

> On Mar 24, 2017, at 11:03 AM, Matthew R. Ochs <mro...@linux.vnet.ibm.com> > wrote: > > Add support for future IBM Coherent Accelerator (CXL) devices > with an IDs of 0x0623 and 0x0628. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> &g

Re: [PATCH v4] cxl: Force context lock during EEH flow

> On Apr 11, 2017, at 6:13 AM, Frederic Barrat > wrote: > Le 11/04/2017 à 12:40, Michael Ellerman a écrit : >> Frederic Barrat writes: >> >>> Le 05/04/2017 à 13:35, Vaibhav Jain a écrit : During an eeh event when the cxl card is

Re: [PATCH 15/17] cxlflash: Support multiple hardware queues

initially implemented as a static array > embedded in the AFU. This will be transitioned to a dynamic allocation in a > later series to improve the memory footprint of the driver. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Looks good! Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 10/17] cxlflash: Fence EEH during probe

> On Apr 13, 2017, at 1:27 AM, Andrew Donnellan <andrew.donnel...@au1.ibm.com> > wrote: > > On 13/04/17 05:14, Uma Krishnan wrote: >> From: "Matthew R. Ochs" <mro...@linux.vnet.ibm.com> >> >> An EEH during probe can lead to a crash as the reco

[PATCH v2] cxl: Enable PCI device IDs for future IBM CXL adapters

Add support for future IBM Coherent Accelerator (CXL) devices with an IDs of 0x0623 and 0x0628. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> --- Cha

Re: [PATCH] cxl: Route eeh events to all slices for pci_channel_io_perm_failure state

d-off-by: Vaibhav Jain <vaib...@linux.vnet.ibm.com> Fix looks good! Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 4/4] cxlflash: Cancel scheduled workers before stopping AFU

is > cancelled after interrupts have been disabled and prior to the mapping > being freed. > > Fixes: b45cdbaf9f7f ("cxlflash: Resolve oops in wait_port_offline") > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Looks good. Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH v2 04/14] cxlflash: Avoid command room violation

o account the > current thread consuming a hardware command. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH] cxl: fix coccinelle warnings

llan <andrew.donnel...@au1.ibm.com> Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 2/2] cxl: Set VPD timeout to avoid access failures

> On Nov 21, 2016, at 6:32 PM, Andrew Donnellan <andrew.donnel...@au1.ibm.com> > wrote: > On 22/11/16 08:10, Matthew R. Ochs wrote: >> Some IBM CXL devices can take up to ~120ms to complete a VPD access > > Which devices? Flash GT

Re: [PATCH 1/2] PCI: Add pci_set_vpd_timeout() to set VPD access timeout

Hi Bjorn, > On Nov 21, 2016, at 4:05 PM, Bjorn Helgaas <helg...@kernel.org> wrote: > > Hi Matthew, > > On Mon, Nov 21, 2016 at 03:09:49PM -0600, Matthew R. Ochs wrote: >> The PCI core uses a fixed 50ms timeout when waiting for VPD accesses to >> complete. When a

[PATCH 2/2] cxl: Set VPD timeout to avoid access failures

for certain CXL devices to a value that allows appropriate VPD access delay when faced with a worst-case scenario. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/misc/cxl/pci.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/misc/cxl/pci.c b/driver

[PATCH 1/2] PCI: Add pci_set_vpd_timeout() to set VPD access timeout

() is added as an exported service. PCI devices will continue to default with the 50ms timeout and use a per-device timeout when a driver calls this new service. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/pci/access.c | 45 - d

[PATCH 0/2] Add device-specific VPD timeout

This small patch series introduces support for a driver to increase the VPD wait timeout for devices with slower interfaces. The series is based on v4.9-rc6 and is intended for v4.10. Matthew R. Ochs (2): PCI: Add pci_set_vpd_timeout() to set VPD access timeout cxl: Set VPD timeout to avoid

Re: [PATCH 04/14] cxlflash: Avoid command room violation

Hi Uma, I do see a potential hang issue with this patch. See my comments below. -matt > On Nov 15, 2016, at 5:14 PM, Uma Krishnan wrote: > > During test, a command room violation interrupt is occasionally seen > for the master context when the CXL flash devices

Re: [PATCH 03/14] cxlflash: Improve context_reset() logic

itionally it adds a debug trace to help pinpoint > hardware errors when a context reset does not complete. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 02/14] cxlflash: Fix crash in cxlflash_restore_luntable()

LUN information structure is updated to > reflect the LUN is no longer in the LUN table once all references to > the LUN are gone. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 01/14] cxlflash: Set sg_tablesize to 1 instead of SG_NONE

issue, sg_tablesize for cxlflash can simply be set > to 1, a value which satisfies the constraints in cxlflash and the > lack of support of SG_NONE in SCSI blk_mq. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [RESEND PATCH] cxl: Fix coredump generation when cxl_get_fd() is used

on the first allocation of a file descriptor by > cxl_get_fd(). > > Tested with cxlflash. > > Signed-off-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 2/6] cxlflash: Remove the device cleanly in the system shutdown path

ime, the remove hook is updated to protect against being > called when the device is not enabled. > > Fixes: 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash > cards") > Signed-off-by: Uma Krishna <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH 1/6] cxlflash: Scan host only after the port is ready for I/O

problem, scsi_scan_host() should be called only after the > 'login succeeded' interrupt. > > Signed-off-by: Uma Krishna <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

Re: [PATCH] cxl: use pcibios_free_controller_deferred() when removing vPHBs

ree the pci_controller after all > devices have been released. Export pci_set_host_bridge_release() so we can > do this. > > Cc: sta...@vger.kernel.org > Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>

[PATCH 6/6] cxlflash: Update documentation

Update the block library link in the API documentation. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- Documentation/powerpc/cxlflash.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/powerpc/cxlflash.txt b/Documentation/powerpc/cxlfla

[PATCH 5/6] cxlflash: Remove adapter file descriptor cache

t;v...@zeniv.linux.org.uk> Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/superpipe.c | 26 +- drivers/scsi/cxlflash/superpipe.h | 1 - 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/cxlflash/superpipe.

[PATCH 4/6] cxlflash: Transition to application close model

that they are responsible for the close following the cleanup (detach) of a context. The documentation is also updated to reflect this change in behavior. Inspired-by: Al Viro <v...@zeniv.linux.org.uk> Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- Documentation/powerpc/cxlfl

[PATCH 3/6] cxlflash: Add kref to context

bug injection. To improve code comprehension and better protect against future bugs, add explicit reference counting to contexts and migrate the context removal code to the kref release handler. Inspired-by: Al Viro <v...@zeniv.linux.org.uk> Signed-off-by: Matthew R. Och

[PATCH 2/6] cxlflash: Cache owning adapter within context

reference as the sole parameter, another means is needed to derive the owning adapter. As a remedy, the owning adapter reference is saved off within the context during initialization. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- drivers/scsi/cxlflash/superpipe.c | 1 + driver

[PATCH 1/6] cxlflash: Avoid mutex when destroying context

of these context management paths are superfluous. This commit removes the obtaining of the context mutex in the context initialization routine and assumes the mutex is not held in the context free path. Inspired-by: Al Viro <v...@zeniv.linux.org.uk> Signed-off-by: Matthew R. Och

[PATCH 0/6] cxlflash: Improvements and cleanup

alongside the modifications. The series is based upon 4.8-rc1, intended for 4.9, and is bisectable. Matthew R. Ochs (6): cxlflash: Avoid mutex when destroying context cxlflash: Cache owning adapter within context cxlflash: Add kref to context cxlflash: Transition to application close model

Re: [PATCH] cxl: fix sparse warnings

<andrew.donnel...@au1.ibm.com> Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 2/2] MAINTAINERS: Update cxlflash maintainers

> On Jul 21, 2016, at 3:44 PM, Uma Krishnan <ukri...@linux.vnet.ibm.com> wrote: > > Adding myself as a cxlflash maintainer. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs

Re: [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown

tdown notify support > for CXL Flash cards"). > > As a fix, shutdown notification should only occur when the AFU is mapped. > > Fixes: 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Flash cards") > Signed-off-by: Uma

Re: [PATCH] cxl: remove dead Kconfig options

perst_reloads_same_image() in cxlflash which is > only used if CXL_EEH isn't defined (i.e. never). > > Suggested-by: Ian Munsie <imun...@au1.ibm.com> > Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> Acke

Re: [v7, 1/2] cxl: Add mechanism for delivering AFU driver specific events

ain the > AFU file descriptor (i.e. cxlflash uses an ioctl on their scsi file > descriptor to obtain the AFU file descriptor) and the generic cxl driver > will never use this event, the ABI of the event is up to each individual > AFU driver. &g

Re: [v6, 1/2] cxl: Add mechanism for delivering AFU driver specific events

> On Jun 21, 2016, at 5:34 AM, Vaibhav Jain wrote: > > Hi Ian, > > Ian Munsie writes: > >> Excerpts from Vaibhav Jain's message of 2016-06-20 14:20:16 +0530: >> >> What exactly is the use case for this API? I'd vote to drop it if we can >> do

Re: [PATCH 3/3] cxlflash: Shutdown notify support for CXL Flash cards

the card and returns. When the device > is removed in the PCI remove path, notification code will > wait for shutdown processing to complete. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> __

Re: [PATCH 2/3] cxlflash: Add device dependent flags

ed and expanded in the future to > support various device specific functions. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/3] cxlflash: Fix to drain operations from previous reset

drain_ioctls() was static, it had to be moved up a bit to be before > cxlflash_eh_host_reset_handler(). > > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [v6, 1/2] cxl: Add mechanism for delivering AFU driver specific events

> On Jun 16, 2016, at 9:13 AM, Philippe Bergheaud > wrote: > > This adds an afu_driver_ops structure with fetch_event() and > event_delivered() callbacks. An AFU driver such as cxlflash can fill > this out and associate it with a context to enable passing custom > AFU

Re: [PATCH] cxl: Make vPHB device node match adapter's

> On Jun 15, 2016, at 9:42 AM, Frederic Barrat <fbar...@linux.vnet.ibm.com> > wrote: > > Tested by cxlflash on bare-metal and powerVM. > > Signed-off-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> Reviewed-by: Matthew R. O

Re: [v5, 1/2] cxl: Add mechanism for delivering AFU driver specific events

Hi Philippe, So I think we're largely okay with this revision. I made one comment below with respect to the name of the event retrieval callback. -matt > On May 23, 2016, at 7:49 AM, Philippe Bergheaud > wrote: > > This adds an afu_driver_ops structure with

Re: [v5, 1/2] cxl: Add mechanism for delivering AFU driver specific events

Vaibhav/Philippe, Finally getting back around to looking at this. -matt > On May 25, 2016, at 2:22 AM, Vaibhav Jain <vaib...@linux.vnet.ibm.com> wrote: > > Hi Matt, > > "Matthew R. Ochs" <mro...@linux.vnet.ibm.com> writes: >> The purpose for the cou

Re: [v5, 1/2] cxl: Add mechanism for delivering AFU driver specific events

> On May 24, 2016, at 1:59 AM, Vaibhav Jain wrote: > > Hi Philippe, > > Few comments, > > Philippe Bergheaud writes: > >> diff --git a/drivers/misc/cxl/cxl.h b/drivers/misc/cxl/cxl.h >> index 4fe5078..b0027e6 100644 >> ---

Re: [PATCH 1/1] cxlflash: Fix to resolve dead-lock during EEH recovery

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] cxl: static-ify variables to fix sparse warnings

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] cxl: fix setting of _PAGE_USER bit when handling page faults

t; > Fix the check so that the _PAGE_USER bit is set only as intended. > > Fixes: f204e0b8cedd ("cxl: Driver code for powernv PCIe based cards for > userspace access") > Signed-off-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> Per Ian's suggestion, I

Re: [PATCH 2/2] cxlflash: Move to exponential back-off when cmd_room is not available

ad the least > overall cost. Cost as being defined as overall time spent waiting. > > The fix is to change the linear back-off to an exponential back-off. > This solution also takes care of the problem with the initial > delay (starts with 1 usec). > > Signed

Re: [PATCH 1/2] cxlflash: Fix regression issue with re-ordering patch

o keep the initialization process symmetric, separate the AFU interrupt > setup also to a distinct function: init_intr(). > > Fixes: 6ded8b3cbd9a ("cxlflash: Unmap problem state area before detaching > master context") > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.c

Re: [PATCH 6/7] cxlflash: Fix to avoid unnecessary scan with internal LUNs

gt;max_channel is retained. This > causes an unnecessary scan over the second port/channel. > > This fix alters the host->max_channel to 0 (1 port), if internal > LUNs are configured and switches it back to 1 (2 ports) while > going back to external LUNs. > > Sign

Re: [PATCH 7/7] cxlflash: Increase cmd_per_lun for better throughput

. > > Increase the value of cmd_per_lun to 256 to improve > throughput. With this change a single adapter is able to > attain close to the maximum throughput (380kIOPS). > Also change the number of RRQ entries that can be queued. > > Signed-off-by: Manoj N. Kumar <ma...@linux.vne

Re: [PATCH 5/7] cxlflash: Reorder user context initialization

ix this problem, cxl_start_work() is called before obtaining > the process element id. > > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 2/7] cxlflash: Unmap problem state area before detaching master context

> > Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/7] cxlflash: Simplify PCI registration

the call the > pci_release_regions() from cxlflash_remove(). > > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 19/20] cxlflash: Use new cxl_pci_read_adapter_vpd() API

This patch should have also been sent to the SCSI list (included now). Changes look fine. Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > On Mar 4, 2016, at 5:26 AM, Frederic Barrat <fbar...@linux.vnet.ibm.com> > wrote: > > To read the adapter VPD, drivers

Re: [PATCH] cxl: Fix PSL timebase synchronization detection

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 3/6] cxlflash: Removed driver date print

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 4/6] cxlflash: Fix to resolve cmd leak after host reset

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 5/6] cxlflash: Resolve oops in wait_port_offline

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 6/6] cxlflash: Enable device id for future IBM CXL adapter

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/6] cxlflash: Fix to escalate LINK_RESET also on port 1

Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] cxl: Enable PCI device ID for future IBM CXL adapter

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] cxl: Fix DSI misses when the context owning task exits

Reviewed-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v6 00/37] cxlflash: Miscellaneous bug fixes and corrections

Hi James, This series has been reviewed/acked. Is there anything else you're looking for before this can make it into -next? -matt > On Oct 21, 2015, at 3:08 PM, Matthew R. Ochs <mro...@linux.vnet.ibm.com> > wrote: > > This patch set contains various fixes and corr

[PATCH v6 11/37] cxlflash: Refine host/device attributes

Implement the following suggestions and add two new attributes to allow for debugging the port LUN table. - use scnprintf() instead of snprintf() - use DEVICE_ATTR_RO and DEVICE_ATTR_RW Suggested-by: Shane Seymour <shane.seym...@hp.com> Signed-off-by: Matthew R. Ochs <mro...@linux.vne

[PATCH v6 00/37] cxlflash: Miscellaneous bug fixes and corrections

Replace magic numbers with literals cxlflash: Fix read capacity timeout cxlflash: Fix to double the delay each time cxlflash: Fix to escalate to LINK_RESET on login timeout Matthew R. Ochs (32): cxlflash: Fix potential oops following LUN removal cxlflash: Fix data corruption when vLUN used

[PATCH v6 04/37] cxlflash: Fix potential oops following LUN removal

. This resolves a potential Oops in the release handler when a dealing with a LUN that has already been removed. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> Review

[PATCH v6 07/37] cxlflash: Fix context encode mask width

The context encode mask covers more than 32-bits, making it a long integer. This should be noted by appending the ULL width suffix to the mask. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Bri

[PATCH v6 09/37] cxlflash: Correct naming of limbo state and waitq

Limbo is not an accurate representation of this state and is also not consistent with the terminology that other drivers use to represent this concept. Rename the state and and its associated waitq to 'reset'. Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: M

[PATCH v6 12/37] cxlflash: Fix to avoid spamming the kernel log

'. The following changes were made: - pr_debug to pr_devel - pr_debug to pr_debug_ratelimited - pr_err to dev_err - pr_debug to dev_dbg Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> Reviewed-by: Bri

  1   2   3   4   >