[PATCH 0/2] add OF wrapper for uio-pdrv-genirq

2009-06-11 Thread Wolfram Sang
This series adds an OF wrapper for the uio-pdrv-genirq driver. Patch 1 refactors the platform driver to expose a generic probe-routine. Patch 2 then adds the OF wrapper. Documentation for the binding is also added. There may be an issue with stack-usage, as noted there. Tested on

[PATCH 1/2] uio/pdrv_genirq: Refactor probe routine to expose a generic part

2009-06-11 Thread Wolfram Sang
This patch refactors the probe routine, so that an of-version of a similiar driver can pick it up later. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Magnus Damm magnus.d...@gmail.com Cc: Hans J. Koch h...@linutronix.de Cc: Greg KH gre...@suse.de --- drivers/uio/uio_pdrv_genirq.c

[PATCH 2/2] uio: add an of_genirq driver

2009-06-11 Thread Wolfram Sang
Picking up the now exported generic probe function from the platform-variant of this driver, this patch adds an of-version. Also add the binding documentation. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Magnus Damm magnus.d...@gmail.com Cc: Hans J. Koch h...@linutronix.de Cc: Greg KH

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-08 Thread Wolfram Sang
mainline nevertheless? Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev

Re: [PATCH 05/04] *** NOT FOR RELEASE *** HACK *** Work around MII clock issue ***

2009-06-07 Thread Wolfram Sang
are related enough to assume it is ips here. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-06 Thread Wolfram Sang
On Sat, Jun 06, 2009 at 09:14:08AM +0100, David Woodhouse wrote: On Fri, 2009-06-05 at 14:05 +0200, Wolfram Sang wrote: Create an of-aware driver using the now exported generic functions from plat-ram.c. Also add the documentation for the binding. Partitions are not yet supported. Tested

[PATCH V2 0/2] mtd/maps/mtd-ram: Make driver usable for the device tree

2009-06-05 Thread Wolfram Sang
Hello, this is the new series to adapt the mtd-ram-driver for use with the device tree. All comments have been addressed and it has been tested on a phyCORE-MPC5200B-IO (with latest linus-git). Albrecht: As you used the patches recently, maybe you want to ack them? Looking forward to comments,

[PATCH V2 1/2] mtd/maps/mtd-ram: refactor probe and remove

2009-06-05 Thread Wolfram Sang
Refactor the probe and remove routines of the mtd-ram driver to export a generic part which can later be accessed by an of-counterpart of this driver. Tested with a phyCORE-i.MX27 (ARM, non-of) and a phyCORE-MPC5200B-IO (PPC, of). Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Albrecht

[PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-05 Thread Wolfram Sang
Create an of-aware driver using the now exported generic functions from plat-ram.c. Also add the documentation for the binding. Partitions are not yet supported. Tested on a phyCORE-MPC5200B-IO. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Albrecht Dreß albrecht.dr...@arcor.de Cc: Grant

Re: MPC8272- Porting HDLC driver from 2.6.14 to 2.6.27- no_irq_chip error

2009-06-01 Thread Wolfram Sang
for some reason. Then again, maybe it should be skipped, as it makes it easier to not use the proper solution (= device tree) :) Kind regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

[PATCH] powerpc/cpm2: make cpm2_pic the default host

2009-05-29 Thread Wolfram Sang
As stated in the source, this one is usually the only interrupt-controller. To ease creating virq mappings, let it be the default host. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Acked-by: Daniel Ng daniel.ng1...@gmail.com Cc: Vitaly Bordug v...@kernel.crashing.org Cc: Kumar Gala ga

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Wolfram Sang
only test it and give a tested-by-tag if it doesn't break anything here. I think Joakim would be a good candidate for an acked-by . -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc

Re: Weird 5200/mtd-ram problem

2009-05-25 Thread Wolfram Sang
byte or high byte indicators in non-muxed mode. How is this supposed to work then? Hmm, as I feared... we were bitten by this, too: http://thread.gmane.org/gmane.linux.drivers.mtd/21521 There is no generic solution yet :( -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH V2 5/9] Main rewite of the mpc5200 audio DMA code

2009-05-24 Thread Wolfram Sang
Rewrite the mpc5200 audio DMA code to support both I2S and AC97. Make it more robust. Why is it more robust? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description

Re: mpc5200 fec error

2009-05-20 Thread Wolfram Sang
the chance to track it down and kill it yet. I believe there are locking issues associated with it. Uuuh, I recall this message. Kept me busy for some time :( You might try this patch which helped in our situation. === Subject: Enable XLB pipelining for MPC5200B From: Wolfram Sang w.s

Re: [PATCH] powerpc/5200: beyond ARRAY_SIZE of mpc52xx_uart_{ports, nodes}

2009-05-20 Thread Wolfram Sang
On Wed, May 20, 2009 at 02:28:52AM +0200, Roel Kluin wrote: Do not go beyond ARRAY_SIZE of mpc52xx_uart_{ports,nodes} Signed-off-by: Roel Kluin roel.kl...@gmail.com Acked-by: Wolfram Sang w.s...@pengutronix.de --- diff --git a/drivers/serial/mpc52xx_uart.c b/drivers/serial/mpc52xx_uart.c

[PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft

2009-05-20 Thread Wolfram Sang
Add a node for the i2c eeprom and delete the superflous gpio-example. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca Cc: linuxppc-dev@ozlabs.org --- arch/powerpc/boot/dts/pcm030.dts | 26 -- 1 files changed, 4 insertions

Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft

2009-05-20 Thread Wolfram Sang
On Wed, May 20, 2009 at 12:10:59PM -0400, Jon Smirl wrote: On Wed, May 20, 2009 at 11:53 AM, Wolfram Sang w.s...@pengutronix.de wrote: -                       /* FIXME: EEPROM */ +                       eep...@52 { +                               compatible = at24,24c32

Re: mpc5200 fec error

2009-05-20 Thread Wolfram Sang
then, have to dig up details, as it doesn't seem to happen here...) Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft

2009-05-20 Thread Wolfram Sang
, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev

Re: Weird 5200/mtd-ram problem

2009-05-20 Thread Wolfram Sang
accesses? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev

[PATCH V2] powerpc/pcm030.dts: add i2c eeprom and delete cruft

2009-05-20 Thread Wolfram Sang
Add a node for the i2c eeprom and delete the superflous gpio-example. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca Cc: linuxppc-dev@ozlabs.org --- Changes since V1: use vendor name in eeprom-node arch/powerpc/boot/dts/pcm030.dts | 26

Re: [PATCH 2/2] maps/mtd-ram: add an of-platform driver

2009-05-20 Thread Wolfram Sang
Hello Grant, as I am just working on V2 (fixed even some additional things), two more questions came up: On Tue, May 19, 2009 at 08:57:15AM -0600, Grant Likely wrote: On Wed, Jan 21, 2009 at 11:41 AM, Wolfram Sang w.s...@pengutronix.de wrote: Create an of-aware driver using the now exported

Re: Q: MTD RAM in OF Device Tree

2009-05-19 Thread Wolfram Sang
://patchwork.ozlabs.org/patch/23557/ http://patchwork.ozlabs.org/patch/23556/ I'd be happy if you could give it a try and donate some {Acked|Tested|Reviewed}-by tags. Maybe this will help for my next try to get it mainline. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH 2/2] maps/mtd-ram: add an of-platform driver

2009-05-19 Thread Wolfram Sang
Hi Grant, thanks a lot for the review! On Tue, May 19, 2009 at 08:57:15AM -0600, Grant Likely wrote: On Wed, Jan 21, 2009 at 11:41 AM, Wolfram Sang w.s...@pengutronix.de wrote: Create an of-aware driver using the now exported generic functions from plat-ram.c. A typical oftree snipplet

Re: mpc5200 fec error

2009-05-19 Thread Wolfram Sang
. With that setup, I could work with NFS flawlessly, no real stress-testing though. Testing latest .3-rt is on my todo, will check the phyCOREs, too. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

Re: [PATCH] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-18 Thread Wolfram Sang
to be resolved? Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing

[PATCH V2] mpc5121/clocks: make debug output more readable

2009-05-15 Thread Wolfram Sang
- refactor printk with pr_info/pr_cont - use '=' in output to connect key/value pairs Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: John Rigby jcri...@gmail.com Cc: Grant Likely grant.lik...@secretlab.ca --- arch/powerpc/platforms/512x/clock.c |8 1 file changed, 4

Re: [PATCH] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-14 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman

Re: [PATCH] leds: Add options to have GPIO LEDs start on or keep their state

2009-05-13 Thread Wolfram Sang
specific reason for the change from u8 to unsigned? Could be mentioned in the patch description maybe. And what Sean mentioned :) Other than that: Acked-by: Wolfram Sang w.s...@pengutronix.de -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions

Re: device trees.

2009-05-12 Thread Wolfram Sang
have the discussion privately. I disagree. There are lots of lurkers on this list who care about virtex stuff, not to mention non-lurkers like me. :-) I would at least like to be a fly on the wall of any such discussion. +1 :) -- Pengutronix e.K. | Wolfram Sang

[PATCH] mpc5121/clocks: make debug output more readable

2009-05-08 Thread Wolfram Sang
- Drop KERN_ levels for printks which print to the same line - use '=' in output to connect key/value pairs Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: John Rigby jcri...@gmail.com Cc: Grant Likely grant.lik...@secretlab.ca --- arch/powerpc/platforms/512x/clock.c |7 +++ 1

[PATCH] net/fs_enet/mii-fec: Use PHY_POLL instead of hard coded '-1'

2009-05-08 Thread Wolfram Sang
Initialize the irq-table with PHY_POLL. '-1' means the same now, but is hardly maintainable. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Vitaly Bordug vbor...@ru.mvista.com Cc: Pantelis Antoniou pantelis.anton...@gmail.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: net

Re: [PATCH] net/fs_enet/mii-fec: Use PHY_POLL instead of hard coded '-1'

2009-05-08 Thread Wolfram Sang
This code no longer exists in net-next. EPIC FAIL! :/ I checked the powerpc-tree, but not linux-next. I'm sorry for the noise, will improve! -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de

Re: [PATCH 10/12] mpc5121: Add MPC5121 Real time clock driver.

2009-05-06 Thread Wolfram Sang
to Domen's original: Changed filenames/routine names from mpc5200* to mpc5121* Why not changing it to mpc5xxx? From a glimpse, it should still work on MPC5200, too. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions

Re: Using archaic I2C with OF

2009-05-01 Thread Wolfram Sang
specific function and create a platform device from there. Sometimes it works to add a bit more info to the device tree (e.g. some gpios) and parse it via an of_wrapper around the platform driver. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH] keywest: Convert to new-style i2c driver

2009-04-21 Thread Wolfram Sang
pushing. Full ACK! -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc

Re: OF PCI howto?

2009-04-15 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman

Re: [PATCH] powerpc: Print information about mapping hw irqs to virtual irqs

2009-04-06 Thread Wolfram Sang
/listinfo/linuxppc-dev -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc

Re: [PATCH] powerpc: Print information about mapping hw irqs to virtual irqs

2009-04-06 Thread Wolfram Sang
an irq. The message is only printed the first time the irq is mapped, and it's KERN_DEBUG so most people won't see it. Signed-off-by: Michael Ellerman mich...@ellerman.id.au Acked-by: Wolfram Sang w.s...@pengutronix.de --- arch/powerpc/kernel/irq.c |4 +++- 1 files changed, 3

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfram Sang
); + } dev_set_drvdata(op-dev, i2c); ___ devicetree-discuss mailing list devicetree-disc...@ozlabs.org https://ozlabs.org/mailman/listinfo/devicetree-discuss Regards, Wolfram -- Pengutronix e.K. | Wolfram

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfram Sang
); + } No, because the I2C registers are not yet mapped. Sorry, I used misleading words :) With 'here' I meant 'at this position', i.e. insert my above block where mpc_i2c_setclock was used anyway. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux

[PATCH v2] powerpc/mpc52xx: add Phytec phyCORE-MPC5200B-IO board (pcm032)

2009-03-10 Thread Wolfram Sang
Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- Changes since V1: * removed defconfig * reworked localbus node arch/powerpc/boot/dts/pcm032.dts | 392 ++ arch/powerpc/platforms/52xx/Kconfig |1 + arch/powerpc/platforms/52xx/mpc5200_simple.c

[PATCH 1/2] powerpc/kernel: typo: s/resouces/resources/

2009-03-09 Thread Wolfram Sang
Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- arch/powerpc/kernel/pci-common.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c index 0f41812..f57b7bf 100644 --- a/arch/powerpc/kernel/pci-common.c

Re: [PATCH] powerpc/5200: remove sysfs debug file from GPT driver

2009-03-07 Thread Wolfram Sang
On Fri, Mar 06, 2009 at 01:31:41PM -0700, Grant Likely wrote: Wolfram, you were right. This was a bad idea. I just took me a bit longer to clue into it. Instant ACK :D Thanks! Acked-by: Wolfram Sang w.s...@pengutronix.de -- Pengutronix e.K. | Wolfram Sang

[PATCH] powerpc/mpc52xx: add Phytec phyCORE-MPC5200B-IO board (pcm032)

2009-02-25 Thread Wolfram Sang
Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- arch/powerpc/boot/dts/pcm032.dts | 391 +++ arch/powerpc/configs/52xx/pcm032_defconfig | 1394 ++ arch/powerpc/platforms/52xx/Kconfig |1 + arch/powerpc/platforms/52xx/mpc5200_simple.c

Re: [PATCH] powerpc/mpc52xx: add Phytec phyCORE-MPC5200B-IO board (pcm032)

2009-02-25 Thread Wolfram Sang
Forgot to mention that this goes on top of Grant's 'next'-branch. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

SPI-Difference between MX1 and MX31

2009-02-12 Thread Wolfram Sang
forward to feedback :) Regards, Wolfram Sang -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Wolfram Sang
, because unacknowledged I2C operations can cause the I2C bus to hang. Signed-off-by: Timur Tabi ti...@freescale.com Acked-by: Wolfram Sang w.s...@pengutronix.de -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

Re: [ANN] Introducing new test branch in powerpc.git tree

2009-02-05 Thread Wolfram Sang
check anytime if you already have picked up a patch or if it has been overlooked... Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital

Re: [ANN] Introducing new test branch in powerpc.git tree

2009-02-05 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org

Re: [PATCH v4] powerpc/5200: Rework GPT driver to also be an IRQ controller

2009-02-04 Thread Wolfram Sang
to pull it tomorrow. Sorry, but it still has issues. This review in a hurry leaves me with a bit uneasy feelings, still, if the remaining issues get resolved, you may add my Reviewed-by: Wolfram Sang w.s...@pengutronix.de g. arch/powerpc/platforms/52xx/Makefile |2 arch/powerpc

Re: [PATCH 2] powerpc/5200: Rework GPT driver to also be an IRQ controller

2009-01-31 Thread Wolfram Sang
- Only set to GPIO mode if it has the gpio-controller property. Otherwise leave the configuration alone. Firmware may have already configured it. Signed-off-by: Grant Likely grant.lik...@secretlab.ca CC: Sascha Hauer s.ha...@pengutronix.de CC: Wolfram Sang w.s...@pengutronix.de CC: linuxppc

Re: [PATCH 1/8] powerpc/5200: update device tree binding documentation

2009-01-29 Thread Wolfram Sang
described elsewhere. Signed-off-by: Grant Likely grant.lik...@secretlab.ca CC: devtree-disc...@ozlabs.org CC: Wolfram Sang w.s...@pengutronix.de Can you please send the updated version so I could add an reviewed-by? Regards, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de

Re: [PATCH 2/8] powerpc/5200: Stop using device_type and port-number properties

2009-01-29 Thread Wolfram Sang
the other devices). Userspace can query sysfs to determine what ttyPSC number is assigned to each PSC instance. Signed-off-by: Grant Likely grant.lik...@secretlab.ca CC: Wolfram Sang w.s...@pengutronix.de I like it. One more optimization below, but it's also good for now... Reviewed

Re: [PATCH 3/8] powerpc/5200: Trim cruft from device trees

2009-01-29 Thread Wolfram Sang
audited, not tested on real hardware. Signed-off-by: Grant Likely grant.lik...@secretlab.ca Reviewed-by: Wolfram Sang w.s...@pengutronix.de CC: Wolfram Sang w.s...@pengutronix.de CC: Wolfgang Grandegger w...@grandegger.com CC: Sascha Hauer s.ha...@pengutronix.de CC: Marian Balakowicz m

Re: [PATCH 5/8] powerpc/5200: Don't specify IRQF_SHARED in PSC UART driver

2009-01-29 Thread Wolfram Sang
the IRQF_DISABLED is not guaranteed on shared IRQs warning message from the console output. Signed-off-by: Grant Likely grant.lik...@secretlab.ca What do I give here? Acked-by? Reviewed? Tested? :D I'll make a guess: Reviewed-by: Wolfram Sang w.s...@pengutronix.de --- drivers/serial/mpc52xx_uart.c

Re: [PATCH 6/8] powerpc/5200: Remove pr_debug() from hot paths in irq driver

2009-01-29 Thread Wolfram Sang
. Signed-off-by: Grant Likely grant.lik...@secretlab.ca Yup! Reviewed-by: Wolfram Sang w.s...@pengutronix.de --- arch/powerpc/platforms/52xx/mpc52xx_pic.c | 23 --- 1 files changed, 0 insertions(+), 23 deletions(-) diff --git a/arch/powerpc/platforms/52xx

Re: [PATCH 7/8] powerpc/5200: Refactor mpc5200 interrupt controller driver

2009-01-29 Thread Wolfram Sang
). The simplification is due to splitting off the handling of external IRQs into a separate block so they don't need to be handled as exceptions in the normal CRIT, MAIN and PERP paths. Signed-off-by: Grant Likely grant.lik...@secretlab.ca CC: Wolfram Sang w.s...@pengutronix.de Can't say much about this one

Re: [PATCH] powerpc/5200: Bugfix for PCI mapping of memory and IMMR

2009-01-29 Thread Wolfram Sang
. Without this patch, PCI appears to work correctly until a PCI device is inserted which DMAs into memory. Signed-off-by: Grant Likely grant.lik...@secretlab.ca No regression with a phyCORE-MPC5200B-tiny. U-Boot did probably the right thing here... Tested-by: Wolfram Sang w.s...@pengutronix.de

Re: [PATCH] powerpc/5200: update device tree binding documentation

2009-01-29 Thread Wolfram Sang
elsewhere. Signed-off-by: Grant Likely grant.lik...@secretlab.ca One minor nit, then you can add Reviewed-by: Wolfram Sang w.s...@pengutronix.de CC: devicetree-disc...@ozlabs.org CC: Wolfram Sang w.s...@pengutronix.de --- Documentation/powerpc/dts-bindings/fsl/mpc5200.txt | 180

Re: [PATCH 8/8] powerpc/5200: Rework GPT driver to also be an IRQ controller

2009-01-27 Thread Wolfram Sang
... Signed-off-by: Grant Likely grant.lik...@secretlab.ca CC: Sascha Hauer s.ha...@pengutronix.de CC: Wolfram Sang w.s...@pengutronix.de CC: linuxppc-dev@ozlabs.org --- arch/powerpc/platforms/52xx/Makefile |2 arch/powerpc/platforms/52xx/mpc52xx_gpio.c | 85 -- arch

Re: [PATCH 7/8] powerpc/5200: Refactor mpc5200 interrupt controller driver

2009-01-26 Thread Wolfram Sang
Hi Grant, I chose to line them up because in my opinion it is easier to follow the pattern with them written in horizontal columns instead of in vertical blocks. I also think the original coding style is easier to read. Kind regards, Wolfram -- Dipl.-Ing. Wolfram Sang | http

Re: [PATCH 1/8] powerpc/5200: update device tree binding documentation

2009-01-26 Thread Wolfram Sang
that it is in Hz? Yes, like in the frequency next to it. Kind regards, Wolfram PS: The other patches look good to me, too. I just want to test them on a real phyCORE-tiny this week. -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry

Re: [PATCH 1/8] powerpc/5200: update device tree binding documentation

2009-01-25 Thread Wolfram Sang
described elsewhere. Signed-off-by: Grant Likely grant.lik...@secretlab.ca CC: devtree-disc...@ozlabs.org CC: Wolfram Sang w.s...@pengutronix.de --- Documentation/powerpc/dts-bindings/fsl/mpc5200.txt | 181 + .../powerpc/mpc52xx-device-tree-bindings.txt | 277

Re: [PATCH 2/2] maps/mtd-ram: add an of-platform driver

2009-01-24 Thread Wolfram Sang
Hello, found one question thing myself... On Wed, Jan 21, 2009 at 06:41:25PM +0100, Wolfram Sang wrote: Create an of-aware driver using the now exported generic functions from plat-ram.c. A typical oftree snipplet for it looks like this: s...@04e0 { compatible = mtd-ram

Re: Bestcomm tasks and interrupts on MPC5200(B)

2009-01-21 Thread Wolfram Sang
on a new release for both, the pcm030 and pcm032 having 2.6.28 for non-RT and 2.6.26 for RT. Kind regards, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry signature.asc Description: Digital signature

mtd-ram: add of-support

2009-01-21 Thread Wolfram Sang
Hello, as we needed an of-mtd-ram driver to support SRAM on the phyCORE-MPC5200B-IO, I did the following: Patch 1: refactor plat-ram.c to have generic probe and remove routines Patch 2: use the new routines for an of-driver Looking forward to comments. (Sidenote: Converting all these

[PATCH 1/2] maps/mtd-ram: refactor probe and remove

2009-01-21 Thread Wolfram Sang
Refactor the probe and remove routines of the mtd-ram driver to export a generic part which can later be accessed by an of-counterpart of this driver. Tested with a phyCORE-MPC5200B-IO. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/mtd/maps/plat-ram.c | 123

[PATCH 2/2] maps/mtd-ram: add an of-platform driver

2009-01-21 Thread Wolfram Sang
. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/mtd/maps/Kconfig |6 ++ drivers/mtd/maps/Makefile |1 + drivers/mtd/maps/of-ram.c | 120 + 3 files changed, 127 insertions(+), 0 deletions(-) create mode 100644 drivers/mtd/maps

Re: Commits added to powerpc.git next and master branches

2008-12-24 Thread Wolfram Sang
Hello Grant, On Sun, Dec 21, 2008 at 03:01:05AM -0700, Grant Likely wrote: Wolfram Sang (3): powerpc/mpc5200: Remove obsolete code from mpc5200 MDIO driver powerpc/mpc5200: add rts/cts handling in PSC UART driver powerpc/mpc5200: fix error paths in PSC UART probe function

Re: [RESEND][PATCH] uio: Add of_platform_driver to uio_pdrv_genirq

2008-12-16 Thread Wolfram Sang
for this way. May have been the wrong path, but nothing that could not be changed. Kind regards, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry signature.asc Description: Digital signature

adding of_platform_drivers (was: Re: [RESEND][PATCH] uio: Add of_platform_driver to uio_pdrv_genirq)

2008-12-16 Thread Wolfram Sang
inbetween. Kind regards, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https

[RESEND][PATCH] uio: Add of_platform_driver to uio_pdrv_genirq

2008-12-11 Thread Wolfram Sang
= 0xa; interrupt-parent = fpga_irq_mux; }; To achieve this, the probe function has been refactored, so it can be used by platform and of code. Then, the of driver has been added. Signed-off-by: Wolfram Sang [EMAIL PROTECTED] --- drivers/uio/uio_pdrv_genirq.c | 178

Re: Erratic MPC8248 CPM2 I2C behaviour

2008-11-28 Thread Wolfram Sang
, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo

[PATCH] mpc52xx/serial: fix error paths in probe function

2008-11-27 Thread Wolfram Sang
- error cases for mapbase and irq were unbundled - mapped irq now gets disposed on error - errors return ENODEV instead of EINVAL as they are not dependant on arguments Signed-off-by: Wolfram Sang [EMAIL PROTECTED] --- drivers/serial/mpc52xx_uart.c | 27 +-- 1 files

Re: [PATCH] mpc52xx/serial: fix error paths in probe function

2008-11-27 Thread Wolfram Sang
-mapbase) { - printk(KERN_ERR Could not allocate resources for PSC\n); - return -EINVAL; - } (Originaly dropout for NO_IRQ) Regards, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry

Re: [PATCH v1] RS485 support for MPC5200x_psc_uart

2008-11-27 Thread Wolfram Sang
seen the TxRTS feature in Mode Register 2? It looks to me that it does the same (in hardware) what you achieve with the *_rts_clear-function and the TX_EMPTY interrupt. Or am I wrong? Kind regards, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions

Re: [U-Boot] MPC5200B: Trouble with config pins

2008-11-26 Thread Wolfram Sang
. Next revision of the PHY will have this fixed. (Yeah, next revision, sigh...) All the best, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry signature.asc Description: Digital signature

[PATCH] mpc52xx/serial: add rts/cts handling

2008-11-26 Thread Wolfram Sang
Add RTS/CTS-support for the PSC of the MPC5200B. Tested with a Phytec MPC5200B-IO. Signed-off-by: Wolfram Sang [EMAIL PROTECTED] --- arch/powerpc/include/asm/mpc52xx_psc.h | 11 +++- drivers/serial/mpc52xx_uart.c | 41 --- 2 files changed, 47

Re: [PATCH v1] RS485 support for MPC5200x_psc_uart

2008-11-13 Thread Wolfram Sang
regards, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org

Re: [PATCH V2] workaround for mpc52xx erratum #364 (serial may not be reset in break state)

2008-11-04 Thread Wolfram Sang
settings */ out_8(psc-command, MPC52xx_PSC_SEL_MODE_REG_1); out_8(psc-mode, mr1); ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev Thanks! Wolfram Sang -- Dipl.-Ing. Wolfram Sang

Re: [PATCH V3] workaround for mpc52xx erratum #364 (serial may not be reset in break state)

2008-11-04 Thread Wolfram Sang
, MPC52xx_PSC_RST_TX); + /* Update the per-port timeout */ + uart_update_timeout(port, new-c_cflag, baud); + /* Send new mode settings */ out_8(psc-command, MPC52xx_PSC_SEL_MODE_REG_1); out_8(psc-mode, mr1); Bye, Wolfram -- Dipl.-Ing. Wolfram Sang | http

Re: [PATCH] workaround for mpc52xx erratum #364 (serial may not be reset in break state)

2008-11-03 Thread Wolfram Sang
in the MPC5200. The first version of this patch used MPC5200_BUGFIX and it was mentioned, that some people might want to run the same kernel on both kind of processors. So, the patch that went mainline checks for the PVR. Maybe we should stick to this here, too? All the best, Wolfram Sang -- Dipl.-Ing

Re: [PATCH] [RESEND] i2c-cpm: Suppress autoprobing for devices

2008-10-16 Thread Wolfram Sang
Similar to commit 618b26d52843c0f85b8eb143cf2695d7f6fd072d, also remove automatic probing for this i2c controller. Might need updates to dts files using it. Signed-off-by: Wolfram Sang [EMAIL PROTECTED] Acked-by: Jochen Friedrich [EMAIL PROTECTED] --- Resend with cc to i2c. drivers/i2c/busses

Re: [PATCH] i2c-cpm: Suppress autoprobing for devices

2008-10-16 Thread Wolfram Sang
. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Please pull 'next' branch of git://git.secretlab.ca/git/linux-2.6-mpc52xx

2008-10-14 Thread Wolfram Sang
Hello Grant, On Thu, Oct 09, 2008 at 02:02:41AM -0600, Grant Likely wrote: Wolfram Sang (1): powerpc/mpc5200: trivial printk-fixes in mpc52xx_common Thanks. What about these? :) http://oldpatchwork.ozlabs.org/linuxppc-embedded/patch?id=20188 (remove obsolete code from mpc52xx_phy

Re: mpc52xx_uart and rs485

2008-09-26 Thread Wolfram Sang
recently read some criticism about software RS485 (http://article.gmane.org/gmane.linux.serial/2573). I don't know if these apply to this patch, but it would be nice to have it sorted out IMHO. All the best, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux

[RFC] GPIO-Watchdog in devicetree

2008-09-22 Thread Wolfram Sang
something like compatible = myvendor, mywatchdog which would result in lots of duplicated code per watchdog. So, which way to go? I am really undecided and would be happy to hear opinions. For completeness, I'll append the current version of my driver. All the best, Wolfram === From; Wolfram Sang

Re: Merge linuxppc-embedded with linuxppc-dev

2008-09-22 Thread Wolfram Sang
gripe about this on irc just the other day. My vote is to kill linuxppc-embedded. I also think one list will suffice nowadays. Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry signature.asc Description: Digital

Re: checkpatch nits ...

2008-08-27 Thread Wolfram Sang
Andy Whitcroft to CC. Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https

Re: MPC5200 FEC problems

2008-08-26 Thread Wolfram Sang
? Note that I don't have any trouble with this platform running RedBoot or eCos, just Linux :-( Try this patch and please report if it worked for you: http://www.nabble.com/-PATCH--MPC52XX:-Don't-touch-pipelining-for-MPC5200B-td19028341.html All the best, Wolfram -- Dipl.-Ing. Wolfram Sang

Re: [BUG] fec_mpc52xx: Don't call mpc52xx_fec_reset() in ISR

2008-08-15 Thread Wolfram Sang
removing some improper usage of netif_* calls; furthermore, I also found some questionable areas in this code (mails will be sent later). So, this driver needs some careful attention IMHO. All the best, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux

Re: bug: mutex_lock() in interrupt conntext via phy_stop() in gianfar

2008-07-22 Thread Wolfram Sang
hope people with more insight to network stuff can deliver a suitable solution to this problem. All the best, Wolfram === -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry signature.asc Description: Digital signature

Re: [i2c] [PATCH] of/i2c: don't pass -1 to irq_dispose_mapping, otherwise kernel will oops

2008-07-12 Thread Wolfram Sang
, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry signature.asc Description: Digital signature ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo

[BUG] fec_mpc52xx: Don't call mpc52xx_fec_reset() in ISR

2008-07-10 Thread Wolfram Sang
which place would be the right one to perform the soft reset. To not make things worse, I hope people with more insight to network stuff can deliver a suitable solution to this problem. All the best, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions

[PATCH] libfdt: Improve documentation in libfdt.h

2008-07-09 Thread Wolfram Sang
Fix a few typos and mistakes. Signed-off-by: Wolfram Sang [EMAIL PROTECTED] --- libfdt/libfdt.h | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/libfdt/libfdt.h b/libfdt/libfdt.h index 8645de0..dafb568 100644 --- a/libfdt/libfdt.h +++ b

Re: Merging seperate FDT-blobs?

2008-07-07 Thread Wolfram Sang
being an alias to the proper bus. Maybe I should add that I am _not_ assuming that the fragment is obtained from the bus which wants to have devices added. That is, one I2C-eeprom may contain data about additional devices on PCI. Kind regards, Wolfram -- Dipl.-Ing. Wolfram Sang | http

Re: [i2c] [PATCH 1/2] Convert i2c-mpc from a platform driver into a of_platform driver, V4

2008-07-02 Thread Wolfram Sang
the correct version perhaps? I'd like to test it, but can't find it at http://khali.linux-fr.org/devel/linux-2.6/jdelvare-i2c/ (because it is scheduled for 2.6.27?). All the best, Wolfram -- Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de Pengutronix - Linux Solutions for Science

[PATCH] Fix wrong 'no interrupt' handling in of_i2c

2008-06-28 Thread Wolfram Sang
-by: Wolfram Sang [EMAIL PROTECTED] --- drivers/of/of_i2c.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c index b2ccdcb..500cb1e 100644 --- a/drivers/of/of_i2c.c +++ b/drivers/of/of_i2c.c @@ -90,8 +90,6 @@ void

<    1   2   3   4   5   6   7   >