Re: [PATCH] ibmvnic: Use -EBUSY in __ibmvnic_reset()

2024-04-24 Thread Jakub Kicinski
On Tue, 23 Apr 2024 18:41:48 +0300 Dan Carpenter wrote: > > So, the point of the patch not doing any behavioral differences is still > > true. > > Ah yes. You're right. Hard call but overall I think this wasted more reviewer time than it's worth. So in the spirit of not encouraging noise I'm

Re: [PATCH] ibmvnic: Use -EBUSY in __ibmvnic_reset()

2024-04-23 Thread Dan Carpenter
On Tue, Apr 23, 2024 at 09:55:57AM -0500, Nick Child wrote: > > You're right that it doesn't affect the behavior of the driver except > > for the debug output when we do: > > > > netdev_dbg(adapter->netdev, "Reset failed, rc=%d\n", rc); > > > > But the - was left off uninitentionally so I

Re: [PATCH] ibmvnic: Use -EBUSY in __ibmvnic_reset()

2024-04-23 Thread Nick Child
On 4/23/24 06:55, Dan Carpenter wrote: On Tue, Apr 23, 2024 at 12:54:55PM +0200, Paolo Abeni wrote: On Fri, 2024-04-19 at 16:08 +0200, Markus Elfring wrote: From: Markus Elfring Date: Fri, 19 Apr 2024 15:46:17 +0200 Add a minus sign before the error code “EBUSY” so that a negative value

Re: [PATCH] ibmvnic: Use -EBUSY in __ibmvnic_reset()

2024-04-23 Thread Dan Carpenter
On Tue, Apr 23, 2024 at 12:54:55PM +0200, Paolo Abeni wrote: > On Fri, 2024-04-19 at 16:08 +0200, Markus Elfring wrote: > > From: Markus Elfring > > Date: Fri, 19 Apr 2024 15:46:17 +0200 > > > > Add a minus sign before the error code “EBUSY” > > so that a negative value will be used as in other

Re: [PATCH] ibmvnic: Use -EBUSY in __ibmvnic_reset()

2024-04-23 Thread Paolo Abeni
On Fri, 2024-04-19 at 16:08 +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 19 Apr 2024 15:46:17 +0200 > > Add a minus sign before the error code “EBUSY” > so that a negative value will be used as in other cases. > > This issue was transformed by using the Coccinelle software.

[PATCH] ibmvnic: Use -EBUSY in __ibmvnic_reset()

2024-04-19 Thread Markus Elfring
From: Markus Elfring Date: Fri, 19 Apr 2024 15:46:17 +0200 Add a minus sign before the error code “EBUSY” so that a negative value will be used as in other cases. This issue was transformed by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/ibm/ibmvnic.c