Re: [PATCH] powerpc/ps3: refactor strncpy usage

2023-08-23 Thread Michael Ellerman
On Wed, 16 Aug 2023 21:39:24 +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > `make_first_field()` should use similar implementation to `make_field()` > due to memcpy having more obvious behavior here. The end result yields > the same

Re: [PATCH] powerpc/ps3: refactor strncpy usage

2023-08-17 Thread Geoff Levand
On 8/16/23 14:39, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > `make_first_field()` should use similar implementation to `make_field()` > due to memcpy having more obvious behavior here. The end result yields > the same behavior as the

Re: [PATCH] powerpc/ps3: refactor strncpy usage

2023-08-17 Thread Michael Ellerman
Justin Stitt writes: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > `make_first_field()` should use similar implementation to `make_field()` > due to memcpy having more obvious behavior here. The end result yields > the same behavior as the previous

Re: [PATCH] powerpc/ps3: refactor strncpy usage

2023-08-16 Thread Kees Cook
On Wed, Aug 16, 2023 at 09:39:24PM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > `make_first_field()` should use similar implementation to `make_field()` > due to memcpy having more obvious behavior here. The end result yields > the

[PATCH] powerpc/ps3: refactor strncpy usage

2023-08-16 Thread Justin Stitt
`strncpy` is deprecated for use on NUL-terminated destination strings [1]. `make_first_field()` should use similar implementation to `make_field()` due to memcpy having more obvious behavior here. The end result yields the same behavior as the previous `strncpy`-based implementation including the