Re: [PATCH] powerpc: Remove device_type = rtc properties in .dts files

2008-10-22 Thread Matt Sealey
I'm extremely troubled that it is not used in the code, surely device_type is checked as a legacy for Open Firmware (otherwise a lot of devices may never be detected!), or does device tree parsing/checking follow a different path for FDT? (absolutely fine with it being removed from new DTS

Re: [PATCH] powerpc: Remove device_type = rtc properties in .dts files

2008-10-22 Thread Anton Vorontsov
On Wed, Oct 22, 2008 at 08:38:03AM -0500, Matt Sealey wrote: I'm extremely troubled that it is not used in the code, surely device_type is checked as a legacy for Open Firmware (otherwise a lot of devices may never be detected!), Checked where? Can you point out a code snippet? (Except for

Re: [PATCH] powerpc: Remove device_type = rtc properties in .dts files

2008-10-22 Thread Matt Sealey
Anton Vorontsov wrote: On Wed, Oct 22, 2008 at 08:38:03AM -0500, Matt Sealey wrote: I'm extremely troubled that it is not used in the code, surely device_type is checked as a legacy for Open Firmware (otherwise a lot of devices may never be detected!), Checked where?

Re: [PATCH] powerpc: Remove device_type = rtc properties in .dts files

2008-10-22 Thread Anton Vorontsov
On Wed, Oct 22, 2008 at 01:40:50PM -0500, Matt Sealey wrote: Anton Vorontsov wrote: On Wed, Oct 22, 2008 at 08:38:03AM -0500, Matt Sealey wrote: I'm extremely troubled that it is not used in the code, surely device_type is checked as a legacy for Open Firmware (otherwise a lot of devices

Re: [PATCH] powerpc: Remove device_type = rtc properties in .dts files

2008-10-22 Thread Matt Sealey
Anton Vorontsov wrote: On Wed, Oct 22, 2008 at 01:40:50PM -0500, Matt Sealey wrote: I think I got it. ;-) You think that I'm not aware of that we _can_ use the device_type for matching the nodes. Well, I'm aware of it, sure we can. ;-) I'm sure you are aware, I am just a little jumpy

Re: [PATCH] powerpc: Remove device_type = rtc properties in .dts files

2008-10-22 Thread Anton Vorontsov
On Wed, Oct 22, 2008 at 02:09:01PM -0500, Matt Sealey wrote: Anton Vorontsov wrote: On Wed, Oct 22, 2008 at 01:40:50PM -0500, Matt Sealey wrote: I think I got it. ;-) You think that I'm not aware of that we _can_ use the device_type for matching the nodes. Well, I'm aware of it, sure we can.

Re: [PATCH] powerpc: Remove device_type = rtc properties in .dts files

2008-10-22 Thread Milton Miller
Matt Sealey wrote: Anton Vorontsov wrote: We don't want to encourage the device_type usage. It isn't used in the code, so we can simply remove it from the dts files. I'm extremely troubled that it is not used in the code, surely device_type is checked as a legacy for Open Firmware

[PATCH] powerpc: Remove device_type = rtc properties in .dts files

2008-10-21 Thread Anton Vorontsov
We don't want to encourage the device_type usage. It isn't used in the code, so we can simply remove it from the dts files. Suggested-by: Scott Wood [EMAIL PROTECTED] Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- arch/powerpc/boot/dts/kuroboxHD.dts |1 -

Re: [PATCH] powerpc: Remove device_type = rtc properties in .dts files

2008-10-21 Thread Grant Likely
2008/10/21 Anton Vorontsov [EMAIL PROTECTED]: We don't want to encourage the device_type usage. It isn't used in the code, so we can simply remove it from the dts files. Suggested-by: Scott Wood [EMAIL PROTECTED] Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] Acked-by: Grant Likely [EMAIL

Re: [PATCH] powerpc: Remove device_type = rtc properties in .dts files

2008-10-21 Thread David Gibson
On Tue, Oct 21, 2008 at 10:58:44PM +0400, Anton Vorontsov wrote: We don't want to encourage the device_type usage. It isn't used in the code, so we can simply remove it from the dts files. Suggested-by: Scott Wood [EMAIL PROTECTED] Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] Acked-by: