Re: [PATCH] powerpc: ps3: mark ps3_notification_device static for stack usage

2024-03-23 Thread Geoff Levand
On 3/23/24 05:24, Arnd Bergmann wrote: > On Fri, Mar 22, 2024, at 09:34, Geoff Levand wrote: >> On 3/21/24 17:32, Geert Uytterhoeven wrote: >>> --- a/arch/powerpc/platforms/ps3/device-init.c +++ b/arch/powerpc/platforms/ps3/device-init.c @@ -770,7 +770,7 @@ static struct task_struct

Re: [PATCH] powerpc: ps3: mark ps3_notification_device static for stack usage

2024-03-22 Thread Arnd Bergmann
On Fri, Mar 22, 2024, at 09:34, Geoff Levand wrote: > On 3/21/24 17:32, Geert Uytterhoeven wrote: >> --- a/arch/powerpc/platforms/ps3/device-init.c >>> +++ b/arch/powerpc/platforms/ps3/device-init.c >>> @@ -770,7 +770,7 @@ static struct task_struct *probe_task; >>> >>> static int

Re: [PATCH] powerpc: ps3: mark ps3_notification_device static for stack usage

2024-03-22 Thread Geoff Levand
On 3/21/24 17:32, Geert Uytterhoeven wrote: > --- a/arch/powerpc/platforms/ps3/device-init.c >> +++ b/arch/powerpc/platforms/ps3/device-init.c >> @@ -770,7 +770,7 @@ static struct task_struct *probe_task; >> >> static int ps3_probe_thread(void *data) >> { >> - struct

Re: [PATCH] powerpc: ps3: mark ps3_notification_device static for stack usage

2024-03-21 Thread Geoff Levand
Hi Geert, On 3/21/24 17:32, Geert Uytterhoeven wrote: >> static int ps3_probe_thread(void *data) >> { >> - struct ps3_notification_device dev; >> + static struct ps3_notification_device dev; >> int res; >> unsigned int irq; >> u64 lpar; > > Making it static

Re: [PATCH] powerpc: ps3: mark ps3_notification_device static for stack usage

2024-03-21 Thread Geert Uytterhoeven
Hi Arnd, On Wed, Mar 20, 2024 at 7:03 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The device is way too large to be on the stack, causing a warning for > an allmodconfig build with clang: > > arch/powerpc/platforms/ps3/device-init.c:771:12: error: stack frame size > (2064) exceeds limit

Re: [PATCH] powerpc: ps3: mark ps3_notification_device static for stack usage

2024-03-20 Thread Geoff Levand
On 3/21/24 03:03, Arnd Bergmann wrote: > From: Arnd Bergmann > > The device is way too large to be on the stack, causing a warning for > an allmodconfig build with clang: > > arch/powerpc/platforms/ps3/device-init.c:771:12: error: stack frame size > (2064) exceeds limit (2048) in

[PATCH] powerpc: ps3: mark ps3_notification_device static for stack usage

2024-03-20 Thread Arnd Bergmann
From: Arnd Bergmann The device is way too large to be on the stack, causing a warning for an allmodconfig build with clang: arch/powerpc/platforms/ps3/device-init.c:771:12: error: stack frame size (2064) exceeds limit (2048) in 'ps3_probe_thread' [-Werror,-Wframe-larger-than] 771 | static