Re: [PATCH] soc: fsl: qe: Replace all non-returning strlcpy with strscpy

2023-07-26 Thread Kees Cook
On Tue, 23 May 2023 02:14:25 +, Azeem Shaikh wrote: > strlcpy() reads the entire source buffer first. > This read may exceed the destination size limit. > This is both inefficient and can lead to linear read > overflows if a source string is not NUL-terminated [1]. > In an effort to remove

Re: [PATCH] soc: fsl: qe: Replace all non-returning strlcpy with strscpy

2023-07-12 Thread Kees Cook
abs.org; linux-ker...@vger.kernel.org; Leo Li > > ; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH] soc: fsl: qe: Replace all non-returning strlcpy with > > strscpy > > > > On Tue, May 23, 2023 at 1:20 PM Kees Cook > > wrote: > > > >

Re: [PATCH] soc: fsl: qe: Replace all non-returning strlcpy with strscpy

2023-07-11 Thread Azeem Shaikh
> Sorry for the late response. But I found some old discussions with the > conclusion to be not converting old users. Has this been changed later on? > https://lwn.net/Articles/659214/ > @Kees Cook what's your advice here?

RE: [PATCH] soc: fsl: qe: Replace all non-returning strlcpy with strscpy

2023-07-10 Thread Leo Li
Subject: Re: [PATCH] soc: fsl: qe: Replace all non-returning strlcpy with > strscpy > > On Tue, May 23, 2023 at 1:20 PM Kees Cook > wrote: > > > > On Tue, May 23, 2023 at 02:14:25AM +, Azeem Shaikh wrote: > > > strlcpy() reads the entire source buffer fir

Re: [PATCH] soc: fsl: qe: Replace all non-returning strlcpy with strscpy

2023-07-09 Thread Azeem Shaikh
On Tue, May 23, 2023 at 1:20 PM Kees Cook wrote: > > On Tue, May 23, 2023 at 02:14:25AM +, Azeem Shaikh wrote: > > strlcpy() reads the entire source buffer first. > > This read may exceed the destination size limit. > > This is both inefficient and can lead to linear read > > overflows if a

Re: [PATCH] soc: fsl: qe: Replace all non-returning strlcpy with strscpy

2023-05-30 Thread Azeem Shaikh
Duplicate of https://lore.kernel.org/all/20230523021425.2406309-1-azeemshaik...@gmail.com/. Sorry about that. On Tue, May 30, 2023 at 12:00 PM Azeem Shaikh wrote: > > strlcpy() reads the entire source buffer first. > This read may exceed the destination size limit. > This is both inefficient

[PATCH] soc: fsl: qe: Replace all non-returning strlcpy with strscpy

2023-05-30 Thread Azeem Shaikh
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No

Re: [PATCH] soc: fsl: qe: Replace all non-returning strlcpy with strscpy

2023-05-23 Thread Kees Cook
On Tue, May 23, 2023 at 02:14:25AM +, Azeem Shaikh wrote: > strlcpy() reads the entire source buffer first. > This read may exceed the destination size limit. > This is both inefficient and can lead to linear read > overflows if a source string is not NUL-terminated [1]. > In an effort to

[PATCH] soc: fsl: qe: Replace all non-returning strlcpy with strscpy

2023-05-22 Thread Azeem Shaikh
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No