RE: [PATCH 0/3] PCI: dwc: Improve code readability

Hello, > From: Krzysztof Wilczyński, Sent: Monday, November 13, 2023 9:22 PM > > [...] > > > > Now, while you are looking at things, can you also take care about the > > > > following: > > > > > > > > drivers/pci/controller/dwc/pcie-rcar-gen4.c:439:15: warning: cast to > > > > smaller

Re: [PATCH 0/3] PCI: dwc: Improve code readability

Hello, [...] > > > I confirmed that the uintptr_t fixed the issue. > > > > We declined a similar fix in the past[1] ... > > > > > I also think that adding a new struct with the mode is overkill. > > > > ... with the hopes that a driver could drop the switch statements in place > > of using the

Re: [PATCH 0/3] PCI: dwc: Improve code readability

Hi Krzysztof, On Mon, Nov 13, 2023 at 1:22 PM Krzysztof Wilczyński wrote: > > > > Now, while you are looking at things, can you also take care about the > > > > following: > > > > > > > > drivers/pci/controller/dwc/pcie-rcar-gen4.c:439:15: warning: cast to > > > > smaller integer type 'enum

Re: [PATCH 0/3] PCI: dwc: Improve code readability

Hello, [...] > > > Now, while you are looking at things, can you also take care about the > > > following: > > > > > > drivers/pci/controller/dwc/pcie-rcar-gen4.c:439:15: warning: cast to > > > smaller integer type 'enum dw_pcie_device_mode' > > from 'const void *'

RE: [PATCH 0/3] PCI: dwc: Improve code readability

Hi Krzysztof-san, Geert-san, > From: Geert Uytterhoeven, Sent: Monday, November 13, 2023 8:07 PM > > Hi Krzysztof, > > On Mon, Nov 13, 2023 at 11:09 AM Krzysztof Wilczyński wrote: > > > This patch series is based on the latest pci.git / next branch. > > [...] > > > > Thank you for following up

Re: [PATCH 0/3] PCI: dwc: Improve code readability

Hi Krzysztof, On Mon, Nov 13, 2023 at 11:09 AM Krzysztof Wilczyński wrote: > > This patch series is based on the latest pci.git / next branch. > [...] > > Thank you for following up to tidy things up! Much appreciated. > > Now, while you are looking at things, can you also take care about the

Re: [PATCH 0/3] PCI: dwc: Improve code readability

Hi Yoshihiro! > This patch series is based on the latest pci.git / next branch. [...] Thank you for following up to tidy things up! Much appreciated. Now, while you are looking at things, can you also take care about the following: drivers/pci/controller/dwc/pcie-rcar-gen4.c:439:15:

[PATCH 0/3] PCI: dwc: Improve code readability

This patch series is based on the latest pci.git / next branch. The patch 1/3 is related to the "note" in the commit [1] The patches [23]/3 are related to the "Note" which in the commit [2]. [1]