[PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2015-01-05 Thread Mel Gorman
Convert existing users of pte_numa and friends to the new helper. Note that the kernel is broken after this patch is applied until the other page table modifiers are also altered. This patch layout is to make review easier. Signed-off-by: Mel Gorman mgor...@suse.de Acked-by: Linus Torvalds

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-12-04 Thread Mel Gorman
On Thu, Dec 04, 2014 at 08:01:57AM +1100, Benjamin Herrenschmidt wrote: On Wed, 2014-12-03 at 15:52 +, Mel Gorman wrote: It's implied but can I assume it passed? If so, Ben and Paul, can I consider the series to be acked by you other than the minor comment updates? Yes. Assuming

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-12-04 Thread Mel Gorman
On Wed, Dec 03, 2014 at 10:50:35PM +0530, Aneesh Kumar K.V wrote: Mel Gorman mgor...@suse.de writes: On Wed, Dec 03, 2014 at 08:53:37PM +0530, Aneesh Kumar K.V wrote: Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Tue, 2014-12-02 at 12:57 +0530, Aneesh Kumar K.V wrote:

[PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-12-04 Thread Mel Gorman
Convert existing users of pte_numa and friends to the new helper. Note that the kernel is broken after this patch is applied until the other page table modifiers are also altered. This patch layout is to make review easier. Signed-off-by: Mel Gorman mgor...@suse.de Acked-by: Linus Torvalds

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-12-03 Thread Aneesh Kumar K.V
Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Tue, 2014-12-02 at 12:57 +0530, Aneesh Kumar K.V wrote: Now, hash_preload can possibly insert an hpte in hash page table even if the access is not allowed by the pte permissions. But i guess even that is ok. because we will fault

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-12-03 Thread Mel Gorman
On Wed, Dec 03, 2014 at 08:53:37PM +0530, Aneesh Kumar K.V wrote: Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Tue, 2014-12-02 at 12:57 +0530, Aneesh Kumar K.V wrote: Now, hash_preload can possibly insert an hpte in hash page table even if the access is not allowed by the

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-12-03 Thread Aneesh Kumar K.V
Mel Gorman mgor...@suse.de writes: On Wed, Dec 03, 2014 at 08:53:37PM +0530, Aneesh Kumar K.V wrote: Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Tue, 2014-12-02 at 12:57 +0530, Aneesh Kumar K.V wrote: Now, hash_preload can possibly insert an hpte in hash page table even if

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-12-03 Thread Benjamin Herrenschmidt
On Wed, 2014-12-03 at 15:52 +, Mel Gorman wrote: It's implied but can I assume it passed? If so, Ben and Paul, can I consider the series to be acked by you other than the minor comment updates? Yes. Assuming it passed :-) Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-12-02 Thread Benjamin Herrenschmidt
On Tue, 2014-12-02 at 12:57 +0530, Aneesh Kumar K.V wrote: Now, hash_preload can possibly insert an hpte in hash page table even if the access is not allowed by the pte permissions. But i guess even that is ok. because we will fault again, end-up calling hash_page_mm where we handle that part

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-12-02 Thread Benjamin Herrenschmidt
On Tue, 2014-12-02 at 13:01 +0530, Aneesh Kumar K.V wrote: Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Fri, 2014-11-21 at 13:57 +, Mel Gorman wrote: void set_pte_at(struct mm_struct *mm, unsigned long addr, pte_t *ptep, pte_t pte) { -#ifdef

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-12-01 Thread Benjamin Herrenschmidt
On Fri, 2014-11-21 at 13:57 +, Mel Gorman wrote: Convert existing users of pte_numa and friends to the new helper. Note that the kernel is broken after this patch is applied until the other page table modifiers are also altered. This patch layout is to make review easier. Aneesh, the

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-12-01 Thread Benjamin Herrenschmidt
On Fri, 2014-11-21 at 13:57 +, Mel Gorman wrote: void set_pte_at(struct mm_struct *mm, unsigned long addr, pte_t *ptep, pte_t pte) { -#ifdef CONFIG_DEBUG_VM - WARN_ON(pte_val(*ptep) _PAGE_PRESENT); -#endif + /* +* When handling numa faults, we

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-12-01 Thread Aneesh Kumar K.V
Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Fri, 2014-11-21 at 13:57 +, Mel Gorman wrote: Convert existing users of pte_numa and friends to the new helper. Note that the kernel is broken after this patch is applied until the other page table modifiers are also altered. This

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-12-01 Thread Aneesh Kumar K.V
Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Fri, 2014-11-21 at 13:57 +, Mel Gorman wrote: void set_pte_at(struct mm_struct *mm, unsigned long addr, pte_t *ptep, pte_t pte) { -#ifdef CONFIG_DEBUG_VM - WARN_ON(pte_val(*ptep) _PAGE_PRESENT); -#endif

[PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-11-21 Thread Mel Gorman
Convert existing users of pte_numa and friends to the new helper. Note that the kernel is broken after this patch is applied until the other page table modifiers are also altered. This patch layout is to make review easier. Signed-off-by: Mel Gorman mgor...@suse.de Acked-by: Linus Torvalds

[PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-11-20 Thread Mel Gorman
Convert existing users of pte_numa and friends to the new helper. Note that the kernel is broken after this patch is applied until the other page table modifiers are also altered. This patch layout is to make review easier. Signed-off-by: Mel Gorman mgor...@suse.de Acked-by: Linus Torvalds

RE: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-11-20 Thread David Laight
From: Mel Gorman Convert existing users of pte_numa and friends to the new helper. Note that the kernel is broken after this patch is applied until the other page table modifiers are also altered. This patch layout is to make review easier. Doesn't that break bisection? David

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-11-20 Thread Mel Gorman
On Thu, Nov 20, 2014 at 10:38:56AM +, David Laight wrote: From: Mel Gorman Convert existing users of pte_numa and friends to the new helper. Note that the kernel is broken after this patch is applied until the other page table modifiers are also altered. This patch layout is to make

Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa

2014-11-20 Thread Aneesh Kumar K.V
Mel Gorman mgor...@suse.de writes: Convert existing users of pte_numa and friends to the new helper. Note that the kernel is broken after this patch is applied until the other page table modifiers are also altered. This patch layout is to make review easier. . diff --git