Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

On Wed, Jan 31, 2024 at 06:53:13AM +, Christophe Leroy wrote: > The problem being identified in commit 677bfb9db8a3 ("module: Don't > ignore errors from set_memory_XX()"), you can keep/re-apply the series > [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro()

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

Hi Christophe, On 31.01.2024 21:07, Christophe Leroy wrote: > Le 31/01/2024 à 16:17, Marek Szyprowski a écrit : >> [Vous ne recevez pas souvent de courriers de m.szyprow...@samsung.com. >> Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> On

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

Le 31/01/2024 à 16:17, Marek Szyprowski a écrit : > [Vous ne recevez pas souvent de courriers de m.szyprow...@samsung.com. > Découvrez pourquoi ceci est important à > https://aka.ms/LearnAboutSenderIdentification ] > > Hi Christophe, > > On 31.01.2024 12:58, Christophe Leroy wrote: >> Le

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

Hi Christophe, On 31.01.2024 12:58, Christophe Leroy wrote: > Le 30/01/2024 à 18:48, Marek Szyprowski a écrit : >> [Vous ne recevez pas souvent de courriers de m.szyprow...@samsung.com. >> Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> On

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

Hi, Le 30/01/2024 à 18:48, Marek Szyprowski a écrit : > [Vous ne recevez pas souvent de courriers de m.szyprow...@samsung.com. > Découvrez pourquoi ceci est important à > https://aka.ms/LearnAboutSenderIdentification ] > > Dear All, > > On 30.01.2024 12:03, Christophe Leroy wrote: >> Le

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

n't ignore errors from set_memory_XX()") >> >> This in fact means that commit 677bfb9db8a3 is responsible for this >> regression, as 65929884f868 has to be reverted only because the latter >> depends on it. Let me know what I can do to help debugging this issue. > > Thanks for the bisect, I've reset my tree to commit > 3559ad395bf02 ("module: Change module_enable_{nx/x/ro}() to more > explicit names") for now then, so to remove those commits. > The problem being identified in commit 677bfb9db8a3 ("module: Don't ignore errors from set_memory_XX()"), you can keep/re-apply the series [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time. Christophe

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

On Tue, Jan 30, 2024 at 06:48:11PM +0100, Marek Szyprowski wrote: > Dear All, > > On 30.01.2024 12:03, Christophe Leroy wrote: > > Le 30/01/2024 à 10:16, Chen-Yu Tsai a écrit : > >> [Vous ne recevez pas souvent de courriers de we...@chromium.org. D?couvrez > >> pourquoi ceci est important ? >

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

Dear All, On 30.01.2024 12:03, Christophe Leroy wrote: > Le 30/01/2024 à 10:16, Chen-Yu Tsai a écrit : >> [Vous ne recevez pas souvent de courriers de we...@chromium.org. D?couvrez >> pourquoi ceci est important ? https://aka.ms/LearnAboutSenderIdentification ] >> >> On Mon, Jan 29, 2024 at

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

Le 30/01/2024 à 10:16, Chen-Yu Tsai a écrit : > [Vous ne recevez pas souvent de courriers de we...@chromium.org. D?couvrez > pourquoi ceci est important ? https://aka.ms/LearnAboutSenderIdentification ] > > Hi, > > On Mon, Jan 29, 2024 at 12:09:50PM -0800, Luis Chamberlain wrote: >> On Thu,

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

Hi, On Mon, Jan 29, 2024 at 12:09:50PM -0800, Luis Chamberlain wrote: > On Thu, Dec 21, 2023 at 10:02:46AM +0100, Christophe Leroy wrote: > > Declaring rodata_enabled and mark_rodata_ro() at all time > > helps removing related #ifdefery in C files. > > > > Signed-off-by: Christophe Leroy > >

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

On Thu, Dec 21, 2023 at 10:02:46AM +0100, Christophe Leroy wrote: > Declaring rodata_enabled and mark_rodata_ro() at all time > helps removing related #ifdefery in C files. > > Signed-off-by: Christophe Leroy Very nice cleanup, thanks!, applied and pushed Luis

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

Le 22/12/2023 à 06:35, Kees Cook a écrit : > [Vous ne recevez pas souvent de courriers de k...@kernel.org. Découvrez > pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > On December 21, 2023 4:16:56 AM PST, Michael Ellerman > wrote: >> Cc +Kees >> >> Christophe

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

On December 21, 2023 4:16:56 AM PST, Michael Ellerman wrote: >Cc +Kees > >Christophe Leroy writes: >> Declaring rodata_enabled and mark_rodata_ro() at all time >> helps removing related #ifdefery in C files. >> >> Signed-off-by: Christophe Leroy >> --- >> include/linux/init.h | 4 >>

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

Cc +Kees Christophe Leroy writes: > Declaring rodata_enabled and mark_rodata_ro() at all time > helps removing related #ifdefery in C files. > > Signed-off-by: Christophe Leroy > --- > include/linux/init.h | 4 > init/main.c | 21 +++-- > 2 files changed, 7

[PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

Declaring rodata_enabled and mark_rodata_ro() at all time helps removing related #ifdefery in C files. Signed-off-by: Christophe Leroy --- include/linux/init.h | 4 init/main.c | 21 +++-- 2 files changed, 7 insertions(+), 18 deletions(-) diff --git