Re: [PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-11-11 Thread Milton Miller
On Nov 10, 2008, at 9:22 AM, Mohan Kumar M wrote: Yes, elf_ret_symbol sets the copy in purgatory. But the following code in purgatory (to be introduced) LOADADDR(6,run_at_load) ld 18,0(6) cmpd18,1 bne skip li 7,1 stw 7,92(4)

Re: [PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-11-10 Thread Mohan Kumar M
Milton Miller wrote: On Oct 23, 2008, at 10:15 AM, Mohan Kumar M wrote: Hi Milton, My suggestions: Milton Miller wrote: i.e., [code snip 1] lwz r7,__run_at_load-_stext(r26) cmplwi cr0,r7,1/* kdump kernel ? - stay where we are */ bne 1f add

Re: [PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-11-07 Thread Milton Miller
On Oct 23, 2008, at 10:15 AM, Mohan Kumar M wrote: Hi Milton, My suggestions: Milton Miller wrote: The __kdump_flag ABI is overly constraining for future development. ... Now that we have eliminated the use of __kdump_flag in favor of the standard is_kdump_kernel(), this flag only controls

Re: [PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-11-07 Thread Milton Miller
On Oct 22, 2008, at 10:43 PM, Paul Mackerras wrote: Paul Mackerras writes: Milton Miller writes: Move the flag to 0x5c, 1 word before the secondary cpu entry point at 0x60. Use the copy at address 0 not the one in the base kernel image to make it easier on kexec-tools. Why is it easier on

Re: [PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-10-23 Thread Mohan Kumar M
Hi Milton, My suggestions: Milton Miller wrote: The __kdump_flag ABI is overly constraining for future development. As of 2.6.27, the kernel entry point has 4 constraints: Offset 0 is the starting point for the master (boot) cpu (entered with r3 pointing to the device tree structure),

[PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-10-23 Thread Michael Neuling
From: Milton Miller [EMAIL PROTECTED] The __kdump_flag ABI is overly constraining for future development. As of 2.6.27, the kernel entry point has 4 constraints: Offset 0 is the starting point for the master (boot) cpu (entered with r3 pointing to the device tree structure), offset 0x60 is

[PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-10-22 Thread Milton Miller
The __kdump_flag ABI is overly constraining for future development. As of 2.6.27, the kernel entry point has 4 constraints: Offset 0 is the starting point for the master (boot) cpu (entered with r3 pointing to the device tree structure), offset 0x60 is code for the slave cpus (entered with r3

Re: [PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-10-22 Thread Michael Neuling
In message [EMAIL PROTECTED] you wrote: The __kdump_flag ABI is overly constraining for future development. As of 2.6.27, the kernel entry point has 4 constraints: Offset 0 is the starting point for the master (boot) cpu (entered with r3 pointing to the device tree structure), offset 0x60

Re: [PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-10-22 Thread Paul Mackerras
Milton Miller writes: Move the flag to 0x5c, 1 word before the secondary cpu entry point at 0x60. Use the copy at address 0 not the one in the base kernel image to make it easier on kexec-tools. Why is it easier on kexec-tools? Doesn't kexec-tools know where it put the kernel? I'd much

Re: [PATCH 3/3] powerpc/ppc64/kdump: better flag for running relocatable

2008-10-22 Thread Paul Mackerras
Paul Mackerras writes: Milton Miller writes: Move the flag to 0x5c, 1 word before the secondary cpu entry point at 0x60. Use the copy at address 0 not the one in the base kernel image to make it easier on kexec-tools. Why is it easier on kexec-tools? Doesn't kexec-tools know where it