Re: [PATCH RFC net] ps3/gelic: Fix possible NULL pointer dereference

2024-02-22 Thread Geert Uytterhoeven
Hi Simon, On Wed, Feb 21, 2024 at 5:57 PM Simon Horman wrote: > Fix possible NULL pointer dereference in gelic_card_release_tx_chain() > > The cited commit introduced a netdev variable to > gelic_card_release_tx_chain() which is set unconditionally on each > iteration of a for loop. > > It is

Re: [PATCH RFC net] ps3/gelic: Fix possible NULL pointer dereference

2024-02-21 Thread Geoff Levand
Hi Simon, On 2/22/24 01:56, Simon Horman wrote: > Fix possible NULL pointer dereference in gelic_card_release_tx_chain() > > The cited commit introduced a netdev variable to > gelic_card_release_tx_chain() which is set unconditionally on each > iteration of a for loop. > > It is set to the

Re: [PATCH RFC net] ps3/gelic: Fix possible NULL pointer dereference

2024-02-21 Thread Geoff Levand
On 2/22/24 03:32, Dan Carpenter wrote: > This driver is PPC so I have never looked at the code before. I noticed > another issue that was introduced last December in commit 3ce4f9c3fbb3 > ("net/ps3_gelic_net: Add gelic_descr structures"). > > net/ethernet/toshiba/ps3_gelic_net.c ... >375

Re: [PATCH RFC net] ps3/gelic: Fix possible NULL pointer dereference

2024-02-21 Thread Dan Carpenter
This driver is PPC so I have never looked at the code before. I noticed another issue that was introduced last December in commit 3ce4f9c3fbb3 ("net/ps3_gelic_net: Add gelic_descr structures"). net/ethernet/toshiba/ps3_gelic_net.c 375 static int gelic_descr_prepare_rx(struct gelic_card

[PATCH RFC net] ps3/gelic: Fix possible NULL pointer dereference

2024-02-21 Thread Simon Horman
Fix possible NULL pointer dereference in gelic_card_release_tx_chain() The cited commit introduced a netdev variable to gelic_card_release_tx_chain() which is set unconditionally on each iteration of a for loop. It is set to the value of tx_chain->tail->skb->dev. However, in some cases it is