Re: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

2024-05-22 Thread Borislav Petkov
On Wed, May 22, 2024 at 06:42:55PM +0530, Balasubrmanian, Vignesh wrote: > > > +enum custom_feature { > > > + FEATURE_XSAVE_FP = 0, > > > + FEATURE_XSAVE_SSE = 1, > > > + FEATURE_XSAVE_YMM = 2, > > > + FEATURE_XSAVE_BNDREGS = 3, > > > + FEATURE_XSAVE_BNDCSR = 4, > > > +

Re: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

2024-05-22 Thread Balasubrmanian, Vignesh
On 5/8/2024 6:32 PM, Thomas Gleixner wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Tue, May 07 2024 at 15:23, Vignesh Balasubramanian wrote: +struct xfeat_component { + u32 xfeat_type; +

Re: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

2024-05-08 Thread Thomas Gleixner
On Tue, May 07 2024 at 15:23, Vignesh Balasubramanian wrote: > +struct xfeat_component { > + u32 xfeat_type; > + u32 xfeat_sz; > + u32 xfeat_off; > + u32 xfeat_flags; > +} __packed; Why repeating xfeat_ for all member names? u32 type; u32 size; u32

Re: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

2024-05-08 Thread Kees Cook
On Tue, May 07, 2024 at 03:23:31PM +0530, Vignesh Balasubramanian wrote: > Add a new .note section containing type, size, offset and flags of > every xfeature that is present. > > This information will be used by the debuggers to understand the XSAVE > layout of the machine where the core file is

Re: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

2024-05-07 Thread kernel test robot
-to-x86-core-files/20240507-175615 base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/execve patch link: https://lore.kernel.org/r/20240507095330.2674-2-vigbalas%40amd.com patch subject: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information

Re: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

2024-05-07 Thread kernel test robot
-to-x86-core-files/20240507-175615 base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/execve patch link: https://lore.kernel.org/r/20240507095330.2674-2-vigbalas%40amd.com patch subject: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information

[PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

2024-05-07 Thread Vignesh Balasubramanian
Add a new .note section containing type, size, offset and flags of every xfeature that is present. This information will be used by the debuggers to understand the XSAVE layout of the machine where the core file is dumped, and to read XSAVE registers, especially during cross-platform debugging.