Re: [PATCHv2] spi_mpc8xxx: fix WARN_ON on remove after 4c1fba44296

2010-01-11 Thread Anton Vorontsov
On Thu, Jan 07, 2010 at 11:23:57AM +0100, Peter Korsgaard wrote: > Commit 4c1fba44296 (Add support for QE DMA mode and CPM1/CPM2 chips) > added unconditional calls to _cpm_init() / _cpm_free() from > probe()/remove(), but only checked if we're actually using CPM mode > in _init(), causing the WARN_

[PATCHv2] spi_mpc8xxx: fix WARN_ON on remove after 4c1fba44296

2010-01-07 Thread Peter Korsgaard
Commit 4c1fba44296 (Add support for QE DMA mode and CPM1/CPM2 chips) added unconditional calls to _cpm_init() / _cpm_free() from probe()/remove(), but only checked if we're actually using CPM mode in _init(), causing the WARN_ON in mpc8xxx_spi_free_dummy_rx() for !CPM. Fix it by adding the same ch