Re: Broken PCI on Sequoia

2009-01-30 Thread Geert Uytterhoeven
On Fri, 30 Jan 2009, Benjamin Herrenschmidt wrote: Yeah. In fact, I think you have that bug in almost every board. You only updated Bamboo and Canyonlands with the initial patch and the changelog says other boards can be updated separately. Nobody did that. So not so weird after all.

Re: Broken PCI on Sequoia

2009-01-30 Thread Benjamin Herrenschmidt
| PCI host bridge /plb/p...@1ec00 (primary) ranges: | MEM 0x00018000..0x0001bfff - 0x8000 | IO 0x0001e800..0x0001e800 - 0x | IO 0x0001e880..0x0001ebff - 0x | \-- Skipped (too many) ! | 4xx

Re: Broken PCI on Sequoia

2009-01-30 Thread Benjamin Herrenschmidt
For that sort of 4xx PHB (ie, the PCI 2.x ones, not the PCI-X nor the PCI-E), we only know how to program 32-bit of PLB address. IE. The old code would have cropped the plb_addr when writing to the register, the new code complains. I suspect some implementation support a register to put

RE: Broken PCI on Sequoia

2009-01-30 Thread Feng Kan
Herrenschmidt Sent: Friday, January 30, 2009 1:30 PM To: Geert Uytterhoeven Cc: Linux/PPC Development Subject: Re: Broken PCI on Sequoia For that sort of 4xx PHB (ie, the PCI 2.x ones, not the PCI-X nor the PCI-E), we only know how to program 32-bit of PLB address. IE. The old code would have cropped

RE: Broken PCI on Sequoia

2009-01-30 Thread Benjamin Herrenschmidt
:30 PM To: Geert Uytterhoeven Cc: Linux/PPC Development Subject: Re: Broken PCI on Sequoia For that sort of 4xx PHB (ie, the PCI 2.x ones, not the PCI-X nor the PCI-E), we only know how to program 32-bit of PLB address. IE. The old code would have cropped the plb_addr when writing

Broken PCI on Sequoia

2009-01-29 Thread Geert Uytterhoeven
Hi Ben, Josh, I did some background bisecting to find out when PCI stopped working on the AMCC EV-440EPX `Sequoia' Reference Board. With ppc44x_defconfig + CONFIG_USB=y + CONFIG_USB_EHCI_HCD=y and a USB 2.0 PCI card in one of the PCI slots, I get: | ehci_hcd: USB 2.0 'Enhanced' Host

Re: Broken PCI on Sequoia

2009-01-29 Thread Benjamin Herrenschmidt
On Thu, 2009-01-29 at 18:37 +0100, Geert Uytterhoeven wrote: Hi Ben, Josh, .../... Git-reverting this commit on top of 2.6.29-rc3 makes the crash go away. Perhaps sequoia.dts (and other 44x DTS files) had to be changed, too? Weird, maybe I have a bug when there is no ISA hole in

Re: Broken PCI on Sequoia

2009-01-29 Thread Josh Boyer
On Fri, Jan 30, 2009 at 09:11:01AM +1100, Benjamin Herrenschmidt wrote: On Thu, 2009-01-29 at 18:37 +0100, Geert Uytterhoeven wrote: Hi Ben, Josh, .../... Git-reverting this commit on top of 2.6.29-rc3 makes the crash go away. Perhaps sequoia.dts (and other 44x DTS files) had to be

Re: Broken PCI on Sequoia

2009-01-29 Thread Benjamin Herrenschmidt
Yeah. In fact, I think you have that bug in almost every board. You only updated Bamboo and Canyonlands with the initial patch and the changelog says other boards can be updated separately. Nobody did that. So not so weird after all. I still don't see off hand what's wrong in the code..